GitLab

Use existing AtomicStrings instead of a string literals
that need to be converted to them.

Review URL: https://codereview.chromium.org/716873002

git-svn-id: svn://svn.chromium.org/blink/trunk@185154 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=374270

Review URL: https://codereview.chromium.org/710213002

git-svn-id: svn://svn.chromium.org/blink/trunk@185153 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that the Blink IDL supports the Promise<T> syntax, update
the EME idl files with the promise type.

BUG=358271
TEST=existing EME tests pass

Review URL: https://codereview.chromium.org/694773004

git-svn-id: svn://svn.chromium.org/blink/trunk@185152 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Things that make you go 'WAT.' This comment was added in the patch
that split RenderBoxModelObject out of RenderBox --
eb6efbfaa79de8624ce72ad4e26ef0d3f808650e -- without any additional
explanation. I don't think it's helping anyone.

H/T to Ojan for finding today's WAT.

Review URL: https://codereview.chromium.org/718843002

git-svn-id: svn://svn.chromium.org/blink/trunk@185151 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The iframe load was racing with the main frame setting the onmessage
event handler. To fix this, defer the iframe loads until the main frame
onmessage event handler has already been set.

BUG=none

Review URL: https://codereview.chromium.org/704413010

git-svn-id: svn://svn.chromium.org/blink/trunk@185150 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The math to position the host layer does not account for scrolling, and
this causes incorrect behavior with nested scrollers.

BUG=None

Review URL: https://codereview.chromium.org/667913003

git-svn-id: svn://svn.chromium.org/blink/trunk@185149 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Take the text path (simple vs complex) into account when computing the
width of a space character used to strip leading and trailing spaces.

R=leviw@chromium.org
BUG=427415
TEST=fast/text/international/complex-text-leading-space-wrapping.html

Review URL: https://codereview.chromium.org/721433002

git-svn-id: svn://svn.chromium.org/blink/trunk@185148 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently animation-test-helpers.js supports prefixing element ids with
"static:". This patch removes this prefix as we just just remove them
and do nothing differently.

Review URL: https://codereview.chromium.org/693613006

git-svn-id: svn://svn.chromium.org/blink/trunk@185147 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Restarting content_shell periodically helps keep memory usage down. This should
improve cycle times on bots by preventing the machines from going into swap.

BUG=427569
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/709603005

git-svn-id: svn://svn.chromium.org/blink/trunk@185146 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The main frame's size is no longer simply the viewport size. Instead,
WebViewImpl sizes it after layout to be the either the content width with
a height matching the viewport aspect ratio, or the viewport at minimum page
scale. This fixes a bug where the innerWidth/innerHeight values would be
wrong during an onload event if the onload would happen before the content was
properly sized.

BUG=431097,428722

Review URL: https://codereview.chromium.org/705423002

git-svn-id: svn://svn.chromium.org/blink/trunk@185145 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch passes 'true' value for layoutPositionedObjects() in case of size change.
It helps to avoid unneccessary setChildNeedsLayout() and setPreferredLogicalWidthsDirty() calls.

Review URL: https://codereview.chromium.org/714933002

git-svn-id: svn://svn.chromium.org/blink/trunk@185144 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Make clear that imageLoader is potentially constructing the
ImageLoader by renaming to ensureImageLoader. Also rename
hasImageLoader to imageLoader and make it return a pointer,
so it can be used both to check if the ImageLoader is created
as well as use it if not null.

http://trac.webkit.org/changeset/175764

Review URL: https://codereview.chromium.org/715633005

git-svn-id: svn://svn.chromium.org/blink/trunk@185143 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use onmessage instead of the iframe onload event, since the test itself
triggers navigation. Depending on the timing, the iframe onload handler
may run more than once.

BUG=381464

Review URL: https://codereview.chromium.org/713453003

git-svn-id: svn://svn.chromium.org/blink/trunk@185142 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=yurys, haraken, keishi, oilpan-reviews

Review URL: https://codereview.chromium.org/707273003

git-svn-id: svn://svn.chromium.org/blink/trunk@185141 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Web to native app navigation transition uses Activity Transitions APIs in Android L. It requires the names and rects of transition elements. This CL gets the names and rects and pass them to TransitionRequestManager.

Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit#
Demo video: https://drive.google.com/a/google.com/file/d/0B3hetueIc91Gd01DU25uT2hWU2M/view?usp=sharing
Activity Transitions in Android L: https://developer.android.com/preview/material/animations.html#transitions

================

Originally this was a 3-way patch since it involves API change in WebFrameClient.h. After the chrome side impl was committed (step 1), we found that it is better to pass struct instead of long list of params. So this turns out to be a 5-way patch.

Here are the 5 steps:
1. Chrome side - save the data (https://codereview.chromium.org/652283002/).
2. Blink side - getting the data and introduce struct WebTransitionElementData, but still using long list of params (this CL).
3. Chrome side - implement the API with WebTransitionElementData (https://codereview.chromium.org/679813003/).
4. Blink side - remove old APIs that use long list of params and start to use new API with WebTransitionElementData.
5. Chrome side - remove redundent implmentations of the old APIs.


BUG=370696

Review URL: https://codereview.chromium.org/654953002

git-svn-id: svn://svn.chromium.org/blink/trunk@185140 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=yhirano

Review URL: https://codereview.chromium.org/714153003

git-svn-id: svn://svn.chromium.org/blink/trunk@185139 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185129

BUG=377845
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/707753007

git-svn-id: svn://svn.chromium.org/blink/trunk@185138 bbb929c8-8fbe-4397-9dbb-9b2b20218538

V8PerIsolateData cannot own IDBPendingTransactionMonitor, because
IDBPendingTransactionMonitor is defined in modules/indexeddb and
V8PerIsolateData is defined in bindings/core. Replace the monitor
entirely by having IDBTransactions register tasks to be run once
the scopes are unwound.

BUG=358074
R=haraken,tasak,adamk

Review URL: https://codereview.chromium.org/686153003

git-svn-id: svn://svn.chromium.org/blink/trunk@185137 bbb929c8-8fbe-4397-9dbb-9b2b20218538

If a partial interface in modules extends an interface in core and uses
any union types, the generated bindings/modules/v8/V8*Partial.cpp file
needs to include UnionTypesModules.h. This did not happen, since use of
union types was only tracked per main (non-partial) interface.

BUG=240176

Review URL: https://codereview.chromium.org/684653009

git-svn-id: svn://svn.chromium.org/blink/trunk@185136 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=401424

Requires https://codereview.chromium.org/677073002

Review URL: https://codereview.chromium.org/676003002

git-svn-id: svn://svn.chromium.org/blink/trunk@185135 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reduces the number of targets that have to be built when changing the
status of a runtime-enabled feature dramatically (for content_shell, from
1229 to 44), because these changes only affect the source file and not the
header.

In such cases, ninja notices when the modification time is left alone, and
it can propagate this "clean" (not changed) state to dependent targets.

Review URL: https://codereview.chromium.org/688443007

git-svn-id: svn://svn.chromium.org/blink/trunk@185134 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the only internal usage of DOMImplementation::hasFeature(), and
the only way that svg:requiredFeatures is observable, other than the
it->isEmpty() case.

If usage is low, DOMImplementation.hasFeature() and this internal usage
can be changed together, see
https://groups.google.com/a/chromium.org/d/msg/blink-dev/r2aARnIHG4k/_dN33g65mYgJ

Review URL: https://codereview.chromium.org/712813002

git-svn-id: svn://svn.chromium.org/blink/trunk@185133 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=185125

BUG=429843,432080,432079
TBR=aberent@chromium.org

Review URL: https://codereview.chromium.org/715463003

git-svn-id: svn://svn.chromium.org/blink/trunk@185132 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We should wait for the V8 side operations to complete *before* tearing down the
Isolate.

BUG=431860

Review URL: https://codereview.chromium.org/716723003

git-svn-id: svn://svn.chromium.org/blink/trunk@185131 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that there is only one implementation it doesn't make sense to separate interface from implementation of TimelineModel.

BUG=428700

Review URL: https://codereview.chromium.org/715803002

git-svn-id: svn://svn.chromium.org/blink/trunk@185130 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of storing glyph advances (only to later convert to offsets for the Skia draw calls), refactor GlyphBuffer to store offsets directly. This reduces the amount of buffer post-processing and decreases the API friction when calling into Skia.

GlyphBuffer offsets are relative to the text run origin and are either horizontal/x-only (generated by the simple shaper) or x/y interleaved (generated by the complex shaper). These correspond to the text positioning modes used by Skia.

Thanks to the new buffer format, the refactor also includes:

* zero offset processing when building text blobs (the offsets are essentially memcpy-ed)
* minimal processing (translate by destination point) for the legacy drawPosText path (we could also optimize this path, but the added complexity is probably not justified given the plans to completely switch to text blobs)
* SimpleShaper::adjustSpacing no longer needs to inject synthetic glyphs but simply adjusts the offsets for following glyps
* drawEmphasisMarks uses explicit offsets to glyph-midpoint instead of computing them based on advances

Other things to investigate:

* multi-run buffer builder (to support multi-run text blobs)
* stop storing space glyphs (simply adjust the following glyph offsets instead)

R=jbroman@chromium.org,eae@chromium.org,dominik.rottsches@intel.com
BUG=377845

Review URL: https://codereview.chromium.org/676523003

git-svn-id: svn://svn.chromium.org/blink/trunk@185129 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds a watchlist for scheduling related code reviews.

BUG=432040

Review URL: https://codereview.chromium.org/715793002

git-svn-id: svn://svn.chromium.org/blink/trunk@185128 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This inspector app is intended to be run inside an iframe.
InspectorAppHost exposes an API between inspector app and hosting app.

Created DevTools app which is only embedding inspector app in iframe.
Next patches will define API and move hosting functionality from
inspector app to devtools app.

BUG=431697

Review URL: https://codereview.chromium.org/710033003

git-svn-id: svn://svn.chromium.org/blink/trunk@185127 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Use ContainerNode more in DOMEditor, specifically
this allows us to call replaceChild/removeChild etc.
on ContainerNode directly, skipping the checks in
Node::replaceChild/removeChild.

Review URL: https://codereview.chromium.org/716603002

git-svn-id: svn://svn.chromium.org/blink/trunk@185126 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We want the overlay cast icon to be visible on all backgrounds, so its
background has to be at least semi-opaque. The non-overlay cast icon,
however, should have the same background as the media controls, which
is easiest to achive by making its background transparent. As such we
need different icons for the two cases.

Note that this also needs a Chromium CL for the new versions of the
icons.

BUG=426373

Review URL: https://codereview.chromium.org/716613002

git-svn-id: svn://svn.chromium.org/blink/trunk@185125 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Once https://codereview.chromium.org/614373007/ lands, the following code doesn't work as expected (It confuses reference counting).

class X : public RefCountedGarbageCollected<X> {
  static PassRefPtr<X> create() {
    return adoptRef(new X);
  }
}

Instead we have to write:

class X : public RefCountedGarbageCollected<X> {
  static X* create() {
    return new X;
  }
}

This CL adds a compile-time verification to detect adoptRef(X*) where X is RefCountedGarbageCollected.

BUG=420515

Review URL: https://codereview.chromium.org/647393002

git-svn-id: svn://svn.chromium.org/blink/trunk@185124 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Gracefully handle cancellation of a parser-blocking script load that
was initiated while already executing scripts. That is, quietly stop
waiting for it to load without notifying the host.

R=marja@chromium.org,kouhei@chromium.org,haraken@chromium.org
BUG=398090

Review URL: https://codereview.chromium.org/710933003

git-svn-id: svn://svn.chromium.org/blink/trunk@185122 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=363976

Review URL: https://codereview.chromium.org/622843002

git-svn-id: svn://svn.chromium.org/blink/trunk@185121 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit cf26e70f1858fec58da5a214468b4252d1917310 aka

https://src.chromium.org/viewvc/blink?view=rev&revision=185102

an auto rebaseline that's waiting on a failing mac 10.8 bot build slave.

Reason for revert: green the blink tree while mac 10.8 build slave has no
space left on device error, issue 432058, chrome troopers mailed. Will do
the auto rebaseline again when the 10.8 bot is fixed.

TBR=yhirano@chromium.org
BUG=432058
NOTRY=true

Review URL: https://codereview.chromium.org/694123004

git-svn-id: svn://svn.chromium.org/blink/trunk@185120 bbb929c8-8fbe-4397-9dbb-9b2b20218538

media/video-overlay-cast-light-rendering.html
media/video-overlay-cast-dark-rendering.html
media/video-controls-with-cast-rendering.html

BUG=429843, 432079, 432080
TBR=senorblanco@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/709123006

git-svn-id: svn://svn.chromium.org/blink/trunk@185119 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch switches to lazily allocating transforms in RenderSVGShape
because local transforms are relatively rare.

BUG=429551

Review URL: https://codereview.chromium.org/701433002

git-svn-id: svn://svn.chromium.org/blink/trunk@185118 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Byte order mark detection needs to be done on the Blink side, since it also
affects encoding detection.

This also enables the preparse data for streamed scripts again, because the
corrupt data was caused by byte order marks not being detected properly.

BUG=430890

Review URL: https://codereview.chromium.org/708093002

git-svn-id: svn://svn.chromium.org/blink/trunk@185117 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings

This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings
(Ref: binding-methods changed:
static v8::Local<v8::Object> createWrapper(v8::Handle<v8::Object> creationContext, const WrapperTypeInfo*, ScriptWrappableBase* internalPointer, v8::Isolate*)
PassRefPtrWillBeRawPtr<ScriptCallStack> createScriptCallStack(v8::Handle<v8::StackTrace>, size_t maxStackSize, v8::Isolate*))

BUG=424446

Review URL: https://codereview.chromium.org/717703002

git-svn-id: svn://svn.chromium.org/blink/trunk@185116 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=vsevik
BUG=424085

Review URL: https://codereview.chromium.org/701153002

git-svn-id: svn://svn.chromium.org/blink/trunk@185115 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove unnecessary explicit keywords from a constructor with more than one parameters in css directory.

BUG=None
TEST=None; No behavior change

Review URL: https://codereview.chromium.org/710293002

git-svn-id: svn://svn.chromium.org/blink/trunk@185114 bbb929c8-8fbe-4397-9dbb-9b2b20218538