GitLab

Revert of Add remoting and PPAPI tests to GN build (patchset #6 id:100001 of https://codereview.chromium.org/961323004/)

Reason for revert:
broke windows GN builds as seen in

http://build.chromium.org/p/chromium.win/builders/Win8%20GN/builds/5206/steps/compile/logs/stdio

Original issue's description:
> Add remoting and PPAPI tests to GN build
>
> Reland of https://codereview.chromium.org/965633002/
>
> TBR=dpranke
>
> Committed: https://crrev.com/66c53eef76f7dff97b1bc76d51740c3a9c07844f
> Cr-Commit-Position: refs/heads/master@{#318756}

TBR=dpranke@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/968243004

Cr-Commit-Position: refs/heads/master@{#318772}

Design: go/chrome-fallback-icons

This adds FallbackIconUrlParser, which will be used to parse the
"explict flow" host chrome://fallback-icon/ to extract size,
FallbackIconStyle, and URL needed to render Fallback icons.

This CL is sliced off from https://codereview.chromium.org/835903005/ .

BUG=455063

Review URL: https://codereview.chromium.org/924063003

Cr-Commit-Position: refs/heads/master@{#318771}

R=inferno@chromium.org
BUG=463217

Review URL: https://codereview.chromium.org/969103002

Cr-Commit-Position: refs/heads/master@{#318770}

This adds tooltips to profile names in both the old and new profile
switcher when they are truncated on OSX.
This lines up with behaviour on Windows.

Also added myself to the AUTHORS file seeing this is my first contribution.

BUG=459572

Review URL: https://codereview.chromium.org/943453003

Cr-Commit-Position: refs/heads/master@{#318769}

Currently, the connect call of the clientPlugin requires a
fetchPinCallback, a fetchThirdPartyTokenCallback, an accessCode and a pairingInfo.

This fields are passed down all the way from crd_connect.js to the plugin via
sessionConnector and clientSession.  As a result, each of the intermediary layers
has its own member variables to cached those properties

This CL creates a new class remoting.CredentialsProvider that represents connection
credentials.  This also eliminates a set of callbacks and useAsyncPinDialog() on the
client plugin interface, which make the credentials negotiation flow between the
plugin and the client session less chatty.

BUG=462383

Review URL: https://codereview.chromium.org/954373002

Cr-Commit-Position: refs/heads/master@{#318768}

BUG=462799
TEST=Resized CrOS Ash-desktop-in-a-window on my local dev workstation to confirm crash is resolved.

Review URL: https://codereview.chromium.org/965093002

Cr-Commit-Position: refs/heads/master@{#318767}

The current implementation has an error in its time delay computation.
It computes negative timedeltas for cache entries that are
> Now(). This causes a CHECK failure in
IncomingTaskQueue::CalculateDelayedRuntime.

BUG=459443
CC=mfoltz@chromium.org

Review URL: https://codereview.chromium.org/937743003

Cr-Commit-Position: refs/heads/master@{#318766}

BUG=459842

Review URL: https://codereview.chromium.org/935223002

Cr-Commit-Position: refs/heads/master@{#318765}

Courgette cannot parse files that have out of order NOBITS sections and instead
will crash. The solution to this is to skip them and encode them as raw bytes.

Also, courgette has a bug where it incorrectly emits ElfRelocationInstruction
instructions even when there are no valid R_386_RELATIVE relocations in the
file.

Added a test file that exhibits both of these symptoms.

BUG=424820,423925
TEST=courgette_unittests
R=dgarrett@chromium.org, tommi@chromium.org

Review URL: https://codereview.chromium.org/664803002

Cr-Commit-Position: refs/heads/master@{#318764}

BUG=462382
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/958123003

Cr-Commit-Position: refs/heads/master@{#318763}

BUG=none
R=davidben@chromium.org

Review URL: https://codereview.chromium.org/969083002

Cr-Commit-Position: refs/heads/master@{#318762}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8f9e816..281bf52

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/969653003

Cr-Commit-Position: refs/heads/master@{#318761}

BUG=463204
TBR=reed@chromium.org, thestig@chromium.org

Review URL: https://codereview.chromium.org/969073002

Cr-Commit-Position: refs/heads/master@{#318760}

Presubmit does not contain any tests for the _CheckUserActionUpdate
function. This commit adds a test to check against an action in
actions.xml and one that is not found there. To do this we have to
improve the MockInputApi and MockFile classes.

BUG=462814

Review URL: https://codereview.chromium.org/966703003

Cr-Commit-Position: refs/heads/master@{#318759}

BUG=460638

Review URL: https://codereview.chromium.org/969833002

Cr-Commit-Position: refs/heads/master@{#318758}

Found by Facebook's flint tool:
$ flint ui/gfx/x/x11_error_tracker.cc
ui/gfx/x/x11_error_tracker.cc:6: The associated header file of .cpp
files should be included before any other includes.

Then built with:
$ gn gen out-gn
$ ninja -C out-gn x

BUG=None
TEST=see above
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/966173002

Cr-Commit-Position: refs/heads/master@{#318757}

Reland of https://codereview.chromium.org/965633002/

TBR=dpranke

Review URL: https://codereview.chromium.org/961323004

Cr-Commit-Position: refs/heads/master@{#318756}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c791d841..155278d6

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/969053002

Cr-Commit-Position: refs/heads/master@{#318755}

Make the chrome://extensions page use chrome.developerPrivate API to
select a file path for a crx and to perform the pack job itself.
Also add tests for the api function, and convert it to a
UIThreadExtensionFunction.

BUG=461039

Review URL: https://codereview.chromium.org/958803004

Cr-Commit-Position: refs/heads/master@{#318754}

Update chrome://settings for "automatic timezone detection" option after UI
review.

BUG=461953
TEST=manual

Review URL: https://codereview.chromium.org/944593002

Cr-Commit-Position: refs/heads/master@{#318753}

The AFTER_WAKEUP autopump policy should only pump a task queue if the task
which was executed is newer (i.e., posted after) the oldest task in the
task queue's incoming queue. Otherwise the queue will be woken by the task
which actually posts the task.

This will be required for implemention of long idle task - design doc:
https://docs.google.com/a/chromium.org/document/d/1yBlUdYW8VTIfB-DqhvQqUeP0kf-Ap1W4cao2yQq58Do/edit

BUG=455713

Review URL: https://codereview.chromium.org/966813003

Cr-Commit-Position: refs/heads/master@{#318752}

Annotate several classes with @TargetApi so lint knows that those
classes can safely use methods introduced in various versions of
Android.

BUG=266140

Review URL: https://codereview.chromium.org/963383002

Cr-Commit-Position: refs/heads/master@{#318751}

This patch changes CallFunctionForSubtree from using base::Bind to
using lambdas, which makes it slightly more readable at the call site.

R=enne, danakj

Review URL: https://codereview.chromium.org/937883002

Cr-Commit-Position: refs/heads/master@{#318750}

The problem was that the preference layout is quite different between L
and pre-L devices, so adjusting the padding of the icon's parent view
had very different effects in those two cases. Now, we simply set the
padding of the icon view itself to get the favicon where we want it.

BUG=454850

Review URL: https://codereview.chromium.org/956303003

Cr-Commit-Position: refs/heads/master@{#318749}

BUG=434064

Review URL: https://codereview.chromium.org/969513002

Cr-Commit-Position: refs/heads/master@{#318748}

For <input type=time step=3600>, the minutes field should be disabled, and the
value should be the minutes of the minimum value, not the current time.
(Actually, it should be the minutes of the step-base value.  This CL adds TODO()
for it.)

Also, this CL fixes a bug for step>3600.  <input type=time step=5400> should
not disable the minutes field.

BUG=409791

Review URL: https://codereview.chromium.org/954363003

Cr-Commit-Position: refs/heads/master@{#318747}

BUG=461039
BUG=463082

Review URL: https://codereview.chromium.org/967393002

Cr-Commit-Position: refs/heads/master@{#318746}

This elevates it from 4 or 5 depending if it is a normal file or unit
test file to 1 for everything.

Used the following command line to lint the files:

$ for in $(g ls-files ui/app_list/ | grep -E '.*\.(cc|h)$' | grep -v
cocoa); do cpplint.py --verbose=1 $f; done

BUG=None
TEST=see above
R=tapted@chromium.org

Review URL: https://codereview.chromium.org/972463002

Cr-Commit-Position: refs/heads/master@{#318745}

BUG=b/19550404

Review URL: https://codereview.chromium.org/968263003

Cr-Commit-Position: refs/heads/master@{#318744}

Issue was addressed by http://crbug.com/445481.

R=jyasskin
BUG=364014

Review URL: https://codereview.chromium.org/962233002

Cr-Commit-Position: refs/heads/master@{#318743}

Revert of Roll src/third_party/WebKit f48b013:696617b (svn 191112:191118) (patchset #1 id:1 of https://codereview.chromium.org/965793004/)

Reason for revert:
broke official builds win,linux,mac
see
http://build.chromium.org/p/chromium/builders/Win/builds/29606/steps/compile/logs/stdio

Original issue's description:
> Roll src/third_party/WebKit f48b013:696617b (svn 191112:191118)
>
> Summary of changes available at:
> https://chromium.googlesource.com/chromium/blink/+log/f48b013..696617b
>
> TBR=alancutter@chromium.org,enne@chromium.org
>
> Committed: https://crrev.com/2f52d5e10d93c872020247c824e01e376999815e
> Cr-Commit-Position: refs/heads/master@{#318726}

TBR=alancutter@chromium.org,enne@chromium.org,blink-deps-roller@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/974463003

Cr-Commit-Position: refs/heads/master@{#318742}

BUG=398061
R=perkj@chromium.org

Review URL: https://codereview.chromium.org/966663002

Cr-Commit-Position: refs/heads/master@{#318741}

TestWebContentsFactory is a class that can create WebContents for unittests,
but can be created on the stack. This gives it the advantage of being able to
be used in tests that are already inheriting from something other than
RenderViewTestHarness.

Review URL: https://codereview.chromium.org/962393002

Cr-Commit-Position: refs/heads/master@{#318740}

Cancel() has an overly paranoid NOTREACHED, which makes it unsafe to cancel a
ProxyScriptDecider in between quickcheck and proxy script fetching. This CL
removes that NOTREACHED altogether, and adds a test to cover it.

BUG=409698

Review URL: https://codereview.chromium.org/962373002

Cr-Commit-Position: refs/heads/master@{#318739}

BUG=461610

Executed run_webapp_unittest.py with these changes and all tests passed.

Review URL: https://codereview.chromium.org/953223002

Cr-Commit-Position: refs/heads/master@{#318738}

[Telemetry] Rename PageRun to UserStoryRun part of switching from PageTestResults to UserStoryTestResults

This is the first step, next will rename PageTestResult to UserStoryTestResult.

BUG=442036

Review URL: https://codereview.chromium.org/964913005

Cr-Commit-Position: refs/heads/master@{#318737}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b3310c2..8f9e816

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=joshualitt@google.com

Review URL: https://codereview.chromium.org/969033002

Cr-Commit-Position: refs/heads/master@{#318736}

BUG=266140
R=aurimas@chromium.org

Review URL: https://codereview.chromium.org/965933002

Cr-Commit-Position: refs/heads/master@{#318735}

BUG=461865
TEST:
1. enable physical keyboard autocorrect feature from IME settings from chrome-extension://jkghodnilhceideoidjikpgommlajknk/hmm_options.html?code=xkb:us::eng
2. type "waht" and wait for a grey triangle appear underneath "waht"
At this point, an IME window is created.
3. verify no default app icon appear in launcher for the IME window

Review URL: https://codereview.chromium.org/955983004

Cr-Commit-Position: refs/heads/master@{#318734}

BUG=461785

Review URL: https://codereview.chromium.org/946423004

Cr-Commit-Position: refs/heads/master@{#318733}