GitLab

Cr-Commit-Position: refs/heads/master@{#311425}

Revert of Relanding this with font test fixes for gdi. (patchset #7 id:120001 of https://codereview.chromium.org/853553002/)

Reason for revert:
still fails on XP

https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/34996/steps/gfx_unittests/logs/DeriveFontWithHeight

Original issue's description:
> Relanding this with font test fixes for gdi.
>
> Get all font unittests running with DirectWrite on Windows 7+
>
> Fixes as per below:-
> 1. Remove the addition of the fLeading value when calculating the height for the font
>    with DirectWrite. fAscent + fDescent is the height of the font and adding the fLeading
>    value to it returns the spacing between lines which is not what we are looking for.
>
> 2. The FontListTest.Fonts_GetHeight_GetBaseline unittest has a condition which basically validates
>    whether the difference between the font height and the baseline is different for Arial and Symbol
>    fonts. This fails for DirectWrite and fails for GDI with font sizes like 50, etc. Replaced this check
>    with a check for the font heights are different.
>
> 3. Reworked the PlatformFontWinTest.DeriveFontWithHeight test to ensure it passes for DirectWrite and GDI.
>
> 4. Ensure that the PlatformFontWin::DeriveFontWithHeight function honors the minimum font size constraint
>    in all cases.
>
> BUG=442010
> R=msw
>
> Committed: https://crrev.com/3e05f41653bf36cce40718d8295ce2293218dab6
> Cr-Commit-Position: refs/heads/master@{#311388}

TBR=msw@chromium.org,ananta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=442010

Review URL: https://codereview.chromium.org/847283003

Cr-Commit-Position: refs/heads/master@{#311424}

Previously we used the center of the bounding box, but this can cause problems if the center of the bounding box is outside the element.

This CL also changes the behavior of the GetElementLocationOnceScrolledIntoView command in the same way.

BUG=

Review URL: https://codereview.chromium.org/848483002

Cr-Commit-Position: refs/heads/master@{#311423}

As the completion callback is called externally it should be cleared first, to
avoid possible double cancellation.

TEST=None
BUG=None

Review URL: https://codereview.chromium.org/838023003

Cr-Commit-Position: refs/heads/master@{#311422}

1. Adds null check when keymap is failed to load. 2. Moves xkb_rule_names construction into worker thread to fix crash problem.

BUG=447415, 444121

Review URL: https://codereview.chromium.org/848833002

Cr-Commit-Position: refs/heads/master@{#311421}

Blink is about to make use of blink_resources.grd for the inline resources of user agent stylesheets.
This removes the dependency upon using make-file-arrays.py which embeds these resources as strings.
See part 1, 2 and 3.

Also the .rodata section of libblink_web (in component build mode) is reduced by ~33kb.

In this CL, the html viewer would implement the loadResource() method and use the DataPack to
load the required resources. The resources are generated from blink_resources.grd which has been
added as the deps.

Part 1: https://codereview.chromium.org/436843004/
Part 2: https://codereview.chromium.org/422023008
Part 3: https://codereview.chromium.org/573553002

BUG=312586

Review URL: https://codereview.chromium.org/827223002

Cr-Commit-Position: refs/heads/master@{#311420}

BUG=chromedriver:1016
NOTRY=true
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/811653005

Cr-Commit-Position: refs/heads/master@{#311419}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9ffdc0b..8f672cd

TBR=hayato@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/851903002

Cr-Commit-Position: refs/heads/master@{#311418}

Revert of Use SuppressFBWarnings to suppress findbugs warnings (patchset #12 id:290001 of https://codereview.chromium.org/793203002/)

Reason for revert:
This is consistently causing bot failures, starting with https://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/72002

Original issue's description:
> Use SuppressFBWarnings to suppress findbugs warnings
>
> This has several benefits:
> Makes the warning obvious at the place of the problem
> Makes suppressing the warnings the same as suppressing compiler and lint warnings
> Makes supporting findbugs as part of the build easier
>
> TBR=rmcilroy, mef, boliu
>
> BUG=431826
>
> Committed: https://crrev.com/e0237aaa82e64439e6186f7723d4b8ceff308b9d
> Cr-Commit-Position: refs/heads/master@{#311402}

TBR=aurimas@chromium.org,newt@chromium.org,tedchoc@chromium.org,mef@chromium.org,rmcilroy@chromium.org,boliu@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=431826

Review URL: https://codereview.chromium.org/797403005

Cr-Commit-Position: refs/heads/master@{#311417}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/31b52b7..812c028

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/853603003

Cr-Commit-Position: refs/heads/master@{#311416}

BUG=447734

Review URL: https://codereview.chromium.org/807723004

Cr-Commit-Position: refs/heads/master@{#311415}

This change resolves a critical issue where two different clocks' values
were being mixed in computations involving TimeTicks for ~32% of users
on Windows. The solution is to force the use of a single clock for
TimeTicks::Now() and HighResNow(). In other words, we're moving towards
a world where the TimeTicks type should guarantee all time values are on
the same timeline.

New behavior: On systems where QPC is reliable AND efficient, Now() will
simply use the QPC clock. This is consistent with how Now() behaves on
the Mac and POSIX platforms. However, if QPC is working but is
inefficient, Now() will use the low-res clock. Finally, like before, if
the QPC is not working on the current system, Now() will use the low-res
clock.

NowFromSystemTraceTime() will always use the QPC clock if it is
working, just as before, and regardless of whether it is expensive to
use. This is to ensure tracing data remains useful. When QPC uses either
HPET or ACPI PM as a clock source, online literature suggests clock
sampling will be ~20 to ~40 times as costly (about 1.2 to 2.4us per
call).

Note: From discussion with stakeholders, there is a concern this change
will increase latency and jitter in the compositor pipeline on the
affected Windows machines. Future changes will take alternate approaches
to resolve these problems.

Note 2: This change minimizes TimeTicks API changes, in favor of future
clean-up changes.

BUG=396384,435931,439656

Review URL: https://codereview.chromium.org/797893003

Cr-Commit-Position: refs/heads/master@{#311414}

This will allow mojo, which uses located KeyboardCode values, to distinguish numpad digits from top-row digits.

BUG=444048
R=wez@chromium.org

Review URL: https://codereview.chromium.org/808793005

Cr-Commit-Position: refs/heads/master@{#311413}

R=mmenke
BUG=446900

Review URL: https://codereview.chromium.org/837223007

Cr-Commit-Position: refs/heads/master@{#311412}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/55561f5..9ffdc0b

TBR=hayato@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/852713002

Cr-Commit-Position: refs/heads/master@{#311411}

BUG=448214

Review URL: https://codereview.chromium.org/847193003

Cr-Commit-Position: refs/heads/master@{#311410}

R=toyoshim
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/838113003

Cr-Commit-Position: refs/heads/master@{#311409}

This forces WeakPtrs to be invalidated before other members' destructors run.
See the bug or the documentation of WeakPtrFactory for more information. I'm
in the process of trying to turn on a clang check for this (see the bug).

BUG=303818
R=rogerta@chromium.org

Review URL: https://codereview.chromium.org/827093006

Cr-Commit-Position: refs/heads/master@{#311408}

There is no default layout, so if we don't initialize one then all the key
events will be ignored.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/848953002

Cr-Commit-Position: refs/heads/master@{#311407}

More surfaceless renderer to using the async SwapBuffers implementation.

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/846283002

Cr-Commit-Position: refs/heads/master@{#311406}

BUG=414272

Review URL: https://codereview.chromium.org/804263005

Cr-Commit-Position: refs/heads/master@{#311405}

The scheduler should trigger it's deadline immediately if there's no
more work to be done in a given frame. This happens for instance when a
commit is aborted and there's nothing to draw.

BUG=432981

Review URL: https://codereview.chromium.org/822933004

Cr-Commit-Position: refs/heads/master@{#311404}

Review URL: https://codereview.chromium.org/851823005

Cr-Commit-Position: refs/heads/master@{#311403}

This has several benefits:
Makes the warning obvious at the place of the problem
Makes suppressing the warnings the same as suppressing compiler and lint warnings
Makes supporting findbugs as part of the build easier

TBR=rmcilroy, mef, boliu

BUG=431826

Review URL: https://codereview.chromium.org/793203002

Cr-Commit-Position: refs/heads/master@{#311402}

Per
https://uberchromegw.corp.google.com/i/clank/builders/instrumentation-volantis-clankium-lmp,
all spdy related tests have failed on volantis bot.

BUG=447837

Review URL: https://codereview.chromium.org/836033006

Cr-Commit-Position: refs/heads/master@{#311401}

This was originally intended to be shared code with another project but that
will no longer be the case.

BUG=303491

Review URL: https://codereview.chromium.org/853603002

Cr-Commit-Position: refs/heads/master@{#311400}

The early out was accidentally dropped in a refactor. Add it back here.
And also add unit tests for clear view.

BUG=448488

Review URL: https://codereview.chromium.org/846323002

Cr-Commit-Position: refs/heads/master@{#311399}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a7f1191..31b52b7

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/806583004

Cr-Commit-Position: refs/heads/master@{#311398}

Almost any character is valid in a filename. The rest of the pattern
should be restrictive enough that we don't actually match anything that
we don't want.

BUG=427718

Review URL: https://codereview.chromium.org/849973002

Cr-Commit-Position: refs/heads/master@{#311397}

Change created by following existing patterns and reading:
http://www.chromium.org/developers/design-documents/ui-localization

BUG=448585,381246

Review URL: https://codereview.chromium.org/811193005

Cr-Commit-Position: refs/heads/master@{#311396}

Review URL: https://codereview.chromium.org/852643003

Cr-Commit-Position: refs/heads/master@{#311395}

BUG=447642, 443766
TEST=TrayIMETest.PerformActionOnDetailedView, TrayIMETest.HidesOnA11yEnabled, TrayIMETest.HiddenWithNoIMEs

Review URL: https://codereview.chromium.org/843603004

Cr-Commit-Position: refs/heads/master@{#311394}

Immediately deletes the Incognito profile's cookies from the cookie
jar as soon as Profile is notified that a profile has been deleted.
The CookiesFetcher will confirm the incognito profile is missing,
then schedule them for deletion.

Also does general cleaning and renaming to less confusing method names.

BUG=447267

Review URL: https://codereview.chromium.org/833533004

Cr-Commit-Position: refs/heads/master@{#311393}

BUG=426119

Review URL: https://codereview.chromium.org/852433002

Cr-Commit-Position: refs/heads/master@{#311392}

BUG=

Review URL: https://codereview.chromium.org/850833002

Cr-Commit-Position: refs/heads/master@{#311391}

Rejig the watcher to run a message loop on the main thread, and to
do the blocking wait on a dedicated background thread.

BUG=412384

Review URL: https://codereview.chromium.org/848033005

Cr-Commit-Position: refs/heads/master@{#311390}

BUG=303818,433583

Review URL: https://codereview.chromium.org/846543002

Cr-Commit-Position: refs/heads/master@{#311389}

Get all font unittests running with DirectWrite on Windows 7+

Fixes as per below:-
1. Remove the addition of the fLeading value when calculating the height for the font
   with DirectWrite. fAscent + fDescent is the height of the font and adding the fLeading
   value to it returns the spacing between lines which is not what we are looking for.

2. The FontListTest.Fonts_GetHeight_GetBaseline unittest has a condition which basically validates
   whether the difference between the font height and the baseline is different for Arial and Symbol
   fonts. This fails for DirectWrite and fails for GDI with font sizes like 50, etc. Replaced this check
   with a check for the font heights are different.

3. Reworked the PlatformFontWinTest.DeriveFontWithHeight test to ensure it passes for DirectWrite and GDI.

4. Ensure that the PlatformFontWin::DeriveFontWithHeight function honors the minimum font size constraint
   in all cases.

BUG=442010
R=msw

Review URL: https://codereview.chromium.org/853553002

Cr-Commit-Position: refs/heads/master@{#311388}

This change upstreams the DownloadManagerService and OMADownloadHandler class, along with java tests.

BUG=15902
R=dtrainor@chromium.org, jbudorick@chromium.org

Review URL: https://codereview.chromium.org/848803002

Cr-Commit-Position: refs/heads/master@{#311387}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/bb928a0..a7f1191

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/846303003

Cr-Commit-Position: refs/heads/master@{#311386}