- 28 Nov, 2019 17 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fa16617226b7..d60fe6b7daaf Created with: gclient setdep -r src-internal@d60fe6b7daaf If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I00559ec5e1565a15bf04848b5327caec688cc90a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939678Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719829}
-
Joshua Peraza authored
7fd5226a97ea Give database settings kOwnerOnly permissions Change-Id: Ie131569a1a1652f782c1008230efa4a949fe4e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940951Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#719828}
-
Rob Schonberger authored
Adds a metric for both all impressions and those that we actually count as "impressions"; Bug: 1026649 Change-Id: Idfd781445f130f82f0d8a5ff4ead194afa37bd75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927731 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#719827}
-
Daniele Castagna authored
This CL connects powerd ambient color temperature reading to the displays' CTMs. The temperature coming from powerd is not applied directly to the display but it's instead interpolated over time to avoid sudden changes and visible noise. Night light and ambient color temperature RGB scaling factors are currently composed by multiplication. In this way if one of the feature is off it won't affect the other. Bug: 1021193 Test: new unittests added Change-Id: I47514b43b5d8a9ea0cf5f433e4c78fcb95b22f46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915021Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Auto-Submit: Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#719826}
-
Noel Gordon authored
With initial icon members files36:success and files36:failure used for visual signals. The icon <svg> source comes from CL:1918902. Not used just yet, so no change in behavior. Bug: 1026943 Change-Id: I43aab4e34286ac04072c2e2c814cc514670a3553 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940313Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719825}
-
Yun Liu authored
https://ci.chromium.org/p/chromium/builders/ci/android-code-coverage-native "//chrome/android:libchrome" causes linker issue when native coverage is on. Getting rid of this library now until linker issue fixed. Bug: 1026891 Change-Id: Ibf99d2fc154c38e637bf1758816c61cc6832492f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941168Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Yun Liu <yliuyliu@google.com> Cr-Commit-Position: refs/heads/master@{#719824}
-
John Abd-El-Malek authored
This will make it easier in the future to add other methods to allow WebLayer to handle the download so that corner cases of downloading (e.g. depend on cookies/auth, POSTs) work. By adding a return value, we would know in future iterations of the API when WebLayer can handle the download. Bug: 1025603 Change-Id: Id933a14a39793aa8f00346ae73557fba5163fa43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941117 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#719823}
-
Sadrul Habib Chowdhury authored
This is a reland of f8030cb2 Original change's description: > viz: Remove unused bottom-controls data from compositor frame. > > The bottom_controls_height and bottom_controls_shown_ratio fields > in CompositorFrameMetadata are currently unused. Their usage has been > replaced by the same fields in RenderFrameMetadata. So remove these > fields. > > BUG=none > > Change-Id: I96af75cc5f933821cfb486fdeb1e314daa2a7030 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1927973 > Auto-Submit: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717874} Tbr: dcheng@ since re-land after trivial change. Bug: 1028641 Change-Id: I16a869c42c74e294eef20f63886be592e4116ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941194Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#719822}
-
Hiroshige Hayashizaki authored
According to the spec, base URL and source text is calculated in early steps in https://html.spec.whatwg.org/multipage/scripting.html#prepare-a-script and then used for creating inline classic scripts in Step 25. However, ClassicPendingScript has been recalculating these values by via ScriptElementBase. This CL instead plumbs these values from PrepareScript() to ClassicPendingScript, to align with the spec, and also as a preparation for [1]. Multiple callers of ScriptElementBase::TextFromChildren() within PrepareScript() should be still merged, but this should be done later, to avoid rebase conflicts with [1]. This CL doesn't change the behavior. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1924523 Bug: 1026549, 686281 Change-Id: I437425a3a8918399364dbe84c898df57b46c252b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937369 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#719821}
-
Kevin Qin authored
Current OpenXR implementation use some strcpy_s without size, replace them with std strcpy_s with a size parameter. Fixed: 1029100 Change-Id: I872f8fe3d97f7a5356d6135085b1f08e76cd8952 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940876 Commit-Queue: Zheng Qin <zheqi@microsoft.com> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#719820}
-
Sergei Datsenko authored
Attach fetch time to elements in the cache and force re-fetch for old ones. BUG=chromium:804691 Fixed: 804691 Change-Id: Ie43600b3c8c26a4f2e7b00deaa54c530a067222b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935768 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#719819}
-
Christopher Thompson authored
This changes the known interception disclosure infobars to be triggered on the CERT_STATUS_KNOWN_INTERCEPTION_DETECTED flag (instead of being triggered on a test URL). This also updates the tests to set up a CRLSet for the embedded test server and use real navigations rather than triggering the disclosure infobars directly. Bug: 1014711 Change-Id: Iaac4fd7eb11ad448921905d842f5b409d21952d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929847 Commit-Queue: Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#719818}
-
Yue Zhang authored
Bug: 1022827 Change-Id: Ie3ee8e5f3ced8c694cf964eb9b596cb30a19c36f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941195Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#719817}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2ed71c811da7..fc3ec57ddf27 git log 2ed71c811da7..fc3ec57ddf27 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 jmadill@chromium.org Reland "Vulkan: Accelerate Texture PBO updates" 2019-11-27 jdarpinian@chromium.org Fix format/internalformat confusion 2019-11-27 syoussefi@chromium.org Fix string literal comparison in validation 2019-11-27 jmadill@chromium.org Roll chromium_revision 5fe256ab..d209d45b (709762:719599) Created with: gclient setdep -r src/third_party/angle@fc3ec57ddf27 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1027098,chromium:None Tbr: cwallez@google.com Change-Id: I12abe5ec93750b82ee6ed219550231017b5d38a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941167Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719816}
-
bttk authored
A defined interface, and a hidden implementation in advance of changes of the behavior of metrics in Java. Bug: crbug.com/658300 Change-Id: Iaa5a8e137526d7118315af6554e0e96d482972f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915193 Commit-Queue: bttk <bttk@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#719815}
-
Chris Hall authored
R=meredithl,dmazzoni Change-Id: Idaa428df8252cdc67d5af5a7fe7bbdfebb5f7d08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937959Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#719814}
-
Peter Kotwicz authored
This CL introduces BaseCustomTabActivityComponent which has accessors which are shared between CustomTabActivityComponent and WebappActivityComponent. BUG=None Change-Id: Id289431dd323d4e5a020517888e0bf840b4dd888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938711 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#719813}
-
- 27 Nov, 2019 23 commits
-
-
Chris Hall authored
R=meredithl,dmazzoni Change-Id: I0bf51e5de97d19027c67dbd6dfae5d4ceb863bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936446Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#719812}
-
Mike Wittman authored
Saves off the function pointer obtained from ntdll.dll so that we don't need to repeatedly query its module handle and take the loader lock while doing so. Bug: 1028808 Change-Id: I25c0dd2872524a28a87df7c4bf2db7551eab6311 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940882 Auto-Submit: Mike Wittman <wittman@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#719811}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/bf46a27cdd73..73beaaa48fcc git log bf46a27cdd73..73beaaa48fcc --date=short --first-parent --format='%ad %ae %s' 2019-11-27 benjaminwagner@google.com [infra] Upgrade Radeon driver Created with: gclient setdep -r src/third_party/skia@73beaaa48fcc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: I41e20c7f072de4b0f1973d9b7da4a88d2e4ae5f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940593Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719810}
-
Sunny Sachanandani authored
Validating command decoder CopySubTexture implementation attempts to GLImage::CopySubTexImage first before binding image. The expected behavior is that CopySubTexImage will return false if not supported, but a crash is not expected. This CL removes the NOTREACHED() calls that cause a crash in debug builds. This was observed when forcing low latency flag for all canvas to find conformance failures in https://crrev.com/c/1868845. Bug: 1011588 Change-Id: Iaf70c2f61d941ab67c2775122940786191a1a6cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941056Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#719809}
-
Miyoung Shin authored
This CL removes unnecessary filters from "navigation:frame" interface filter. - Remove media.mojom.Renderer since this instance is brokered by InterfaceFactory. - Remove since there isn't PrefetchURLLoaderService mojo interface. Bug: 936482 Change-Id: I677782fe9bdd775287f149c26cc4b2e2cd6819bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939072Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#719808}
-
Yuly Novikov authored
conformance/textures/misc/tex-video-using-tex-unit-non-zero.html conformance2/textures/misc/npot-video-sizing.html TBR=bsheedy Bug: 1026468 Change-Id: I2bd346748dc8be2cc10f543afc05ee128e2d6ac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941109Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#719807}
-
Noel Gordon authored
Bug: 1029019 Change-Id: I991f34d115702c8a0224b2662e0527c5766f08f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940311Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#719806}
-
Daniel Murphy authored
This changes adds dom_storage, blink_dom_storage, and storage_service as watchable categories. Also, this change adds dmurph@ to the watchlist for indexed_db, blink_indexed_db, dom_storage, blink_dom_storage, and storage_service. Change-Id: I7a82e79d5c9be729fd7f16adf252b24753d1283f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941192 Auto-Submit: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
enne <enne@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#719805}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/46665521b3e1..fa16617226b7 Created with: gclient setdep -r src-internal@fa16617226b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1029038,chromium:1027271 Tbr: jbudorick@google.com Change-Id: Ica73abe485646188c938814c42e3b16be60b9151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940594Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719804}
-
Etienne Pierre-doray authored
Before: ReadElfBuildId() assumes that base_address is the start of the address space (address 0). This isn't true on Android for many modules, where sections have a load bias. Fix: Find the first LOAD executable segment and use p_vaddr as |load_bias|, which is subtracted from |base_address|. Consider libart.so: PHDR 0x000034 0x0000c034 0x0000c034 0x00120 0x00120 R 0x4 LOAD 0x000000 0x0000c000 0x0000c000 0x45c354 0x45c354 R E 0x1000 LOAD 0x45c840 0x00469840 0x00469840 0x09ab0 0x0bad1 RW 0x1000 DYNAMIC 0x463cf0 0x00470cf0 0x00470cf0 0x00178 0x00178 RW 0x4 NOTE 0x000154 0x0000c154 0x0000c154 0x00038 0x00038 R 0x4 |load_bias| = 0x0c000 (|base_address| is offset by |load_bias|). Reading NOTE at |base_address + 0x0c154| is invalid. Change-Id: If81c0052c19557ddcbe63ba8c3a0dee64140dc1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894165Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#719803}
-
Kent Tamura authored
It was stored as a double, milliseconds from the Epoch and 0.0 as an invalid value. Representing it as base::Optional<base::Time> is reasonable because - Binding layer maps base::Time to JavaScript Date. - The source of anticipatedRemoval is base::Time::Exploded - anticipatedRemoval is encoded as base::Optional<base::Time> in mojo * This CL renames some instances of variables 'anticipatedRemoval' to 'anticipated_removal'. * This CL fixes an issue that anticipatedRemoval was sent via mojo as 1000 times larger value. DeprecationReportBody::AnticipatedRemoval() treated a milliseconds value as a seconds value. This CL should have no user-visible behavior changes. Bug: 988343 Change-Id: If4e12659badb5ad6d6c35d147e3f976dde0d2b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928094Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#719802}
-
Lukasz Anforowicz authored
This CL changes behavior of session-restore so that when recreating FrameNavigationEntries history entries for about:blank and/or data:... URLs we attempt to also recreate FrameNavigationEntry::site_instance_. After this CL, the SiteInstance will be recreated for all such about:blank and data:... frames ("all" = both for main frame and for subframes) but only if the FrameNavigationEntry::initiator_origin_ is available. The CL helps fix the following GetOriginForURLLoaderFactory CHECK: CHECK(policy->CanAccessDataForOrigin( navigation_request->GetRenderFrameHost()->GetProcess()->GetID(), result)); This CHECK is tracked in https://crbug.com/1026474. This CHECK would be hit by 3 of the new test cases added in this CL: BackToAboutBlank1, BackToAboutBlank2, BackToAboutBlankSubframe. This CL also adds a BackToAboutBlank1_Omnibox test for completeness (even though this test wouldn't hit the CHECK, because the CHECK is skipped for opaque origins which would be used when there is no initiator - for example in omnibox navigations to about:blank). Bug: 1026474 Change-Id: Ia20a3956237bcbe3ca307342b1748af413fd19ac Tbr: chrisha@chromium.org for //chrome/browser/sessions Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929850 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#719801}
-
Anand K. Mistry authored
Google Drive API doesn't depend on extensions in any way. Bug: 809382 Change-Id: Ia0722108b0c847576d7fa484af9643d87e988611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939129Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#719800}
-
Jordan Bayles authored
This is a reland of 5848123a Original change's description: > Move dependencies on cast_channel protos > > This patch rectifies a duplicate definition error, since certain proto > definitions are defined both in components/cast_channel and in > third_party/openscreen, by moving all consumers of these protos to using > the Open Screen version. > > Change-Id: I0347424c019b1489eb09b3822fd4a97d062e0e0f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1902718 > Reviewed-by: Luke Halliwell (slow) <halliwell@chromium.org> > Reviewed-by: Karan Bhatia <karandeepb@chromium.org> > Reviewed-by: mark a. foltz <mfoltz@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: Jordan Bayles <jophba@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715462} NOTE: Attempting TBR after recommendation from @karandeepb. TBRing reviewers: halliwell: Please review changes to components/ TBR=halliwell@chromium.org Change-Id: I5cb0bcedaf10982542fe0bf2b6db36da7e958f77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925133 Commit-Queue: Jordan Bayles <jophba@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#719799}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/74a93d412a1e..2f875b2946bb git log 74a93d412a1e..2f875b2946bb --date=short --first-parent --format='%ad %ae %s' 2019-11-27 ilkos@google.com Plumb build fingerprint to trace processor Created with: gclient setdep -r src/third_party/perfetto@2f875b2946bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:b/142858742 Tbr: perfetto-bugs@google.com Change-Id: I6ed16cf51bd342bbf49c8489dd7dfbf7ab4974a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941008Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719798}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/1d6155d8679a..30f0559dd278 git log 1d6155d8679a..30f0559dd278 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 rharrison@google.com Remove spvc's dependency on shaderc's util library (#914) 2019-11-27 rharrison@google.com Clean up how include dirs are propegated for spirv_cross (#912) Created with: gclient setdep -r src/third_party/shaderc/src@30f0559dd278 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com Change-Id: Iece0afaf98dcf880f070892eff5211b1a8cbe6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940592Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719797}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1b6546d2..8b811565 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ia02f0f91f657a36057b2de7cb6b02c69d8649e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940136Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719796}
-
Findit authored
This reverts commit 4c424ef5. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 719737 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzRjNDI0ZWY1NWNmNGI5NTFiNTU0ZWE0MjdjMjk1MzEzNTI4MWQ4ZTYM Sample Failed Build: https://ci.chromium.org/b/8895602508996479984 Sample Failed Step: compile Original change's description: > Enable init_stack_vars for non-official Windows builds > > With crrev.com/c/1914359 merged so we can enable the flag on Windows. > Patch is similar to crrev.com/c/1795632 and crrev.com/c/1838383. > > Bug: 977230 > Change-Id: I166392ee0f65ed7fd7f68cbdd5b7a3b7d589539b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1854805 > Commit-Queue: Vitaly Buka <vitalybuka@chromium.org> > Auto-Submit: Vitaly Buka <vitalybuka@chromium.org> > Reviewed-by: Hans Wennborg <hans@chromium.org> > Cr-Commit-Position: refs/heads/master@{#719737} Change-Id: Id1e9211184814bdcbcacf5f1decd1774e16cb9e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 977230 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941199 Cr-Commit-Position: refs/heads/master@{#719795}
-
danakj authored
Use OnceCallback where possible, and BindRepeating where it is meant to be called more than once. TBR=avi@chromium.org Bug: 953861, 1007763 Change-Id: I58af3a799b7b376f1a7a902823cda3ca0c5ffb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939965Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719794}
-
John Rummell authored
On some bots the license server is failing to start, so log a warning when it fails to hopefully indicate what is going wrong. Bug: 976083 Test: compiles Change-Id: Idff11ea2885289608c549396b6e11e28e095ed72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940954Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#719793}
-
Maggie Chen authored
If the GPU main thread makes a progress after waiting in OnWatchdogTimeout(), the arm_disarm_counter has changed. last_arm_disarm_counter_ saved before the wait functions is stale. Without updating it again, the GPU main thread is always considered making a progress in the next timeout cycle, which is not correct. Bug:949839 Change-Id: Ic54c7681e9bbe606004555fbf7f16cbebe91d9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940383Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#719792}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ic40f098e542d9d976d6e9007bf4570e97a6ec315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940557Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#719791}
-
John Lee authored
This CL makes the TabElement not animate any space it takes up, including width and padding, so that the window can immediately scroll to it without having to wait for the slideIn animation to finish. This is the first step to animating scroll. Bug: 1023492 Change-Id: I7b1ba8bf5fdb8400e1333c2542d644b9afbaa9b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937782Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#719790}
-