- 19 Jan, 2021 40 commits
-
-
Yuke Liao authored
This is a reland of e2f3b551 Original change's description: > Lacros: create lacros tast test targets > > This CL creates gn targets for lacros tast tests, and the main > motivation is to run lacros tast tests on Chromium CI. > > Bug: 1158590 > Change-Id: I783779c3386a39743b8227367189b0b87832b9dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606188 > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@google.com> > Cr-Commit-Position: refs/heads/master@{#844127} Bug: 1158590 Change-Id: I4baefe78970cb928476166875b519738be0c9f79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633073 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#844818}
-
Egor Pasko authored
If pinpoint_traces.py is interrupted while html2trace is busy, the next extraction would take partial results. To make the process robust in presence of interruptions, create a temporary directory for html2trace, then atomically rename it to the directory that will be searched on extraction. The operation may seem not equivalent to creating a '.tmp.json' and renaming it, because this is indeed not equivalent. This change fixes the bug that I missed in previous testing when I forgot to delete the json_cache, hence this code was not executing. This time json_cache was deleted before testing. Bug: 1119406 Change-Id: I7cfb19572a9ffa26827dd113bb92b2253b0a2b2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637838Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#844817}
-
Colin Blundell authored
This CL coalesces the implementation of ChromeSubresourceFilterClient::ShowNotification() to simplify a followup CL that will: - Move the bulk of this implementation into a new ProfileInteractionManager::MaybeShowNotification(client) method that the throttle manager will invoke directly, with that method calling client->ShowNotification() and the only remaining code in ChromeSubresourceFilterClient::ShowNotification() being the actual showing of the infobar With that followup CL, WebLayer will then share the core logic that will be moved into ProfileInteractionManager. In this CL, however, there is no behavioral change. Bug: 1116095 Change-Id: Ia9d61d6ebc8c323cfc9054a58a22acbe89e27d22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628992 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#844816}
-
Andy Perelson authored
R=ajgo Bug: 1167291 Change-Id: I252d2eef1967cb5a2510f4f9648bdc0d3bda58c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633973Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Andy Perelson <ajp@chromium.org> Cr-Commit-Position: refs/heads/master@{#844815}
-
Wez authored
The test suite was removing all services from the browser process' incoming service directory, causing the NetworkService to sometimes fail to be able to contact the platform network stack. Fix the test suite not to disable access to platform services. Bug: 1150754 Change-Id: Idd34735bcd494502af9391ab212313cea2b94c22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637517 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#844814}
-
Wez authored
Bug: 1168167 Change-Id: I2972d60b27925816579629f164c26a18a9892886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637583 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1611035655-73de094cb5ff55b60927a0f5adde75a5bce05096.profdata to chrome-win64-master-1611057528-899a688a15a64f3c7bd554cd5ab3f72fe33a7d09.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I116ff756cff1bba34f8e571becee00f0208b769b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637898Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844812}
-
Tim van der Lippe authored
R=szuend@chromium.org Bug: 1050549 Change-Id: Id404e0427b150b6301c3b73bf3a5eecfe871781c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637501 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#844811}
-
Xida Chen authored
TBR=eirage@chromium.org NOTRY=true Bug: 1168170 Change-Id: I675d070a129826054f285085ff1f6771caa3a1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636839Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#844810}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. Bug: 1145565 Change-Id: I41c527483afce87b1b28c3345bd5d23f1d0140a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635071Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844809}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611024810-772a0a2d15ca5658988961a1c7ea3d1b91cdca35.profdata to chrome-win32-master-1611057528-c042fc837e99141efabc34633cbdaeed88679432.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I339d3cd859debf9ccd9852f2742216138fb55602 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637894Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101190600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/V5FYlmqYUEfkAqfSEHzekB27KIr2sLJjCa2Z4wp13lYC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/154430508,b/172415656,b/176852796,b/177381366,b/177381582,b/177382762,b/177604649,b/177774996,b/177784709,b/177856222 Tbr: media-app@grotations.appspotmail.com Change-Id: I462173835d168002c92edaf819f63716febfc959 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637738Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#844807}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cc7aa8e318bb..0bc32f23f69e 2021-01-19 reed@google.com Add query to test our cached convexity If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: Ice90967ddd3c0086a53ce5ec24c04d2a101b709d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637896Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/66a69e614cbb..c895583f9314 2021-01-19 inker@google.com chromite: add hotline group to expected group of base profile 2021-01-18 chrome-bot@chromium.org Update config settings by config-updater. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I1dbcae8cd4773b413ff1f1aaceaa1b8c786d2d21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637897Reviewed-by:
-
Xida Chen authored
TBR=eirage@chromium.org NOTRY=true Bug: 1156793 Change-Id: I7814bd0d0267038f00fbf3cb18230559b6c32d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637399Reviewed-by:
-
Xida Chen authored
The test is flaky on win and linux TBR=eirage@chromium.org NOTRY=true Bug: 1150197 Change-Id: I8f7913aac1dcb45facd26212cb9985702438e39c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637257Reviewed-by:
-
Olivier Li authored
This is the first step needed to enable defining a similar class that will detect different chromium usage scenarios to be recorded alongside power use. Bug: 1153193 Change-Id: I29e59a8cffae7cc5962882f78c8fbbf29073a170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597013 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#844802}
-
Mike Taylor authored
Note: after this CL lands, mozilla0011-test and mozilla0011-expected will still be around. The intent is to port that with the rest of the domain-test.html tests. Here's a mapping from the legacy http-state/general-tests.html to their new location (found in wpt/cookies/), which will have a cookie with some variation of test=N in it. 0001 => Not ported. Already covered. 0002 => test=3 (attributes/expires.html) 0003 => test=4 (attributes/expires.html) 0004 => Not ported. Already covered. 0005 => test=2 (attributes/max-age.html) 0006 => test=3 (attributes/max-age.html) 0007 => test=14 (attributes/invalid.html) 0008 => test=15 (attributes/invalid.html) 0009 => Not ported. Basically the same as test=14 and 15 and otherwise covered. 0010 => Not ported. Already covered. 0011 => test=16 (attributes/invalid.html) 0012 => test=17 (attributes/invalid.html) 0013 => test=12 (name/name.html) 0014 => testA=13 (name/name.html) 0015 => a=test14 (name/name.html) 0016 => z=test15 (name/name.html) 0017 => z=test16 (name/name.html) 0018 => test=18 (attributes/invalid.html) 0019 => test=19 (attributes/invalid.html) 0020 => test=20 (attributes/invalid.html) 0021 => test=16 (name/name.html) 0022 => test=22 (value/value.html) 0023 => test=21 (attributes/invalid.html) 0024 => test=22 (attributes/invalid.html) 0025 => test=23 (attributes/invalid.html) 0026 => test=24 (attributes/invalid.html) 0027 => test=17 (name/name.html) 0028 => test=25 (attributes/invalid.html) Here's the mapping for http-state/mozilla-tests.html: mozilla0001 => test=4 (attributes/max-age.html) mozilla0002 => Not ported. Dupe of test=3 in max-age.html. mozilla0003 => test=5 (attributes/expires.html) mozilla0004 => Not ported. Covered by test=2 in max-age.html. mozilla0005 => test=5 (attributes/max-age.html) mozilla0006 => Not ported. Covered by test=2 in max-age.html (and dupe of mozilla0004?) mozilla0007 => Not ported. Dupe of mozilla0003. mozilla0008 => test=6 (attributes/max-age.html) mozilla0009 => test=7 (attributes/max-age.html) mozilla0010 => test=8 (attributes/max-age.html) mozilla0011 => Not ported yet, will be ported as part of Bug 1159858 mozilla0012 => test=9 (attributes/max-age.html) mozilla0013 => test=10 (attributes/max-age.html) mozilla0014 => Not ported. Covered by test7 in value.html mozilla0015 => test=11a (attributes/name.html) mozilla0016 => test=11b (attributes/name.html) mozilla0017 => test=11c (attributes/name.html) Bug: 1159862 Change-Id: I662c4af50289fef313ddf0c509a30ab6b24c88b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628259Reviewed-by:
Steven Bingler <bingler@chromium.org> Commit-Queue: Mike Taylor <miketaylr@chromium.org> Cr-Commit-Position: refs/heads/master@{#844801}
-
Evan Stade authored
Bug: 1164069 Change-Id: I5061c1c90688daf15ee2c42e233eaee37a9ea77b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626196 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#844800}
-
ckitagawa authored
This CL re-enables the ContinuousSearchTabHelperTest. To de-flake, the following actions were taken: - Change how URLs were loaded. - Increase time delay for Handler.postDelayed. - Added more helpful debugging information in the event the loadUrl fails. Tested using run-swarmed on Nexus 5X and appears to no longer be flaky. Bug: 1157325 Change-Id: I5023c4ef3e3055ac007ac5dfd36577c42dde050f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626426Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#844799}
-
Zhiyuan Cai authored
Bug: 1163136, 1166702, 1166704 Change-Id: If1ab00206e17596230ff5874a9d98da896dc15ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2629694 Commit-Queue: Zhiyuan Cai <zhiyuancai@google.com> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#844798}
-
Stephen Chenney authored
We do not support context-fill and context-stroke for defining colors in SVG. Bug: 367737 Change-Id: I633fdfda851d0fe359d713bc18a476959c23edb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637394Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#844797}
-
Mark Edward Winter authored
Fixed the typo of obfuscated in the field obfudscated_gaia_id in ChromeSignedInUser R=zmin@chromium.org Bug: 1036237 Change-Id: Ic39fce4d836af6cf3f69fed9a061330127f87b2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636004 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#844796}
-
Hans Wennborg authored
These flags were removed in crrev.com/824947 but the win thinlto flag was accidentally left behind. Bug: 1127713 Change-Id: Ie7698e4a5819eb2dcd97effcf3715f208f75801f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637577 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#844795}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/29bd8638adb0..6cdb67fb33ed 2021-01-19 danilchap@webrtc.org Document expected thread safety of the TaskQueue interface 2021-01-19 webrtc-version-updater@webrtc-ci.iam.gserviceaccount.com Update WebRTC code version (2021-01-19T04:01:32). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ice33cb7d048d32f7dc0136c4d80f05650ec3fc46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637736Reviewed-by:
-
Philipp Hancke authored
BUG=webrtc:2488 Change-Id: Ie69222d78cebf881a311e3d9590a7367a44bc4d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627519 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#844793}
-
Evan Shrubsole authored
Was set to the wrong value in https://chromium-review.googlesource.com/c/chromium/src/+/2621817 Bug: 1156144 Change-Id: I82ddd9432ca6aa10ad9ab01edd0cae2fdc45610c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637578 Commit-Queue: Evan Shrubsole <eshr@google.com> Reviewed-by:
-
Wez authored
Several of the AccessibilityBridgeTest suite's tests expect exact numbers of commit calls to the SemanticTree, which will not be met in general due to the asynchronous nature of e.g. page loads. Also rename the TestNavigation to give it a less generic sounding name. Bug: 1168126, 1167266 Change-Id: I51d557face6c31ee3b6649cc5a28f784311d64b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637500 Commit-Queue: Wez <wez@chromium.org> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202101190600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/8CHDR6OyUJOhDursCeohpsk9HLyo0NS2MhikX4GjSPgC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Id52d3245940ff39276a3aef3822fbbb07a993af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637893Reviewed-by:
-
Xida Chen authored
[sheriff] Disable ProactivelySwapBrowsingInstancesSameSiteTest.StorageModificationAfterPagehideHistogram This is flaky on all major platforms. TBR=eirage@chromium.org NOTRY=true Bug: 1156218 Change-Id: Ic8893aad0a1e1b1c55f1ae7c6220d17e7b03b5d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637075Reviewed-by:
-
Yuta Hijikata authored
This is in preparation to switching lacros-chrome from target_os="linux" to target_os="chromeos". The change is made so that the behaviour of lacros-chrome is consistent. More detail on http://go/lacros-macros. Bug: chromium:1052397 Change-Id: Icfc3a9418fb83c9d91e0ecdce8cab9db48cc1ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636906 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Yuta Hijikata <ythjkt@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#844788}
-
Dominique Fauteux-Chapleau authored
This fixes the crash observed in crbug.com/1166233 and adds tests for it. See the comments in that bug for more details. This fix also removes the dialog for unauthorized users for pasting after the initial scan that does authentication, so crbug.com/1028133 is affected. Bug: 1166233, 1028133 Change-Id: Id3c992fdeccfa92a9f88e25c13e7a15bcb1afd8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633701Reviewed-by:
anthonyvd <anthonyvd@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#844787}
-
danakj authored
There are no observers to inform as this happens before RenderFrameCreated, so we can just remove it. R=dcheng@chromium.org Bug: 1158869 Change-Id: Ib42a75e89b6f2391c994062effb54f24d4b7d14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633921Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#844786}
-
Sebastien Marchand authored
Bug: 1153193 Change-Id: I09fcbbbe6335dfbc420d551957399a2999e3b97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624768 Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#844785}
-
Andrew Grieve authored
Codesearch indexes with is_java_debug=true, so this change will allow looking up method hashes via codesearch. Bug: None Change-Id: I1d8d841073c5ef502d1e1b421a411894776e4cf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636297 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#844784}
-
Jonathan Ross authored
With DCHECKs enabled base::HashInts uses a random seed, which is only valid in its process. This means that a given viz::LocalSurfaceId would have different hashes in different process. Which breaks performing Traces with Flow. Additionally while debugging issue 1060058 I noticed it was difficult to know when Viz was blocked on pending surfaces, and when rotations were occurring. This change adds a new trace to viz::Surface to list the Surface being waited on. As well as adding new traces to LayerTreeHost to denote the current viewport rect. Bug: 1154826 Change-Id: I60d9f2f195ae6ca45e9eabd101df971462b34224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633098 Commit-Queue: Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#844783}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/95612c220891..9e417d1e36be 2021-01-19 alexrudenko@chromium.org Increase required contrast for color suggestions 2021-01-19 janscheffler@chromium.org [JSDOC2TS]: Migrate recorder 2021-01-19 tvanderlippe@chromium.org Migrate trimMiddle to string-utilities 2021-01-19 jacktfranklin@chromium.org Fix type of DataGrid renderer. 2021-01-19 alexrudenko@chromium.org Fix the size of the select in Layout pane If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1050549,chromium:1158760 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0d323dd190b35774c6417ca7cc81496b462f44bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636926Reviewed-by:
-
Victor Costan authored
The Google C++ style guide recommends explicit constructors, with a few exceptions where implicit conversion is desirable. Implicit conversion between TaskRunner and RefCountedDeleteOnSequence seems surprising. This CL does not introduce any functional changes. Change-Id: I1ccf85fa5a673e7a91dd6090676788d682890412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634866 Auto-Submit: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Luke Zielinski authored
Bug: 1168130 Change-Id: I6f7e3a0e5b6b9d5eb758c368d61d5366cbd3d6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637455 Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Luke Z <lpz@chromium.org> Cr-Commit-Position: refs/heads/master@{#844780}
-
Xida Chen authored
This reverts commit d660a480. Reason for revert: Test fails: https://ci.chromium.org/ui/p/chromium/builders/ci/Win%207%20Tests%20x64%20(1)/76721/overview Original change's description: > [profiles] Clean up guest ephemeral profile on startup > > This CL fixes a bug which leads to the guest ephemeral profile not being > cleaned up on startup if it has been left over in the previous session. > > ProfileManager::CleanUpEphemeralProfiles() needs to pass the `true` > parameter in ProfileAttributesStorage::GetAllProfilesAttributes() to get > the full list of registered profiles. > > Bug: 1167883 > Change-Id: I3051a9174e8472eb2af046126be88dbfb44bcb47 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635158 > Commit-Queue: Alex Ilin <alexilin@chromium.org> > Reviewed-by: David Roger <droger@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844749} TBR=droger@chromium.org,alexilin@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I6fb55866ddcda42c54d60aaa2e823da18b353348 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1167883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637395Reviewed-by:
-
