GitLab

Currently, the user can unlock their device using one of three methods:
  - their password,
  - a PIN or password,
  - no authentication.

The setup pin screen is in a dependent CL.

The choose-method screen is available from the /quickUnlock/chooseMethod
endpoint.

BUG=603217
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2097673002
Cr-Commit-Position: refs/heads/master@{#405249}

BUG=627578
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2141063003
Cr-Commit-Position: refs/heads/master@{#405248}

Mostly removing unneeded methods, reworked mute console.

BUG=none

Review-Url: https://codereview.chromium.org/2139363003
Cr-Commit-Position: refs/heads/master@{#405247}

Now that the shards are more evenly distributed, this is feasible.
Increase the number of shards to handle the additional ~15 minutes of
run time.

BUG=586033
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2133673003
Cr-Commit-Position: refs/heads/master@{#405246}

no_pch and disable_precompiled_headers do the same thing; drop one of them.

No behavior change.

BUG=none

Review-Url: https://codereview.chromium.org/2148953002
Cr-Commit-Position: refs/heads/master@{#405245}

Clean up compositor_model_bench code.
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2145543002
Cr-Commit-Position: refs/heads/master@{#405244}

Got reverted due to breaking
WebRtcWebcamBrowserTests/WebRtcWebcamBrowserTest.MANUAL_TestAcquiringAndReacquiringWebcam/0
in some WebRtc Mac bot, possibly because it has no real WebCam
or it has one without  AVCaptureStillImageOutputClass support.

This CL adds a guard  [captureSession_ canAddOutput:...]
before [captureSession_ addOutput:...]

Original description ----------------------------------------------
ImageCapture: Implement takePhoto() for Mac AVFoundation

By pulling the necessary symbols out of AVFoundation
and using them; most notably (Cr)AVCaptureStillImageOutput.

TakePhoto is already implemented for Android (both APIs).

Also adding VideoCaptureDeviceTest::MAYBE_TakePhoto
test case, enabled only for Mac.

BUG=518807
TEST=Run build with flag --enable-blink-features=ImageCapture,
navigate to [1] and push buttons
- Open Camera ...
- Create ImageCapturer
- takePhoto()  (N times!) --> profit

[1] https://rawgit.com/Miguelao/demos/master/imagecapture.html

TBR=rsesek@chromium.org since the change is trivial.

Review-Url: https://codereview.chromium.org/2146973002
Cr-Commit-Position: refs/heads/master@{#405243}

When file loading is finished ResourceMultiBufferDataProvider count
DataBuffer queue size twice, so GetSize returned incorrect value.

BUG=625515, 627525, 624853

patch from issue 2110853006 at patchset 1 (http://crrev.com/2110853006#ps1)

Review-Url: https://codereview.chromium.org/2133803004
Cr-Commit-Position: refs/heads/master@{#405242}

StopReason is passed to following observer methods:
- ArcBridgeBootstrap::Observer::OnStopped
- ArcBridgeService::Observer::OnBridgeStopped

Those callbacks can now tell the reason the bridge stopped.

I am planning to use this soon to show notifications on failures.
See the bug entry for more details.

BUG=chromium:625923
TEST=components_unittests --gtest_filter=ArcBridgeTest.*
TEST=Manually verified that ARC boots.

Review-Url: https://codereview.chromium.org/2133653002
Cr-Commit-Position: refs/heads/master@{#405241}

Revert of Enable PassiveDocumentEventListeners on waterfall. (patchset #2 id:20001 of https://codereview.chromium.org/2119403002/ )

Reason for revert:
Revert this for now. We are seeing cc:scheduler changes as a result of this and we need to understand them better and I'm not going to be in the office the next two days.

Original issue's description:
> Enable PassiveDocumentEventListeners on waterfall.
>
> Enable passive document event listeners finch experimentl on waterfall.
>
> BUG=625675
> R=rkaplow@chromium.org
>
> Committed: https://crrev.com/19233086ad7e2363e7e1d14582dc6a5428816169
> Cr-Commit-Position: refs/heads/master@{#404351}

TBR=rkaplow@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=625675

Review-Url: https://codereview.chromium.org/2149673002
Cr-Commit-Position: refs/heads/master@{#405240}

This reverts commit 198e264e.

The root cause of the crash has been fixed and we don't need this patch now.

BUG=625357
TBR=warx@chromium.org

Review-Url: https://codereview.chromium.org/2151613002
Cr-Commit-Position: refs/heads/master@{#405239}

This protocol allows the wayland server to notify the client of
connected gamepads and their state.
The protocol does not support axis mapping but assumes the use of the
'Standard Gamepad' as defined by the W3C gamepad API.

BUG=620977

Review-Url: https://codereview.chromium.org/2093803002
Cr-Commit-Position: refs/heads/master@{#405238}

Removes support for the old field-at-a-time autofill on iOS. Full-form
has been enabled for all iOS users for many months.

Corresponding internal change:
https://chromereviews.googleplex.com/470777015

BUG=504644,268279

Review-Url: https://codereview.chromium.org/2146523004
Cr-Commit-Position: refs/heads/master@{#405237}

BUG=none

Review-Url: https://codereview.chromium.org/2145873002
Cr-Commit-Position: refs/heads/master@{#405236}

BUG=610376

Review-Url: https://codereview.chromium.org/2130623002
Cr-Commit-Position: refs/heads/master@{#405235}

This CL does some minor changes to web_js_test.h based on eugenebut's
recommendations in https://codereview.chromium.org/2150513002/#msg21.

R=eugenebut@chromium.org
BUG=627775

Review-Url: https://codereview.chromium.org/2148723003
Cr-Commit-Position: refs/heads/master@{#405234}

Remove the last use case of texture-backed SkBitmaps in Chroimum.

Review-Url: https://codereview.chromium.org/2143183004
Cr-Commit-Position: refs/heads/master@{#405233}

 - Force render parts of the page that should be searched but
   are currently not rendered.
 - Ensuring that searching code yields often enough to the main
   thread to prevent UI freeze.

Specifically
 - Adding three types of tasks TopLevelSearchTask, SearchTask and
   RenderTask.
 - Adding a task manager class, which yields before executing a
   task by using window.requestIdleCallback().
 - Canceling obsolete tasks (happens when a new search is issued after the
   task was posted but before it made it to the front of the queue).

BUG=608535
TEST=Navigate to chrome://md-settings. Search for a term that exists in
an unrendered sub-page, for example "engine". Navigate to the subpage by
clicking "Manage search engines". Notice that matches are magically
highlighted even though this subpage was not rendered when the search was
initiated.

CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2103133007
Cr-Commit-Position: refs/heads/master@{#405232}

ash::PlaySystemSound* methods are used only from chrome. The code in ash
plays sounds through the AccessibilityDelegate interface. So remove these
methods from ash. This has two benefits: (1) ash no longer has dependency
on media, and (2) media::SoundsManager is initialized from chrome. So it
makes sense to move its usage into chrome as well.

BUG=none

Review-Url: https://codereview.chromium.org/2142463002
Cr-Commit-Position: refs/heads/master@{#405231}

Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/kJMa2rpAYqI
Dashboard: https://www.chromestatus.com/feature/6687420359639040

R=foolip@chromium.org
BUG=496901

Review-Url: https://codereview.chromium.org/2023123002
Cr-Commit-Position: refs/heads/master@{#405230}

CronetEngine.createRequest has been deprecated. This
CL changes the test to use the new Builder API.
R=kapishnikov@chromium.org
BUG=547970

Review-Url: https://codereview.chromium.org/2142953002
Cr-Commit-Position: refs/heads/master@{#405229}

This patch updates the code to prevent auto deducing to a raw pointer.

R=nyquist, danakj, dcheng
BUG=554600

Review-Url: https://codereview.chromium.org/2102173003
Cr-Commit-Position: refs/heads/master@{#405228}

This is just code cleanup, IsSigninProfile does the same thing. This affects chromeos only.

BUG=
TBR=skuhne@chromium.org

Review-Url: https://codereview.chromium.org/2149603003
Cr-Commit-Position: refs/heads/master@{#405227}

A few https engagement tests used the test server resource at URL '/'.
It turns out that this resource gets served with mime type text/plain,
which we're planning to have page load metrics infrastructure ignore
in the future. This change switches those tests to use '/simple.html'
which is served with mime type text/html.

Additionally, this change adds a new test
Navigate_Both_NonHtmlMainResource, which we'll use to verify that we do
not track non-HTML resources.  The test currently asserts that we do
track these resources, with a comment explaining that we'll update it
to assert they are untracked as part of fixing bug 627536.

BUG=627536

Review-Url: https://codereview.chromium.org/2148473002
Cr-Commit-Position: refs/heads/master@{#405226}

According to the X11 doc: "The created window is placed on top in
the stacking order with respect to siblings."  Since all windows
that DWTHX11 creates are children of the root window, they are
all siblings, so new windows should instead be added to the front
of the stacking list.

BUG=556048

Review-Url: https://codereview.chromium.org/2148923002
Cr-Commit-Position: refs/heads/master@{#405225}

The app-menu button upgrade icon is a circle, while the menu item used a rounded rectangle. This ensures the menu image/icon is consistent with the button icon.

BUG=626915

Review-Url: https://codereview.chromium.org/2138103002
Cr-Commit-Position: refs/heads/master@{#405224}

InstantPage objects are never instantiated except as InstantTab, which
is its only subclass.

BUG=627747

Review-Url: https://codereview.chromium.org/2144733004
Cr-Commit-Position: refs/heads/master@{#405223}

This patch is to make SyntheticPointerAction handle touch actions for multiple fingers, which will be dispatched together in one frame.

Next patch: Modify SyntheticGestureController to queue all the actions in one SyntheticPointerAction until we see a PROCESS action, then pushing in a queue and flush.
Make sure mouse actions also work.
Put the TouchActionSequence in the GpuBenchmarking for now.

Please see the design doc here:
https://docs.google.com/document/d/1adz5Xb1hYt6SCRdMdhR2EXjhvF-AqshCIhZv7jVuZF4

BUG=525187

Review-Url: https://codereview.chromium.org/1884883005
Cr-Commit-Position: refs/heads/master@{#405222}

Revert of Color: Don't duplicate ICC profile data (patchset #3 id:40001 of https://codereview.chromium.org/2140803002/ )

Reason for revert:
Broke static initializers step of sizes on Linux:
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/22278

Maybe making map_ a base::LazyInstance would solve your problem?

Original issue's description:
> Color: Don't duplicate ICC profile data
>
> Make gfx::ColorSpace have an internal pointer to a globally-unique
> structure for the color space, where its ICC profile can be stored.
>
> BUG=622133
>
> Committed: https://crrev.com/92294e78c762e993e8dcf538860abf65629f3320
> Cr-Commit-Position: refs/heads/master@{#405211}

TBR=hubbe@chromium.org,ccameron@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=622133

Review-Url: https://codereview.chromium.org/2148013002
Cr-Commit-Position: refs/heads/master@{#405221}

Cr-Commit-Position: refs/heads/master@{#405220}

../../chrome/installer/mac/app/NetworkCommunication.m:48:17: error: 'dataTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability]
      [session_ dataTaskWithRequest:request_
                ^
/Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:203:1: note: 'dataTaskWithRequest:completionHandler:' has been explicitly marked partial here
- (NSURLSessionDataTask *)dataTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSData *data, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0);
^
../../chrome/installer/mac/app/NetworkCommunication.m:48:17: note: explicitly redeclare 'dataTaskWithRequest:completionHandler:' to silence this warning
      [session_ dataTaskWithRequest:request_
                ^
../../chrome/installer/mac/app/NetworkCommunication.m:57:30: error: 'downloadTaskWithRequest:completionHandler:' is partial: introduced in macOS 10.9 [-Werror,-Wpartial-availability]
    downloadTask = [session_ downloadTaskWithRequest:request_
                             ^
/Applications/Xcode5.1.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.10.sdk/System/Library/Frameworks/Foundation.framework/Headers/NSURLSession.h:218:1: note: 'downloadTaskWithRequest:completionHandler:' has been explicitly marked partial here
- (NSURLSessionDownloadTask *)downloadTaskWithRequest:(NSURLRequest *)request completionHandler:(void (^)(NSURL *location, NSURLResponse *response, NSError *error))completionHandler NS_CLASS_AVAILABLE(NSURLSESSION_AVAILABLE, 7_0);
^
../../chrome/installer/mac/app/NetworkCommunication.m:57:30: note: explicitly redeclare 'downloadTaskWithRequest:completionHandler:' to silence this warning
    downloadTask = [session_ downloadTaskWithRequest:request_
                             ^

R=dpranke@chromium.org, mark@chromium.org
BUG=627890

Review URL: https://codereview.chromium.org/2144033002 .

Cr-Commit-Position: refs/heads/master@{#405219}

git cl try now schedules CQ dry run by default.

BUG=577224
R=sergiyb@chromium.org,phajdan.jr@chromium.org

Review-Url: https://codereview.chromium.org/2151543002
Cr-Commit-Position: refs/heads/master@{#405218}

This creates a copy of the downstream web_js_test.h upstream in
ios/web/public/test and puts it into the ios_web_test_support build target
(+equivalent in GN).

The upstream web_js_test.h is an almost-identical copy of the downstream version, with 2 differences:
  (1) git cl format is required upstream, which changed indenting in a single location.
  (2) namespace web was introduced to match the style of the target directory.

BUG=627775

Review-Url: https://codereview.chromium.org/2150513002
Cr-Commit-Position: refs/heads/master@{#405217}

DevTools: Move Spectrum from elements/ to components/ so that it can be used in both Sources and Elements.

Review-Url: https://codereview.chromium.org/2142133002
Cr-Commit-Position: refs/heads/master@{#405216}

DevTools: Added styling to checkboxes so that a focus state is displayed when tabbing through the checkboxes (for keyboard accessibility).

BUG=580199

Review-Url: https://codereview.chromium.org/2096183002
Cr-Commit-Position: refs/heads/master@{#405215}

BUG=626740

Review-Url: https://codereview.chromium.org/2142283002
Cr-Commit-Position: refs/heads/master@{#405214}

media/audio/audio_device_description.h.  The renderer needs a way to specify which audio device the sound should be play out.

Bug=b/28193093

Review-Url: https://codereview.chromium.org/2016053003
Cr-Commit-Position: refs/heads/master@{#405213}

Each story in the benchmark does the following:
1. Load the main page.
2. Open and scroll the first news item.
3. Go back to the main page and scroll it.
4. Open and scroll the second news item.
5. Go back to the main page and scroll it.
6. etc.

This workflow is interesting because it is close to real world
and generates a lot of garbage by creating and discarding pages.

A couple of websites crash with OOM on svelte device, so by
tracking and optimizing for this benchmark we can improve
user experience on low-memory devices.

*** NOTE TO SHERRIF ***
Regressions are expected in system_health.memory_mobile and
system_health.memory_desktop for the following stories:
- load:news:cnn
- load:social:facebook
- load:news:qq
- load:news:reddit
- load:social:twitter

If there are failing tests in form of benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.*
please do not revert this CL but instead disabling failing
test by adding them into the _DISABLE_TESTS list in
tools/perf/benchmarks/system_health_smoke_test.py

BUG=589726
CQ_INCLUDE_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2118293002
Cr-Commit-Position: refs/heads/master@{#405212}

Make gfx::ColorSpace have an internal pointer to a globally-unique
structure for the color space, where its ICC profile can be stored.

BUG=622133

Review-Url: https://codereview.chromium.org/2140803002
Cr-Commit-Position: refs/heads/master@{#405211}

Eliminates races between IPCChannelPosixTest instances
which were all using the same named pipe path to establish
an IPC channel.

BUG=627730
R=amistry@chromium.org

Review-Url: https://codereview.chromium.org/2141403002
Cr-Commit-Position: refs/heads/master@{#405210}