GitLab

It currently only takes in paths. Taking in an already opened file will
allow it to be used in a sandboxed process with limited ability to open
files itself.

Previously, when an upload was retried, the old FileStream would be
deleted, and a new one created and the file re-opened. This won't work
with the aforementioned sandbox, so instead, rewind the file.

This also means that when there's an operation in progress when we try
to re-initialize the UploadFileElementReader, it has to wait for the
previous operation to complete. In order to achieve this, this CL
switches UploadFileElementReader to using a DoLoop pattern.

Bug: 777879
Change-Id: I6b1f9f9ec727c588ca99427b949bc7410068b314
Reviewed-on: https://chromium-review.googlesource.com/772978
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Randy Smith <rdsmith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517624}

With this CL, these resources are no longer specified in all caps.
Instead, they are converted to all caps before rendering.

Bug: 779669
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Iac4c83813a649949aa130677b23b06be259a9685
Reviewed-on: https://chromium-review.googlesource.com/777861
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Reviewed-by: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517623}

The bug is fixed upstream

BUG=internal b/32972611
TEST=Run TimeFormattingTest*

Change-Id: Iadeab960f2eb67913a3d4f3bb302b8b95f200d4c
Reviewed-on: https://chromium-review.googlesource.com/777402Reviewed-by: Stephen Lanham <slan@chromium.org>
Commit-Queue: Bailey Forrest <bcf@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517622}

Change-Id: Ifeee6108329beaf8f254af37f46bccf66ee06239
Reviewed-on: https://chromium-review.googlesource.com/777639Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517621}

Clipping will be re-enabled with a more robust solution for
newer versions of chrome, that will expose both the clipped
and unclipped bounds to ChromeVox.

Bug: 786164
Change-Id: Ia22fc00236168f9ba41841f6810b72bdd24d4612
Reviewed-on: https://chromium-review.googlesource.com/777541
Commit-Queue: Katie D <katie@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517620}

This change adds a feature flag and the piping to hook up & run a mojo
implementation of SessionStorage. Nothing is implemented yet and all
calls trip a NOTREACHED - this is just the setup for the renderer side
of the feature.

Bug: 716490
Change-Id: Id3ad5cf3fa1e27bf7e5ef9369818d94a1a5364d3
Reviewed-on: https://chromium-review.googlesource.com/767287Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Daniel Murphy <dmurph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517619}

- Remove the Android Manifest DAL that is done in
canSessionLaunchInTrustedWebActivity which is always called on UI
thread.
- To reliably handle the above missing check before launching the
TrustedWebActivity add a related param to SessionParams
- Make the same call as a part of validateRelationship and cache the
result to be used later
- Fixes to validateRelationship threading and calling order.

BUG=782904

Change-Id: Ief5432bc7004e56f9106d58ddbff31d69d0ddc55
Reviewed-on: https://chromium-review.googlesource.com/759232
Commit-Queue: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517618}

Some of the selection tests are flaking because they long-press the wrong node.
There was a similar problem in IMETests that was fixed in
https://chromium-review.googlesource.com/c/chromium/src/+/773105 by making
the test html small enough to avoid any scrolling. This CL attempts to solve
the flakiness using the same method.

Change-Id: If9a1ac5653c21bcd1bb79dbbde43ec4a35bae985
Reviewed-on: https://chromium-review.googlesource.com/777607Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517617}

BUG=773489
R=thestig@chromium.org

Change-Id: I753e3a2916d357a19c9194930da3b1c69978cf1f
Reviewed-on: https://chromium-review.googlesource.com/777465Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517616}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/4f332747..e6c939ba

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: If4ce9c1ec8c4c5ddc07338d742414859035a35be
Reviewed-on: https://chromium-review.googlesource.com/777586Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517615}

Add a gfx::SwapResponse that contains the swap result and the timing
information for every swap.

Let the client add those timestamps to cached LatencyInfos rather
than passing LatencyInfo to the GPU service to modify and send back.

Behaviorally, this patch is a no-op, but the intent is to:
1) Simplify later patches that will add timestamps to the SwapResponse.
2) Step towards removing PassThroughImageTransportSurface.
3) Remove gpu's dependency on ui/latency_info, which was a layering smell.

Bug: 769415
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9e1ac97d32600d13ee05467d70fad5674e1355f0
Reviewed-on: https://chromium-review.googlesource.com/767572
Commit-Queue: Brian Anderson <brianderson@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517614}

Migrates most of the tests in these directories:
websocket/
timeline-time/
timeline-style/
timeline-paint/
timeline-network/
timeline-misc/

Bug: 667560
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Ib91f9c397767c46f19a52af909d522b29d308559
Reviewed-on: https://chromium-review.googlesource.com/777421
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Reviewed-by: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517613}

https://skia.googlesource.com/skia.git/+log/3e4d1fde7fab..39631f3df172

$ git log 3e4d1fde7..39631f3df --date=short --no-merges --format='%ad %ae %s'
2017-11-17 bsalomon Add Atlas Text interface for rendering SDF glyphs.
2017-11-17 benjaminwagner Specify image dimension for all Win2016 tasks.
2017-11-17 ethannicholas converted Premul / Unpremul to SkSL
2017-11-17 brianosman Revert "Revert "Revert "Revert "Revert "Add private grpixelconfigs for alpha_8 and alpha_half"""""
2017-11-16 herb Remove api call from SkGaussFilter
2017-11-17 benjaminwagner Specify image dimension for Win2016.
2017-11-17 egdaniel Revert "Revert "Revert "Revert "Add private grpixelconfigs for alpha_8 and alpha_half""""
2017-11-17 angle-deps-roller Roll skia/third_party/externals/angle2/ 2c7f34c83..3d70ca9cc (1 commit)
2017-11-17 liyuqian Do not return null paint if shaderFP is null
2017-11-17 bsalomon Revert "Revert "Add method to sk_gpu_test::TestContext to automatically restore the previous context.""

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I7ee07c54dea0a222cbf5cf318172ef881106caf0
Reviewed-on: https://chromium-review.googlesource.com/777760Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517612}

Change-Id: I21815d765aaa22a3601d21fdcc26a0f0d5df862f
Reviewed-on: https://chromium-review.googlesource.com/777547Reviewed-by: Matt Mueller <mattm@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517611}

Dump real and virtual current contexts, command decoder's context, and
what IsCurrent returns.

R=piman
BUG=724999

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I086efa8b7c5f0e7108b1fd4c6502c3d4824b862e
Reviewed-on: https://chromium-review.googlesource.com/767567Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517610}

This change updates the FYI filter to block a known failing test.
This change updates the main filter to match the FYI filter.
This change also adds viz_content_browsers to the Mojo Linux FYI bot to start
getting an idea of our current coverage/failures on Linux

TEST=viz_content_browsertests

Bug: 760181
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Id1744c21afdcce06312074962451e440bf6eb604
Reviewed-on: https://chromium-review.googlesource.com/776623Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517609}

There seem to be OS-level race conditions in restoring the system's
color profile (to Color LCD from the sRGB color profile) and these
seem to be worked around by leaving the system using the sRGB profile
after the tests exit.

BUG=784456

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I09e588f1e8f6dc9c948fd6f2a30e912bc88c820e
Reviewed-on: https://chromium-review.googlesource.com/775625Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517608}

This roll includes one commit:
- [inspector_protocol] generated only used types.

R=dgozman@chromium.org

Bug: chromium:778796
Change-Id: I1bbf953340308b1f3ccbfa972dd2cc2a65dab439
Reviewed-on: https://chromium-review.googlesource.com/775619
Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517607}

This CL instantiates an AutocompleteController upon first use, and
supplies resulting matches to the UI.

BUG=777542

Change-Id: I1d7323f0bc4889f4e93664c129253adb921df8f5
Reviewed-on: https://chromium-review.googlesource.com/772979
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517606}

U+0131 (doltess i) and U+0237 (dotless j) are blocked from being
followed by a combining mark in U+0300 block.

Bug: 774842
Test: See the bug
Change-Id: I92aac0e97233184864d060fd0f137a90b042c679
Reviewed-on: https://chromium-review.googlesource.com/767888
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517605}

https://webrtc.googlesource.com/src.git/+log/c296255c7ee7..2707fb2782e7

$ git log c296255c7..2707fb278 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I41fa407360e037cfaabff8c784d69ae5334411f1
Reviewed-on: https://chromium-review.googlesource.com/777741Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517604}

Do not add dialogs (buttons do not work). Dummy version of
destination loading animation, changes from spinner to destination
name and icon 5 seconds after load.

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I3359ec6e9b1687c7c56e1ef2bd454842aa90fe6c
Reviewed-on: https://chromium-review.googlesource.com/773561Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517603}

https://chromium.googlesource.com/webm/libvpx.git/+log/8c7213bc00b5..ea14a1a965c5

$ git log 8c7213bc0..ea14a1a96 --date=short --no-merges --format='%ad %ae %s'
2017-11-13 jianj vp9 svc: Rework/fix scale partitioning on boundary.
2017-11-15 johannkoenig fwd txfm ssse3: use GLOBAL() for loading constants
2017-11-14 marpan vp9-svc: Fix flag for usage of reuse-lowres partition
2017-11-14 slavarnway tiny_ssim.c : clang compile error fix
2017-11-13 jianj vp9 svc: Change conditions on VPX_ENCODER_ABI_VERSION.
2017-11-13 jimbankoski add 10 and 12 bit to tiny_ssim
2017-09-27 paulwilkins New content type to improve grain retention.
2017-11-06 paulwilkins Small parameter clean up.
2017-11-10 slavarnway vpx: [x86] add vpx_satd_avx2()
2017-11-07 jianj vp9: Fix mem rel for non-ref for external buffer.
2017-11-01 paulwilkins Fix to frames considered in arf boost calculation.
2017-10-10 paulwilkins CVBR command line option.

Created with:
  roll-dep src/third_party/libvpx/source/libvpx
R=johannkoenig@google.com

BUG=b/68819248

Change-Id: Ib8c3801cf427ad19d3a0ce592bdb40cef5465bd4
Reviewed-on: https://chromium-review.googlesource.com/777399Reviewed-by: Tom Finegan <tomfinegan@chromium.org>
Commit-Queue: Jerome Jiang <jianj@google.com>
Cr-Commit-Position: refs/heads/master@{#517602}

These seem to happen in a few different circumstances and there's
no real point to restricting to just AAC; the code is simpler and
we already have to handle this regardless downstream in rendering.

BUG=784008
TEST=new unittest

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I4e3d1dd9fee0ea1e0817046b13e085d683f5ad84
Reviewed-on: https://chromium-review.googlesource.com/777540Reviewed-by: Thomas Guilbert <tguilbert@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517601}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/23b8214cec26..0844d0e4444c

$ git log 23b8214ce..0844d0e44 --date=short --no-merges --format='%ad %ae %s'
2017-11-17 machenbach Revert "bot_update: make --output_json required in script invocation."
2017-11-17 flackr Revert "bot_update: make --output_json required in script invocation."
2017-11-15 tandrii bot_update: refactor _git_checkout moving invariants out of the loop.
2017-11-14 tandrii bot_update: make --output_json required in script invocation.

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: I6d6e4997b00955b4d1a95287da5ba0a6367f95ea
Reviewed-on: https://chromium-review.googlesource.com/777467Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517600}

Introduces a TabModelListObserver interface that notifies its
implementations when a TabModel is registered to a browser state.

Also makes loose utility functions in tab_model_list.h static functions
of the TabModelList and expands the unit tests for the TabModelList class.
Signed-off-by: Mohamad Ahmadi <mahmadi@chromium.org>
Bug: 738938
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie6dd56b8dd87467a3a5d280fc4f38ab35d9bad10
Reviewed-on: https://chromium-review.googlesource.com/772319Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517599}

Bug: NONE
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I583c207a627d26ad51d13c0f4e916dfb0e4ac134
Reviewed-on: https://chromium-review.googlesource.com/776238
Commit-Queue: Biao She <bshe@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517598}

Adding mohsen@ as the owner for gesture navigation.

Bug: NONE
Change-Id: Ia87c5bdfedbc899f828306b3fa7c33cb8685fd1c
Reviewed-on: https://chromium-review.googlesource.com/774995Reviewed-by: Mohsen Izadi <mohsen@chromium.org>
Commit-Queue: Mikhail Fomitchev <mfomitchev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517597}

This converts a batch of tests from the old test framework (html file)
into the new test framework (js file).

Most of it was done through an automated transformation script, with
a small amount of manual clean-up.

Bug: 667560
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I22a4805c3ad642c14f3cbee13001638d5c346c2b
Reviewed-on: https://chromium-review.googlesource.com/776037Reviewed-by: Alexei Filippov <alph@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517596}

Bug: 
Change-Id: I9347c378a49baec7f0e50b3904f8ee05dbeaec2c
Reviewed-on: https://chromium-review.googlesource.com/777879Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Klaus Weidner <klausw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517595}

The WithBaseSyncPrimitives() trait is deprecated.

ScopedAllowBaseSyncPrimitives(ForTesting|OutsideBlockingScope)
should be used instead.

Bug: 766678
Change-Id: Ib8e512a0c4f32ab7eec0ade8764495614bf3fb69
Reviewed-on: https://chromium-review.googlesource.com/703200Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517594}

When a browser plugin is recreated we destroy and create a new
BrowserPlugin. This necessitates reembedding the WindowTreeClient
from the renderer rendering the plugin (because the BrowserPlugin ows
the mus window).

To get the reembeding working required changing
RenderWidgetHostViewGuest to initiate embedding when attached, not
init.

As the renderer rendering the plugin gets a new connection to mus it
needed to be updated. A result of this is the connection to viz is
being dropped, which means ClientLayerTreeFrameSink is seeing it's
connection dropped. The connection is reestablished by way of calling
DidLoseLayerTreeFrameSink().

BUG=755328
TEST=covered by test

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I43838b38bedaf75a341262fcba3befaca77d5c87
Reviewed-on: https://chromium-review.googlesource.com/773104Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517593}

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: If7404806548362af847a58283cd543ef57215a85
Reviewed-on: https://chromium-review.googlesource.com/773818Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Yixin Wang <wangyix@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517592}

Up until now, there has been no way to ensure that no in-product help is
displayed during important user journeys. It can conceptually pop up at
any time.

This CL therefore adds a way to acquire a display lock that locks all
display of in-product help. It does not remove currently displaying
in-product help, but it does ensure nothing new is displayed.

When the protected user journey has finished, the lock must be
released to ensure that other in-product help can be displayed.

On most platforms, the lock is released simply by deleting the
DisplayLockHandle, which is given out as an std::unique_ptr. On Android,
there are two APIs, one in C++ (shared with the other platforms), and
one in Java. Since Java does not support destructors, a particular
release() method must be invoked on the DisplayLockHandle instead to
ensure that the C++ object is deleted.

These locks are tracked separately in UMA for why in-product help has
not been displayed: TriggerHelpUIResult.FAILURE_DISPLAY_LOCK.

BUG=776168

Change-Id: I388fe8d626a59c5128481d5758b3bb66821e0aa3
Reviewed-on: https://chromium-review.googlesource.com/758631
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517591}

Change-Id: Ib32799d4f3f7a41615f92b271994ace68ea1df45
Reviewed-on: https://chromium-review.googlesource.com/776028Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517590}

With WebUI we rely more on networkingPrivate events which are
triggered by NetworkStateHandler.

NetworkPropertiesUpdated is getting triggered more often than is
necessary. In areas with a large number of visible WiFi networks
this can generate significant extra work for the WebUI JS when
scanning (i.e. when the WiFI subpage is open).

This CL eliminates some uninteresting event notifications (most
of which were already removed from the log but were still firing
events).

Bug: 784026
Change-Id: I7ccf7dc443d6ce59ea36cf425cec6e9a1c1f0222
Reviewed-on: https://chromium-review.googlesource.com/773507
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517589}

There is a threading issue for ScopedFeatureList that it can't be called
in SetupOnMainThread in content browser test. From thread santinizer
log, it seems some early IO thread code is reading while main thread
ScopedFeatureList is writing into FeatureList.

This CL tries to write to FeatureList after the test started to run.

There is some conflicting comment and DCHECK in ScopedFeatureList and
ContentBrowserTest, that the comment in ScopedFeatureList suggests init
in Setup, where ContentBrowserTest::Setup has a DCHECK to suggest to init
in SetupOnMainThread. However, lots of tests do the init in test case
and don't have the flaky issue.

Bug: 782037
Change-Id: Ia6ca649b7df2b49f7e88de6a114d7d099290454b
Reviewed-on: https://chromium-review.googlesource.com/769793Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517588}

Multiple tests were manually waiting for bookmarks to load.

Bug: 638674
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Id6ac5f242478119aaaee673f8ac8d671a3638ad3
Reviewed-on: https://chromium-review.googlesource.com/777393Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Baxley <baxley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517587}

Updates Smart Text Selection to enable on WebView for O+ and for
Chrome to be O_MR1+.  This effectively reverts CL 773782 for WebView,
but leaves Chrome unchanged.

BUG=785033

Change-Id: Iccdb8a5a56d34cb5275a87260e95fa1974db8ce0
Reviewed-on: https://chromium-review.googlesource.com/776198
Commit-Queue: Donn Denman <donnd@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517586}

This converts a batch of tests from the old test framework (html file)
into the new test framework (js file).

Most of it was done through an automated transformation script, with
a small amount of manual clean-up.

Bug: 667560
Change-Id: I16afeab5237e191519abb2aa8c959569df28b9cf
Reviewed-on: https://chromium-review.googlesource.com/777389Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Will Chen <chenwilliam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517585}