- 26 Nov, 2019 40 commits
-
-
Mustaq Ahmed authored
User activation state sync across frames didn't previously consider outer-vs-inner WebContents boundary. As a result, a user interaction in an inner WebContents didn't activate any frames in the outer WebContents. This CL minimally completes the notification state propagation from inner to outer WebContents to fix the bug. Bug: 1013447 Change-Id: If06fa2c1c5c431b45219eeb4b75ec8cf93164042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907209Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#719142}
-
David Bienvenu authored
This is a partial revert of crrev.com/c/1686222, which changed app model ids to include the default profile name. That caused issues with duplicate taskbar icons, which were worse than the original bug being fixed. Bug: 1007911 Change-Id: I28da312817b4223b7be842acf71e2d14f39711c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934525 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#719141}
-
Andrew Grieve authored
There is one non-trivial one which I've just suppressed here, where CronetEngine.Builder.addPublicKeyPins() takes a Set<byte[]>. Apparently byte[] does not implement hashCode() nor compare(), so they should not be used as keys in maps/sets: https://errorprone.info/bugpattern/ArrayAsKeyOfSetOrMap Bug: 894616 Change-Id: I1feefa33a4d9a28f859b21ee0eeb051d969483cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934314Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#719140}
-
Denis Kuznetsov authored
It should remove flakiness upon shutdown. Bug: 997685 Change-Id: I7258be4a2be53e6e42e9fc0cebc23bd0d78d6fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934342Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#719139}
-
Bret Sepulveda authored
This patch rewrites all the tests in ToolbarActionsBarUnitTest that are relevant to the new UI into ExtensionsMenuViewUnitTest: * BasicToolbarActionsBarTest is converted to PinnedExtensionAppearsInToolbar and ReorderPinnedExtensions. Since ExtensionsToolbarContainer does not shrink to fit available space, that part of the test has not been converted. * ToolbarActionsReorderOnPrefChange is converted to PinnedExtensionsReorderOnPrefChange. * TestHighlightMode is not converted because highlight mode is not yet supported on the new UI. * The relevant part of TestActionFrameBounds is converted to PinnedExtensionLayout. * TestStartAndEndIndexes is not converted because ExtensionsToolbarContainer cannot be manually shrunk. * TestNeedsOverflow is not converted because there is no "overflow" container in the new UI. * ReuploadExtensionFailed is converted and split into two tests: ReloadExtension and ReloadExtensionFailed. This patch also disables the kExtensionsToolbarMenu feature for the ToolbarActionsBarUnitTest suite, so they will now pass when the feature is enabled by default. Bug: 984654 Change-Id: I287efbbe916354d7572ec0ea684cce86777213f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930816 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719138}
-
Yifan Luo authored
`Sec-Fetch-Dest` header for both manifests and resources should be `empty` for the requests called from application cache according to step 4 and 18.3 of https://html.spec.whatwg.org/#application-cache-download-process: ``` 4. Let request be a new request whose url is manifest URL, client is null, destination is the empty string, referrer is "no-referrer", synchronous flag is set, credentials mode is "include", and whose use-URL-credentials flag is set. 18.3. Let request be a new request whose url is URL, client is null, destination is the empty string, origin is manifest URL's origin, referrer is "no-referrer", synchronous flag is set, credentials mode is "include", use-URL-credentials flag is set, and redirect mode is "manual". ``` Bug: 1024198 Change-Id: I6566cead95f995089685fc8eed9635d82e3d4d81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926478 Commit-Queue: Yifan Luo <lyf@google.com> Reviewed-by:
Chase Phillips <cmp@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#719137}
-
Arthur Hemery authored
A prerequisite to COOP is to move COEP computation before we have selected a RenderFrameHost. This is done in this patch. Bug: 922191 Change-Id: Id78dc3a984b984f0b5daf5d0dd5729d60eeb7dae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930563 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719136}
-
Yi Su authored
In iOS 12, calling [UITableView reloadRowsAtIndexPaths:withRowAnimation:] inside the completion handler of [UITableView performBatchUpdates:completion:] may trigger a crash. The workaround is to get UITableViewCell via [UITableView cellForRowAtIndexPath:] and then reconfigure the cell directly. This will lose the built-in animation from UIKit when cells are updated. Once iOS 12 is deprecated, remove this workaround and use [UITableView reloadRowsAtIndexPaths:withRowAnimation:]. Bug: 1028074 Change-Id: Ida4fbf94f31b7b00cb9052177f3350c60ae9e4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936487Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#719135}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for UDPSocketListener from UDPSocket and uses PendingReceiver and Receiver, which are new Mojo types. Bug: 955171 Change-Id: Id5987eadff71ac110c223e4b3d20287caacddbc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935582 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#719134}
-
Julie Jeongeun Kim authored
This CL cleans up old Mojo types for mojom::KeepAlive using Remote and PendingRemote. Bug: 955171 Change-Id: I7ef3aecf2cca7c595b5fcae0dd9138814da8ec79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935485 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Olivier Robin authored
Bug: None Change-Id: I1d6b104c7d9723ce11c1dc94e533cc24c61bc297 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936288 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#719132}
-
Kevin Ellis authored
Bug: 960944 Change-Id: I9001bae7cccbd006f34a98d28aca470c44ecc0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929391 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719131}
-
Andreas Haas authored
We saw this issue in another CL. R=haraken@chromium.org Change-Id: Ib1bd74d8df9de318430970d7c36e0b18f42e37bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936489Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#719130}
-
Corentin Wallez authored
Mark all WebGL tests as flaky to make Win10 FYI x64 Release (NVIDIA) green while the failures are investigated. [ win nvidia vulkan passthrough ] conformance/* [ RetryOnFailure ] BUG=chromium:1017162 TBR=kbr@chromium.org Change-Id: I617d892f33233d427557b38bd322054ef029d8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936490Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#719129}
-
sandromaggi authored
Aligning the colors of the icons to use either default blue or default. Before: Light: https://screenshot.googleplex.com/ZSgf03CQaaM Dark: https://screenshot.googleplex.com/at6MybZraag After: Light: https://screenshot.googleplex.com/zF7wCHx9gZa Dark: https://screenshot.googleplex.com/gQqS2Wm5Vza Bug: b/144416230 Change-Id: Ice808de834db62c79949792af74b3d059f689de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932802Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#719128}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2a597d3d. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mstensho@chromium.org: external/wpt/css/css-break NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Icef92122032e6c04ef393e49508cc67155facb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936389Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719127}
-
Omer Katz authored
These new tests revealed 14 new TSAN warnings for concurrent tracing of collections. Change to heap.cc required to allow the concurrent tracing to run without help from the mutator thread. This maximizes the amount of data races reported by TSAN. Bug: 986235 Change-Id: Ic648cc099870762babaf0d3be3eca96386e25aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932805 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Anton Bikineev <bikineev@chromium.org> Cr-Commit-Position: refs/heads/master@{#719126}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d5e2f215d65d..a88655daf934 git log d5e2f215d65d..a88655daf934 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 alessiob@webrtc.org NetEQ RTP play: textlog to stderr as option 2019-11-26 peah@webrtc.org DCHECKing for deprecated 8kHz support in AGC and changing fuzzer 2019-11-26 titovartem@google.com Reland "Add IvfVideoFrameGenerator" Created with: gclient setdep -r src/third_party/webrtc@a88655daf934 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1028092,chromium:1028172 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I47be5b193738e32208532f2705d14b01839d428e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935084Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719125}
-
Johannes Kron authored
frameBitDepth and bitDepth have recently been added to the WebRTC stats specification. https://github.com/w3c/webrtc-stats/pull/517 Bug: chromium:1018825 Change-Id: I28ce4361ae7bd70b280564a23913731af7450d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932442 Commit-Queue: Johannes Kron <kron@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#719124}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8e8781a2b944..a1cb75450db1 Created with: gclient setdep -r src-internal@a1cb75450db1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I30ba281689d14e96127bf73f1a537f8d64ab3274 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935083Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719123}
-
Dominic Farolino authored
Bug: N/A Change-Id: Ie297ab97852df2694e205ae977ef97f279d7b0a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935815Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#719122}
-
Friedrich Horschig authored
This change adjusts the bottom sheet behavior when closing. The main problem was that the half state would always be skipped when swiping down. Since the previous state was guessed during a scroll, this allows for unpredictable behavior, e.g.: - scroll a sheet in half state up for 3 pixels but don't release - scroll the sheet down for 2 pixels Instead of bobbing back into place, the sheet would skip the half state. This CL stores the start of the scrolling which fixes this. Additionally, skipping the half state isn't always intended (see linked bug). This CL keeps this default behavior but allows BottomSheetContent objects to override it. Bug: 1024213 Change-Id: I108f2e1069f13731b856b73a915d91741d8a176d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931076 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#719121}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5069a6c9..e78d04eb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3a157aaa4c29aae9982d0019387de53f292879b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936390Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719120}
-
Mohamed Abdelhalim authored
Make the callback function boolean, that return true to skip the On*ChecksComplete functions. And use |state| instead of |complete_callback| to determine the right function to call. Bug: 916537 Change-Id: I4ae0af25e687868d121a238c31632b89b0c0df2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919210Reviewed-by:
-
Greg Thompson authored
This verifies that a mapped file cannot be deleted, but can still be moved as long as it was opened with appropriate sharing settings. It happens to be the case that the Windows loader uses compatible sharing settings, so a mapped file can ordinarily be moved from one name to another on the same volume. This change also disables the whole test suite, as it is an educational experience and doesn't need to be run on the bots all the time. BUG: None Change-Id: I47b4c76e97ab159c484aa1ca3ee6d4e7e6bfa4b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768764Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#719118}
-
Peter Marshall authored
A lot of our tests don't await promises which means they can rely on ordering of tasks in the backend which is not guaranteed. Upcoming work on the inspector task scheduler makes some of these tests start to flake because they expect events to happen in a certain order, even when they don't await those events. These tests might already be flaky because of this but it's hard to tell. These aren't the only tests that don't await protocol messages but I focused on tests that use Target.setAutoAttach or runIfWaitingForDebugger as they trigger the flakiness. Change-Id: I4709c47256ad7ff557a34d0def1721ceaa8af706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936289 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#719117}
-
Felipe Andrade authored
Replaces the usage of banned method (std::to_string) on authpolicy credentials manager files by the appropriated one. In this case, since the notification_id is not an user-visible string, the locale-independent method base::NumberToString will be used. Bug: 1027241 Change-Id: I7884f0dbeabefa315d4b1c096c89654d4f5e9719 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929811 Commit-Queue: Felipe Andrade <fsandrade@chromium.org> Reviewed-by:
-
Francois Beaufort authored
This CL replaces the vectorized icon for NFC settings with png images so that it can be decoded in the Page Info UI. Without this, icon was not visible. Screenshots: https://photos.app.goo.gl/k7wz55v9ELVTS19i8 Bug: 520391 Change-Id: I356a15a24e4cfdb9d236cb92b6b45355564e3327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932541Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
-
Rohit Rao authored
Resources in //components can be shared by desktop and iOS. BUG=1027249 Change-Id: I8f262f7b5cba0bb500b596340b63ee518d6552f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929554 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#719114}
-
Andreas Haas authored
With a recent change, ArrayBuffers are allowed to have nullptr as their `Data` pointer. However, a condition in ArrayBuffer::Transfer bailed out if Data() was nullptr. I changed the condition now, and added a test. R=haraken@chromium.org Bug: chromium:1027937 Change-Id: I2fe466bcfe016d850f11211f2ef8104f1f27d41f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932791 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
-
Tanmoy Mollik authored
Closing out these bugs as they are either not used in production code anymore or are simple renaming that seems unnecessary now. Bug: 1010878 Change-Id: I1a0def462163d989f60bd0d5ad429a8db3e1ef76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930565Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#719112}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/da4c7cba65d0..8e8781a2b944 Created with: gclient setdep -r src-internal@8e8781a2b944 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I4c85e6143c0b0d531f98b909e4102343cbb10308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935789Reviewed-by:
-
Andreas Haas authored
Again I added a checked getter of return type unsigned for legacy code. We will replace uses of that getter eventually. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I3e7b8aa82cc4f98e44320276d4156c337054af21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932902Reviewed-by:
-
Colin Blundell authored
This CL ports WebLayer to share the //components-level SSLBlockingPage rather than having a custom fork. Changes to enable this: - The configuration done in //weblayer's SSLBlockingPage::Create() is moved to //weblayer's SSLErrorHandler::ShowSSLInterstitial() Differences between //weblayer's ssl_blocking_page.cc and the //components-level ssl_blocking_page.cc mainly relate to the latter's usage of CertReportHelper, which helps report invalid certificate chains: - The latter calls CertReportHelper::PopulateExtendedReportingOption() in its PopulateInterstitialStrings() method - The latter calls CertReportHelper::HandleReportingCommands() in its CommandReceived() method - The latter inherits SSLBlockingPageBase::OnInterstitialClosing(), which calls UpdateMetricsAfterSecurityInterstitial() and CertReportHelper::FinishCertCollection() [the //weblayer version's impl of OnInterstitialClosing() is empty] A final difference is that the latter inherits SSLBlockingPageBase::OverrideRendererPrefs(), which takes action if |renderer_pref_callback_| is non-null. In the //weblayer context |renderer_pref_callback_| *is* null as SSLBlockingPageBase::set_renderer_pref_callback() is never invoked, so this particular difference won't have any behavioral impact. Bug: 1025059 Change-Id: I64795ed164cc9e3d778d5ef6d9d505badc9d741a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924570 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#719109}
-
Olya Kalitova authored
Adds configuration step to Crostini installer dialog steps. That step is present only when CrostiniAnsibleInfrastructure feature flag is enabled. Bug: 1022784 Change-Id: Ia0201eb75780be5691774a9546ae2c43c91c8b03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910232 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#719108}
-
Wenxiang Qian authored
This fuzzer will test sqlite3 FTS3 shadow tables and related functions by implementing a custom structure aware fuzzing. It will try to generate some grammatical correct queries to manipulate shadow tables, or to execute some built-in functions of FTS3 to find memory corruption vulnerabilities. Bug: 1025467 Change-Id: I809fe02efd43449bee8a072e490309175e533d6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924174 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#719107}
-
Eldar Rello authored
Re-enable testing of wpt/webrtc/RTCPeerConnection-setRemoteDescription-rollback.html and improve some test cases Bug: chromium:1025557 Change-Id: I5be63e394c830faf55442d62a053e100875de5a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932793 Commit-Queue: Eldar Rello <elrello@microsoft.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#719106}
-
Chris Blume authored
This reverts commit ea6b9281. Reason for revert: It turns out the V8 team needs the MSVC build. :) I tried installing the Clang compiler as part of Visual Studio 2017 and 2019 but neither of them became options in the toolchain. I'll need to spend more time figuring out how to get Clang on Windows. Original change's description: > Remove use of inline ASM in insert_string_sse > > It seems that some years ago clang@Windows didn't have the > proper intrinsic required, which prompted the use of inline > ASM. > > It has a side effect in that it will allow compilation of the > optimized function within the same compilation unit while using regular > compiler flags (i.e. 'crc32' instruction on x86 requires some special > compiler flags). > > Main issue is that inline ASM is blocked on dependencies (e.g. 'base') > that will be linked to NaCl. > > The main idea here is to allow the whole Chromium code base to use the > highly optimized checksums in zlib (e.g. crc32 and Adler-32), exported > through an interface (i.e. base::Crc32()). > > This patch fixes this issue by removing the use of inline ASM. > > The workaround is to use clang/gcc 'target attributes' to instruct the > backend to use different code generation options for the optimized > function, see: > https://clang.llvm.org/docs/AttributeReference.html#target > > Bug: 902789 > Change-Id: I0d139268aefb8335310c0e3f6533006be9af6470 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931272 > Reviewed-by: Adenilson Cavalcanti <cavalcantii@chromium.org> > Commit-Queue: Adenilson Cavalcanti <cavalcantii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718788} TBR=cavalcantii@chromium.org,cblume@chromium.org,mtklein@chromium.org,adenilson.cavalcanti@arm.com Change-Id: I6b3fcce10197121b548300855710e99f7048f1ae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 902789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936189Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#719105}
-
Oriol Brufau authored
The specification added a step to increase sizes to accommodate spanning items crossing flexible tracks instead of ignoring their contents completely. This is done after handling all grid items that don't cross such tracks, and this time items are considered together, not grouped by their span size. This is a reland of r705228, which was reverted due to a performance regression. The main problem was that non-spanning items in flex tracks have to be handled with a variant of the algorithm for arbitrary spans, which was much slower. But now that has been greatly improved by r714511 and r715665. I have also refactored the patch to avoid worsening the performance of spanning items that don't cross flex tracks. However, the algorithm for arbitrary spans is still a bit slower than the one for span of 1. Therefore the nested-grid perf test will decrease by ~5%. This is expected since it has lots of non-spanning items in flexible tracks, that will now be handled with the arbitrary span algo. Spec: https://drafts.csswg.org/css-grid/#algo-spanning-flex-items BUG=935102 TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-001.html TEST=third_party/blink/web_tests/external/wpt/css/css-grid/layout-algorithm/grid-flex-track-intrinsic-sizes-002.html TEST=third_party/blink/web_tests/fast/css-grid-layout/flex-and-content-sized-resolution-columns.html TEST=third_party/blink/web_tests/fast/css-grid-layout/grid-gutters-and-flex-content.html Change-Id: I4dfae4a0293aea611b04b59738cfced5e4fe8d44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913406 Commit-Queue: Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#719104}
-
Antonio Gomes authored
BUG=787254, 939192 R=guidou@chromium.org, haraken@chromium.org Change-Id: Ic4d7594070d71ca8ca9153ca197a8d9b4ade053f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932089 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#719103}
-
