- 26 Oct, 2020 40 commits
-
-
Ken Rockot authored
This test was disabled due to flake. The flake was caused by a bug which was fixed by crrev.com/ae1a0ae1 quite a while ago. Fixed: 995181 Change-Id: Ic1afcbb3b25cdcf70d6179bf365dc4729e1c451d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495512 Auto-Submit: Ken Rockot <rockot@google.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#820761}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202010260700_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/d_W31KKgRgYuvgrFL3we1kiiq2UPrniL8Q6CCbFkclAC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/165720635,b/171275495 Tbr: media-app@grotations.appspotmail.com Change-Id: Ia260895dcdcae8741cd2445944ff43d04376b1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498842Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820760}
-
Titouan Rigoudy authored
These requests are not blocked by content/, so there is no point in counting them in Blink. When we get closer to having a plan for these requests, we will want to revisit this so as to gather data. Bug: chromium:1129326 Change-Id: Ib5829385727db3a29955c5246aa9c0ce07d55f09 Fixed: chromium:1134601 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489918 Commit-Queue: Steve Kobes <skobes@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Auto-Submit: Titouan Rigoudy <titouan@chromium.org> Cr-Commit-Position: refs/heads/master@{#820759}
-
Jan Wilken Dörrie authored
This change adds C++ syntax highlighting to the code blocks found in //docs/pattern and removes unnecessary leading whitespace. While this highlighting is not visible in Code Search's markdown view, it is supported when viewed through gitiles: https://github.com/google/gitiles/blob/master/Documentation/markdown.md#compiled Bug: None Change-Id: Id2d4298fc69f57b7abe1aa589f547221785791ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494580Reviewed-by:
-
Chris Lu authored
The PasswordInfobarModalOverlayRequestCallbackInstaller class was written to handle both Save and Update Password Infobar Overlay actions. However, this caused problems with the overlay callback manager logic, which executed all callbacks that matched a request's config. Thus, each PasswordInfobarModalOverlayRequestCallbackInstaller instance needs to know which Password type it is handling, so that it can only handle logic if the triggering request was of the same type. Bug: 1141708 Change-Id: I12a6eb14a30ed9308c58a1cd7a1568da9736cb0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493433 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#820757}
-
Illia Klimov authored
As part of http://crbug.com/1064647 this CL removes Flash from the Settings page and UI tests. Bug: 1133888 Change-Id: Iabe202b9d1c3529b117a4ec045bddb689cc80f29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461344Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Illia Klimov <elklm@google.com> Cr-Commit-Position: refs/heads/master@{#820756}
-
Stephane Zermatten authored
With this change, it becomes possible, in Selectors, to evaluate a CSS expression against an element that was found previously and weed out elements that don't match that expression, such as: filters { css_selector: "label" } filters { inner_text { re2: "text" } } filters { labelled {} } filters { match_css_selector: ":checked" } This is necessary for the "check box" actions, that guarantee that they're going to check the checbox, not uncheck it. Currently, scripts cannot use labelled checkbox, because they can't figure out whether clicking on them will check or uncheck them. This change also allows checking the type of elements found with labelled: filters { css_selector: "label" } filters { inner_text { re2: "text" } } filters { labelled {} } filters { match_css_selector: "input[type='checkbox']" } Bug: b/171537366 Change-Id: Ifc9475b00d2ddf526c62ecca70aae5905ad5c093 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494931 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#820755}
-
Nicolas Ouellet-Payeur authored
This objects holds an sql::Database, so its destructor can do IO. But it was destroyed on the UI thread. Bug: 1141999, 88586 Change-Id: I5ad15deaf7eb3ab5c234d1d4b629dc65216d780b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495351Reviewed-by:
-
Olesia Marukhno authored
Background::get_color() doesn't return the actual color for painter background. This caused wrong color for the dark theme. Also updated ink drop opacity because now buttons match row background. The base color now is darker so it would be darker than row background with default hover opacity. Bug: 1133847 Change-Id: Iaa942fbd4dc133cd64a671c105c31c45919c14ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498602Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Olesia Marukhno <olesiamarukhno@google.com> Cr-Commit-Position: refs/heads/master@{#820753}
-
Nektarios Paisios authored
This is the only remaining occasion, as far as I can tell, where we are still forgetting to set the parent of a child object properly. All other cases have been fixed either by my previous patches or by patches recently authored by aleventhal@. Also added a few DCHECKs in AXSlider and AXMenuList. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I22af3f276cc325a71968f6b2956d17120ce03320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356484 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#820752}
-
Ramin Halavati authored
Incognito mode is not available in ephemeral Guest profiles, but other OTR profiles are allowed. Bug: 1125474 Change-Id: I78f5b86f11dac8572ab5198cb8e07012e87fd4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494940Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#820751}
-
Victor Hugo Vianna Silva authored
Before this CL, upon sign-out, Sync.StopSource was recorded both in the SIGN_OUT bucket and in one of the auto-sync buckets, i.e. ANDROID_MASTER_SYNC or ANDROID_CHROME_SYNC. This CL fixes this by adding a check for whether there's still a primary account by the time the auto-sync buckets are recorded. Bug: 1140912 Change-Id: Id00d0da70571a05c19af50a576b8cb1cb60ad2c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495145Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#820750}
-
Christoph Schwering authored
This CL uses FieldRendererIds to retrieve an AutofillField from the FormStructure cache of AutofillHandler. Before this CL, the first AutofillField that satisfied SameFieldAs() was considered a hit. For forms with multiple identical fields, this may have been a false positive. In particular, this fixes the filling of the wrong section in forms like billing+shipping forms with multiple identical fields. Bug: 1141847 Change-Id: Ib95aef11be43ece7db001eb02c495ac14cc21685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495063Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#820749}
-
Marc Treib authored
"Model association" was a directory concept that doesn't exist anymore in the USS world. This CL renames the ModelAssociationManager class according to what it actually still does. Bug: 1102837 Change-Id: I66f07a6cd1726fef794b3c11d69ba89bd54d24d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497174Reviewed-by:
Rushan Suleymanov <rushans@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#820748}
-
Jan Scheffler authored
This patch disables a test that blocks landing the following cl: https://crrev.com/c/2466187 Bug: chromium:1093791 Change-Id: Ibb9c14b30f346d6bda0a0b67bed1b3593b0aab55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498504Reviewed-by:
Mathias Bynens <mathias@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#820747}
-
Yoshifumi Inoue authored
This patch changes |NGInlineCursor::PositionForEndOfLine()| to use first or first item in line instead of hit-testing at inline start offset[1] of line box to handle position:relative[2], correctly. This patch is similar to the CL[3] which changes |PositionForEndOfLine|. [1] inline start offset: left-top offset for horizontal writing mode with left-to-right direction. [2] position:relative items can be outsize of line box or any point in line to place first item at last item. [3] http://crrev.com/c/2467046 Make NGInlineCursor:: PositionForEndOfLine() not to use hit-testing Bug: 1136740 Change-Id: I5004c8d9c32b89bd3d6e2d3f7031350e1777a804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497742 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#820746}
-
Matt Jones authored
Bug: 223587 Change-Id: I1b61f97f9c864d467593c490fa4fc5b7efd16989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493001Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#820745}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/08c34aef9625..b5ba693316fd 2020-10-26 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 8012e62471be to bb66fa41a163 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Id46802a16f2bb93083ed2a920fe81f300227fe98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498782Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#820744}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7031d066796ec3be3cf8ac98b71eea09c199f852 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498785Reviewed-by:
-
Rohit Rao authored
BOOL and bool are equivalent on arm64, but they map to different underlying types on other platforms, such as Mac Catalyst. BUG=1142431 Change-Id: I871e83e958ddc4619da634a972036599fc6d02db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498801Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#820742}
-
Leo Lai authored
A good reason to fix this typo is to apply gtest_filter with right spelling to include such a set of test items. BUG=b:158955123 TEST=unit_tests with filter as *CertProvision"; observe that the test items increase. Change-Id: Ide1389d59d40676b0bda001102a221280f366c20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497385Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#820741}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1603691326-ded4cf98fc57f32e31937f939ee80f292f889c4d.profdata to chrome-linux-master-1603713364-255d86fa5592c315dc7718e8b4c93f0ba1279e07.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie15332a756a6f35ed2804fcff061da0d269ffc29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498786Reviewed-by:
-
Christos Froussios authored
This reverts commit aa433c9b. Reason for revert: Suspected of breaking DesktopCaptureAccessHandlerTest.ScreenCaptureAccessSuccess DesktopCaptureAccessHandlerTest.GenerateStreamSuccess on Mac10.15 Tests https://ci.chromium.org/p/chromium/builders/ci/Mac10.15%20Tests/5200 Original change's description: > DLP: Do not start screen capture for restricted content. > > During creation of a screen capture (desktop, window or tab) it needs to > be checked whether the captured area contains any DLP > (Data Leak Prevention) restricted content. > The corresponding MediaAccessHandlers should do this check on Chrome OS. > > Bug: 1134566 > Change-Id: Id77739a9b6df9f3ed946e563d508c43df83b5580 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2446329 > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Commit-Queue: Sergey Poromov <poromov@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820713} TBR=miu@chromium.org,guidou@chromium.org,poromov@chromium.org Change-Id: If9484e55acb65caef725ebdea3a96bb8b3725f97 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1134566 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497449Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#820739}
-
Avi Drissman authored
If someone wants to install the x86 version of Chrome onto an Arm Mac, let them. This is especially true in the early days when a native Arm version might not be available. Bug: 1098940, 1142330 Change-Id: I74d31897c5fcfe4d85209c2fd5d7cab2dfb3fc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497567 Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820738}
-
Denis Kuznetsov authored
Part of core_oobe_handler cleanup, Requisition dialogs can now only be triggered on the Welcome screen. Bug: 1100910 Change-Id: I3f96b286f2022bf1f78ece7baba8be75c97a7794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492441Reviewed-by:
Renato Silva <rrsilva@google.com> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#820737}
-
Alessio Bazzica authored
Bug: webrtc:7494 Change-Id: I01691bece3b927e00f799eb4216326c5e2a14acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494804Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Ale Bzk <alessiob@chromium.org> Cr-Commit-Position: refs/heads/master@{#820736}
-
Richard Knoll authored
To opt-out of the new muting behaviour this adds a "Show" ("Show all" if multiple notifications have been muted) action to the muted notification. This will show all currently muted notifications and will keep showing future ones until the current screen capture session is over. This will not persist across further sessions so when a screen gets captured again we start muting notifications again. Bug: 1131375 Change-Id: I2b1824d632aaafeb716d7ffc691d2df702b1ffb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2452770 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#820735}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/82a2948010cb..5d039126f32d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC cfroussios@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: cfroussios@google.com Change-Id: I5e310320df98aef7b149603d0c34bcb588beb976 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498053Reviewed-by:
-
Christoph Schwering authored
English patterns are added to each language (which is motivated by the HTML attributes often being in English). This CL fixes that PatternProvider::GetAllPatternsByType() returns the English entries for English and for every other language. This CL also does some very small refactorings to make PatternProvider style-compliant. Bug: 1141407 Change-Id: Ic7a11c6a6a39a1bea5a9aef3121bb364dd16cdd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493600 Commit-Queue: Christoph Schwering <schwering@google.com> Reviewed-by:
-
Henrik Boström authored
media/capture/video/mac owners frequently have to touch files in media/capture, especially the BUILD.gn file which covers all subfolders. Bug: chromium:1132299 Change-Id: Ic61b5c7cfe938a07a0b8e345786614a2b7497250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498684Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#820732}
-
Sebastien Lalancette authored
Added helper functions to be used to generate a URL for selected text on a page, based on TextFragment values. Bug: 1136043 Change-Id: I8adab1b8cf3dfd00f09387f74f5dab76d682289b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495920 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#820731}
-
Elizabeth Popova authored
This CL introduces a feature toggle than controls whether honorific prefix is shown and editable in Autofill Settings on Android, iOS and Desktop. Bug: 1141884 Change-Id: I962b5a62c303dd711581a34c3b9fbd95e7b0dbd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490013Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7b2a3361a577..6ddda3e8e6f2 2020-10-26 alexrudenko@chromium.org Enable TypeScript for LayoutSidebarPane.js 2020-10-26 alexrudenko@chromium.org Icons for all flex-direction values If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1139945 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7254c696aa73d95f186d8f126edb8c62baa99d75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498056Reviewed-by:
-
Christoph Schwering authored
Test that English patterns are added correctly and missing languages are handled correctly. Bug: 1141012, 1141407 Change-Id: I35ca9582d871aab1c1ef5521d0ddc663b50a136e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490117Reviewed-by:
-
Andreea Costinas authored
Bug: 1142382 Test: presubmit tests Change-Id: I03a2d0e42d0b198a48b3c97a2cc59a616cf23e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498461Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#820727}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1603613972-73699eb7c90ca72304abe78e4e06ee3df85b698a.profdata to chrome-win32-master-1603680975-76e0bcad480e2e9cf63aee149b7c46a4d88220b4.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I572ab9dddf9c452d683f7d9fbe73829b96510ca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498062Reviewed-by:
-
Rohit Agarwal authored
This CL removes the PermissionInfo#isIncognito method and |mIsIncognito| variable associated with. This CL also touches PermissionInfoTest file which passed the incognito boolean to PermissionInfo ctor which is not needed anymore. Bug: 1142405, 1060940 Change-Id: I908520543c45539d42e2cb821e93078e744f3a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498583 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
-
Takashi Sakamoto authored
This CL fixes "Chrome 88.0.4300.3(pulse canary) crashes on launch". g_allocator_buffer is used as an instance of PartitionRoot. So its alignment must be base::kAlignment(i.e.sizeof(std::max_align_t))-aligned. If not aligned, we will see "Signal 7 (SIGBUS), code 1 (BUS_ADRALN)" when accessing the PartitionRoot instance. Bug: 1141752 Change-Id: I6712aac19873343b1e9077ca22b61afae4370b5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497396Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#820724}
-
Yuki Shiino authored
After refactoring of WrapperTypeInfo, cleans up InstallPropertiesPerFeature function and its family. Bug: 839389 Change-Id: I15bd70da5387d68a31dc260e87d9cb7b1972a37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494247 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#820723}
-
Antonio Sartori authored
An experimental feature of Content-Security-Policy 3 introduced the 'csp3-' prefix for hashes. This should have allowed to write backwards compatible CSP policies using the CSP3 'unsafe-hashed-attributes'. It should be safe to remove this. Bug: 771922 Change-Id: I6f0773eee43b249811ba20a1f3f5b95d1e27e971 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494723 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#820722}
-
