- 17 Jul, 2017 40 commits
-
-
Geoff Lang authored
TBR=zmo@chromium.org NOTRY=true BUG=668223 Change-Id: Ibf09100c74fa4ec2c8e7738f7f977153f1816c69 Reviewed-on: https://chromium-review.googlesource.com/574929Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#487198}
-
Robert Liao authored
If shared SchedulerWorkers are released before joining, they are effectively detached and may outlive the SchedulerSingleThreadTaskRunnerManager. BUG=735701 Change-Id: Ie83b50b99698a4059041454f579f4a2c1fbaabc0 Reviewed-on: https://chromium-review.googlesource.com/572233Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#487197}
-
Kyle Horimoto authored
Bug: 672263 Change-Id: I9c9ad8b4925f109718bef273b489bb9bbcacc8ca Reviewed-on: https://chromium-review.googlesource.com/572212 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#487196}
-
Marijn Kruisselbrink authored
There doesn't appear to be a reason all BlobReaders should use the same task runners for their file operations (and furthermore it doesn't seem to matter if the task runner even for a single blob reader is sequenced), so this change BlobReader to create its own TaskRunner. This assumes that blobs aren't being read for no reason, so uses USER_VISIBLE as priority for all blob reads. Ideally the creation of the TaskRunner would be pushed even further down into the stack (maybe all the way down to net::FileStream), but at that point it doesn't seem safe to assume anymore that all users of FileStream want the same priority and shutdown behavior. Shutdown behavior for these tasks should not matter, as BlobReader is only used on the IO thread, which gets shutdown before the task scheduler is shut down, making it impossible for tasks to get posted after shutdown. Change-Id: If44f32aad5d566d04fc845113f05ef6044592aa4 Reviewed-on: https://chromium-review.googlesource.com/570945Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#487195}
-
dougt authored
BUG=703369 Review-Url: https://codereview.chromium.org/2975413002 Cr-Commit-Position: refs/heads/master@{#487194}
-
yolandyan authored
TBR=twellington Bug: 744710 Change-Id: Ib01c1b081b5c34641aeae8dae8c4234d38472837 Reviewed-on: https://chromium-review.googlesource.com/574760Reviewed-by:
Yoland Yan <yolandyan@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#487193}
-
Kyle Horimoto authored
[CrOS Tether] Separate network stack code from MasterHostScanCache and convert MasterHostScanCache into a manager of both the networking and persistent caches. This is the third step of persisting host scan results so that we can recover from crashes. Steps listed below: (1) Create a HostScanCache interface and move the concrete implementation to MasterHostScanCache. (2) Create a HostScanCache implementation which persists cache entries to user prefs. (3 - this CL) Move code which adds entries in the network stack to another HostScanCache implementation, and have MasterHostScanCache manage the other two HostScanCache implementations. After this CL, host scan results will be restored after a crash, but the active host will not yet be restored. That will occur in a follow-up CL. Bug: 672263, 737273 Change-Id: I594ad829c5c5b010accc6089f9575aef9afb0cae Reviewed-on: https://chromium-review.googlesource.com/570925Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#487192}
-
James Cook authored
This reverts commit 1b600061. Reason for revert: Causes a startup crash with chrome --mash, possibly because mash does not have a DeviceDataManager. You might want to check with sadrul@ or rjkroege@ about whether there's a good way to do this under mash. Failing build (chromeos-side waterfall): https://luci-milo.appspot.com/buildbot/chromeos.chrome/tricky-tot-chrome-pfq-informational/5205 Stack (from running manually with chrome --mash on Linux): [60089:60089:0717/114019.863351:FATAL:device_data_manager.cc(84)] Check failed: instance_. DeviceDataManager was not created. #0 0x7f06a03468bc base::debug::StackTrace::StackTrace() #1 0x7f06a036a121 logging::LogMessage::~LogMessage() #2 0x7f069aeb08ff ui::DeviceDataManager::GetInstance() #3 0x55f183402a41 chromeos::LoginDisplayHostImpl::LoginDisplayHostImpl() #4 0x55f1834066ad chromeos::ShowLoginWizard() #5 0x55f1833e4bf7 chromeos::ChromeSessionManager::Initialize() #6 0x55f1832f9cb4 chromeos::ChromeBrowserMainPartsChromeos::PostProfileInit() #7 0x55f1837e7aa2 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #8 0x55f1837e709d ChromeBrowserMainParts::PreMainMessageLoopRun() #9 0x55f1832f8f4a chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() #10 0x7f069d9e5081 content::BrowserMainLoop::PreMainMessageLoopRun() #11 0x7f069dde6407 content::StartupTaskRunner::RunAllTasksNow() #12 0x7f069d9e353b content::BrowserMainLoop::CreateStartupTasks() #13 0x7f069d9e7a72 content::BrowserMainRunnerImpl::Initialize() #14 0x7f069d9e0b57 content::BrowserMain() #15 0x7f069e1e8462 content::ContentMainRunnerImpl::Run() #16 0x7f06a0890d39 service_manager::Main() #17 0x7f069e1e7384 content::ContentMain() #18 0x55f182e8132f ChromeMain #19 0x7f069454af45 __libc_start_main #20 0x55f182e81194 <unknown> Original change's description: > Listen to changes to touch input devices > > In https://codereview.chromium.org/2964823002 the OobeDisplayChooser > started using the DeviceDataManager to look for touchscreen devices when > searching for a good primary display to use during OOBE. > > On device cold boot the DeviceDataManager has not yet found any > touchscreen devices at the time OobeUi::ShowOobeUI() is called (likely > due to lower level systems not being fully initialized). > > This CL make LoginDisplayHostImpl an observer of changes to connected > touchscreen devices, re-triggering the OobeDisplayChooser when the > DeviceDataManager is notified of the connected touchscreens. This > overcomes the timing issues on cold boot. > > Bug: 738885 > Change-Id: Iae488ddc9428b7c5e74d36cf18e35ba3d1235bbd > Reviewed-on: https://chromium-review.googlesource.com/569958 > Reviewed-by: Jacob Dufault <jdufault@chromium.org> > Commit-Queue: Felix Ekblom <felixe@chromium.org> > Cr-Commit-Position: refs/heads/master@{#487007} TBR=alemate@chromium.org,jdufault@chromium.org,felixe@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 738885 Change-Id: If31322734e679bbb1f4eef0a9aa802d34263cba4 Reviewed-on: https://chromium-review.googlesource.com/574731Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#487191}
-
Ian Vollick authored
Previously, vr_shell_resources.grdp contained a condition that it be included if enable_vr, but in browser_resources.grd we only included this part if is_android. This allows vr_common_unittests to build on linux when enable_vr is true. We will eventually want to, for tests, use generic assets for the controller (see crbug.com/743687), but this lets us test on linux in the interim. This change also relocates our resources to a more appropriate location. Bug: None Change-Id: Ic17545487555595a867913fa58b74e559b26391d Reviewed-on: https://chromium-review.googlesource.com/572943 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#487190}
-
Hidehiko Abe authored
This CL migrates ArcStorageManager. BUG=672829 TEST=Ran try. Change-Id: If91bab2be503825fa3c10ee71053acf52c504057 Reviewed-on: https://chromium-review.googlesource.com/572886 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#487189}
-
Daniel Hollingshead authored
Merges server-side changes 161104822, 161260482 by dahollings, birenroy. Bug: 488484 Change-Id: I7888fe8b6901132a83086c471c7f3e3935999679 Reviewed-on: https://chromium-review.googlesource.com/568857 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#487188}
-
David Tseng authored
- treat the Docs content editable as a root (note that the role=textbox has a parent that is also richly editable; the only way to distinguish is based on focus. Could have used role as well, but focused state seems more relevant). This means that jumping to the next link while ChromeVox range is inside of a content editable wraps inside the content editable. Also, control duplicate/overlapping output by suppressing the usual output in navigation when the node is richly editable. - fix an issue where we were clearing text edit handler state on focus. We actually set focus after every jump command, so this resulted in us speaking "deleted" after every jump command. - handle another state transition in AutomationRichEditableText. This one is non-overlapping selections from prev to cur. These occur as a result of jump commands among other possibilities. TEST=jump around in a complex document. Bug: Change-Id: I1f5b555e143a2998576b746671761eeb0705ede1 Reviewed-on: https://chromium-review.googlesource.com/574787Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#487187}
-
Justin Schuh authored
Style nit. R=piman@chromium.org TBR=piman@chromium.org Change-Id: I96477350fae2688d31143086797dc3e35d1c771c Reviewed-on: https://chromium-review.googlesource.com/572330Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Justin Schuh <jschuh@chromium.org> Commit-Queue: Justin Schuh <jschuh@chromium.org> Cr-Commit-Position: refs/heads/master@{#487186}
-
Peter K. Lee authored
Password filling uses JavaScript injection, so it must be ran on main thread. iOS 11 runs the Extension callback on a non-main thread and results in a crash. This CL fixes this be detecting that the crucial piece of code is not on main thread and re-dispatches it. Bug: 742554 Change-Id: I7a337e424800052069dfd207903d17da8df04458 Reviewed-on: https://chromium-review.googlesource.com/572701Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#487185}
-
Elliot Glaysher authored
In non-mash mode, chromeos uses a list of keys in cursor_manager_chromeos.cc to determine whether pressing a key should hide the cursor. This patch adds a window manager interface which lets the window manager send a list of EventMatchers which will determine whether the cursor is shown or hidden after a key event. Note: This does not yet deal with key events generated by the accessibility keyboard. Bug: 637853 Change-Id: I2bbb66562b2ded407fc6b05f9b02f1ed18704613 Reviewed-on: https://chromium-review.googlesource.com/570766Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#487184}
-
pdr authored
This patch removes the LayerImpl references from DidUpdateScrollOffset. Instead of looking up scroll and transform property nodes with Layers, ElementId is used. Tests have been modified to ensure property trees exist before updating scroll offset. This should be true in all real cases but is not for synthetic testing scenarios. A bug has been fixed in UpdateScrollChildPosition where the scroll layer was not actually scrollable. This is a reland of [1] which was rolled out because the active tree can have a scroll offset for an element id that is not present in the pending tree. The comment in DidUpdateScrollOffset has been updated to reflect this. This is tested in PushPropertiesToMirrorsCurrentScrollOffset. [1] https://chromium-review.googlesource.com/c/560584/ Bug: 743241, 742039 Change-Id: Ia13380d749843064f30de76ccfeeb5e72502e6b2 Reviewed-on: https://chromium-review.googlesource.com/572426Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487183}
-
Dave Schuyler authored
This CL adds the internet_options_handler_strings to the i18n set when loading the proxy_settings_ui. Bug: 743097 Change-Id: Ic5930f90d185a4f09545380de9f5af623aad626a Reviewed-on: https://chromium-review.googlesource.com/572265Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#487182}
-
gmx authored
Add Kabylake and Goldmont models to the Intel uarch table and enable profiling for them. BUG=b:63543388 TEST=none Review-Url: https://codereview.chromium.org/2970163002 Cr-Commit-Position: refs/heads/master@{#487181}
-
Mike Dougherty authored
Bug: 734856 Change-Id: I84190bfb4a41cb6a0b08f3c7964ba599040ea565 Reviewed-on: https://chromium-review.googlesource.com/572863Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#487180}
-
Eric Holk authored
This is a reland of 714060db Original change's description: > Implement updated array buffer allocator in gin > > Bug: chromium:720302 > Change-Id: I127daca6ee9954774b8ff23382ba38cb23da7318 > Reviewed-on: https://chromium-review.googlesource.com/543670 > Commit-Queue: Eric Holk <eholk@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#481959} Bug: chromium:720302 Change-Id: I880773c83d51c8ec0d3d55dfa8913e6b3a16ddec Reviewed-on: https://chromium-review.googlesource.com/570978Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Eric Holk <eholk@chromium.org> Cr-Commit-Position: refs/heads/master@{#487179}
-
Wei-Yin Chen (陳威尹) authored
Enabled: - DistillerPageWebContentsTest.UsingCurrentWebContentsReadyForDistillation - DistillerPageWebContentsTest.UsingCurrentWebContentsNotFinishedLoadingYet These tests were reported flaky, but couldn't repro locally. Re-enable to get more info on bots. BUG=648578 Change-Id: Ifee5adf4fded7d549d8480d5148c603c45319fe3 Reviewed-on: https://chromium-review.googlesource.com/566591Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#487178}
-
Wei-Yin Chen (陳威尹) authored
Also add a missing call in BookmarkAddActivity. Bug: None Change-Id: Ic7a4d88e5677386f657134619eda9ae2e5b004aa Reviewed-on: https://chromium-review.googlesource.com/572401 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#487177}
-
zpeng authored
Instead of using system webview's resource whitelist, now uses a generated list of resource IDs that are actually packed into Webview's locale paks. This fixes the missing strings issue. Original issue: https://codereview.chromium.org/2980773002/ TBR=agrieve@chromium.org,dpranke@chromium.org,thestig@chromium.org,sadrul@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=724110, 742388 Review-Url: https://codereview.chromium.org/2977993002 Cr-Commit-Position: refs/heads/master@{#487176}
-
Hidehiko Abe authored
This CL migrates ArcProcessService. BUG=672829 TEST=Ran try. Change-Id: Ia1b34a32eba2e8c3c069dcca9e89712e2e1396a2 Reviewed-on: https://chromium-review.googlesource.com/572445 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#487175}
-
Jay Civelli authored
Moving the classes related to ChildProcessConnection from content to base now that ChildProcessConnection lives in base. Bug: 702316 Change-Id: If79a101768ea72cc00732fbb81d579e9948358ba Reviewed-on: https://chromium-review.googlesource.com/568759Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bo Liu <boliu@chromium.org> Commit-Queue: Jay Civelli <jcivelli@chromium.org> Cr-Commit-Position: refs/heads/master@{#487174}
-
Steven Holte authored
Bug: 507665 Change-Id: If67ff3f6596cc9ca99cd99b0dc2b69ee442161c2 Reviewed-on: https://chromium-review.googlesource.com/571438Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#487173}
-
Scott Haseley authored
The swap-promise used to compute the GPU swap timestamp for FMP was not queued until SetFirstMeaninfulPaint is called, but this method is called with a timestamp that was computed before the network quiet timer fired and FMP was decided. The implications are that (1) when the swap promise is fulfilled, it's because of some other paint, and (2) there might not be any subsequent paints, and so we don't get a swap timestamp for FMP. This CL fixes the problem by having the FMP detector queue the swap-promise in when the FMP candidate is selected, which is on the Paint path. PaintTiming reports the swap time to the FMP detector when the swap-promise is fulfilled. The FMP detector now reports both the swap and non-swap FMP timestamps to PaintTiming when the FMP is finally chosen. Bug: 741961 Change-Id: I0fa9d396f6b46c90acea9f1a46e6d7cbbf5d7ef7 Reviewed-on: https://chromium-review.googlesource.com/570488Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#487172}
-
Dongseong Hwang authored
All cros kernel from v3.8 to v4.4 supports native GMB on Intel, and it boosts performance on all generation Intel SoCs. [1] [1] https://software.intel.com/en-us/articles/native-one-copy-texture-uploads-for-chrome-os-on-intel-architecture-enabled-by-default TEST=tested by jenny.q.cao@intel.com on APL(reef, R61-9731.0.0), BYT(Squawks, R61-9741.0.0) and KBL(Soraka, R61-9743.0.0) 1. launch "http://browsertests.herokuapp.com/perf/background_color_animation.html" in browser for 10 minutes. 2. run smoothness.top_25_smooth with --enable-native-gpu-memory-buffers --enable-zero-copy --disable-gpu-rasterization No visual glitch during the test, and no errors print in dmesg during test. BUG=chromium:475633 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I3359ca9af02f98cac4cf5ce25c25019224dfb4bb Reviewed-on: https://chromium-review.googlesource.com/551365 Commit-Queue: Dongseong Hwang <dongseong.hwang@intel.com> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Dongseong Hwang <dongseong.hwang@intel.com> Cr-Commit-Position: refs/heads/master@{#487171}
-
Zijie He authored
In change https://codereview.chromium.org/2941623003, base/win/windows_version.h was included in remoting/host/host_attributes.cc for all platforms. This issue breaks gn analyze. Refer to the bug for more details. Bug: 661774 Change-Id: I940bf9a87870fad76d14f6f7bea2c439cde081dc Reviewed-on: https://chromium-review.googlesource.com/573560Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Zijie He <zijiehe@chromium.org> Cr-Commit-Position: refs/heads/master@{#487170}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/185312303814..ffbc0d9a08f8 $ git log 185312303..ffbc0d9a0 --date=short --no-merges --format='%ad %ae %s' 2017-07-17 tsepez More tightly validate format strings in util.cpp. 2017-07-17 dsinclair Move CPWL_Utils Draw methods to CFX_RenderDevice 2017-07-13 dsinclair Add CFX_FloatRect::GetDeflated Created with: roll-dep src/third_party/pdfium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls TBR=dsinclair@chromium.org Change-Id: Ie1401bedf8ee19a22407886b7b514287b036d11f Reviewed-on: https://chromium-review.googlesource.com/574754 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#487169}
-
Vaclav Brozek authored
Currently, the passwords settings EG tests enable the "viewing passwords" feature through NSDefaults (=experimental flags). Since recently, controlling through a base::Feature is also possible. This CL gets rid of the NSDefaults code, which needs to reset the state manually with a simpler ScopedFeatureList, which limits the boilerplate. Bug: 744058 Change-Id: I594fb4bbd3f90dd81a1f0f35c7f1ccb70aee965c Reviewed-on: https://chromium-review.googlesource.com/573023Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#487168}
-
Alexandr Ilin authored
ResourcePrefetchPredictor doesn't use LoadingStatsCollector since the CL https://crrev.com/2937623007 was landed. Bug: 715525 Change-Id: Ic16227b20fe2f3dfbd2b28e662a28f9339cc816e Reviewed-on: https://chromium-review.googlesource.com/574606Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#487167}
-
Geoff Lang authored
TBR=zmo@chromium.org NOTRY=true BUG=angleproject:2103 Change-Id: I72b1be3b79c1ac784bf343a23095ad4bdbc1e7f8 Reviewed-on: https://chromium-review.googlesource.com/575011Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#487166}
-
Alexey Kozyatinskiy authored
TBR=pfeldman@chromium.org Bug: chromium:743085 Change-Id: I66dee48fbf5f0dfc8ae1dadcfcba3deb374af4e6 Reviewed-on: https://chromium-review.googlesource.com/574637Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#487165}
-
Scott Violet authored
The cursor config controls the scale (additional factor influencing how fast the cursor moves) and rotation of the cursor in ozone. Ash was applying this, but in mus/mash we need the window-server to apply it. This patch makes mus automatically apply the scale. BUG=701068 TEST=covered by test Change-Id: Ibb4fb3d4584bc23bd17e9f1b527857e27f0b6564 Reviewed-on: https://chromium-review.googlesource.com/572326Reviewed-by:
Elliot Glaysher <erg@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#487164}
-
Geoff Lang authored
https://chromium.googlesource.com/angle/angle.git/+log/c5af8ba..4cff8d6 BUG= TBR=cwallez@chromium.org TEST=bots CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I6d79c2fab74d84d4fc66d14ab2ccfb4df4a193b7 Reviewed-on: https://chromium-review.googlesource.com/574633Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#487163}
-
Randall Raymond authored
Two build bot json files have been edited so that they run with the appropriate command line flags. Given that these build bot changes are related to adding to this test this is all being packaged as one CL. From original CL description: "The added HTML file and JS file have been downloaded from here: https://rsolomakhin.github.io/pr/multi/ And thus do not need to be thoroughly reviewed. The only changes made to these files are as follows 1) In the html file an "id" attribute is added to the "buy" button, the 2016 copyright is changed to 2017, and the stylesheet and favicon links are removed. 2) In the js file "requestPayerEmail," "requestPayerPhone," and "requestPayerName" is added to options on line 106, the JSLint directives are removed from the top of the file, and the long line on line 137 was changed into two lines." TBR=@lpromero@google.com -- Reviewed already in last past. Only addition here is the build bot changes. Change-Id: Ia20efa783eb763ae97f7e0df2f80e710823d7482 Reviewed-on: https://chromium-review.googlesource.com/570879 Commit-Queue: Randall Raymond <rayraymond@google.com> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
mahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#487162}
-
Mike Dougherty authored
Expands on the shared initialization to include base::AtExitManager, net::NetworkChangeNotifier, and base::MessageLoopForUI. With this change Cronet and ChromeWebView can successfully be used when built together in the framework created by //ios/web_view:cronet_web_view_combined. Bug: 738510 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester Change-Id: Iead4ba5d4f2376b09edf3f5c87a13829229b83b4 Reviewed-on: https://chromium-review.googlesource.com/558268 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#487161}
-
David Trainor authored
Add the way for the DownloadService Model to attempt a hard recovery. This will be used along with other component CLs to allow the DownloadService to attempt to reset itself. The recovery method for the Model happens via the following steps: 1. Clears the Model of all Entries. 2. Has the Store destroy itself. 3. The Store attempts to re-initialize. 4. Return the result back to the Model::Client. BUG=736222 Change-Id: I4e0a256d0b241ef627d457d9c2276691d61da8ce Reviewed-on: https://chromium-review.googlesource.com/568712 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#487160}
-
Klaus Weidner authored
Currently, GLFenceEGL's ClientWait always uses EGL_FOREVER_KHR. This change adds a way to specify a timeout so that a thread can yield to do other work while waiting. This is being used in the critical path for WebVR rendering, and even a 1ms delay noticeably cuts into the 16ms frame time budget. The workaround was to repeatedly poll checking for completion, but that needs a very aggressive timeout to avoid unnecessary delay. Using a timeout is more efficient. Bug: 726026 Change-Id: I4c4292f31cf472e538cfdf18a835d48226d6ac58 Reviewed-on: https://chromium-review.googlesource.com/572663Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#487159}
-