GitLab

Because RunSegmenter needs pre-context but is forwad-only, it
scans the input string from the beginning for each shaping.
This characteristics does not work well with LayoutNG, where
it constructs a string for each block, segment it, and use
range shaping for each segment.

This patch keeps a cache of RunSegmenter in HarfBuzzShaper
instance, and re-use if caller shapes multiple ranges
incrementally.

This change turns 90 Timeouts in LayoutNG, 6 out of it to
Failure and others to Pass.

56 Timeouts are still left, probably from other reasons.
Most looks like testharness tests, probably from large
text files. I will look into them after this.

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I09afa9c9bd38de09189b0242cc00e5d8dc739042
Reviewed-on: https://chromium-review.googlesource.com/1053346
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558852}

https://chromium.googlesource.com/angle/angle.git/+log/966cd5076be3..01e83581864b

$ git log 966cd5076..01e835818 --date=short --no-merges --format='%ad %ae %s'
2018-05-15 geofflang Add dEQP EGL expectations OpenGL on Windows.
2018-05-10 lucferron Vulkan: Pre-work for copyImage/copySubImage features

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=ynovikov@chromium.org

Change-Id: Ida342dadbc543a0eaeb1c34cc49d0165657b24ea
Reviewed-on: https://chromium-review.googlesource.com/1060100Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558851}

TBR=mmoroz@chromium.org

Change-Id: Id96ec7a5d2ed444c613ccb324ed47c9df95eb6bc
Reviewed-on: https://chromium-review.googlesource.com/1060457Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558850}

Adds a message size check to the case where
ChannelAssociatedGroupController must post a task to the IO thread
before sending a message. This will allow us to extract useful stack
information from such message size violations.

Bug: 840388
Change-Id: I6861252dcc3451d4551c84e7e389566e8c62dced
Reviewed-on: https://chromium-review.googlesource.com/1059587Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558849}

The WebLayer* given to SetWebLayer() must be kept alive until /after/
the next call to SetWebLayer(), as the client will hold and use that
pointer, including inside the next SetWebLayer() call.

R=xhwang@chromium.org

Bug: 843114
Change-Id: Iee4bc139f02f918f60e7b13455ed2b47bedaa1b9
Reviewed-on: https://chromium-review.googlesource.com/1059698
Commit-Queue: danakj <danakj@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558848}

This CL introduces a new experimental feature
'document-stream-insertion' whose purpose is to limit the usage of
specific (anti-pattern) javascript API for "dynamic markup insertion".

The list of javascript methods to be blocked by this feature are:
document.{write, writeln, open, close}.
The set of disabled APIs is a subset of "dynamic-markup-insertion" from
HTML spec:

https://dev.w3.org/html5/spec-LC/apis-in-html-documents.html#dynamic-markup-insertion
https://html.spec.whatwg.org/multipage/dynamic-markup-insertion.html#dynamic-markup-insertion

Bug: 841605
Change-Id: I9cc31fab36e2cea70cdce575e3868ce1d0cfecfa
Reviewed-on: https://chromium-review.googlesource.com/1053349Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Ojan Vafai <ojan@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558847}

R=primiano@chromium.org
BUG=839060

Change-Id: I12fce3acecc060ade7ea98b1c1556f40dcc4a4c9
Reviewed-on: https://chromium-review.googlesource.com/1048565Reviewed-by: Primiano Tucci <primiano@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558846}

This is to avoid the possible race when the page is
refreshed (so the callback id is now invalid) and the result
of GetIsPinnedToTaskbarState() from the previous javascript
call is received before the current page calls
getPinnedToTaskbarState().

Bug: 842925
Change-Id: I41e8cd3a40d22f98f020eb7bd02487713a62df98
Reviewed-on: https://chromium-review.googlesource.com/1058929Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558845}

It's not really used, we can use DragOperation instead.

Change-Id: I85b997c9534dc7ce6522a9806a4d7bc4e8f82642
Reviewed-on: https://chromium-review.googlesource.com/1058589Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558844}

(Reland of ea78046d with win compile fix.)

Change-Id: Iac81b6de149d42edf7bd5b2954d2a8ddc106a52f
Reviewed-on: https://chromium-review.googlesource.com/1058444
Commit-Queue: Matt Mueller <mattm@chromium.org>
Reviewed-by: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558843}

TBR=zmo

Bug: 840394
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: I61e8896bfff86145b124b9d4b24a59e5f31c756a
Reviewed-on: https://chromium-review.googlesource.com/1060014
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558842}

This updates the bindings generators and hard-coded interface names in
tests and the service_manager.

The remainder of the CL was generated by:

for f in $(find . -name '*.json' -not \( -path './out/*' -o -path './third_party/*' -o -path '*.xcassets/*' \)); do
  grep interface_provider_spec "./$f" >/dev/null && gsed -i s/::/./g "$f";
done

Tbr: jam@chromium.org
Bug: 835446
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I0bb22615b9c66824c6f95da66e3d7016809d63c7
Reviewed-on: https://chromium-review.googlesource.com/1026419
Commit-Queue: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558841}

This updates the JS autocomplete keyword list with keywords from
Section 11.6.2.1
https://www.ecma-international.org/ecma-262/8.0/index.html

Screenshot: https://imgur.com/a/sX1wOP7

Bug: none
Change-Id: Ia555723e35311a83d6e64f19fc253a3ea9368384
Reviewed-on: https://chromium-review.googlesource.com/1058562Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558840}

Bug: 842929
Change-Id: I2e4f67cd3ae1620f6c4cb6fdfeb2a99139168f04
Tbr: mvanouwerkerk@chromium.org
Tbr: tedchoc@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1060119Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558839}

A double cannot hold all of the values that an int64_t can hold, and
this is certainly true for the max() and min() values. Adding a cast
suppresses a new VC++ warning and makes it explicit that some rounding
is going on.

Change-Id: I8373f6784360a0c71ed3f27fc21aec4bc8c1e77f
Reviewed-on: https://chromium-review.googlesource.com/1053730
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558838}

The goal of this CL is to understand whether TimeToReadyToCommit
regressions with --site-per-process are affected by whether the
navigation is for a main frame or subframe.

Bug: 808114
Change-Id: Ib55b51f2b777defc508443788cc036866e638075
Reviewed-on: https://chromium-review.googlesource.com/1058606
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558837}

https://chromium.googlesource.com/catapult.git/+log/0273fdc65acb..a8692f3255c2

$ git log 0273fdc65..a8692f325 --date=short --no-merges --format='%ad %ae %s'
2018-05-15 sullivan Add label 'Performance-Regression-Recovered' to recovered bugs.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=sullivan@chromium.org

Change-Id: I8d6bc0e7b25760647d05f61ec07fa93c32e500d9
Reviewed-on: https://chromium-review.googlesource.com/1060276
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#558836}

This should be safe since the final RenderFrameHost for the error page
is already determined in NavigationRequest::OnRequestFailedInternal().
As part of this change, pass that final RenderFrameHost to
NavigationHandle::WillFailRequest and store it on NavigationHandle
before running WillFailRequest through the throttles.

One use case for this will be DevTools, which needs to know whether a
given subframe is transitioning to/from an OOPIF in the throttles,
even for error pages.  That logic is already in WillProcessResponse(),
and with this change it can also be used in WillFailRequest() to fix
inspecting error pages loaded in OOPIFs.  Note that DevTools needs to
defer the response, so simply doing the work at ReadyToCommit time
doesn't work.

Today, WillFailRequest throttles are allowed to change the error code,
but they should not be changing it in a way that alters the final
error page RenderFrameHost.  Previously, this was implicitly true
because OnFailureChecksComplete() did not check if the error page
RenderFrameHost needed to be updated.  This CL makes that assumption
explicit.  Note that with error page isolation, this won't be an issue
since all error pages will end up in the error page process, which
won't change regardless of what WillFailRequest returns.

Bug: 817881
Change-Id: Ifc1a53a70f8a649a8d9ddc67f6fd39ebc5c1efd7
Reviewed-on: https://chromium-review.googlesource.com/1045266Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558835}

After the change to recalc style for reattachment in the style recalc
step also for elements with custom style hooks, we no longer need to
have this special code for non-attached style for options/optgroups with
slots.

This also means we don't need to re-retrieve the non-attached style for
the LayoutTreeBuilder.

Bug: 813068
Change-Id: I978a429dd43d00863ca8987054b7902c2e9318f5
Reviewed-on: https://chromium-review.googlesource.com/1059517Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558834}

gvr's Arm model apparently does not take into account the user's head position
on 6DoF systems, leaving the arm model "locked" in place near the origin. This
change manually offsets the controller model by the head's position so that the
arm model for the controller stays at a constant relative position to the head.
This yields behavior that matches Google's other first-party VR applications.

Bug: 831610
Change-Id: Id5cf7013c5b671e320304cd78bc80abd11580300
Reviewed-on: https://chromium-review.googlesource.com/1058558
Commit-Queue: Brandon Jones <bajones@chromium.org>
Reviewed-by: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558833}

Use this handler in NavigationAndLoadCallbacksTest. HandleForm will be
used in ErrorPageTest for testing POST errors (the change will be landed
in a separate CL).

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I79bd13ff20be38fa80ca4ebcccbed4532fa93a2d
Reviewed-on: https://chromium-review.googlesource.com/1053064Reviewed-by: Danyao Wang <danyao@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558832}

Gets rid of MutableStyleRef() access where we called SetHasPseudo() for
the inherited first-line styles in order to not return early from
GetCachedPseudoStyle.

TEST=fast/css/invalidation/first-line-change-inline-color-inherited.html

Bug: 813068
Change-Id: Ib34d8ae23e6203ccb27511fb3f5580d8d3002500
Reviewed-on: https://chromium-review.googlesource.com/1059249Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558831}

- Put "More settings" in an iron-collapse that opens when more settings
is clicked
- Remove settings section behavior as it is no longer needed.
- Port metrics for "more settings".

Bug: 773928
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: If120534bf5abbc6fbba97e80b2d872576f10b6d8
Reviewed-on: https://chromium-review.googlesource.com/1055657
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558830}

Chrome tracing allows starting similarly named events from different
threads. EarlyTraceEvents throws an exception in this case because it
keys pending events by name only.

This CL changes pending events key to be name+tid, separating events
from different threads.

Bug: 807034
Change-Id: Ia6d4ac740ec028a14c5269d09148db4d1a5d33ce
Reviewed-on: https://chromium-review.googlesource.com/1055941
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558829}

R=hinoka@chromium.org

Bug: 731542, 790165, 731544, 790171, 731354, 790170, 776178, 790167
Change-Id: Ic8c0d03a013368901939992405dae3ceea7c21d5
Reviewed-on: https://chromium-review.googlesource.com/1060284Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Sergey Berezin <sergeyberezin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558828}

- Adds ActionView to DialogPlate.
- Handles ActionView press event in Assistant controller.

Press event is handled in the following way:
- If using keyboard input modality, action press == commit.
- If using voice input modality, action press == toggle voice
  interaction.

ActionView will be a wrapper around LogoView which is still under
development (b/78191547).

See bug for details.

Bug: b:79473532
Change-Id: I9ee4d465b29b3812caceb9d4804504d63b90df29
Reviewed-on: https://chromium-review.googlesource.com/1053160
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558827}

This ensures they trigger a playback failure instead of green frames.

BUG=842890
TEST=none

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibe27767c5f4779d7b9d4ebecb74f442bf0701b15
Reviewed-on: https://chromium-review.googlesource.com/1060237Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558826}

This test passes today by accident of the fact that the iframe is the
exact size necessary to be promoted to the root scroller. This indicates
the test is failing in a realistic environment since the root scroller
promition isn't yet shipped.

Bug: 841602
Change-Id: I10c68e7f2f0d3c2d00536d278f7f6ed6d5978ba0
Reviewed-on: https://chromium-review.googlesource.com/1053350Reviewed-by: Wei Li <weili@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558825}

With iOS11 there is API to access WKHTTPCookieStore and through
WKHTTPSystemCookieStore, URLFetcher can use this api to set and get
cookies from WKHTTPCookieStore

This should fix PDF download problems, it also should allow suggestions
queries to send cookies and will use cookies for NTP tiles.

Bug: 779106, 831678
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I59637ebde557fae09cfd39105d84675724ac0140
Reviewed-on: https://chromium-review.googlesource.com/1050404
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558824}

This file will be used by layout tests in http/, so it needs to be visible to them. I was told to
move the file to http/tests/resources, but it looks like another option would be to expose
sensor/resources to http tests via the apache_http.py script, which might be cleaner. Thoughts?

Bug: 802815
Change-Id: I3a8e37e0d41915d8cd5c5983d50d0f4dcc69ebcb
Reviewed-on: https://chromium-review.googlesource.com/1058549Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Robbie McElrath <rmcelrath@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558823}

Bug: 841475
Change-Id: I55e6008c29008fea3ca24bdca430fa3daa66a0d8
Tbr: chengx@chromium.org
Tbr: peter@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1060165Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558822}

These network quality estimator histograms were deprecated earlier,
but they were not correctly marked as deprecated.

Change-Id: Ib1081681cda243e7cd1c27f81ff453899242860f
Bug: 843210
Reviewed-on: https://chromium-review.googlesource.com/1058843Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558821}

Being added to buildbucket cfg in https://crrev.com/c/1058180

Bug: 790531,731983
Change-Id: Icdfaad8cb64db6d62f620e729e776232fc7ec564
Reviewed-on: https://chromium-review.googlesource.com/1058279Reviewed-by: Ryan Tseng <hinoka@chromium.org>
Commit-Queue: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558820}

BrowserStartupController.StartupCallback.onSuccess() has 'alreadyStarted'
argument, which is not used anywhere.

Bug: 841403
Change-Id: I8faf23c3b1d61d217460c0e3943dadeb6111ee05
Reviewed-on: https://chromium-review.googlesource.com/1055796Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Dmitry Skiba <dskiba@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558819}

Tests initialization by checking getters return the right values. Also
checks updating by checking setters properly modify the properties.

Bug: 778764
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I01ae81f5a7475b5e1bb5548707b7d9ab1b592701
Reviewed-on: https://chromium-review.googlesource.com/1058556
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558818}

This adds a presubmit check in the support library that all references
to InvocationHandlers should be annotated with the type they represent.

Annotations take the form of comments:

/* RetType */ InvocationHandler m(/* ParamType */ InvocationHandler p);

This intentionally skips import statements. The presubmit check is only
a warning, in case of false-positive.

Bug: 842022
Test: git cl presubmit -f --upload
Change-Id: I298d488d14f4fe828b02f4ac062bba6d4b1e9ae8
Reviewed-on: https://chromium-review.googlesource.com/1059009Reviewed-by: Richard Coles <torne@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558817}

Previously we were timing out 'null' favicon results after 60 seconds.

This has turned out to be too simple of a heuristic now that we are
using the FaviconCache to back the default search provider icon in the
location bar.

Users would expect that the favicon appear immediately after loading a
matching search results page, and would be confused by a 60 second
delay.

Bug: 88243, 823535
Change-Id: I062361ffad0e0bdaa45f44ad67a7071efa086f2c
Reviewed-on: https://chromium-review.googlesource.com/1055787
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558816}

R=cmasso@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iae0bcff5ffab587114e0b1257981257115d27a15
Reviewed-on: https://chromium-review.googlesource.com/1060252Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558815}

This patch removes a check that causes the scrim to remain visable
after the bottom sheet is closed. The check in question blocked offset
change events if the bottom sheet is closed, but in certain cases like
when the sheet doesn't animate, the sheets state is closed before any
offset events occur.

This patch also adds a BottomSheetObserver when the sheet is opened
that controls the opacity of the scrim and removes it when the sheet
is closed.

Bug: 842902,842765
Change-Id: Ic70532cefa0ddcafc06d0a2b3a5b6e28639ff24e
Reviewed-on: https://chromium-review.googlesource.com/1058437
Commit-Queue: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558814}

Bug: 843024
Change-Id: I559a2d65f5112724112a0a57b38e4da4ef375bc4
Reviewed-on: https://chromium-review.googlesource.com/1060116Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558813}