- 03 Apr, 2018 40 commits
-
-
Mustafa Emre Acer authored
This is the first translation screenshot to be used by http://go/chrome-translation-screenshots. This CL adds the SHA1 hash of the actual image which is stored in the Google Cloud Storage bucket at gs://chromium-translation-screenshots The screenshot can be downloaded using the gsutil tool like so: gsutil cp gs://chromium-translation-screenshots/378650e81625e476126a1a3d4b6ff559df54ef7c ~/translation.png Bug: 814897 Change-Id: I95bff8b6ac41be48a13212ad2bc9b4dcd5c4518b Reviewed-on: https://chromium-review.googlesource.com/976950Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#547763}
-
Xiaocheng Hu authored
The |if| statement's condition is always false, since |level| is set to |inline_box->BidiLevel()| in L165. Note: The code was originally introduced in crrev.com/edfe20, which already contains this redundant branching. Bug: 771398 Change-Id: If83f178b8ab91f15fcc7176e429541e69a681b15 Reviewed-on: https://chromium-review.googlesource.com/991604Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#547762}
-
Lei Zhang authored
https://chromium.googlesource.com/breakpad/breakpad.git/+log/ac4a549e29fb..adcc90ddb8c9 $ git log ac4a549e2..adcc90ddb --date=short --no-merges --format='%ad %ae %s' 2018-04-02 thestig Linux: Write out si_code for SIGBUS exceptions. 2018-03-27 tikuta Add missing header for free function 2018-03-09 ted Allow minidump_dump to print module lists that would normally be rejected for being too long. 2018-02-23 bratell Fixing incorrect include guard (missing #define) 2018-01-31 lv Fix Travis build by running tests as root 2018-02-02 adamharrison Fix crash when an NSException is thrown. Created with: roll-dep src/third_party/breakpad/breakpad Change-Id: I22af38b45e0526afc5539a05d67d2795589535ec Reviewed-on: https://chromium-review.googlesource.com/992995Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#547761}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 02de1dcf. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/15340 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams TBR=ajuma No-Export: true Change-Id: I77a008c5077e22979fc93d487960dd93cbe8d0e6 Reviewed-on: https://chromium-review.googlesource.com/992692 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#547760}
-
Julie Hockett authored
Updates the gn args --list command with an additional --json flag, which emits the same information as the normal --list command but in json format. Intended to be used to generate structured documentation for GN build arguments. The --markdown output is nice, but we want to do more processing than that to get it into good shape to integrate with our docs. Also updates the GetContextForValue function to get the file and the line number separately, rather than as one string, and updates the callsites with the new parameters. Change-Id: Id1240c37f835a18a12a6e4f5be58b9f8c7a663d1 Reviewed-on: https://chromium-review.googlesource.com/978423 Commit-Queue: Julie Hockett <juliehockett@google.com> Reviewed-by:
Roland McGrath <mcgrathr@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#547759}
-
John Abd-El-Malek authored
The problem was the constructor was posting a task to a different thread, which could execute before the constructor returns and a reference is held. This was seen in https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.memory%2FLinux_ASan_LSan_Tests__1_%2F44439%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FMSE_ExternalClearKey__x2f_EncryptedMediaTest.Playback_VP9Video_WebM_Subsample__x2f_0%2F0 Bug: 825242 Change-Id: Ib851536adc57bfab14748e1f7324b143aff55033 Reviewed-on: https://chromium-review.googlesource.com/992876Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#547758}
-
Raphael Kubo da Costa authored
Instead of doing an assignment within one of the expressions, just use the constant being assigned to. This also fixes a warning produced by GCC: ../../chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc: In function ‘void {anonymous}::RecordTokenChanged(const string&, const string&)’: ../../chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.cc:95:16: warning: operation on ‘transition’ may be undefined [-Wsequence-point] transition = ~~~~~~~~~~~^ (new_token == ~~~~~~~~~~~~~ MutableProfileOAuth2TokenServiceDelegate::kInvalidRefreshToken) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ? TokenStateTransition::kRegularToInvalid ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ : transition = TokenStateTransition::kRegularToRegular; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I8ea1dbd6ca499f3ba13a36dce41e152dc8263917 Reviewed-on: https://chromium-review.googlesource.com/992323Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#547757}
-
Yuta Kitamura authored
Scheduler classes are being renamed as part of scheduler architecture refactoring. Bug: 826203 Change-Id: I1f59849cdb83bbc861cc3110b87d4f0bec901761 Reviewed-on: https://chromium-review.googlesource.com/989528Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#547756}
-
Robert Liao authored
Before this change, when the user clicks on the button to dismiss the Extension Popup, the popup would dismiss and destroy. Next, the incoming mouse-up would note that the popup is already gone and show the popup. We want the popup to stay closed if it was dismissed by clicking the action button. The Views Browser doesn't have this problem because MenuButton tracks the last time the locked state was released and suppresses any activation if it occurs too soon. This change simply carries similar logic from Views MenuButton to Cocoa BrowserActionButton. BUG=825866 Change-Id: I089f0ab8658277ae8cbf71e2813e62aeb3c5505f Reviewed-on: https://chromium-review.googlesource.com/991596Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#547755}
-
Henrik Boström authored
MediaStreams added to an RTCPeerConnection using the legacy addStream() API is wired up such that the RTCPeerConnection is informed when tracks are added or removed from the MediaStream so that the corresponding sender can be added/removed from the PC. OnStreamAddTrack/OnStreamRemoveTrack was wired up to call addTrack() and removeTrack(), the crash occurred if these operations were to throw an exception even though we just want to suppress any exceptions thrown. The ExceptionState is updated to allow an exception to be thrown before being cleared. This fixes the referenced bug. Bug: 814139 Change-Id: I7798d7cf43bb71d42b7b8108f40ffba36dc95946 Reviewed-on: https://chromium-review.googlesource.com/992321Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#547754}
-
John Budorick authored
Bug: 731759 Change-Id: Ied650ef11b381acf050fb606a06670fe78e187de Reviewed-on: https://chromium-review.googlesource.com/920682Reviewed-by:
Benjamin Pastene <bpastene@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#547753}
-
David Black authored
Bug: b:77282340 Change-Id: I88ea25128043ec69ec88357f36babfae36fe88fd Reviewed-on: https://chromium-review.googlesource.com/986921Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#547752}
-
Zhiling Huang authored
Bug: 790142 Change-Id: I24385ce8be54b9d36bbbeb87a963aff18818e72d Reviewed-on: https://chromium-review.googlesource.com/989300Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#547751}
-
Troy Hildebrandt authored
The new LocationBarVoiceRecognitionHandler was using Tab's #getActivity instead of using WindowAndroid's #getActivity. In the search widget, Tab's getActivity returned null and exited #startVoiceRecognition early. This fix just gets the WindowAndroid from the Tab first and then uses its activity and all is well. Bug: 828309 Change-Id: I05b68b0228d1c5f962ee1ee2fa23675ccaa5b6db Reviewed-on: https://chromium-review.googlesource.com/992992Reviewed-by:
Maria Khomenko <mariakhomenko@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#547750}
-
Owen Min authored
Disable this test as it consistently failed on Win10 and Win7. Tbr: irisu@chromium.org Bug: 828042 Change-Id: I5366a98999fca0911ae018a94ca479a3e6a308d9 Reviewed-on: https://chromium-review.googlesource.com/992881Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547749}
-
AJITH KUMAR V authored
Currently, on every hover event we are creating a deep copy of the event for offsetting purpose. Actually this is needed when any of the (x,y) offset is updated prior to it. If not updated creating a deep copy for a 0.0f offset is additional overhead for nothing. Hence doing offsetting only when either x or y offset is non-zero. Change-Id: I1f39b4058cad217769ea6ba02b7b87c222420fd9 Reviewed-on: https://chromium-review.googlesource.com/989595Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Commit-Queue: AJITH KUMAR V <ajith.v@samsung.com> Cr-Commit-Position: refs/heads/master@{#547748}
-
Katie D authored
Bug: 823359 Change-Id: I62707b079f9ee899feb7c624a498c5f16f6fe061 Reviewed-on: https://chromium-review.googlesource.com/988226Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#547747}
-
Kyle Horimoto authored
When a device registers to use the CryptAuth back-end, it must provide an ID during the enrollment process. Since EasyUnlock was the first CrOS feature using CryptAuth, this logic was originally implemented as part of EasyUnlock. At a later point, some of this code was copied to ChromeCryptAuthService, so there were multiple versions of this code living in various parts of the code base. This code is now moved to a single location and is shared among clients. Implementation is split between a pure-virtual CryptAuthDeviceIdProvider class living in //components/cryptauth and an implementation which relies on browser local storage in //chrome/browser/chromeos/cryptauth. This separation is necessary so that a future CL, which will rely on the device ID from within //chromeos, will be able to access this code behind an interface. Bug: 824568, 752273 Change-Id: I4155d49dbf7ab55afb0245bd595a1c033db68ee2 Reviewed-on: https://chromium-review.googlesource.com/989018Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
James Hawkins <jhawkins@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#547746}
-
Justin Cohen authored
Also corrects the scroll distance to fix iPhone X tests. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I516c19f8343eaa21f5dcd9ce4e6e35e1fcd62640 Reviewed-on: https://chromium-review.googlesource.com/991574 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#547745}
-
Koji Ishii authored
This test: fast/text/international/combining-marks-position.html passes on Windows but fails on Linux and Mac. It renders Arabic using LinLibertine, which is a Latin font, and that falls back to system fallback. LayoutNG added an expectation to pass at one point where it passed, probably due to some errors. Now it fails as in the current layout engine, which is expected. TBR=drott@chromium.org, atotic@chromium.org, bashi@chromium.org NOTRY=true Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I93b33c96ed1ead3baa1ec535f86610425ae1fd4c Reviewed-on: https://chromium-review.googlesource.com/992712 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#547744}
-
Becca Hughes authored
Do not create the volume slider on the new media controls as we don't need it. Also, avoids adding elements to the DOM that are permanently hidden. BUG=821961,821414 Change-Id: Ia0e334b6079450d4a3b084371629f6b6ba37176c Reviewed-on: https://chromium-review.googlesource.com/991293 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#547743}
-
Harald Alvestrand authored
Since the constructor of RTCDTMFToneChangeEvent is exposed, creating such events with other names than "tonechange" is possible. No reason to discriminate against such. Also adds tests for constructor. Bug: chromium:822799 Change-Id: I4b36f3094acee200dd4200c4d24f6b46e10a06e6 Reviewed-on: https://chromium-review.googlesource.com/992038Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#547742}
-
Scott Violet authored
This test installs a MockNetworkChangeNotifier that starts out in the disconnected state. It then switches to WIFI and ensures VariationsService did a request. BUG=826930 TEST=covered by test Change-Id: I8d193647689e8f67dfc9674bd81bd0d6da9e056b Reviewed-on: https://chromium-review.googlesource.com/990728 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#547741}
-
Lei Zhang authored
BUG=827748 Change-Id: Id011527d001ffbb70130bfee085e4a21b80c8100 Reviewed-on: https://chromium-review.googlesource.com/989287 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#547740}
-
Nate Fischer authored
No change to behavior. This removes no-longer-needed annotations for Safe Browsing methods. For initSafeBrowsing(), the SuppressWarnings and TargetApi annotations are leftover from when this method relied on reflection. For other, maybeEnableSafeBrowsingFromManifest, the SuppressWarnings annotation was similarly leftover from reflection. Bug: 682070 Test: N/A Change-Id: I828dc570217742c4d052e3fb5ef16c799d7c9715 Reviewed-on: https://chromium-review.googlesource.com/991162Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#547739}
-
Raphael Kubo da Costa authored
Instead of doing an assignment within one of the expressions, just use the constant being assigned to. This also fixes a warning produced by GCC: ../../components/crash/content/app/crashpad.cc: In function ‘void crash_reporter::GetReportsImpl(std::vector<crash_reporter::Report>*)’: ../../components/crash/content/app/crashpad.cc:355:18: warning: operation on ‘report.crash_reporter::Report::state’ may be undefined [-Wsequence-point] report.state = pending_report.upload_explicitly_requested ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ? ReportUploadState::Pending_UserRequested ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ : report.state = ReportUploadState::Pending; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: Ie4330b29016fce305335bb8009306a44ebba55ee Reviewed-on: https://chromium-review.googlesource.com/992324Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#547738}
-
Tommy Nyquist authored
This CL aims to describe how the Omaha client code works on Android, since it is a bit different than our other platforms. This is done as a README.md file in the main directory. The document describes the core flow, triggering, requests and responses, scheduling, class structure, and testing. This also adds new users to the OWNERS file in the omaha client directory. BUG=806040 Change-Id: Ib20b65d00d4bf8489067a2a0595b8d78dafc32bd Reviewed-on: https://chromium-review.googlesource.com/991057Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#547737}
-
chrome://flagsCarlos IL authored
Change-Id: I5d785b931191df2870d2edd182454c6a2208e1ee Reviewed-on: https://chromium-review.googlesource.com/985354 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#547736}
-
Xi Cheng authored
Bug: 734095 Change-Id: Iefbf6199c442ce15104e9afbc449ae910d620079 Reviewed-on: https://chromium-review.googlesource.com/989833Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#547735}
-
Roman Sorokin authored
Switching from my own invented bike to a library function for credentials and config files. BUG=815158 TEST=manual Change-Id: I32db516219a7db17d8b0dd7a3ed0f15c8430389f Reviewed-on: https://chromium-review.googlesource.com/974108Reviewed-by:
Lutz Justen <ljusten@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#547734}
-
Chris Nardi authored
Custom property names are defined [1] to be "any valid identifier that starts with two dashes." As such, they need to be serialized as identifiers, in order to ensure that reparsing generates a valid custom property name. Change our serialization of custom property names to use SerializeIdentifier(). [1]: https://drafts.csswg.org/css-variables/#typedef-custom-property-name Bug: 828272 Change-Id: Icd830b6b3b38f0414877c6d8dec69efa00318bb3 Reviewed-on: https://chromium-review.googlesource.com/991608Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Chris Nardi <cnardi@chromium.org> Cr-Commit-Position: refs/heads/master@{#547733}
-
Christopher Grant authored
This change completes the merge of URL rendering into VR's text system. Text can now accept custom callbacks to run at two keys points during text rendering. This is done via callbacks to allow Text to continue using its private texture class under the hood. BUG=824472 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1cd0b48f51f36435f0f79b51131cd2e1b48e93a9 Reviewed-on: https://chromium-review.googlesource.com/986670 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#547732}
-
Mitsuru Oshima authored
BUG=822960 TEST=None Change-Id: I63cb34bab20ba4801bed00ffd997063e6e45ef1e Reviewed-on: https://chromium-review.googlesource.com/981909Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#547731}
-
Elly Fong-Jones authored
Bug: 825610 Change-Id: I23daefcdbc318009d083a65f611a2b821c77b2c4 Reviewed-on: https://chromium-review.googlesource.com/992653Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#547730}
-
Xi Cheng authored
Bug: 734095 Change-Id: I0ad44050d97f942e5cebf4d9f302ce74f4527b34 Reviewed-on: https://chromium-review.googlesource.com/990574Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#547729}
-
Ken Rockot authored
Cherry-picks a couple of things: - Adds support for wrapping and unwrapping new base shm regions - Ports one use (PDF compositor test code) to use the above - Updates base::SharedMemory wrapping to force read-only regions when wrapping a handle as read-only Bug: 826213 Change-Id: I11d923b23688454ffdbf26ba5efa93ba1605b855 Reviewed-on: https://chromium-review.googlesource.com/992360Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#547728}
-
Becca Hughes authored
The slider positions are constantly updated even when they have not changed. This changes them to only be updated when changed. BUG=821961,821414 Change-Id: Ia978e130d51915bce121913db7f66caccbd9e636 Reviewed-on: https://chromium-review.googlesource.com/991075Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#547727}
-
Hiroki Nakagawa authored
This CL adds the OffMainThreadWebSocket flag to enable the off-main-thread WebSocket for WebWorkers. With the flag, WebSocket connection requests on worker threads are not routed via the main thread. Also, this CL runs layout tests and web-platform-tests with the flag. Failing tests will be fixed by following CLs. Design Doc: https://docs.google.com/document/d/1ya3sfQ5YsDtHSCXn2renQjCxM4AWeYlhehw8Skppsr8/edit?usp=sharing Bug: 825740 Change-Id: I9fe5a98632a02eb97c0d32d63917088af7f69994 Reviewed-on: https://chromium-review.googlesource.com/979835 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#547726}
-
Gabriel Charette authored
This is a precusor cleanup extracted from https://chromium-review.googlesource.com/c/chromium/src/+/957760/7 in the broader effort to restrict usage of MessageLoop::current(). This CL was uploaded by git cl split. R=sadrul@chromium.org Bug: 825327 Change-Id: I6f8ceff1f344ac21727f1b90a3e35291718f88af Reviewed-on: https://chromium-review.googlesource.com/986537 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#547725}
-
erikchen authored
This CL sets up the directory structure of components/services/heap_profiling and moves in the profiling mojom files. It has no intended behavioral change. This is in preparation for moving the rest of the heap profiling logic into components/services/heap_profiling in order to support Android WebView. Bug: 827545 Change-Id: I8409c2fc67d96b18ac148538da7f2a0f7a79b9dd Reviewed-on: https://chromium-review.googlesource.com/990495Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#547724}
-