GitLab

Part of getting OpenSSL working on OS X, the networking_private_crypto.cc
implementation is renamed to networking_private_crypto_nss.cc and a stubbed out
version networking_private_crypto_openssl.cc.

BUG=393023

Review URL: https://codereview.chromium.org/387753003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282526 0039d316-1c4b-4281-b951-d872f2087c98

This error seems to pop up when adb is not currently running. It isn't clear to
me why we get that instead of NoSuchProcess, but in any case, this should allow
us to continue instead of aborting like in:
http://chromegw/i/chromium.perf/builders/Android%20Nexus5%20Perf/builds/1022/steps/device_status_check/logs/stdio

BUG=388885

Review URL: https://codereview.chromium.org/385733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282525 0039d316-1c4b-4281-b951-d872f2087c98

This should fix a document leak from r270279.

BUG=392121

Review URL: https://codereview.chromium.org/380533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282524 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387985
TEST=components_unittests

Review URL: https://codereview.chromium.org/382663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282523 0039d316-1c4b-4281-b951-d872f2087c98

The condition should find entry change but '!' is missing so far.

BUG=392055
TEST=manually

Review URL: https://codereview.chromium.org/383463004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282522 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/389443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282521 0039d316-1c4b-4281-b951-d872f2087c98

BUG=393024

Review URL: https://codereview.chromium.org/384983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282516 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282513 0039d316-1c4b-4281-b951-d872f2087c98

r=wtc

Review URL: https://codereview.chromium.org/380403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282511 0039d316-1c4b-4281-b951-d872f2087c98

For some applications where we need to keep multiple copies of the audio bus around (particularly in STL containers), a scoped_ptr to an audio bus isn't enough. For those rare situations, we're adding a RefCounted version of the AudioBus.

R=dalecurtis@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/388563005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282510 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=392585

Review URL: https://codereview.chromium.org/386863002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282509 0039d316-1c4b-4281-b951-d872f2087c98

BUG=336640

Review URL: https://codereview.chromium.org/223143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282508 0039d316-1c4b-4281-b951-d872f2087c98

In order to update forbidden header names in Blink side, I remove a subtest
from a browsertest.
I will restore the subtest once the Blink side CL[1] is landed.

1: https://codereview.chromium.org/378183003/

BUG=373120

Review URL: https://codereview.chromium.org/385523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282507 0039d316-1c4b-4281-b951-d872f2087c98

This is done by setting results_are_the_same_on_every_page property on
TimelineBasedMeasurement to False.

BUG=393049

Review URL: https://codereview.chromium.org/387783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282506 0039d316-1c4b-4281-b951-d872f2087c98

This patch uses the existing browser_navigation_start field in
FrameMsg_Navigate to set the navigation start time for browser
navigations in new tabs.

For browser navigations that result in cross-site swap, the value is
later overriden with the end of the beforeunload event of the current
document.

BUG=376004

Review URL: https://codereview.chromium.org/339573003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282505 0039d316-1c4b-4281-b951-d872f2087c98

The navigation transition needs to apply some styles during the transition, so we need to expose this call to java.

Design doc: https://docs.google.com/a/chromium.org/document/d/17jg1RRL3RI969cLwbKBIcoGDsPwqaEdBxafGNYGwiY4/edit# 
Implementation details: https://docs.google.com/a/chromium.org/document/d/1kREPtFJaeLoDKwrfmrYTD7DHCdxX1RzFBga2gNY8lyE/edit#heading=h.bng2kpmyvxq5
BUG=370696

Review URL: https://codereview.chromium.org/375073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282504 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391943
TBR=nduca@chromium.org

Review URL: https://codereview.chromium.org/387753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282502 0039d316-1c4b-4281-b951-d872f2087c98

Creating a canvas can fail, so be robust to this.

BUG=392587

Review URL: https://codereview.chromium.org/386803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282500 0039d316-1c4b-4281-b951-d872f2087c98

The default cookie option excludes http only cookies. And thus causing some streams not being able to play.

android bug 66050

Review URL: https://codereview.chromium.org/386723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282499 0039d316-1c4b-4281-b951-d872f2087c98

android_tools/sdk/tools/proguard/bin/proguard.sh was removed with SDK tools
update. https://gerrit.chromium.org/gerrit/#/c/70802/ updates SDK tools
and we want to roll to start using it.

BUG=393019

Review URL: https://codereview.chromium.org/377353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282498 0039d316-1c4b-4281-b951-d872f2087c98

It still takes time to componentize autocomplete input and search
features. However, we have componentized some important parts
already. The added code will be replaced by the real autocomplete
code in the future, but meanwhile, this is good enough.

Feature:
- the logic to check if the input looks like URL / host names
- canonicalize the input to form the actual URL (http://...)
- use TemplateURLService to create the search result page URL
  if it looks like a query.

BUG=387207
R=oshima@chromium.org, hashimoto@chromium.org
TBR=pkasting@chromium.org, jar@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/382683002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282497 0039d316-1c4b-4281-b951-d872f2087c98

Inputs:
- directory to libffmpegsumo.so.
- network simulation parameters given as a proto.

BUG=none

Review URL: https://codereview.chromium.org/362123005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282496 0039d316-1c4b-4281-b951-d872f2087c98

Having the same name for a grd is bad because the post processor flattens
the file so one of them gets overriten with the other.

NOTRY=true
TBR=blundell
BUG=372175

Review URL: https://codereview.chromium.org/381353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282495 0039d316-1c4b-4281-b951-d872f2087c98

BUG=392874

Review URL: https://codereview.chromium.org/382963003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282494 0039d316-1c4b-4281-b951-d872f2087c98

It looks like this crash came from the following CL:
https://codereview.chromium.org/338523007

R=sehr@chromium.org
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3032

Review URL: https://codereview.chromium.org/383803003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282493 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/386733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282492 0039d316-1c4b-4281-b951-d872f2087c98

Makes the "IsSystemThemeDistinctFromDefaultTheme()" detection logic
compatible with non-GTK (ie. Aura) Linux.  It moves the check out of
sync code and into the ThemeService so this kind of bug will be less
likely to recur if the themes logic changes again.

Re-enables an integration test that was disabled during the transition
to Aura.

BUG=304554,392934

Review URL: https://codereview.chromium.org/388563004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282491 0039d316-1c4b-4281-b951-d872f2087c98

Pending libvpx updates
BUG=392309

R=scherkus@chromium.org

Review URL: https://codereview.chromium.org/376283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282490 0039d316-1c4b-4281-b951-d872f2087c98

There is a typo in the output element of the "Build Remoting Webapp unittest.html" action.  The current output element refers to a non-existent location.  As a result, ninja invoke the action on every build run.

I also removes exclude-js from the input element, as there is no need to re-invoke the action if the content of an excluded script is modified.

BUG=392834

Review URL: https://codereview.chromium.org/385713003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282486 0039d316-1c4b-4281-b951-d872f2087c98

This builds on https://codereview.chromium.org/385653002/ .

Many functions in Python's logging module grab a lock internally. Some
appear to do so before converting the provided message to a string via
its __str__ method.

Calling an object's __str__ method before calling a logging funciton
allows anything called by the __str__ method to log without the risk of
hitting a deadlock.

BUG=392869

Review URL: https://codereview.chromium.org/383793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282485 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that enrollment recovery really only is triggered when the
machine id can be accessed.

BUG=389481

Review URL: https://codereview.chromium.org/386643003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282484 0039d316-1c4b-4281-b951-d872f2087c98

We probably shouldn't allow this, but it's currently relied upon by the
WebAudio code and cleaning it up is a big deal: http://crbug.com/151051.

The AudioRendererSink interface does not specify that after Stop() the
sink can no longer be used.  All other sinks allow restart, so this is
just keeping with the pace.

In http://crrev.com/280502 I conflated the one-stop-only mechanics of
AudioRenderer:Stop() with those of AudioRendererSink::Stop().  This
patch reverts that mistake while keeping the fixes for the original
issue.

BUG=389204,390977
TEST=new unittest.

Review URL: https://codereview.chromium.org/381823003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282481 0039d316-1c4b-4281-b951-d872f2087c98

As requested by frankf:
  https://codereview.chromium.org/351603002/#msg2
  https://codereview.chromium.org/358993003/#msg9
  https://codereview.chromium.org/371813005/#msg8

BUG=267773

Review URL: https://codereview.chromium.org/377373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282480 0039d316-1c4b-4281-b951-d872f2087c98

ChromeRenderViewObserver::CapturePageInfo is a relic. It hasn't captured page content for indexing for about a year now (r212459), and the fancy footwork to avoid re-indexing isn't needed any more.

BUG=371151
TEST=everything still works

Review URL: https://codereview.chromium.org/363293005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282479 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromedriver:843
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/385753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282477 0039d316-1c4b-4281-b951-d872f2087c98

We recently moved to new directory structure, and while refactoring
we missed to specify localname for the module. crreve.com/282209

NOTRY=true
BUG=393057

Review URL: https://codereview.chromium.org/389453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282476 0039d316-1c4b-4281-b951-d872f2087c98

Pre-CL for https://codereview.chromium.org/379943003/:

We need to delay load "setupapi.dll" as device/bluetooth now uses "SetupDiGetDevicePropery" which is available on Vista+ only.

BUG=388016
TBR=keybuk@chromium.org, armansito@chromium.org

Review URL: https://codereview.chromium.org/387673002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282472 0039d316-1c4b-4281-b951-d872f2087c98

TEST=Observe an onvoiceschanged event handler gets called when...
- built-in extension tts engine loads.
- webstore-based extension engine is enabled/disabled.

Review URL: https://codereview.chromium.org/361363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282471 0039d316-1c4b-4281-b951-d872f2087c98

Previously, errors in the user-defined callback function could break the
internal state of the pageCapture API. This is now mitigated by reading
and nulling the callback before using it, and only access the properties
of the response object after verifying that it is not void.

Also fixed a typo in an error message.

BUG=392800
TEST=Manually the tests from the bug report (or read the source code and
infer from the changes that the reported bugs have been fixed.)

Review URL: https://codereview.chromium.org/384653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282470 0039d316-1c4b-4281-b951-d872f2087c98

Fixes an issue when using managed_install=1 with Android L.

BUG=None
NOTRY=true
TBR=cjhopman@chromium.org

Review URL: https://codereview.chromium.org/380343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@282469 0039d316-1c4b-4281-b951-d872f2087c98