GitLab

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/668093002

Cr-Commit-Position: refs/heads/master@{#300570}

Check for EGL_KHR_wait_sync extension before calling eglWaitSyncKHR. If
extension not present, fallback to EGL_KHR_fence_sync and
eglClientWaitSyncKHR.

BUG=

Review URL: https://codereview.chromium.org/670843002

Cr-Commit-Position: refs/heads/master@{#300569}

From [1]:
"Filename globs follow the simple UNIX shell conventions
("*" and "?" are supported), and relative and absolute
paths are not allowed (globs may only refer to the files
in the current directory)."

So I'm pushing my name to the appropriate new
OWNERS file.

[1] http://www.chromium.org/developers/owners-files

Review URL: https://codereview.chromium.org/667483005

Cr-Commit-Position: refs/heads/master@{#300568}

telemetry downloads gsutil sometimes there when its running tests. This isn't shipped to users.

R=thestig@chromium.org

Review URL: https://codereview.chromium.org/672513002

Cr-Commit-Position: refs/heads/master@{#300567}

* If CommitFrame is skipped to to stall, ensure we invalidate.
* Make sure force_invalidate does not get cancelled by a
  pending fallback tick.
* Allow hardware initialization even when visible rect is
  empty, so fallback tick is always in the right mode.
* Fix visible rect empty checks.

BUG=425372

Review URL: https://codereview.chromium.org/654403006

Cr-Commit-Position: refs/heads/master@{#300566}

BUG=NONE

Review URL: https://codereview.chromium.org/651323002

Cr-Commit-Position: refs/heads/master@{#300565}

Hopefully this will discourage people landing patches to this directory
without knowing the development model.

R=ben@chromium.org

Review URL: https://codereview.chromium.org/665723006

Cr-Commit-Position: refs/heads/master@{#300564}

There are currently 1072 violations of this check in chromium codebase.

BUG=318404

Review URL: https://codereview.chromium.org/650693003

Cr-Commit-Position: refs/heads/master@{#300563}

There's a few lingering bits that could be split out into separate
classes (ClearBrowsingDataObserver, VersionStrings) but can be done in a
separate change.

BUG=169106
NOTRY=true

Review URL: https://codereview.chromium.org/666063002

Cr-Commit-Position: refs/heads/master@{#300562}

- Layout adjustments
- Parsed capture formats (resolution, fps, [pixel format])
- String representation of capture API types
- Unit test checking all capture API types and video format strings are up to date

Preview screenshot (linux): http://goo.gl/QTPUhj

BUG=425029, 344882

Review URL: https://codereview.chromium.org/637953008

Cr-Commit-Position: refs/heads/master@{#300561}

R=ben@chromium.org

Review URL: https://codereview.chromium.org/670653004

Cr-Commit-Position: refs/heads/master@{#300560}

In particular BTN_* events for the touchpad should not be dispatched as
keypresses. So just filter any presses that aren't mapped.

BUG=425617
TEST=manual on link_freon, events_unittests

Review URL: https://codereview.chromium.org/668943003

Cr-Commit-Position: refs/heads/master@{#300559}

"Block all" really means "Right-click to play".

BUG=251024

Review URL: https://codereview.chromium.org/666523004

Cr-Commit-Position: refs/heads/master@{#300558}

Revert of Use -s to pass string date to 'adb shell date' command to set date in provision. (patchset #1 id:1 of https://codereview.chromium.org/668013003/)

Reason for revert:
Broke the same tests mentioned on the bug on existing android bots, ex:
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/23612
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/16366

Original issue's description:
> Use -s to pass string date to 'adb shell date' command to set date in provision.
>
> The 'date -u' was not working on N5 devices. The -s option seems to work across
> devices. I've tested on N4 and N5.
>
> BUG=406848
>
> Committed: https://crrev.com/e3b2f5071ae50778f07abbc84fc6a9e07e169892
> Cr-Commit-Position: refs/heads/master@{#300542}

TBR=zty@chromium.org,jbudorick@chromium.org,yfriedman@google.com,navabi@google.com
NOTREECHECKS=true
NOTRY=true
BUG=406848

Review URL: https://codereview.chromium.org/667303002

Cr-Commit-Position: refs/heads/master@{#300557}

Revert of exclude SyncBackendRegistrarShutdownTest.BlockingShutdown from Dr.Memory bots (patchset #1 id:1 of https://codereview.chromium.org/668063002/)

Reason for revert:
the excluded test SyncBackendRegistrarShutdownTest.BlockingShutdown is removed

Original issue's description:
> exclude SyncBackendRegistrarShutdownTest.BlockingShutdown from Dr.Memory bots
>
> BUG=425568
> TBR=stanisc@chromium.org
> NOTRY=true
>
> Committed: https://crrev.com/f4efb8d1513eb996cf0f0f1f842a8c729ce2a098
> Cr-Commit-Position: refs/heads/master@{#300552}

TBR=stanisc@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=425568

Review URL: https://codereview.chromium.org/674433002

Cr-Commit-Position: refs/heads/master@{#300556}

1) Replace android remote debugging unix domain socket path with
   cast_shell_debugging_remote.
2) Fix sandbox permission name correctly.

BUG=425615

Review URL: https://codereview.chromium.org/637353004

Cr-Commit-Position: refs/heads/master@{#300555}

R=lcwu@chromium.org,gusfernandez@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/668933002

Cr-Commit-Position: refs/heads/master@{#300554}

BUG=57376

Review URL: https://codereview.chromium.org/634523004

Cr-Commit-Position: refs/heads/master@{#300553}

BUG=425568
TBR=stanisc@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/668063002

Cr-Commit-Position: refs/heads/master@{#300552}

- make each device contents an ordered list so we get "list 5 items" spoken.
- add a title to each ContextMenuButton so "Actions" is said instead of just "button".
- remove "required" from search input as it is spoken and unnecessary.
- create a useful summary aria-label for checkboxes so users can scroll quickly through entries

R=dmazzoni@chromium.org
BUG=385344

Review URL: https://codereview.chromium.org/664863004

Cr-Commit-Position: refs/heads/master@{#300551}

This is mostly to fix MSVC warnings about possible value truncation.

BUG=81439
TEST=none

Review URL: https://codereview.chromium.org/660953002

Cr-Commit-Position: refs/heads/master@{#300550}

actual time QuicStreamFactory state machine was waiting to load QUIC
server information from disk cache.

Retired Net.QuicServerInfo.DiskCacheReadTime.

R=asvitkine@chromium.org, rch@chromium.org

Review URL: https://codereview.chromium.org/667683004

Cr-Commit-Position: refs/heads/master@{#300549}

This helper to upcast in return statements is no longer needed.

BUG=423621

Review URL: https://codereview.chromium.org/663243003

Cr-Commit-Position: refs/heads/master@{#300548}

Moved constants out of web_view.js and into a new file, web_view_constants.js, so that the constants can be shared by multiple webview files.

Review URL: https://codereview.chromium.org/661743005

Cr-Commit-Position: refs/heads/master@{#300547}

The NSPR problem was fixed in NSPR 4.9.5. Right now we require
NSS 3.14.3, which requires NSPR 4.9.5.

R=viettrungluu@chromium.org,mark@chromium.org
BUG=

Review URL: https://codereview.chromium.org/639293007

Cr-Commit-Position: refs/heads/master@{#300546}

Use the associated contents instead of the extensions::WindowController to get the parent window for the "uninstall prompt" dialog.
This results in the correct parent window used for uninstall dialogs on Athena
because there is no extensions::WindowController for Athena.

BUG=414341
TEST=None

Review URL: https://codereview.chromium.org/636083003

Cr-Commit-Position: refs/heads/master@{#300545}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/dd5a1e0..183e985

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/667233002

Cr-Commit-Position: refs/heads/master@{#300544}

BUG=399701

Review URL: https://codereview.chromium.org/671533005

Cr-Commit-Position: refs/heads/master@{#300543}

The 'date -u' was not working on N5 devices. The -s option seems to work across
devices. I've tested on N4 and N5.

BUG=406848

Review URL: https://codereview.chromium.org/668013003

Cr-Commit-Position: refs/heads/master@{#300542}

BUG=268157

Review URL: https://codereview.chromium.org/672463002

Cr-Commit-Position: refs/heads/master@{#300541}

BUG=none
R=sky@chromium.org

Review URL: https://codereview.chromium.org/602043006

Cr-Commit-Position: refs/heads/master@{#300540}

BUG=424685

Review URL: https://codereview.chromium.org/669713002

Cr-Commit-Position: refs/heads/master@{#300539}

TtsController doesn't need to know about it.

BUG=347045

Review URL: https://codereview.chromium.org/625503002

Cr-Commit-Position: refs/heads/master@{#300538}

BUG=365354

Committed: https://crrev.com/f406302bb6e9ab6a533d3ac39c39b39705d7d422
Cr-Commit-Position: refs/heads/master@{#296922}

Review URL: https://codereview.chromium.org/494633003

Cr-Commit-Position: refs/heads/master@{#300537}

BUG=425599

Review URL: https://codereview.chromium.org/667053006

Cr-Commit-Position: refs/heads/master@{#300536}

According to specs, ARIA role region should be exposed as below

MSAA+IA2: ROLE_SYSTEM_PANE

AXRole:AXGroup
AXSubrole:AXDocumentRegion
AXRoleDescription:'region'

Also section tag should have AXRoleDescription as 'region'

BUG=424521
TBR=avi

Review URL: https://codereview.chromium.org/638103003

Cr-Commit-Position: refs/heads/master@{#300535}

The toolchains now contain an up-to-date version
of thie header to its not longer needed here.

Review URL: https://codereview.chromium.org/666163004

Cr-Commit-Position: refs/heads/master@{#300534}

This is a simple search and replace:
  s/usage_mask/usages/g

There was some inconsistenty on when variables were called "usages" versus "usage_mask"; now they all read "usages".

Review URL: https://codereview.chromium.org/670773003

Cr-Commit-Position: refs/heads/master@{#300533}

BUG=401438

Review URL: https://codereview.chromium.org/644913006

Cr-Commit-Position: refs/heads/master@{#300532}

BUG=chromedriver:783

Review URL: https://codereview.chromium.org/613163004

Cr-Commit-Position: refs/heads/master@{#300531}