- 17 Jul, 2020 40 commits
-
-
Ewann authored
This Cl makes the bottom toolbar visible when initiating a drag down to close a modal setting view. Bug: 1106665 Change-Id: I519fac84a18c36c6838384241af01f1c57a824b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302633Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#789454}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a74cd08cb159..e810d53b527e 2020-07-17 tvanderlippe@chromium.org Move lit-html entrypoint to front_end/third_party 2020-07-17 tvanderlippe@chromium.org Remove empty script arrays from module.json files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1105476 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5331f571a59d4d15daf58ffd1efb101508f112f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304404Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789453}
-
Maria Kazinova authored
One of the obstacles for recording the FillingAssistance metric on iOS is that it's not always possible to recoved autofilled values. Now they are stored in FieldDataManager as well. Bug: 918846 Change-Id: Ic2bbbd5b5bc5ea61230ab8844a2278d8adc64168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302112 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#789452}
-
Matthias Körber authored
Currently, the utils only contain functions to parse/match regular expressions and a cache for compiled regular expressions. I kept the RE2 engine since the support for named capture groups is very limited in ICU: You can have named capture groups but there seems to be no method to acquire the the group names. Change-Id: I664c4ce548d35971e43881c70a3849a5b09bbf33 Bug: 1099202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279980 Commit-Queue: Matthias Körber <koerber@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#789451}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/d9b254b474d3..f50a0fb8a663 2020-07-17 lalitm@google.com Merge "tp: organize all tp tests and remove legacy folder" 2020-07-17 lalitm@google.com Merge "tp: merge test/metrics into test/trace_processor" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I936cfc2b8cc8da8dcf6545dc160be935bfdbda58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304403Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1594878809-f70bebc20790ac0846ac45f570a81eb656b74862.profdata to chrome-win64-master-1594943787-7f5d9753ae33a53104b9969d76a646b53f10ccce.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I08f4f2ff4e22ff5e2198bcd9f48c94907d948e82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304140Reviewed-by:
-
Ioana Pandele authored
Bug: 1100694 Change-Id: I25bc5e12cdc5d956b759f99fa2813d564a5c02cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302695Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#789448}
-
sandromaggi authored
Before this change, when the Autofill Assistant was dismissed with the cancel button showing the Snackbar, and changing from CCT to Browser during the time the Snackbar was open, Autofill Assistant would revive in the browser. This happens, because the UI gets destroyed and recreated, losing all knowledge about the Snackbar. Now, if a Snackbar is showing when the switch happens, we execute the callback immediately, which might shut down Autofill Assistant. Bug: b/159784978 Change-Id: I600bc0de4796c9f65533d1627030963a83b02865 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302196Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#789447}
-
Maksim Ivanov authored
Refactor the CertificateProviderService to return an error when the supplied sign request ID is unknown. This will be used in a follow-up CL to implement returning an error to the extension when the new reportSignature() function is called with a bad ID. Bug: 1078761 Change-Id: I51dd4cee5237ea240d504be67079ebc2a4b15e60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250200 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Cr-Commit-Position: refs/heads/master@{#789446}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/13fbc08b938e..1a09faed62a4 2020-07-17 nisse@webrtc.org Delete SignalDataChannelTransportNegotiated 2020-07-17 nisse@webrtc.org Delete unused enum values for DataChannelType If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie6c911562c98e26543c716fc72eb10248cda4c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304402Reviewed-by:
-
Side Yilmaz authored
This CL replaces deprecated |createImageFecther| function by passing profile to the function. Since assistant is only available in regular mode, |AutofillAssistantUiController#getProfile| returns |Profile#getLastUsedRegularProfile|. Then, the caller classes creates image fecther using |AutofillAssistantUiController#getProfile|. Previous discussions are in crrev.com/c/2276422. Bug: 1041781, 1083923, 1075562 Change-Id: I339c4e69f01de8a855a6353614adc26c1cac6439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301769 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#789444}
-
Luke Seunghoe Gu authored
In order to prevent crashes due to unchecked uses of GetWindowAndroid(), this CL creates dialog instance only if window is successfully retrieved. Plus, null-checks for dialog instance are needed before using it. Bug: 1051035, 1049090 Change-Id: Icae3747474398b09c73372a0879f3df7a2afa978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294761 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#789443}
-
Mike West authored
TBR: nifong@google.com Bug: 1106590 Change-Id: I669d42c97d98de839c62140df4b3ca90829211cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302635Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#789442}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c648f63ca9e2..1769f267f216 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mkwst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mkwst@google.com Change-Id: I4b215086b752c074e5861ee60e36b45c4d7370c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304398Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789441}
-
Aya ElAttar authored
Change-Id: I9fe9f01c3550a329c8eae2ecec574cfa98965016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302611 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#789440}
-
Mike West authored
`TopControlsSlideControllerTest.TestScrollingPage` is flakily timing out on ChromeOS builders. See [1], and [2], and [3]. [1]: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=TopControlsSlideControllerTest.TestScrollingPage&testType=browser_tests [2]: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/19632 [3]: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874539563088802240/+/steps/browser_tests/0/logs/Deterministic_failure:_TopControlsSlideControllerTest.TestScrollingPage__status_TIMEOUT_/0 TBR: afakhry@chromium.org Bug: 1106700 Change-Id: If3f33c2c6bfeed156b422193d57ac599b746af7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303439Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/45f54928a628..cc5513855cc5 2020-07-17 cclao@google.com Vulkan: Add cache for default uniform descriptor set 2020-07-16 cclao@google.com Vulkan: add Buffer/Texture/ImageViewSerial class 2020-07-16 timvp@google.com Remove ProgramPipelineState::mHasBeenBound 2020-07-16 cclao@google.com Vulkan: Let all shader stages share one buffer for default uniform 2020-07-16 jmadill@chromium.org Perf Tests: Fix trace test calibration. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Test: Test: CQ Change-Id: I91d2d9aa6131a404fad69b36bddfe7242ca8f391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303296Reviewed-by:
-
Sigurd Schneider authored
With the browser-side issue storage in place, we don't file any issues cross-process anymore. Bug: chromium:1105790 Change-Id: I8a20dc1d2cb62fb4d280299d198071d7deb26ed0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299720Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#789437}
-
Jacobo Aragunde Pérez authored
It could happen that the dialog window is closed because the parent window was closed (e.g. Ctrl+C on Chrome running on terminal). In that case, the parent X11Window object doesn't exist any more, and calling it would cause a segfault. Bug: 1104585 Change-Id: I3aee31c5fa9e567f55e0317d9df8c675502ff990 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300094Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Nick Yamane <nickdiego@igalia.com> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#789436}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4cbb6ef49709..a74cd08cb159 2020-07-17 mathias@chromium.org Exclude generated Lighthouse locale files If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1106483 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id6aa5a0e6174ebe3e3fd186eeb91bffdd6b6eeee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304397Reviewed-by:
-
Minoru Chikamune authored
If ExecutionContext is destroyed, SpeechSynthesis should stop processing. Bug: 1058076, 1095955, 1049056 Change-Id: I8a05a376f3c0472b3833bb9d1c57f89d0e7d8e05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300905 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#789434}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 85-4181.3-1594639678-benchmark-85.0.4183.26-r1 to 86-4181.3-1594638142-benchmark-86.0.4194.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Iee3711a2816574293aad7dd4e3316c3563abe195 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304400Reviewed-by:
-
Jonathan Mengedoht authored
Bug: 1086141 Change-Id: I6681eebcc8b14c649dac7622bf9c32c3e7b2eb98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283595 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#789432}
-
Jan Wilken Dörrie authored
This change updates Chromium's copy of the affiliation_api.proto to the most recent version from the server (http://shortn/_IVIGZCTREH). Bug: 437865 Change-Id: I3634fdc0ad17679268a433ba1c88af983233b39e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302174 Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
-
David Jean authored
When the resize causes a change of UI (compact vs !compact) Bug: 1076046 Change-Id: Ied57f3ddf332c7f4b44a7cd4920cb7e0f84a381c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301971Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#789430}
-
Friedrich Horschig authored
This CL adds all UI elements that will be used to render a single compromised credential. Button and more-icon have no function yet. Origin, Username and compromising reason are bound to model. IDS_PASSWORD_CHECK_CREDENTIAL_ROW_CHANGE_BUTTON_CAPTION.png and IDS_PASSWORD_CHECK_CREDENTIAL_ROW_REASON_LEAKED.png.sha1 image: https://storage.cloud.google.com/chromium-translation-screenshots/662ab4bd4aec81ac0ef54848efad843452a0a601 IDS_PASSWORD_CHECK_CREDENTIAL_ROW_REASON_PHISHED.png image: https://storage.cloud.google.com/chromium-translation-screenshots/952ee79c665274f11d86424f83fa10ee1bfc3c13 Screenshot in the linked bug. Bug: 1106277, 1092444 Change-Id: I894286c8a238f7c0018e9cf0ba09fbff969de5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300301 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#789429}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: If4275b2f0b12d6fb66724b10f8d045c64aec5250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304362Reviewed-by:
-
Rushan Suleymanov authored
This reverts commit 8ebf771a. Reason for revert: revert didn't fix win-asan failures, it doesn't affect them and must be safe to reland. Original change's description: > Revert "[Sync] Postpone reupload of bookmarks until next updates received" > > This reverts commit 56f7b697. > > Reason for revert: win-asan failures > https://bugs.chromium.org/p/chromium/issues/detail?id=1106392 > > Original change's description: > > [Sync] Postpone reupload of bookmarks until next updates received > > > > When reupload is initiated after loading from the disk right away, it > > may lead to upload bookmarks which were removed from the other device. > > This would restore removed bookmarks. In practise it may be caused by > > some devices which a rarely used. > > > > Initiating reupload after receiving latest updates from the server helps > > to prevent such behaviour. > > > > Bug: 1061411 > > Change-Id: Ibc5646b19bf133de496140fa152b544bc06ebcf9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2299721 > > Commit-Queue: Rushan Suleymanov <rushans@google.com> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#788775} > > TBR=mastiz@chromium.org,rushans@google.com > > Change-Id: Ib00d0dfc3cd570aaf1081482cf1bd727b3dbdf8e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1061411 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302773 > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com> > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> > Cr-Commit-Position: refs/heads/master@{#789078} TBR=mastiz@chromium.org,jonahr@google.com,rushans@google.com # Not skipping CQ checks because this is a reland. Bug: 1061411 Change-Id: Id4884cd8d26c73142fb5772ee0ab617613c7a8d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302752Reviewed-by:
Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#789427}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/df50009d3ede..d9b254b474d3 2020-07-17 ssid@google.com Merge "Remove error logs for missing intern data packets" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I74f1afa12fc5d1d28fbcd91360947ae405a80aab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303952Reviewed-by:
-
Mario Sanchez Prada authored
Instead of setting this value in the browser process when an IPC message from the renderer arrives, assign the AXTreeID of a frame in the renderer process already when serializing its tree-related data in an AXTreeData struct. In order to do this, we add a new WebLocalFrame::GetAXTreeID() method that will return the AXTreeID of a local frame (as backed by its associated embedding token), that will be useful in the future to allow certain use cases to communicate directly with the renderer, without having to go through the browser process. Bug: 1094150 Change-Id: Ib2c23f811741f4328184099bb6b9027af9c7e2cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292391 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#789425}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8428d2664eb5..c648f63ca9e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mkwst@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mkwst@google.com Change-Id: I6413a81c969892e5855ddc88e2f581cf0292fd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304364Reviewed-by:
-
David Roger authored
This CL adds strings and buttons to the signin interception WebUI bubble Screenshot with this CL: https://drive.google.com/file/d/1dpWiA-o3ktL5eRaYqMt2kMd2h7IC09t_/view?usp=sharing Mock: https://drive.google.com/file/d/134DKn6B_QIX2rJ91kSWS4zpRpm3XUmy5/view?usp=sharing Bug: 1076880 Change-Id: Ib0d4d2e3768bf2cbcb92beb335de8e87cd6f8c9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279751 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#789423}
-
Sigurd Schneider authored
Change-Id: Iee09385689779f70903de9c998639f115f4b9ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302171 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#789422}
-
Carlos Caballero authored
Get rid of all references to MessageLoopCurrent(ForIO|ForUI) This is a mechanical change. Just ran the following commands mffr.py base/message_loop/message_loop_current base/task/current_thread mffr.py -f MessageLoopCurrentForUI CurrentUIThread mffr.py -f MessageLoopCurrentForIO CurrentIOThread mffr.py -f MessageLoopCurrent CurrentThread rm base/message_loop/message_loop_current.h This patch will be reviewed according to https://chromium.googlesource.com/chromium/src/+/master/docs/code_reviews.md#mechanical-changes TBR=gab@chromium.org Bug: 891670 Change-Id: If3892558ad71333f93a4698ac5411f141ccd5657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279990 Commit-Queue: Carlos Caballero <carlscab@google.com> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#789421}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b8c03e40673f..13fbc08b938e 2020-07-17 dharmesh.r.chauhan@gmail.com Explicitly set presentation style to full screen, because, If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Iacf4b7f4e444c400f4942d520db29bba39d2458e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304368Reviewed-by:
-
Makoto Shimazu authored
Bug: 1092515 Change-Id: Iafa16e996334b01a5b7048f2905a263ec3180fc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2301709 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#789419}
-
dizg authored
Added profile_creation_flow/BUILD.gn, updated profile_picker/BUILD.gn, added profile_type_choice.html and added this file to the profile_picker_resources.grd as include. R=droger@chromium.org, msalama@chromium.org, rbpotter@chromium.org Bug: 1105865 Change-Id: I778223d1f7f576502e02c7fba4d20be805537c05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300109 Commit-Queue: Diana Zagidullina <dizg@google.com> Reviewed-by:
Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#789418}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Iabcfdc536849d91574a6438f7bd7d3a6625a69f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304529Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#789417}
-
Eugene But authored
This is a follow up to: https://chromium-review.googlesource.com/c/chromium/src/+/2300834/1/ios/chrome/browser/ui/download/download_manager_coordinator_unittest.mm#708 CL updates comments which explain the reason for wrapping certain code into @autorelease block. Bug: None Change-Id: Ie31e5701f81d6f3fdd8d5347e81441732c1afa75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303033 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e8e089ad282e..450b6f4f844d 2020-07-17 cwallez@chromium.org Use MapAsync callback for server->client map callbacks. 2020-07-17 enga@chromium.org Vulkan: Fix MemoryServiceZirconHandle CreateImage 2020-07-17 enga@chromium.org D3D12: Bucket descriptor allocation by powers of two If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I4c74fe221aaa09a2b25b43e54385b16e5c3cceb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2304367Reviewed-by:
-
