GitLab

This code is inlined all over the place, however, there's no good
location to put it. Just factoring it out in two places, however,
doesn't really make sense, so don't do it

R=mkwst@chromium.org
BUG=478250

Review URL: https://codereview.chromium.org/1141993002

Cr-Commit-Position: refs/heads/master@{#330308}

If a link has target=_blank we don't navigate to it, but create a new tab,
and then navigate to it. To be able to write a layout test for the policy used to create the new tab, I need to dump it here too

BUG=454222
R=mkwst@chromium.org

Review URL: https://codereview.chromium.org/1129203005

Cr-Commit-Position: refs/heads/master@{#330307}

LayerTreeAsJson is useful during debugging of layer tree operations.
Adding the layer id into the information for the layer currently being
serialized. This helps the function be more usable as user knows which
layer he is looking when checking the json.

BUG=None

R=danakj,enne

Review URL: https://codereview.chromium.org/1140913002

Cr-Commit-Position: refs/heads/master@{#330306}

BUG=323462

Review URL: https://codereview.chromium.org/1128963004

Cr-Commit-Position: refs/heads/master@{#330305}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ae8e195..21445b8

TBR=

Review URL: https://codereview.chromium.org/1144723002

Cr-Commit-Position: refs/heads/master@{#330304}

Cr-Commit-Position: refs/heads/master@{#330303}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/573d924..ae8e195

TBR=

Review URL: https://codereview.chromium.org/1138003008

Cr-Commit-Position: refs/heads/master@{#330302}

    to receive the ack on browser/.

We perform a sanity check upon background page ACKing an event,
    by checking whether the ACKed message is expected to
    be ACKed. We store the pending ACK message IDs into a set
    |unacked_messages_|, but due to PostTask call to
    IncrementInFlightEventsOnUI, the event ack might arrive earlier
    than storing the pending message's ID. This results in incorectly
    kill the renderer process.

BUG=485440, 473821
Test=Rise Vision chrome app shouldn't crash anymore.

Review URL: https://codereview.chromium.org/1138643010

Cr-Commit-Position: refs/heads/master@{#330301}

When drmemory_full runs, the browser tests are slowed down enough to
timeout the user gesture indicator, which prevents autofill from
processing the input and passing the browser test. The fix is to disable
user gesture checking for all autofill browser tests except
AutofillRendererTest.IgnoreNonUserGestureTextFieldChanges.

TBR=thestig@chromium.org,estade@chromium.org
BUG=484910

Review URL: https://codereview.chromium.org/1143593003

Cr-Commit-Position: refs/heads/master@{#330300}

clang can't handle dllexported classes with only member initializers yet
(see crbug and http://llvm.org/PR23542). As a workaround, don't dllexport
this class.  This has the effect of emitting the class's constructor into
every translation unit that uses it instead of just every translation unit of
the media component, but in a way that seems nicer anyways since there's no
.cc file for this header and so currently this relies on some translation unit
in media including this header by lucky accident (else the constructor wouldn't
be defined anywhere.)

Once the clang bug is fixed we can consider adding this back; in the meantime
this seems like a tiny price to pay to get the bots back green.

Also add the .h file to the relevant gyp/gn files, else the analyze
step will make the trybots think that nothing changed when this
.h file is touched.

BUG=488634,467779
TBR=sandersd

Review URL: https://codereview.chromium.org/1133423003

Cr-Commit-Position: refs/heads/master@{#330299}

Cr-Commit-Position: refs/heads/master@{#330298}

This CL should facilitate conversion of cr- elements and help debugging
them in isolation.

To view elements in demo_elements.html, navigate to:
chrome://resources/cr_elements/v0_8/demo_page.html

BUG=485381

Review URL: https://codereview.chromium.org/1124073007

Cr-Commit-Position: refs/heads/master@{#330297}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/410d4d6..573d924

TBR=

Review URL: https://codereview.chromium.org/1137123003

Cr-Commit-Position: refs/heads/master@{#330296}

This time with correct copyright headers.

On Windows, clang-cl only parses template methods that are
referenced (-fdelayed-template-parsing), so members traced from
unreferenced template methods weren't seen by the plugin, which
caused it to warn about them.

Explicitly parse delayed template methods that look like they
are trace methods and that aren't in system headers to work around
this. This is based on Kim Grasman's patch for the IWYU project:
https://code.google.com/p/include-what-you-use/source/detail?r=566

Together with clang r237531 (
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20150511/129285.html )
this should fix all failing oilpan plugin tests on Windows.

BUG=486571
TBR=hans

Review URL: https://codereview.chromium.org/1135333007

Cr-Commit-Position: refs/heads/master@{#330295}

Revert of Add support for backgrounding processes on the Mac (patchset #21 id:400001 of https://codereview.chromium.org/989703002/)

Reason for revert:
Speculative; several browser_tests started failing on the Mac 10.9 bots, and this looks like the most likely culprit:

http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests/builds/1929
http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/6014

Original issue's description:
> Add support for backgrounding processes on the Mac
>
> Added process_mac.cc with implementations of IsProcessBackgrounded() and
> SetProcessBackgrounded().
>
> BUG=460102

TBR=rsesek@chromium.org,gab@chromium.org,asvitkine@chromium.org,avi@chromium.org,kbr@chromium.org,shrike@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=460102

Review URL: https://codereview.chromium.org/1128183011

Cr-Commit-Position: refs/heads/master@{#330294}

BUG=

Review URL: https://codereview.chromium.org/1113203002

Cr-Commit-Position: refs/heads/master@{#330293}

BUG=332112

Review URL: https://codereview.chromium.org/1124553002

Cr-Commit-Position: refs/heads/master@{#330292}

Review URL: https://codereview.chromium.org/1133283004

Cr-Commit-Position: refs/heads/master@{#330291}

Once the DNS test conversion CL lands, I'll be able to remove DelayedSocketData.

Review URL: https://codereview.chromium.org/1117863003

Cr-Commit-Position: refs/heads/master@{#330290}

This reverts commit 28c1b109.

The delayed_parsing.cpp file has no license which is causing license check
failures.

TBR=hans@chromium.org,thakis@chromium.org,rnk@chromium.org
BUG=486571

Review URL: https://codereview.chromium.org/1146563002

Cr-Commit-Position: refs/heads/master@{#330289}

to use SequencedSocketData.  Reduces runtime to 7 seconds from 11 seconds on my linux workstation

BUG=332112

Committed: https://crrev.com/d7b1887392866667126162a4e7854a2736449970
Cr-Commit-Position: refs/heads/master@{#328221}

Review URL: https://codereview.chromium.org/1124533002

Cr-Commit-Position: refs/heads/master@{#330288}

Reduces runtime to 11 seconds from 59 seconds on my linux workstation.
There are still a number of tests which have not been unconverted because they make use of "CompleteRead" semantics which I still need to implement in SequencedSocketData.

BUG=332112

Committed: https://crrev.com/73e1742f4729161d16f70cbdad9d4c1c1836be52
Cr-Commit-Position: refs/heads/master@{#328171}

Review URL: https://codereview.chromium.org/1114213005

Cr-Commit-Position: refs/heads/master@{#330287}

BUG=483693

Review URL: https://codereview.chromium.org/1132913004

Cr-Commit-Position: refs/heads/master@{#330286}

Since all volumes can be now configurable, make the method generic, instead of
limiting to FSP API only.

NOPRESUBMIT=true
TEST=Tested manually on configurable and non-configurable volumes.
BUG=474146

Review URL: https://codereview.chromium.org/1142593002

Cr-Commit-Position: refs/heads/master@{#330285}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1ccc7b3..410d4d6

TBR=timvolodine@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1140653005

Cr-Commit-Position: refs/heads/master@{#330284}

Cr-Commit-Position: refs/heads/master@{#330283}

This CL depends on Blink change https://chromiumcodereview.appspot.com/1128933011

BUG=487782

Review URL: https://codereview.chromium.org/1126203011

Cr-Commit-Position: refs/heads/master@{#330282}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/49f55fa..1ccc7b3

TBR=timvolodine@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1133283007

Cr-Commit-Position: refs/heads/master@{#330281}

This function was used only in application_lifetime.cc.
Since http://crrev.com/307026, this function has been unused.

BUG=None

Review URL: https://codereview.chromium.org/1138863003

Cr-Commit-Position: refs/heads/master@{#330280}

This means we can remove the direct intercept, which
is currently causing lua5.2 tests to fail on the
naclports tree.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_nacl_sdk;tryserver.chromium.mac:mac_nacl_sdk;tryserver.chromium.win:win_nacl_sdk

Review URL: https://codereview.chromium.org/1127103006

Cr-Commit-Position: refs/heads/master@{#330279}

Increase the data rate and the commit rate.

BUG=480228

Review URL: https://codereview.chromium.org/1136123006

Cr-Commit-Position: refs/heads/master@{#330278}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/f1045f3..49f55fa

TBR=timvolodine@chromium.org,kbr@chromium.org

Review URL: https://codereview.chromium.org/1135793004

Cr-Commit-Position: refs/heads/master@{#330277}

Add the histogram Ash.AppList.TimeBetweenTaskSwitches
to record the time between selecting items from
the app list (launcher) in Ash.

BUG=478933
TEST=TaskSwitchMetricsRecorderTest.VerifyTaskSwitchesFromAppListAreRecorded

Review URL: https://codereview.chromium.org/1145453003

Cr-Commit-Position: refs/heads/master@{#330276}

Added process_mac.cc with implementations of IsProcessBackgrounded() and
SetProcessBackgrounded().

BUG=460102

Review URL: https://codereview.chromium.org/989703002

Cr-Commit-Position: refs/heads/master@{#330275}

This CL migrates the backend of ServiceWorkerDiskCache from Default to
SimpleCache on all platforms.

If old DiskCache images exist,
(1) DiskCache backend fails to open an pre-existing data due to incompatible
format (in both Default->SimpleCache and SimpleCache->Default cases),
(2) ServiceWorkerStorage wipes out all cached scripts and registrations via
DeleteAndStartOver, and
(3) navigation falls back to network.

BUG=487482
TEST=manual (use DiskCache and SimpleCache alternately and make sure the system can recover)

Review URL: https://codereview.chromium.org/1140853002

Cr-Commit-Position: refs/heads/master@{#330274}

Also, we don't need field trial for dev and canary.

BUG=477084
TEST=new tests

Review URL: https://codereview.chromium.org/1139633005

Cr-Commit-Position: refs/heads/master@{#330273}

Revert of Disable user gesture checking for all autofill browser tests. (patchset #2 id:20001 of https://codereview.chromium.org/1125173006/)

Reason for revert:
This CL broke Linux GN Clobber bot.

Original issue's description:
> Disable user gesture checking for all autofill browser tests.
>
> When drmemory_full runs, the browser tests are slowed down enough to
> timeout the user gesture indicator, which prevents autofill from
> processing the input and passing the browser test. The fix is to disable
> user gesture checking for all autofill browser tests except
> AutofillRendererTest.IgnoreNonUserGestureTextFieldChanges.
>
> BUG=484910

TBR=estade@chromium.org,thestig@chromium.org,rouslan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=484910

Review URL: https://codereview.chromium.org/1140013004

Cr-Commit-Position: refs/heads/master@{#330272}

Cr-Commit-Position: refs/heads/master@{#330271}

BUG=488739
TBR=derat@chromium.org

Review URL: https://codereview.chromium.org/1137393004

Cr-Commit-Position: refs/heads/master@{#330270}

Revert of Create net::FormatOriginForDisplay helper function. (patchset #8 id:140001 of https://codereview.chromium.org/1133943002/)

Reason for revert:
This CL needs more work, and potentially to be moved to a new module.

Original issue's description:
> Create net::FormatOriginForDisplay helper function.
>
> net::FormatOriginForDisplay provides a canonical, concise, human-friendly
> display for origins. It supports callers in any higher-layer module.
>
> Based heavily on earlier work by dewittj and felt. Thanks!
>
> BUG=402698
> TBR=thakis,brettw

TBR=asanka@chromium.org,dewittj@chromium.org,felt@chromium.org,rsleevi@chromium.org,thakis@chromium.org,brettw@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=402698

Review URL: https://codereview.chromium.org/1131813004

Cr-Commit-Position: refs/heads/master@{#330269}