- 02 Nov, 2020 40 commits
-
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b0e426fcf955..eaf1c53544a7 2020-11-02 sugoi@google.com Merge changes If776b87d,I27098964 2020-11-02 capn@google.com Consistently remove double colon from llvm namespace 2020-11-02 capn@google.com Emulate gather/scatter for MSan builds 2020-11-02 capn@google.com Prevent 'most vexing parse' issue If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I17d6d9b14f99d8d2ab717b811d90db4e6f6c75f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514510Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823313}
-
Daniel Libby authored
When a native click accessibility operation is performed on an option element that is part of a select popup, we mark the option as selected, then do a native click on the parent select to dismiss it. This sequence of operations ends up not firing `input` and `change` events, which normally happens as part of the popup being dismissed by the click in the normal case. However, the AccessKeyAction for option takes care of this, so we perform that operation instead of directly setting the option as selected. Bug: 1143990 Change-Id: Ied6023b4b2aee759575eebf75a32b7f2720f3068 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508884Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Victor Fei <vicfei@microsoft.com> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#823312}
-
Moe Ahmadi authored
crrev.com/c/2505739 makes the promos hidden by default until it is decided whether the promo can be shown or not. Promos now remain hidden until the promo loaded event or a window resize event is fired where visibility of the promo is recalculated externally based on whether or not it overlaps with the most-visited tiles. This change coordinates these two steps by firing the promo loaded event after the promo's visibility is determined internally. It also uses a consistent mechanism for controlling the promo's visibility internally and externally, i.e., 'hidden' attr aka 'display: none;' Fixed: 1144624, 1143366 Change-Id: I3b2d2d86e56e0baba3f8042077a07aa0b6ce20a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514667Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#823311}
-
Corentin Wallez authored
Bug: dawn:455 Change-Id: Iaa5e5baf06de4e255b29f3c1a23a103ae8e00320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493380 Commit-Queue: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#823310}
-
Ted Meyer authored
R=liberato Change-Id: I1dea9e0b00675145a57d29318d0fa1e6c3cb6347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510916Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Reviewed-by:
Ted Meyer <tmathmeyer@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#823309}
-
dpapad authored
Specifically: - Update remaining usages of js/util.js to explicitly pull-in js/assert.js. - Update webui_resources.grd to not use flattenhtml=true for JS files. - Remove "// <include src=..." directives from affected files This is in preparation of moving such files over to the auto-generated webui_generated_resources.grd, which (purposefully) no longer supports flattenhtml. Bug: 1132403 Change-Id: Idb9e4df54348c3eac3cbe7152893e3d5c5bd82a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503833 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#823308}
-
Matt Menke authored
In particular, migrate SocketsUdpApiTest.SocketsUdpExtension and SocketApiTest.SocketUDPExtension. This CL introduces a new C++ TestUdpEchoServer class, which echoes back the data it receives over an ephemeral UDP socket, and makes those two tests use it. They had been the only consumers of the SpawnedTestServer's UDP_ECHO mode, so once this lands, that mode can be removed from the test server. The reason for migrating tests off of SpawnedTestServer is that it has been a source of flaky failures and timeouts for years, so everything that can use an in-process C++ server should be doing so. Bug: 492672 Change-Id: Iec532fc94ee9c33c612fca3d9392388b594707e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513787Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#823307}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/584ab491091a..888c272811ad 2020-11-02 dproy@chromium.org Fix some tracing UI tests under the polyfill If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1111537 Tbr: sadrul@google.com Change-Id: I6dd0c3cb0c5cd9b10dffd43926fa194e00b82749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514506 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Torne (Richard Coles) authored
The retry behaviour of the WebView data directory lock is now well-understood and we're not going to change the code any further; remove the retry count metric. Also remove the metric logging when init has already been started previously - this has shown that a very small number of apps are actually hitting this case and only in a very tiny percentage of cases. Just remove the metric and don't introduce any new check for this condition; these apps will either work or not and it's not worth us worrying about it. Fixed: 1142488 Change-Id: I90b85e999ca74ebecdc66c2ac7e11aa4b0bf1d2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498110 Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#823305}
-
Matt Menke authored
In particular, migrate SocketsTcpApiTest.SocketTcpExtension, SocketsTcpApiTest.SocketTcpExtensionTLS, and SocketApiTest.SocketTCPExtension. The second test was using SpawnedTestServer in HTTPS mode, which could be directly replaced with EmbeddedTestServer in HTTPS mode. The other two uses the SpawnedTestServer in TCP echo mode. Rather than write a TCP echo server in C++, this CL switches them over to use the EmbeddedTestServer in HTTP mode, matching the TLS socket API test. The reason for migrating tests off of SpawnedTestServer is that it has been a source of flaky failures and timeouts for years, so everything that can use the EmbeddedTestServer or other in-process C++ servers should be doing so. Bug: 492672 Change-Id: I655a77abc5a552f6a4edc5edfe3302abdf67fd7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513568Reviewed-by:
-
Asanka Herath authored
We are using the word "sample" in too many ways. Try to move to less ambiguous terminology. Bug: 973801 Change-Id: I4d1feeeef22e756e82952e4b53a2a6615dac8715 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510240 Auto-Submit: Asanka Herath <asanka@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Reviewed-by:
Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#823303}
-
Tommy Li authored
This CL adds a IsBetterThanEngineWithConflictingKeyword method to TemplateURL in an attempt to introduce a total ordering where we can decide consistently across clients whether a given TemplateURL is better than another one with a conflicting keyword. There's already something very similar called: TemplateURLService::BestEngineForKeyword(), which this CL replaces. There's also TemplateURLService::IsLocalTemplateURLBetter() which this CL leaves alone, but I hope to replace that with this new method too as a followup. My goal is that if every client can agree on which conflicting TemplateURL is better than another, then we can resolve sync conflicts in a consistent way. One major caveat: Because the sync GUIDs are not globally unique, it's possible to have a true tie, so there's no total ordering yet. I hope to fix this once I can make the sync GUIDs globally unique. Moreover, IsLocalTemplateURLBetter() privileges the default search provider, which we probably have to keep doing. That would also be an obstacle to this idea. Bug: 1022775 Change-Id: I9249222cb10d2c34c3bc0a90da37fe88c52a6218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511256 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#823302}
-
Greg Thompson authored
This CL adds and uses DeleteWithRetry, which will work extremely hard to delete a files or an empty directory. mini_installer.exe extracts a number of files into a working directory of its creation and deletes these files and directory after running setup.exe. This deletion is known to fail from time to time (e.g., when racing against termination of setup.exe's crashpad handler or against A/V scanners). DeleteWithRetry should eliminate this class of failures (except where the other entity takes more than ten seconds to relinquish control over a file). This CL also retires the temp dir fallback metric that had been reported via ExtraCode1 and replaces it with a new metric that reports the max number of retries required to delete any single item. We hope that this is far lower than 100 (the max). BUG=516207,1138157 Change-Id: I96d8cda32058987201d0cef36ec0a6d6976e9069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503951 Commit-Queue: Greg Thompson <grt@chromium.org> Reviewed-by:
James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#823301}
-
Reilly Grant authored
This change adds a check before creating a new chooser dialog that the web contents it is being displayed over is the currently active one. Bug: 1143057 Change-Id: I3a4e6fdb1745f2994e0e998fc2346d7485d118c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505746 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#823300}
-
Jamie Walch authored
Change-Id: I6580d6544444c9c78deb280d2d7c35094c16a07a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511856 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@google.com> Cr-Commit-Position: refs/heads/master@{#823299}
-
Bo Majewski authored
Removes DISALLOW_COPY_AND_ASSIGN and replaces it with explicit deletions. Bug: 1113981 Change-Id: I8deba3663a6ded97bf13c3398c199a8623a13bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513808 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#823298}
-
Angus L. M. McLean IV authored
This prevents the slider views from awkwardly overlapping with the shelf. Bug: 1136564 Change-Id: I83551c6c5c2efb244d245a1055238ba6841d96c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499641 Commit-Queue: Angus McLean <angusmclean@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#823297}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1604318145-b605b3c459c88318c18e2e9d5bcf292a903238e1.profdata to chrome-linux-master-1604339911-22c5796f1ee7929b52f85640391db819ccf5f295.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie0c5af72b0cff2d0976d2712b5b6f9ce7288b411 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514839Reviewed-by:
-
Mirko Bonadei authored
After https://chromium-review.googlesource.com/c/chromium/src/+/2510772, the toolchain "android_clang_arm" defines "arm_float_abi" but in case this is not the default toolchain (e.g. current_cpu != "arm"), "arm_float_abi" is not declared. This CL makes sure that is always declared. Bug: 1144188 Change-Id: Ic8b3791f9db037549b25ab3f13f3aa27518c4c0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512899Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Geoff Lang <geofflang@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#823295}
-
Jesse Schettler authored
The default scan-to path is the active user's My files folder. Remove the TODO that states the check for this path should be removed and combine the various checks into a single if statement. Bug: 1059779 Change-Id: I1ad09b67e5fd7d80a6fe711bec22673a43d3eb43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510860Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#823294}
-
Jan Wilken Dörrie authored
This change modifies base::flat_tree, base::flat_set and base::flat_map to make the underlying container type configurable. This is consistent with the standardization proposal. The default container continues to be a std::vector. Bug: 682254 Change-Id: Ic430e97fa981f21b3f8b20a9e83c153340ea258b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510249Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#823293}
-
Victor Hugo Vianna Silva authored
This CL takes care of a quick clean-up TODO for the linked bug, and no behavior is changed. registerForEvents() and requestUpdatedAboutInfo() are two private APIs used by the chrome://sync-internals debugging page and always called together, so they are now merged into a single API. Fixed: 1138535 Change-Id: I712959f49bcb89820f369ba5d41c4e50e2203735 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514421 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#823292}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d5f49275a2e..552f47beb892 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rogerm@google.com,tommycli@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1142775,chromium:1143787,chromium:1144711,chromium:897470 Tbr: rogerm@google.com,tommycli@google.com Change-Id: Ibff7044290276fd21b26fdbe13128be87436e358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514701Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823291}
-
Sophie Chang authored
Bug: 1144811,1144812 Change-Id: I3b28456a40e9d553cff5c0ad85532a520fa1d2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512523Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Reviewed-by:
-
Etienne Pierre-doray authored
This includes: -Setup.Install.PeakPagefileUsage -Setup.Install.PeakWorkingSetSize -Setup.Install.CumulativeDiskUsage2 Bug: 1053133, 1104997 Change-Id: I9ed442897b9753ed32dc45dcf63194067dff6e46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225263 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#823289}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1604318145-3b01fb5e7b79197c4a7ae82826a66d6b8766a4ea.profdata to chrome-mac-master-1604339911-496ad7cd0b2f151b52bf1dbd6e77aab393c02169.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I03c58c0213727e3de4df20403826ed3b7a45bd84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514707Reviewed-by:
-
Chris Sharp authored
Bug: 1018157 Change-Id: I6a8579a21df1f06fac2ac37edc37a0eba8213e20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503148 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#823287}
-
Robert Kaplow authored
Bug: 1089551 Change-Id: If3701dd617bc8eab76e8e575b31de6ed0566b7da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511129Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#823286}
-
Yashar Dabiran authored
this new metric records the minimum recorded value of Startup.Android.Cold.TimeToFirstContentfulPaint and Browser.PaintPreview.TabbedPlayer.TimeToFirstBitmap. It represents the time it takes for a user to see content. Bug: 1142922 Change-Id: Ic0f6571e3699d042a1a57bfcf9f9f54cba4cdc06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500323Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Yashar Dabiran <yashard@chromium.org> Cr-Commit-Position: refs/heads/master@{#823285}
-
Michael Hansen authored
The original change was reverted because one of the sha files was actually a png file. This fix changes the contents of that file to an actual sha. Revert is here: https://chromium-review.googlesource.com/c/chromium/src/+/2514420 Original change is here: https://chromium-review.googlesource.com/c/chromium/src/+/2511852 Original change's description: > Removes the "Contacts" title and updates strings in the description > for each visibility mode to match the latest specs. > > Screenshots: > https://screenshot.googleplex.com/An6Ta8EDzfS3KZU.png > https://screenshot.googleplex.com/C5WwqifMeCnLhkH.png > https://screenshot.googleplex.com/C48HQVfgouJrhHF.png > > Strings spec: > https://docs.google.com/document/d/1s-KjC1mM4ZPYeYAO7oI8lXltS_1FaYYfMMnNDdbfRag Bug: b:168841167 Change-Id: I487d7d4614e6cfa8971fab3c7e5ee39c552ab4cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514178Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#823284}
-
Daniel Rubery authored
The experiment is running on Windows, but the field trial testing config was landed when there were too many configs on Windows. The temporary workaround was to leave Windows out of the platforms. We can now undo that temporary workaround. Change-Id: Ifee05f28112cc8af9c87cc18816b10450f9fae44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512519Reviewed-by:
-
Francois Doray authored
We did not receive crash reports, so we are confident that the assertion is correct. We can convert it to a DCHECK to avoid the overhead in production. Fixed: 1078387 Change-Id: I5a14f215718cc1d9b12cd04f0e071094a575afe7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510776 Auto-Submit: François Doray <fdoray@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#823282}
-
Eric Orth authored
*Allow empty alias names (indicates that a service does not exist). *Add the "mandatory" service param. Also added an IsCompatible() method to indicate if any listed keys are not handled by the parser. Normally I would consider that level of handling to be higher level than the wire-format stuff the parser should deal with, but the parser is the code that knows what params it can handle. *Also added some extra IP hint validation in the fuzzer while I was poking at it for the other changes. Bug: 1138620 Change-Id: I8172fb5cc9b6ba06d42e6f68c2d11517115f80e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508429Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#823281}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5d35d2afddac..11789f5ed0cf 2020-11-02 me@heardanieljames.com Adjust tabindex of network summary links to 0 2020-11-02 aerotwist@chromium.org TypeScriptify CSSShadowEditor.js 2020-11-02 tvanderlippe@chromium.org Typecheck object_ui/CustomPreviewComponent.js with TypeScript 2020-11-02 bmeurer@chromium.org [formatter] Utilize available CPU cores. 2020-11-02 alexrudenko@chromium.org Enable TypeScript for ProfileSidebarTreeElement.js 2020-11-02 alexrudenko@chromium.org Add align-items icons to the styles panel 2020-11-02 aerotwist@chromium.org TypeScriptify IndexedDBViews.js 2020-11-02 tvanderlippe@chromium.org Typecheck lighthouse/LighthouseProtocolService.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1139945 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic451cc886da11b0c9299f100e4eefc77a3e5b88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514700Reviewed-by:
-
dpapad authored
Previously scrollbars always appeared light, even if a WebUI page was otherwise respecting dark mode. The upcoming FormControlsDarkMode feature allows webpages to specify whether scrollbars should follow the system's theme, by specifying a new <meta name="color-scheme"> tag. Launch Chrome with the following flags to experience dark scrollbars. --enable-features=WebUIDarkMode,CSSColorSchemeUARendering \ --force-dark-mode Bug: 1142291 Change-Id: Iaaea8427a88bdf7cb53559e5fed35d8d59df5ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513686Reviewed-by:
-
chrome://site-engagementKen Rockot authored
Bug: 1004256 Change-Id: Icf4818cd885e77549f50f01e3553c81034348381 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506520 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#823278}
-
Jan Wilken Dörrie authored
This change allows the construction of a dictionary value from flat_map<string, Value>, while keeping unique_ptr<Value> as the mapped type of the underlying storage. This is in line of reducing heap allocations for Value, and simplifies its usage. It is still planned to eventually remove unique_ptr<Value> from the underlying storage as well. Bug: 646113 Change-Id: I3ebe11f11faef77e19a4610aba84c541e5f5b3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505980Reviewed-by:
Christoph Schwering <schwering@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
-
Stephen Sigwart authored
Bug: 1143104 Change-Id: I3a01e6a37b62fdf61f4393edbdf4521aec9fa238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511709Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Stephen Sigwart <ssigwart@gmail.com> Cr-Commit-Position: refs/heads/master@{#823276}
-
chromium-autoroll authored
Roll ChromeOS Atom AFDO profile from 88-4296.0-1603709458-benchmark-88.0.4307.0-r1 to 88-4305.0-1604314829-benchmark-88.0.4312.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-atom-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I06a9cfcb1fa781178d15770a26c9ac2fe1a42782 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514704Reviewed-by:
-
Fredrik Söderqvist authored
Introduce the SVGListablePropertyBase subclass and move the |owner_list_| member field to it. This facilitates slightly better type-safety for 'listable' property types. Since the most commonly occurring types (SVGLength for example) are also 'listable' this does not constitute any major memory savings, but it will trim off a few bytes (the size of a pointer) here and there. Bug: 1106762 Change-Id: Ia91ba222de07ed22bbde4b1550b565b591ed0041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514151 Auto-Submit: Fredrik Söderquist <fs@opera.com> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#823274}
-
