- 14 Jun, 2019 40 commits
-
-
Christopher Cameron authored
Because PWAs (and anything using RemoteCocoa) need an app shim to be running to get anything on-screen, we added code to re-create an app shim if one cannot be launched. But this re-creation wasn't guarded on being a PWA, and as a consequence platform apps would go and create app shims that nobody expected to exist. So let's not do that. Some tests were inappropriately relying on this behavior. Update WebAppShortcutCreator to be more explicit about where it creates and updates its shortcuts. Also, re-enable tests in component build (that was fixed a while ago in crrev.com/619648). Bug: 941160 Change-Id: I5fb233f346095116d28ddbbfa9e23aca1bb1eab3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657522Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#669111}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/1e83e141f541..17937cb2333c git log 1e83e141f541..17937cb2333c --date=short --no-merges --format='%ad %ae %s' 2019-06-14 jflat@chromium.org chromeos_config: Make samus-kernelnext paladin important Created with: gclient setdep -r src/third_party/chromite@17937cb2333c The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Id886a70d413206317c43fccbac734b3c340ac314 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659536Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669110}
-
Kenneth Russell authored
These were primarily intended to be run as pixel tests. The trace_test suite seems more stressful and we don't have the resources to investigate the context loss issues here. Bug: 974077 Change-Id: Ia6bb6a028e73459bae1ac8cd8de2188235b84a28 Tbr: ynovikov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659605Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#669109}
-
kyle Ju authored
- Remove the tweak from bug 881513, a revert of https://crrev.com/c/1450396 - Enable the import of external/wpt/webdriver Bug: 881513 Change-Id: I9c03081d52576b2057d18bd8a3efd2b11a41033f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615704 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#669108}
-
Jeremy Klein authored
In BleCharacteristicFinder, we currently override onGatt*Added BluetoothAdapter::Observer functions which are all deprecated. When we get all the characteristics we're looking for, we call back immediately. Instead, this CL just waits for GattServicesDiscovered before parsing the services and characteristics. This does not affect latency at all because GATT service discovery is done in batch anyway in BlueZ before all of the callbacks are just triggered in series. This is much simpler and will also allow for an easy discovery process when fixing work profiles (see go/beto-work-profiles). Bug: b/67412244 Change-Id: I22d3baf485b386ee5ba6a41e2b254a5f9919b01d Tested: Heavily manually tested and also added unit tests. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658432 Commit-Queue: Jeremy Klein <jlklein@chromium.org> Auto-Submit: Jeremy Klein <jlklein@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#669107}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f457ae77aa76..839329243a13 Created with: gclient setdep -r src-internal@839329243a13 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mmentovai@google.com,aboxhall@google.com,mstensho@google.com,oksamyt@google.com Change-Id: I4c831511ea21e6691da27976be2adf811bd88ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659537Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669106}
-
Takuto Ikuta authored
Bug: 973731, 855319 Change-Id: I759663fd82492c6dc17cb63c03557bc729d71102 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657384 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Reviewed-by:
Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#669105}
-
Julian Watson authored
Bug: 932339 Change-Id: Ib835835ac8e58262091232be7ba285c2901f3746 Cq-Depend: chromium:1630343,chromium:1630135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631157 Commit-Queue: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#669104}
-
Yuly Novikov authored
Bug: 898684 Change-Id: I05ae0f474c5b9978932bd2bc98033075b12bd5ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1656672Reviewed-by:
-
Christopher Lam authored
This CL changes ExternallyInstalledWebAppPrefs::GetInstalledAppUrls to BuildAppIdsMap which does not check for installation, to fix a dependency cycle when querying for apps in the constructor of WebAppProvider. This also represents a step towards refactoring the WebApp test environment. Bug: 973324 Change-Id: Ia0ad9f29fe6694a548acd716885a7d538d376332 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654676 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#669102}
-
Giovanni Ortuño Urquidi authored
The test was getting the profile from a recently closed app browser. Change the test to retrieve the profile from the harness. Bug: 972930 Change-Id: I3eb0f907ed53b3e7dc31fd9c1932c52dbfe75545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659551 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jay Harris <harrisjay@google.com> Auto-Submit: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Jay Harris <harrisjay@google.com> Cr-Commit-Position: refs/heads/master@{#669101}
-
Findit authored
This reverts commit 6e65ba90. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 669034 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNmU2NWJhOTA3ZjUyMGNlZmU5YjYyMDg3MWNmZmIyZTc1N2NhNmQ2Nww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.linux/Linux%20Tests%20%28dbg%29%281%29%2832%29/59319 Sample Failed Step: content_browsertests Sample Flaky Test: AccessibilityIpcErrorBrowserTest.DISABLE_ResetBrowserAccessibilityManager Original change's description: > Disable flaky test AccessibilityIpcErrorBrowserTest.ResetBrowserAccessibilityManager > > TBR=kschmi@microsoft.com > > Bug: 973946 > > Change-Id: I69b54fdfe9421acacaf98c2bcf684680e7cb66fd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659029 > Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> > Reviewed-by: Kurt Catti-Schmidt <kschmi@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#669034} Change-Id: Ic5a44c3d23a11cd0f209a6143067d51e803a617a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 973946 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660008 Cr-Commit-Position: refs/heads/master@{#669100}
-
Sammie Quon authored
One is the screenshot was showing weird on actual device. The other is the screenshot is not deleted when using SetBoundsDirect. That was because it was not animating, but still managed by TabletModeWindowManager. The screenshot should have been deleted if it is either not animating or not tracked, not require both, which this CL fixes. Test: manual Bug: 948706 Change-Id: I87add8592a8f1e6bbec55dbe44e93eb52844c5a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659020 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#669099}
-
Alexei Filippov authored
This is a quickfix for a crash when a heap profile is being reported over UMA on Android. BUG=973430 Change-Id: I07cf28ef18809ab82c1a447f686871f6bedb71fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659025 Commit-Queue: Alexei Filippov <alph@chromium.org> Auto-Submit: Alexei Filippov <alph@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#669098}
-
Regan Hsu authored
Change-Id: Ie778b542676ff6d2f4850d422d1984a72905dcb2 Bug: 860438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659356 Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#669097}
-
Kent Tamura authored
It kicks eslint for *.mjs via tools/web_dev_style/js_checker.js. Change-Id: I669639d438205b03b5bd04de0ccd6d9e6169604a Bug: 972476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654732 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#669096}
-
Reilly Grant authored
The set_paused() and set_connection_error_handler() methods on extensions::SerialConnection are not trivial and are renamed to SetPaused() and SetConnectionErrorHandler(). Bug: 893334 Change-Id: I10cc92a5f61c9907ccbf5e6975a7028f9a9b688e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658682 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#669095}
-
Jérôme Lebel authored
Google services settings should be able to be opened from the incognito mode. Bug: 967674 Change-Id: I9008c0159b7729c17a7fc703c5a61171d2dd85e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640555Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#669094}
-
Yuwei Huang authored
This CL removes signature and sequence ID from the heartbeat request since they are no longer required by the server. It also rewrites HeartbeatSenderTest to mock the HeartbeatClient directly instead of creating in process channel and mocking the server, so that the tests can be more deterministic. Bug: 971363 Change-Id: I3b9be0819172d06da657536c56744532df39a75e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653602 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#669093}
-
Alan Cutter authored
This CL is a simple code move taking FindAppIdForUrl out of WebAppTabHelperBase and putting it in web_app::AppRegistrar for easier reuse of the functionality. There are no behavioural changes in this CL. Bug: 956810 Change-Id: I74858b74421763aa1e7050a5d0672321b8019718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638212 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Ben Kelly authored
ServiceWorker subresource fallback currently has a work-around for CORS requests. Because CORS has been implemented in blink in the past the code had to message back into blink in order correctly perform CORS on the fallback request. This create performance problems. This CL skips this fallback workaround if the out-of-renderer CORS (OOR-CORS) feature is enabled. Bug: 973633 Change-Id: If8a3510291639fda359fd425c2e08173f2a87cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658868 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#669091}
-
Steve Anton authored
Previously, the most direct route was through WebString. Bug: 950077 Change-Id: I7a825bee18849c069870cdb2122fd34c012269a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658954Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#669090}
-
Alberto Herrera authored
When battery_percentage field in device::BluetoothDevice is populated, display such value in Ash Tray and Bluetooth Settings UI. Bug: 785758 Change-Id: I51434b1aba5a409a81d94c17b4c072d637648a15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1648750 Commit-Queue: Alberto Herrera <ahrfgb@google.com> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#669089}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9cea40ce..5db6ccdb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idff8bd5683f467104e6476c26c78052e5d587ef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658642Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669088}
-
Anastasia Helfinstein authored
TBR=katie@chromium.org Change-Id: I5b3a16ce61173c66d251fa356bb95524e25827d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659675Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#669087}
-
Daniel Libby authored
The original change to enable scrollbar latency for the composited scrollbars incorrectly used an existing member to try and determine whether a GestureScrollUpdate was the first one in an injected sequence or not. is_first_gesture_scroll_update_ was incorrect because it is only updated when input is actually dispatched to InputHandlerProxy, and the flag is cleared for all GSUs before the location where it was being read. This bug was missed because of incorrect tests. The VerifyRecordedSamplesForHistogram method doesn't actually assert or expect anything - the return value must be inspected. As part of fixing up the tests, I made a few other changes to get them passing consistently across all platforms: - turn on main thread scrollbar injection feature (in case it's ever turned off we don't want the tests to start failing) - enable mock scrollbars - disable smooth scrolling - don't run scrollbar tests on Android The composited scrollbar button test is disabled due to a bug in how the mock theme reports its button sizes, which throws off the region detection in ScrollbarLayerImplBase::IdentifyScrollbarPart (filed crbug.com/974063 for this issue). Change-Id: Ie1a762a5f6ecc264d22f0256db68f141fc76b950 Bug: 954007 Change-Id: Ib258e08e083e79da90ba2e4e4216e4879cf00cf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1652741 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#669086}
-
Takuto Ikuta authored
This allows to use VMs with SSD in builderless pool only for builders we want to use ssd. Bug: 956776 Change-Id: I19e4612c3485c75243ec7291d94c490bf24b13b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654757Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
smut <smut@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#669085}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/88596beab317..853ebacf99a4 git log 88596beab317..853ebacf99a4 --date=short --no-merges --format='%ad %ae %s' 2019-06-14 ynovikov@chromium.org Suppress Mac 10.13.6 Intel OpenGL dEQP failures 2019-06-13 dongja@google.com Vulkan: implement primitive restart 2019-06-13 syoussefi@chromium.org Vulkan: Output render pass loadOp in graph dump Created with: gclient setdep -r src/third_party/angle@853ebacf99a4 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@google.com Change-Id: Iebac2a1a174e5422458d0c06460c6722de8a34c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658647Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c8c1ab9dcdb1..f457ae77aa76 Created with: gclient setdep -r src-internal@f457ae77aa76 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=mmentovai@google.com,aboxhall@google.com,mstensho@google.com,oksamyt@google.com Change-Id: I7ef49fc5f4f4f52dafdbafe35b9ffb1196339783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658646Reviewed-by:
-
Chris Harrelson authored
This removes also one of the four callsites of FindHostChildBySlotName, which is a slow method. Bug: 971930 Change-Id: I48cc5c29786277b320cdb17094bab5ada8402e4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653350Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#669082}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 038a01f1. With Chromium commits locally applied on WPT: 9e3affdd "Ship `referer` header length limitation." 723f9a78 "Prevent leaking Sec-CH-/Sec-Fetch- Request Headers on HTTPS Downgrade Redirects." 8bbed8ff "Reland tests from "Change ICE connection state on transceiver changes"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: eae@chromium.org, szager@chromium.org: external/wpt/intersection-observer foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools guidou@chromium.org, armax@chromium.org: external/wpt/mediacapture-streams NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Iaf8eac655a69d8d48bc3a4a6cbd92bc5a154fb5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659632Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669081}
-
Xida Chen authored
Right now the CSSPaintAPIArguments is not enabled by default yet. When it is disabled, the |parsed_input_arguments_| in the CSSPaintValue will be nullptr, and BuildInputArgumentValues should not happen. Bug: 946519 Change-Id: I9f58d7565bfe715bbe6f760a55c830b6c9d064b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653414Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#669080}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/38c7d9e30add..1e83e141f541 git log 38c7d9e30add..1e83e141f541 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 saklein@chromium.org ExtractBuildDepsGraph: Don't enter chroot manually. 2019-06-13 saklein@chromium.org PrepareBinhostUploads: Finish updating package index before deduplication Created with: gclient setdep -r src/third_party/chromite@1e83e141f541 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: Iacadf5fdc60b48dc42761c78a853f08d4afc7571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659640Reviewed-by:
-
Caleb Raitto authored
LSAN doesn't currently support Windows [1]. This fixes win-asan trybot breakage caused by https://crrev.com/c/1590404. [1] https://github.com/google/sanitizers/wiki/AddressSanitizerWindowsPort#lsan Cq-Include-Trybots: luci.chromium.try:win-asan Change-Id: I62e5ee13bb0d83a414e4a0456e9ffa27129ae28d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658436 Commit-Queue: Caleb Raitto <caraitto@chromium.org> Reviewed-by:
-
Mandy Chen authored
Change string concatenation to be a complete string: "1 x 1 pixels (intrinsic: 1 x 1 pixels)". This is because not all languages use space before left bracket and use the English left bracket. Bug: 941561 Change-Id: I762fc0f743010da461e3108d41f2b17c8247b6e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657037Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Cr-Commit-Position: refs/heads/master@{#669077}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/ce4e27f24632..92eba93b33c8 git log ce4e27f24632..92eba93b33c8 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 asweintraub@google.com Fix 12 ClangTidy - Readability findings in //pdfium/HEAD/. 2019-06-13 asweintraub@google.com Fix declaration/definition parameter name mismatches. Created with: gclient setdep -r src/third_party/pdfium@92eba93b33c8 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: I648cbda750fe09b4e9b66e2df9373861d493367e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659668Reviewed-by:
-
Robert Flack authored
Running LayerTreeHost::AnimateLayers from the main thread is necessary in order for the main thread KeyframeModels to progress from WAITING_FOR_TARGET_AVAILABILITY to STARTING. Failing to advance to this state results in the cc KeyframeModels never being removed as the animation is still considered current and needing to affect the pending tree. Bug: 762717,962346 Change-Id: Ia559c0a7e3c73e12cc883e64fb4adb284a924418 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1256422 Commit-Queue: Robert Flack <flackr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#669075}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/d05ca1537ccd..bc23ca13f1b3 git log d05ca1537ccd..bc23ca13f1b3 --date=short --no-merges --format='%ad %ae %s' 2019-06-13 smut@google.com [bootstrap/win] Canary Python 2.7.15 Created with: gclient setdep -r src/third_party/depot_tools@bc23ca13f1b3 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:879378 TBR=agable@chromium.org Change-Id: Icd377acb9f79d773ce663f9ce5b32a3594ed376a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659639Reviewed-by:
-
Pavol Marko authored
CommandLine::RemoveSwitch should also remove the switch from argv_. Bug: 964068 Test: base_unittests --gtest_filter=*CommandLine* Change-Id: If44106642c8089b83eb897e09c98ab8cf88fa24b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1653929 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#669073}
-
Mandy Chen authored
Use UI.formatLocalize to embed a link inside a localizable string. UI.formatLocalized takes a string and a list of strings or DOM elements. A span element is created, and a string is appended as a text node through appendChild(createTextNode(str)), while an element is just appended through appendChild(element). Code: https://cs.chromium.org/chromium/src/third_party/blink/renderer/devtools/front_end/ui/UIUtils.js?type=cs&q=uiutils.js&sq=package:chromium&g=0&l=622 Example before vs after: https://imgur.com/XBouvPo There are other places where the same change can be applied. To keep this patch small I only modified the remote devices tab. Sebsequent patches will be made. Bug: 941561 Change-Id: Iaf1ed0451c2f748943c4b9dfc918a969e1c24d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658750 Commit-Queue: Mandy Chen <mandy.chen@microsoft.com> Reviewed-by:
-
