GitLab

This implements UpdateForErrors, which allows the
AutofillDialogController to initiate form validation. Necessary so
fields can be validated on e.g. instrument change.

BUG=277319
TEST=Use Wallet, use incomplete instrument, see error markers.

Review URL: https://codereview.chromium.org/100203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238364 0039d316-1c4b-4281-b951-d872f2087c98

This includes the "enable-linkable-ephemeral-apps" switch as well as
the EphemeralAppThrottle.

BUG=324815, 312460
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/100553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238363 0039d316-1c4b-4281-b951-d872f2087c98

Current code just uses the key_event.nativeKeyCode which is copied
from the Windows' lParam. The proper scancode needs to be shifted
and masked out of the lParam (as is done for UsbKeyCodeForKeyboardEvent.

BUG=325015

Review URL: https://codereview.chromium.org/100533003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238362 0039d316-1c4b-4281-b951-d872f2087c98

Always show a prompt before an ephemeral app is about to be installed
and launched, whether it has permission warnings or not.

BUG=324817, 312460

Review URL: https://codereview.chromium.org/100393004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238361 0039d316-1c4b-4281-b951-d872f2087c98

Zero suggest request re-uses the same URL as regular suggest and
therefore will be requesting xssi=t by default. We should make sure the
output is then correctly parsed.

BUG=

Review URL: https://codereview.chromium.org/96753004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238360 0039d316-1c4b-4281-b951-d872f2087c98

The webkitGetUserMedia maxWidth/maxHeight parameters only define the maximum
frame sizes. The actual capture resolution should not exceed that or the
actual desktop resolution. In other words it should only downscale the desktop
but not upscale it.

BUG=324923
TEST=trybot, Chrome OS feedback screen captures in native resolution

Review URL: https://codereview.chromium.org/100313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238359 0039d316-1c4b-4281-b951-d872f2087c98

R=tonyg
CC=eseidel

Review URL: https://codereview.chromium.org/100283003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238358 0039d316-1c4b-4281-b951-d872f2087c98

BUG=260538
TEST=unit_tests

Review URL: https://codereview.chromium.org/99893007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238357 0039d316-1c4b-4281-b951-d872f2087c98

It now matches the timing and timing function of the advanced options section in settings.

BUG=none

Review URL: https://codereview.chromium.org/99873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238356 0039d316-1c4b-4281-b951-d872f2087c98

BUG=318551, 251070
TEST=manually tested

Review URL: https://codereview.chromium.org/99703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238355 0039d316-1c4b-4281-b951-d872f2087c98

This is needed to handle create-create conflict of folders in LocalToRemoteSyncer.

BUG=240165
NOTRY=true

Review URL: https://codereview.chromium.org/99813005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238354 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TBR=antrim@chromium.org

Review URL: https://codereview.chromium.org/99783005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238353 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316397

Review URL: https://codereview.chromium.org/99483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238352 0039d316-1c4b-4281-b951-d872f2087c98

The rename is because I'm planning to generate Bitmaps from things other than
PNGs and there's nothing really PNG specific about this Bitmap class.

The move is because this is exposed in the Tab API, so it belongs in core, not
backends.

This will make the new Platform video capture API a little cleaner too.

BUG=323813

Review URL: https://codereview.chromium.org/99253005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238351 0039d316-1c4b-4281-b951-d872f2087c98

Flip --enable-privet-local-printing to --disable-privet-local-printing.

BUG=311390

Review URL: https://codereview.chromium.org/99093007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238350 0039d316-1c4b-4281-b951-d872f2087c98

BUG=321520

Review URL: https://codereview.chromium.org/98703003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238349 0039d316-1c4b-4281-b951-d872f2087c98

This CL refactors many of the tests in profile_sync_service_unittest.cc.
It continues the refactoring work begun in r233533, r235661, and
r235854.

The JsController tests have been deleted.  There is not much point in
testing the JsController here; it can be more easily tested on its own
in sync_js_controller_uniittest.cc.  The SyncJsController unit tests
have been updated so they now cover the few cases that were formerly
only exercised in the ProfileSyncService unit tests.

It converts all remaining uncoverted tests from relying on the
TestProfileSyncService to using a real ProfileSyncService with an
injected backend.  The injected backend makes it easier to create the
scenarios we want to test.  We can inject a specially crafted SBH rather
than fiddling with "synchronous init" and "fail initial download" flags.

Since the TestProfileSyncService no longer needs to support the wide
variety of test scenarios required by the tests in
profile_sync_service_unittest.cc, we can greatly simplify its
implementation.  Many of its parameters and associated code have been
removed.

BUG=140354,312994

Review URL: https://codereview.chromium.org/67683005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238348 0039d316-1c4b-4281-b951-d872f2087c98

Currently, we don't enable accelerated 2d canvas in software rendering mode, but
chrome://gpu does not concern software rendering mode.

This CL adds GPUInfo::SupportsAccelerated2dCanvas() so that any clients query if
accelerated 2d canvas is supported.

Review URL: https://codereview.chromium.org/95013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238347 0039d316-1c4b-4281-b951-d872f2087c98

This method is very long. Factor out code building a resource handler
into a separate method to improve readability.

BUG=none

Review URL: https://codereview.chromium.org/94503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238346 0039d316-1c4b-4281-b951-d872f2087c98

Remove unsued arguments from the constructor.

This doesn't change the actual behavior.

BUG=N/A

Review URL: https://codereview.chromium.org/90933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238345 0039d316-1c4b-4281-b951-d872f2087c98

The error type will be used for UMA or the message on the bubble UI.

BUG=318649 (UMA)
TEST=gtest_filter=TranslateBubbleViewTest.*

Review URL: https://codereview.chromium.org/87503004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238344 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise it could crash the browser process

BUG=325046
TEST=manual (launch Chrome, immediately open syncfs-internals)
R=nhiroki@chromium.org, tzik@chromium.org

Review URL: https://codereview.chromium.org/98473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238340 0039d316-1c4b-4281-b951-d872f2087c98

The bookmark bubble will close when the browser window size changes with this CL.

We already close it when the browser window moves, so this is more consistent with that behavior.

BUG=321034
TEST=BubbleDelegateTest.CloseWhenAnchorWidgetBoundsChanged.
manual. see bug for repro step.

Review URL: https://codereview.chromium.org/89503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238339 0039d316-1c4b-4281-b951-d872f2087c98

If the model association happens at the right time (i.e. when a tab is being
dragged from one window to another), the tab strip model may be out of date.
Just handle this gracefully for now and return false.

BUG=282590
TBR=haitao@chromium.org

Review URL: https://codereview.chromium.org/81193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238338 0039d316-1c4b-4281-b951-d872f2087c98

The links are now prefixed as needed with enough '../'s as appropriate.
This fixes $ref links from manifest articles.

BUG=315390

Review URL: https://codereview.chromium.org/80183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238337 0039d316-1c4b-4281-b951-d872f2087c98

Added the headers and non-platform-specific base class definitions for
the NFC API.

BUG=chromium:316471
TEST=device_unittests

Review URL: https://codereview.chromium.org/77563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238336 0039d316-1c4b-4281-b951-d872f2087c98

BatterBar is replaced with new ProgressCenter class. This is no longer
needed. This CL removes the ButterBar class, HTML elements and CSS styles.

BUG=318931
TEST=manually
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/98213003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238333 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a unit test of ProgressCenterHanler class for copy operatons.

BUG=324679
TEST=file_manager_jstest
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/98363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238332 0039d316-1c4b-4281-b951-d872f2087c98

The DBusClient interfaces shouldn't provide functionality related to testing code (like Stubs/fake implementations).
Instead fake clients are now directly created without relying on the static Create() functions. The now unused DBusClientImplementationType argument of the Create() functions could be removed.

BUG=275286
R=satorux@chromium.org

Review URL: https://codereview.chromium.org/91413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238330 0039d316-1c4b-4281-b951-d872f2087c98

This allows to create these stubs directly without routing through the static Create() function in the client's interface.

BUG=275286
R=satorux@chromium.org

Review URL: https://codereview.chromium.org/91373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238329 0039d316-1c4b-4281-b951-d872f2087c98

Implement __asan_default_options() for the Chrome OSX binary. This function
sets handle_segv=0 iff the binary is executed with --type=nacl-loader.

BUG=323510
TEST=browser_tests pass under ASan on OSX x64
R=cpu@chromium.org, mseaborn@chromium.org

Review URL: https://codereview.chromium.org/96683003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238328 0039d316-1c4b-4281-b951-d872f2087c98

> Attempt to fix audio wedges by restarting all streams on OSX.
> 
> Introduces two new methods to AudioOutputDispatcher:
> CloseStreamsForWedgeFix() and RestartStreamsForWedgeFix().
> 
> Respectively, each method closes or restarts all active
> streams owned by a given dispatcher.  The process is
> completely transparent to upstream clients.
> 
> A new method on AudioManager, FixWedgedAudio() calls
> CloseStreamsForWedgeFix() for all dispatchers and then
> calls RestartStreamsForWedgeFix() afterward.
> 
> FixWedgedAudio() is called by each AudioOutputController
> when a wedge is detected.  Multiple in flight wedge checks
> are serialized by the audio thread.  The hope is that wedges
> will be fixed before the next WedgeCheck() fires.
> 
> While the methods are available on all platforms, FixWedgedAudio()
> is only wired up on OSX.
> 
> BUG=160920
> TEST=unittest. fake wedge and observe stream recreation.
> R=scherkus@chromium.org
> 
> Review URL: https://codereview.chromium.org/61203008

TBR=dalecurtis@google.com

Review URL: https://codereview.chromium.org/101473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238327 0039d316-1c4b-4281-b951-d872f2087c98

Introduces two new methods to AudioOutputDispatcher:
CloseStreamsForWedgeFix() and RestartStreamsForWedgeFix().

Respectively, each method closes or restarts all active
streams owned by a given dispatcher.  The process is
completely transparent to upstream clients.

A new method on AudioManager, FixWedgedAudio() calls
CloseStreamsForWedgeFix() for all dispatchers and then
calls RestartStreamsForWedgeFix() afterward.

FixWedgedAudio() is called by each AudioOutputController
when a wedge is detected.  Multiple in flight wedge checks
are serialized by the audio thread.  The hope is that wedges
will be fixed before the next WedgeCheck() fires.

While the methods are available on all platforms, FixWedgedAudio()
is only wired up on OSX.

BUG=160920
TEST=unittest. fake wedge and observe stream recreation.
R=scherkus@chromium.org

Review URL: https://codereview.chromium.org/61203008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238325 0039d316-1c4b-4281-b951-d872f2087c98

When many readbacks will be occuring in a row, we don't want to have
texture create/delete calls constantly churning through GPU memory.
In particular, this has been a severe performance bottleneck on some
intel drivers.

Instead provide a way for the copy request client to provide a texture
to the compositor that it will use, and then the texture can be reused
for as long as the client wishes.

In the case of tab capture, the client (in RenderWidgetHostViewAura)
wants to use the GLHelper to act on the given texture. Since the
GLHelper lives on the main thread, and the compositor draws on the
compositor thread, we provide the texture from the client through
the main thread CopyOutputRequest API rather than hooking directly
into the compositor thread.

I moved the async readback unit tests out to their own file as
there are now quite a few.

Tests:
LayerTreeHostCopyRequestTestCreatesTexture
LayerTreeHostCopyRequestTestProvideTexture

R=piman@chromium.org
BUG=312497

Review URL: https://codereview.chromium.org/99253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238324 0039d316-1c4b-4281-b951-d872f2087c98

The Mac app launcher now fades away when it is dismissed, so the
animation that resets the search state can be seen while it's fading
out. To match Win/CrOS, this CL moves the clear to when the window is
closed; at the end of the animation.

Adds a unit test: AppListWindowControllerTest.CloseClearsSearch to
cover.

BUG=321541
TEST=Launch something from a search in the Mac App Launcher. While it's
fading out you shouldn't see the apps grid slide back in.

Review URL: https://codereview.chromium.org/98233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238323 0039d316-1c4b-4281-b951-d872f2087c98

BUG=324169
TEST=manual

Review URL: https://codereview.chromium.org/98213002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238322 0039d316-1c4b-4281-b951-d872f2087c98

BUG=323263

Review URL: https://codereview.chromium.org/90253002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238321 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238320 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240165
NOTRY=true
R=kinuko@chromium.org, nhiroki@chromium.org

Review URL: https://codereview.chromium.org/98653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238319 0039d316-1c4b-4281-b951-d872f2087c98

The "reasons" field had been a subset of {NO_SERVICE, NO_NETWORK, NOT_READY},
but it is now used only for signaling errors when it has NOT_READY
without other reasons. This can more simply be represented
by a single "reason" field whose value is set in the order:
NO_SERVICE > NO_NETWORK > NOT_READY, i.e., NOT_READY is set
only when other two states are not set.

BUG=237427
R=benwells@chromium.org, yoshiki@chromium.org

Review URL: https://codereview.chromium.org/98493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@238318 0039d316-1c4b-4281-b951-d872f2087c98