- 23 Oct, 2019 40 commits
-
-
Matt Mueller authored
Bug: 635205 Change-Id: I5b5e69ed79d017fcd36110c7ad73d08f8f6adea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876739Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#708820}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/17e452a6..f3b63d6f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaa9488a1705f6d50070ee7969c2f4942fcf88d7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877087Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708819}
-
Jamie Walch authored
We register a handler for Ctrl+Alt+Esc for remote assistance to give a keyboard shortcut for the local user to use if they need to disconnect the remote user in a hurry. Unfortunately, on Catalina this means that the user needs to whitelist the process for "monitor keyboard activity from all process" permission, which is more than we need and quite an alarming thing to ask our users to approve. Since this shortcut is not advertised anywhere, it seems more prudent to remove it, on Mac only for now, but potentially on all platforms in the future. Fixed: 1015242 Change-Id: I72ae4c214eb7d6fcec77bafff91495b07b7b91c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876206 Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#708818}
-
Livvie Lin authored
https://chromium-review.googlesource.com/c/chromium/src/+/1769353 added a mode to IOSSSlErrorHandler that returns error HTML in a callback. This CL calls into IOSSSLErrorHandler::HandleSSLError from PrepareErrorPage to display the actual interstitial on an SSL error instead of a generic error page. Bug: 987407 Change-Id: I472e9012988a0b8fcc3f72d8dbc52aad07c067a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793260 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#708817}
-
manuk authored
With this CL, the doc provider will have 6 query-length related parameters: DocumentProviderMin(Max)QueryLength Limits for which inputs the provider will make a request to the drive backend. This is useful to relieving backend load. DocumentProviderMin(Max)QueryShowLength Limits for which inputs the provider will show doc suggestions (assuming the backend returned documents). These help analyze experiments by allowing observing the effect of changing |min(max)_query_length_| while keeping data populations consistent. DocumentProviderMin(Max)QueryLogLength Limits for which inputs the provider will log field_trial_triggered_(in_session_). These help analyze experiments by restricting data populations to avoid noise when only interested in a range of input lengths. E.g. experimenting with |max_query_show_length_| would affect only the small subset of long queries. Bug: 1015977, 864302 Change-Id: Iacb16d8b67b4adeb20e3e73d8570d45e0174d33a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869374 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#708816}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/75647d9e1ae7..720447713e24 git log 75647d9e1ae7..720447713e24 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 seanabraham@chromium.org chromeos_config: don't run HW tests for VM-only build target Created with: gclient setdep -r src/third_party/chromite@720447713e24 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I2c8daf827666d0762684c0da8e90ac2229841a3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875651Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708815}
-
Peter Kasting authored
* Makes CreateLabelRange() a member function (and renames it CreateLabel()) to allow it to use various members that are currently passed as arguments the same way at both callsites. This makes the code simpler and more future-proof. It also allows moving the color-related functionality in from the caller. * To allow CreateLabel() to be const, moves the set_listener() call to the caller side. Only one caller needs this anyway. * Stop calling AdvanceOneLine() in the "very first line was empty" case, where it will have no effect, since |new_line| is false and there are no views to adjust. * The final post-loop call of AdvanceOneLine() doesn't actually care about whether |new_line| is set to false (since the adjusted values won't be read afterwards). Combined with the change above, this means the |new_line| arg can be eliminated entirely. * Change |max_line_height| (which sounds like the max height of all lines) to the less-ambiguous (and shorter) |line_height|, since it's the height of the current line. * At the end of the loop, adjust |remaining_string| before calling AdvanceOneLine() instead of after. These are independent, so this has no effect, but it will allow for a control flow change in a subsequent patch. Bug: 1015717 Change-Id: Ie1858c29b70f5c8ff1e9ba005a7fddb5e446e133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875028 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#708814}
-
Brandon Walderman authored
This change moves the logic for constructing DevTools endpoint URLs into a common location (DevToolsHttpEndpoint). Call sites that were previously building URL strings directly can now call the appropriate method on DevToolsHttpEndpoint instead. For example, List() returns an endpoint's /json/list URL. A DevToolsHttpEndpoint can be constructed from a NetAddress for the common case where the endpoint is running on localhost on a certain port. It can also be constructed from a URL with a path prefix. The prefix will be included in all URLs for that endpoint. This is mainly to support some downstream features in MSEdgeDriver that rely on devtools endpoints with path prefixes and which may be served over HTTPS. There is no functional change to ChromeDriver. Just some refactoring. Bug: 1016888 Change-Id: I50dc97f23637f58f972e7f5a5807e74a7af5f69a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874200Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Brandon Walderman <brwalder@microsoft.com> Cr-Commit-Position: refs/heads/master@{#708813}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/08af1c80188f..88a99e4382c1 git log 08af1c80188f..88a99e4382c1 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 tobine@google.com Vulkan:Roll Loader 2019-10-23 tobine@google.com OES_depth32 is for render buffer capability Created with: gclient setdep -r src/third_party/angle@88a99e4382c1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Bug: None Change-Id: Ie62667ad86bd376e1c668cd0c066c6392d56359e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875652Reviewed-by:
-
Sammie Quon authored
It's an edge case when moving the divider either in portrait mode, or like in the video in the attached bug. Test: manual Fixed: 1017370 Change-Id: I78e11fc1785cf9d39363aa90c52a851243b9736e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877190Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#708811}
-
Mason Freed authored
Prior to this CL, the HTML Imports deprecation message would only be shown if HTML Imports was enabled directly by a command line flag. It would not show if the page being visited was participating in the Web Components v0 origin trial, and enabled the feature that way. Bug: 911943 Change-Id: I8884ea755fdcdd69e2af57c6f131eed83f76b4f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876799 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#708810}
-
Natalie Chouinard authored
Bug: 1016957 Change-Id: I5baf2577d2df7fd37827811102bbcba746280542 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876877Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#708809}
-
Sebastien Marchand authored
Most frames won't set a freeze origin trial policy and so making kDefault the default state when a frame gets created will reduce the number of IPC calls. This could cause pages to be frozen before all their frames have reported their policy, a following CL will unfreeze frozen pages that receive an opt-out OT token. Change-Id: I3059b57e44f9bbdb9fb9bdd8b860bebda36329a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872637Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#708808}
-
Evan Stade authored
Bug: 268984 Change-Id: I703e5a294a7c51d02a19cfd504cb8e0f2dfbd97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875270Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#708807}
-
Evan Stade authored
Bug: 268984 Change-Id: I49aa469198d7fe48d7d3cf10cc742499489decfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876912Reviewed-by:
-
Mathieu Binette authored
Following up on change https://crrev.com/i/2022512. Change-Id: I5cdb19e71d9999aa7a4bc90d866f06668ed53648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876788Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Mathieu Binette <mbinette@google.com> Cr-Commit-Position: refs/heads/master@{#708805}
-
Jia authored
This cl adds more logging into sys report so that we can help users better when they file a bug report. Bug: 881215 Change-Id: Iea0f1ef052d68ee608f64fed25e1a727b1c50c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1871719 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#708804}
-
Anastasia Helfinstein authored
Bug: None Change-Id: I10a3685214f10695de897510199450d687b1ab8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874053 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#708803}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/577977ad233c..376ccc06cd30 git log 577977ad233c..376ccc06cd30 --date=short --no-merges --format='%ad %ae %s' 2019-10-23 sadrul@chromium.org trace-viewer: Make some style changes for the toolbar. Created with: gclient setdep -r src/third_party/catapult@376ccc06cd30 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:1017326 Change-Id: I5baadf45053f51c4b61d1b5f21caa0a8c20fe24e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876915Reviewed-by:
-
Peter Kotwicz authored
This CL daggerizes WebappActivity. BUG=1016650 Change-Id: I06f75fdce90985bfb6a59efca0ce268032821375 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873276 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#708801}
-
Ricardo Quesada authored
This CL adds the "installPWAForCurrentURL" function into private_autotest. This functionality is needed for some Tast tests. BUG=chromium:1015520 TEST=locally tested using a Tast test that is WIP. Change-Id: I710fb788142d3c3984394aceca1311d7f3652dd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866851 Commit-Queue: Ricardo Quesada <ricardoq@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
-
Etienne Bergeron authored
A recent change in RenderText caused a regression while showing command accelerators on MAC (see: http://crbug.com/1016676). The change in RenderText is replacing the embedded control characters with their equivalent unicode visual pictures. This change should not cause that regression. By digging into the code, we found that some strings are incorrectly providing string with embedded nul character. These controls characters doesn't have 'glyphs' in font and will triggers expensive font fallbacks before faling to find the appropriate font. This CL is removing the leading \0 character from Accelerator::KeyCodeToMacSymbol(...) R=robliao@chromium.org,ellyjones@chromium.org CC=thomasanderson@chromium.org Bug: 1016676 Change-Id: Iaf3de8e5aec4de4e63e09f1071bf27768d0762d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876468Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Auto-Submit: Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#708799}
-
Christopher Cameron authored
As part of the investigation of the hangs in the Metal shader compiler, we will be running some Metal code in the browser process. Create a stand-alone component for Metal utility functions that will be used in the browser process and also in the gpu process. For the moment this functionality includes the C++ Metal types and the function to select the default Metal device (low-power if available). Functionality to compile a test shader to determine if it hangs will also be moved there (and called from the browser process). Bug: 974219 Change-Id: Ic6a696686e0c438ec339c6cc40b8200be6b0a689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869127 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Cait Phillips <caitkp@chromium.org> Cr-Commit-Position: refs/heads/master@{#708798}
-
Garrett Beaty authored
Bug: 922150 Change-Id: I77a1e390bdcef85cd538b204ee6274cc52fe2a81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859636 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#708797}
-
Dave Tapuska authored
In order to use cc::TouchAction on the blink mojom API we require it the definition to move to somewhere blink can depend on (not content). Being that touch_action is defined in CC it seems natural to introduce it there. BUG=1008432 Change-Id: I62ab198a169bd242d36e27a5357636800e296593 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867036Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#708796}
-
Alexei Svitkine authored
Some small fixes and Py3 compatibility. Bug: None Change-Id: I09855299135799527dbcf4d0070a2ce9d9147d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872564 Auto-Submit: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#708795}
-
Avi Drissman authored
It's ignored by the Mac codesigning apparatus nowadays, anyway, so this simplifies things. Bug: 913074 Change-Id: I1aff929788171821a835bd5a4eed5514fe2df1be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876764Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708794}
-
Daniel Libby authored
Revert the code changes from crrev.com/c/1590960 and mark the histogram as obsolete. We were investigating how modifying the slop region affected this metric, and have seen data showing that, as expected, the metric goes proportional to the decrease in slop distance. Bug: 988762 Change-Id: I802aad4f80b718d163f4b536f3ee66e7a90b3526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875367Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#708793}
-
Christopher Cameron authored
In order to do this, we will need to know whether or not a PWA is installed for a given profile, without actually loading that profile. The suggested mechanism for this is to check the for the presence of a Extensions/app_id subdirectory of the profile path. Add a profile_menu_items_ member to ExtensionAppShimHandler that lists all profiles in the AvatarMenu. Add a installed_profiles member to ExtensionAppShimHandler::AppState that lists all profiles for which a given app is installed (this is a subset of the profiles in ExtensionAppShimHandler:: profile_menu_items_). Add a ExtensionAppShimHandler::Delegate::GetProfilesForAppAsync method to do the aforementioned path check. Update ExtensionAppShimHandler::UpdateAppProfileMenu to sort menu items by |menu_index| and to send an empty list if just one profile would have appeared in the menu. Add tests. Restructure tests such that ExtensionAppShimHandler takes its delegate as a constructor argument (instead of having it be set-able). R=dominickn TBR=skuhne Bug: 1001215 Change-Id: I10bb7128c6f775759f1d1f381000eb7b33960eb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1864098Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#708792}
-
Matt Menke authored
This sets what field trials are enabled by default when running tests, and is needed before the option can be enabled on beta. The option is added to the pre-existing experiment PartitionConnectionsByNetworkIsolationKey to mirror the server-side configuration. Bug: 963480 Change-Id: Ib1a6ca42b997658f2b66658b9ba2713f1669545d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873959Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
-
Natalie Chouinard authored
Add a generic isManagedPreference method to PrefServiceBridge, making use of the prefs.h enums. Migrate Java usages of prefs::kSearchSuggestEnabled to use the generic methods as a sample (more to follow). Bug: 1016957 Change-Id: Ib13181fd9ed6c2e2265b08c141985899bfbabe0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874719Reviewed-by:
-
Ian Clelland authored
This macro had apparently not been effective at detecting removed origin trials since the OT/RTEF bindings were refactored earlier this year. WebVR was removed from OT without triggering an assertion failure. This CL fixes that now by testing for a method which is only generated if the feature is part of a trial. Bug: 960132 Change-Id: I1a8d8542d3c2513170ac5fc57411991e3988d938 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874191 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#708789}
-
Brian White authored
Adds expires_after attribute for 7 histograms that do not already have one. The date will get pushed out automatically if significant use is detected. Change-Id: I8d2c670e6619a8e2d3477b982fcedfe4a7a9892e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876751Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Commit-Queue: Brian White <bcwhite@google.com> Cr-Commit-Position: refs/heads/master@{#708788}
-
Michael Ludwig authored
This relaxes the requirements for tiled draw quads that can bypass a RenderPass. Previously, the content quad had to have an identity transform and fill the RenderPass's layer. With this change, the geometry and transform constraints go away, and the RPDQ params struct is updated to remember the additional transform that has to be applied to draw the content correctly. The base transform and the new transform are kept separate because the image filters of the render pass have to be processed in the base transform's coordinate space. However, we also don't want to just draw the base geometry with the content quad's textures because the texture coordinates may not map to a gfx::Rect anymore. Storing separate transforms cleanly handles both of these challenges. Bug: 1013735 Change-Id: I0a05d2aa318238dae093899c697fac6a84e5c261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860302 Commit-Queue: Michael Ludwig <michaelludwig@google.com> Reviewed-by:
weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#708787}
-
Matt Menke authored
The NetworkService only considers redirects to certain schemes it's familiar with unsafe. Now that it no longer handles data or file URLs, there's no such scheme. As a result, allowing redirects to unsafe URLs doesn't actually do anything. The same mechanism was also being used to preserve the (lack of) a fragment on redirects injected by extensions, rather than copying over the fragment like a normal redirect, so in its place, add a concept of a URL that, if redirected to, keeps its frament. Unfortunately, the unsafe URL concept is still used for redirects to chrome URLs on iOS (which doesn't allow that to be overridden), so this CL does not completely remove the concept of unsafe redirects. Bug: 934009 Change-Id: I366156d94aed9067ff18dc14bfd7bf9142817123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869727 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#708786}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6adb0a26846c..d7bf5c56b69b git log 6adb0a26846c..d7bf5c56b69b --date=short --no-merges --format='%ad %ae %s' 2019-10-23 mbonadei@webrtc.org Revert "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." 2019-10-23 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." 2019-10-23 danilchap@webrtc.org change PacketBuffer to return it's result rather that use callback 2019-10-23 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 6dc3a51e..b5030084 (708537:708640) Created with: gclient setdep -r src/third_party/webrtc@d7bf5c56b69b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None,chromium:None Change-Id: I7bd0d1650c7147745e0b051076aba23c45aa9a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876968Reviewed-by:
-
Stephen McGruer authored
This reverts commit 29a875e1. Reason for revert: Strong suspect for compile failure blocking the tree: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8898774375244271360/+/steps/compile/0/stdout Original change's description: > Add underflow duration to our media UKM reporting. > > This associates a completed underflow count and total underflow duration > with each segment of watch time reported to UKM. > > Generally the completion will always fall within a given segment of > watch time, however it is possible that a completion can happen after a > resolution change or other secondary property update and thus end up in > a subsequent segment. > > We impose impose a maximum value of 1 minute for rebuffer durations to > avoid noise from rebuffers which may cross a suspend/resume boundary. > > BUG=994021 > TEST=new unittests > R=sandersd > > Change-Id: I1b4386845e21ec17472cbf8c85bf62185e28eb25 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869023 > Reviewed-by: Mustafa Emre Acer <meacer@chromium.org> > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#708778} TBR=dalecurtis@chromium.org,meacer@chromium.org,sandersd@chromium.org,holte@chromium.org Change-Id: I6bdff8dee0fb365eabee3bea8501a22155059d0d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 994021 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877192Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#708784}
-
Martin Barbella authored
This was not an issue in release builds, but it's causing failures in libFuzzer debug builds. Change-Id: Ic4297a97c3cd6361e778b19f66aa8779bbb89e0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1875516 Auto-Submit: Martin Barbella <mbarbella@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#708783}
-
Daniel Rubery authored
The stable_eset tag was deprecated August 22, but Omaha is still reporting many users still using the stable_eset tag. It's possible something is pulling tag values from fieldtrial_testing_config, so add a unique value for those tags. Fixed: 1017200 Change-Id: Icc8dd004cf84e6f3af05e03d0eb7a9ce03719617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876026Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#708782}
-
Sinan Sahin authored
This CL adds the plumbing to have separate top and bottom shown ratios. Having separate ratios is required for the upcoming CLs as we ultimately want to be able to animate the top and the bottom controls independently. Bug: 989148 Change-Id: I874cf7f6fa0380cb9a1497d3804969b82bd419c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1827951 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#708781}
-
