- 22 Feb, 2019 40 commits
-
-
Tanmoy Mollik authored
This is a reland of http://crrev.com/633591 . There were a small error in that patch. That patch also only added statistics in the background. This patch modifies the histogram.xml and memory_emitter.cc file to reflect it on UMA. Bug: 931669 Change-Id: Ic03717102ab2a2126e716c024464222372e15990 Reviewed-on: https://chromium-review.googlesource.com/c/1475404 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634629}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3acdefa9aad9..b1b14cdf2bee git log 3acdefa9aad9..b1b14cdf2bee --date=short --no-merges --format='%ad %ae %s' 2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-22 hferreiro@igalia.com Limit the rebase-update call after reparent-branch Created with: gclient setdep -r src/third_party/depot_tools@b1b14cdf2bee The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I116f778184a71389bf27afb1dd66faa236dccb3d Reviewed-on: https://chromium-review.googlesource.com/c/1482623Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634628}
-
Kush Sinha authored
Summary of changes: - Remove subscription from Chrome OS Account Manager. - Use IdentityManager as the source of truth for account updates. IdentityManager transitively uses Chrome OS Account Manager as the source of truth for Chrome OS accounts. - Remove usages of AccountTrackerService and AccountMapperUtil since they are no longer needed. Bug: 925827 Test: browser_tests --gtest_filter="*Arc*AuthService*Test*" Change-Id: If1caea0580eda094466c5fe17565013a038383c5 Reviewed-on: https://chromium-review.googlesource.com/c/1480518 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:Yury Khmel <khmel@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634627}
-
Christos Froussios authored
because it is flaky TBR=mmenke@chromium.org Bug: 934778 Change-Id: I06f222489a3bcc61d6b5b6f2ce2b7f3559ad65aa Reviewed-on: https://chromium-review.googlesource.com/c/1483051 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#634626}
-
Christos Froussios authored
This reverts commit d41579e2. Reason for revert: Speculative revert. This is the only CL in https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-kevin-rel/325 when it started to break. Original change's description: > Fix search restart after zero entries (again). > > The fix was lost in refactoring that ended up duplicating > the last_find_request_completed_with_no_matches_ member. > > BUG=669983 > > Change-Id: I09229496d183ef3f9b69c6089a6ac3ecd8b5ef82 > Reviewed-on: https://chromium-review.googlesource.com/c/1477835 > Reviewed-by: Rakina Zata Amni <rakina@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634599} TBR=haraken@chromium.org,rakina@chromium.org,allan.jensen@qt.io Change-Id: I5b59c759eb23e526892b8fdab7ed580306cfd6d6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 669983 Reviewed-on: https://chromium-review.googlesource.com/c/1482455Reviewed-by:
-
Rakina Zata Amni authored
When a shadow root with non-empty |adoptedStyleSheets| is inserted, we should make sure that the |active_tree_scopes_| list is updated and the tree scope is marked dirty so that style invalidation & recalc will work. Bug: 934340 Change-Id: I365936e4bcc0132c938fe4e200e208abac91d3d9 Reviewed-on: https://chromium-review.googlesource.com/c/1482437 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#634624}
-
Colin Blundell authored
identity_services_provider_android.cc serves as the glue between the Java Profile object and the Java signin-related objects associated with that Profile. In particular, it allows for getting the Java AccountTrackerService and OAuth2TokenService objects associated with the Java Profile. This mapping isn't done in Java itself as the Java Profile object does not have a concept of KeyedServices. When we have internalized usage of these classes behind IdentityManager in Java, this glue will naturally be only on IdentityManager rather than on the underlying internal classes. In order to enable the completion of internalization of the C++ classes (of which this is one of the very few remaining blockers), we are introducing legacy C++ APIs on IdentityManager to get the Java objects for AccountTrackerService and ProfileOAuth2TokenService. Bug: 934701 Change-Id: Iab70b66a14892dcb37a6924e1e76742b5ac570a4 Reviewed-on: https://chromium-review.googlesource.com/c/1482793Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634623}
-
Christos Froussios authored
The test is timing out on WebKit Linux Trusty MSAN. Example https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Linux%20Trusty%20MSAN/12923 The failure was probably introduced with https://chromium.googlesource.com/chromium/src/+/69d311c45f95b958dfdf07fd2a48469ca94015d7 Bug: 929122 No-try: True No-presubmit: True Change-Id: I494a4c6d9619d368577dd4a4924398d708b27d96 Reviewed-on: https://chromium-review.googlesource.com/c/1482898Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dceb02b288e4..6e1bc9a8d48c Created with: gclient setdep -r src-internal@6e1bc9a8d48c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I04efa75eee5e2b70a8c8aaa5db9b53395fe0a1fb Reviewed-on: https://chromium-review.googlesource.com/c/1482624Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634621}
-
Balazs Engedy authored
Registering event handlers to `devicemotion`, `deviceorientation`, and `deviceorientationabsolute` events is still possible, but the handlers will never be invoked in non-secure browsing contexts. The following, related, interfaces are marked as [SecureContext]: -- DeviceOrientationEvent, -- DeviceMotionEvent, -- DeviceMotionEventAcceleration, -- DeviceMotionEventRotationRate. The change is gated on RestrictDeviceSensorEventsToSecureContexts, which is disabled by default, so this CL is a no-op unless the base::Feature with the same name is manually enabled. Intent to remove: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/5yqfAXibz1I Bug: 932078 Change-Id: I9baaafd1f4483f121feadc054650c4d510a2c88d TBR: haraken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1473992 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#634620}
-
Colin Blundell authored
Missed when this unittest was converted. Bug: 883330 Change-Id: I2c6bfcb3de58aa741c4e33fc63ea457dc139714c Reviewed-on: https://chromium-review.googlesource.com/c/1482972Reviewed-by:
Lowell Manners <lowell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634619}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/969659dbb313..b7cddd1ec983 git log 969659dbb313..b7cddd1ec983 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@b7cddd1ec983 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jvanverth@chromium.org Change-Id: If9ab17c15dc442ff86d429b4a125e493a0b51068 Reviewed-on: https://chromium-review.googlesource.com/c/1482621Reviewed-by:
-
Friedrich Horschig authored
This CL adds a space below the last UserInfo element and the first non-UserInfo element. Effectively, this means the FooterCommands have the same padding to the UserInfo as UserInfo elements have to each other. Screenshot before: https://photos.app.goo.gl/h3By5RN2zUiDGVLw8 Screenshot after: https://photos.app.goo.gl/MVzu6uirjkkVhnBF9 Alternatives considered: 1. A static top margin for a footer command would not work here since footer commands are not supposed to have paddings between each other. 2. Adding the space relative to the first Footer Command adds a padding between the "No saved passwords" text and the footer commands if no UserInfo is available. Such padding isn't supposed to exist either. 3. Wrapping FooterCommands or UserInfos into a Layout and add the margin to the layout would work but degrades the effectiveness of the RecyclerView which wants to reuse containers. Change-Id: I63e08ab42215f81befb05bd5a26b96d27dc4b908 Reviewed-on: https://chromium-review.googlesource.com/c/1481295Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#634617}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e11b7d2e8087..45af00f33bfc git log e11b7d2e8087..45af00f33bfc --date=short --no-merges --format='%ad %ae %s' 2019-02-22 ssilkin@webrtc.org Revert "Adds resource path support for video files in scenario tests." 2019-02-22 kwiberg@webrtc.org Use `final` so that the compiler will be able to inline calls 2019-02-21 kwiberg@webrtc.org Add thread safety annotations for PeerConnection::configuration_ 2019-02-21 srte@webrtc.org Adds resource path support for video files in scenario tests. 2019-02-21 andersc@webrtc.org Make sure RTC_SUPPORTS_METAL is set in AppRTCMobile. 2019-02-21 devicentepena@webrtc.org CreateAudioProcessor: do not propagate an unset echo control factory to the AudioProcessing instance 2019-02-21 peterhanspers@webrtc.org Adding entry point for the v2 stats API. 2019-02-21 hta@webrtc.org DtlsTransport::ice_transport is const and can be called off thread 2019-02-21 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 94ca2b10..f39a1b89 (634089:634190) 2019-02-21 kron@webrtc.org Reland "Extend TransportSequenceNumber RTP header extension" 2019-02-21 jakobi@webrtc.org Refactor DelayManager into separate Histogram class and make it injectable for testing purposes. 2019-02-21 danilchap@webrtc.org Migrate stdlib task queue to TaskQueueBase interface Created with: gclient setdep -r src/third_party/webrtc@45af00f33bfc The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:907849,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4fdff3902d583c16e383b3db12a450f4407fad39 Reviewed-on: https://chromium-review.googlesource.com/c/1482618Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a74495a2956d..0a94c0324d42 git log a74495a2956d..0a94c0324d42 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 khokhlov@google.com Clean up benchmark_runner.py Created with: gclient setdep -r src/third_party/catapult@0a94c0324d42 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Iaad29a8641f444a2f4a200592f7f076d18e35e20 Reviewed-on: https://chromium-review.googlesource.com/c/1482622Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/43b5c7b0..c4b8be31 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Icf1715b7e157250f3fdd4c0b04bc8635b412e0dd Reviewed-on: https://chromium-review.googlesource.com/c/1482599Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#634614}
-
Colin Blundell authored
Helps clarify what the actual users are here. Change-Id: I8554fb008046df105e619a56a8fdd73d8269d9d3 Reviewed-on: https://chromium-review.googlesource.com/c/1477013Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634613}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4309189029fc..dceb02b288e4 Created with: gclient setdep -r src-internal@dceb02b288e4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I950ec43dee6479d6bd511f5f18d2754298e08c7a Reviewed-on: https://chromium-review.googlesource.com/c/1482619Reviewed-by:
-
Mugdha Lakhani authored
Per the documentation, setting windowEndTime as min_delay will run the task after min_delay has passed, without respecting network type constraints: https://cs.chromium.org/chromium/src/third_party/android_tools/sdk/sources/android-25/android/app/job/JobParameters.java?rcl=347a7c8078a009e98995985b7ab6ec6b35696dea&l=89 This change sets the start time as min_delay for the Chrome wake up task for Background Sync, and sets the end of the window to Integer.MAX, so that network connectivity constraints are always respected. Bug: 924490 Change-Id: I2888127ce1133d5ae262f507180c5aa067e102aa Reviewed-on: https://chromium-review.googlesource.com/c/1480528Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#634611}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c0546b9817ee..3acdefa9aad9 git log c0546b9817ee..3acdefa9aad9 --date=short --no-merges --format='%ad %ae %s' 2019-02-22 hferreiro@igalia.com Omit "Skipping <branch>" message when unneeded Created with: gclient setdep -r src/third_party/depot_tools@3acdefa9aad9 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Id18bf39261ffc192f3593a1451cdc91f9e15bab5 Reviewed-on: https://chromium-review.googlesource.com/c/1482620Reviewed-by:
-
Guido Urdaneta authored
Prior to this CL, the event was fired before the transceiver state was updated, in contradiction with the spec, which says it should be fired after the transceiver state is updated. Bug: 920200 Change-Id: I757cc0161a5da4888cd628619180e24a54dc732b Reviewed-on: https://chromium-review.googlesource.com/c/1458203 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#634609}
-
Danil Chapovalov authored
by making WebrtcTaskQueue::RunTask properly static RunTask supports running after WebrtcTaskQueue is destroyed, it has protection |this| is not accessed in that case, however calling non-static non-virtual function of a destroyed object is still an undefined behaviour Bug: chromium:933851 Change-Id: Idc30bc59eff1193997d7e53537cd1493b668dd08 Reviewed-on: https://chromium-review.googlesource.com/c/1479233Reviewed-by:
Per Kjellander <perkj@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Auto-Submit: Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#634608}
-
Christos Froussios authored
http/tests/devtools/tracing/worker-events.js virtual/threaded/http/tests/devtools/tracing/worker-events.js are flaky on Mac10.13 Tests (dbg) Bug: 934768 No-try: True No-presubmit: True Change-Id: Id114e2e590e1d4642160b228cee9987b65a28c2c Reviewed-on: https://chromium-review.googlesource.com/c/1482731Reviewed-by:
-
Alexandre Courbot authored
We have made V4L2ReadableBufferRef's destruction thread-safe, but they still hold a scoped_refptr to their V4L2Queue. This means that the V4L2Queue can be destroyed from V4L2ReadableBufferRef's destructor, i.e. in the incorrect thread. Fix this by changing the scoped_refptr to a WeakPtr. This design also fixes another issue: it lets us invalidate the WeakPtrs if buffers get reallocated, making it impossible to access the wrong buffer after such an event. Methods of V4L2ReadableBufferRef that make use of the queue accordingly check that the WeakPtr is valid and return an error value if it is not. Bug: 792790 Bug: b:119794200 Test: VDA unittest passed in regular and import mode on Hana. Change-Id: I82722033d9b902fd44f5c090be47ffb4469222a3 Reviewed-on: https://chromium-review.googlesource.com/c/1481186 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#634606}
-
dstockwell authored
Bug: 902646 Change-Id: I60ade36f35629834b8ef4249e05635a28a8a702e Reviewed-on: https://chromium-review.googlesource.com/c/1481279 Auto-Submit: dstockwell <dstockwell@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: dstockwell <dstockwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#634605}
-
Greg Thompson authored
BUG=933004 R=wfh@chromium.org Change-Id: I911be4cbfc38a4d41dec85d85f7fe0f50ddca392 Reviewed-on: https://chromium-review.googlesource.com/c/1481210 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#634604}
-
Gyuyoung Kim authored
The OnionSoup effort has a goal of allocating all garbage-collectable Blink objects with Oilpan or PartitionAlloc. However, the some classes of //blink/renderer/core/timing has not yet been allocated with them so far. So their uses of non-garbage-collected objects should be restricted to cases where the garbage collector can discover their references. The macros of Allocator will be useful for the non-garbage-collected objects to avoid unintended allocations. After some analyzes, it was concluded that for the case of the EventTiming, SubTaskAttribution, and TimeClamper classes, they make sense to use USING_FAST_MALLOC because they have been used with smart pointers. Bug: 919389 Change-Id: Ib8cddb4c1e4db37b6542bfabae7a13cc4a6d5749 Reviewed-on: https://chromium-review.googlesource.com/c/1482250Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#634603}
-
Boris Sazonov authored
This CL fixes an issue introduced in https://crrev.com/c/1466744. SetUrlKeyedAnonymizedDataCollectionEnabled was using 'true' instead of 'enabled' parameter when calling UnifiedConsentService, making it impossible to disable UKM from SyncAndServicesPreferences. Bug: 933648 Change-Id: I30abdb2a65472357e5054e36e8338527390f8433 Reviewed-on: https://chromium-review.googlesource.com/c/1480005 Auto-Submit: Boris Sazonov <bsazonov@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#634602}
-
Christos Froussios authored
This reverts commit 8f219b08. Reason for revert: broke base_unittests on win-asan First failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/win-asan/3559 Original change's description: > [Sampling profiler] Make ModuleCache::Module a reference type > > Changes ModuleCache::Module from a value type to a reference type, > with ModuleCache maintaining ownership of the Module. ModuleCache needs > to own its Modules to properly support Windows, which reference counts > its modules. > > ModuleCache is retained as a struct to minimize the size of this change, > but will be changed to a class in a later CL. > > Bug: 931418 > Change-Id: Ifa5bb0e763de14d91c1663ba01aeb3bab09447be > Reviewed-on: https://chromium-review.googlesource.com/c/1477817 > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634408} TBR=wittman@chromium.org,alph@chromium.org,oysteine@chromium.org,charliea@chromium.org Change-Id: Iad9daf5933823b3139d4a81d5d2d6ba6b8e655f6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931418 Reviewed-on: https://chromium-review.googlesource.com/c/1482894 Commit-Queue: Christos Froussios <cfroussios@chromium.org> Reviewed-by:
-
Christos Froussios authored
This reverts commit 9de3faa3. Reason for revert: Prevents reverting https://chromium-review.googlesource.com/c/chromium/src/+/1477817 due to a merge conflict. This needs to be reverted before reverting the guilty CL. Original change's description: > [Sampling profiler] Move Windows module cache into ModuleCache > > Moves the parallel module caching implementation for Windows into > ModuleCache. This implementation will be merged with the existing module > caching implementation over the course of later refactoring CLs. > > Bug: 931418 > Change-Id: I65309bca1edc2675e7e5d74e0305bf5cfe017fd1 > Reviewed-on: https://chromium-review.googlesource.com/c/1478035 > Commit-Queue: Mike Wittman <wittman@chromium.org> > Reviewed-by: Alexei Filippov <alph@chromium.org> > Reviewed-by: Charlie Andrews <charliea@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634493} TBR=wittman@chromium.org,alph@chromium.org,charliea@chromium.org Change-Id: I081c040b0a187a0d955625a6a76f832ad3bb567e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 931418 Reviewed-on: https://chromium-review.googlesource.com/c/1482895Reviewed-by:
-
Allan Sandfeld Jensen authored
The fix was lost in refactoring that ended up duplicating the last_find_request_completed_with_no_matches_ member. BUG=669983 Change-Id: I09229496d183ef3f9b69c6089a6ac3ecd8b5ef82 Reviewed-on: https://chromium-review.googlesource.com/c/1477835Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Abhishek Bhardwaj authored
This reverts commit 91b547aa. The same functionality will be submitted in a separate CL that will re-suspend based on system wide wake locks and not just ARC++ wake locks. BUG=chromium:898297 TEST=ArcWakeLockBridgeTest unit tests. Change-Id: I626733d89dfa7aadeb620997091abd0a2f958c10 Reviewed-on: https://chromium-review.googlesource.com/c/1372333 Commit-Queue: Abhishek Bhardwaj <abhishekbh@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#634598}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4a8ea42840ca..4309189029fc Created with: gclient setdep -r src-internal@4309189029fc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iec08f54dfd6b736fdd6c4c3290a16e91363a8898 Reviewed-on: https://chromium-review.googlesource.com/c/1482617Reviewed-by:
-
Egor Pasko authored
In crrev.com/634314 I forgot to upload the last changes addressing the latest comments from perezju@. Transferring those tweaks into this followup change. Bug: 925453 Change-Id: If8293d9b63977082f645697bd8fb110fbaae5ceb Reviewed-on: https://chromium-review.googlesource.com/c/1481299Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#634596}
-
Christos Froussios authored
This reverts commit 21a4eef0. Reason for revert: ios_web_inttests is broken on ios-webview Example failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/ios-webview/6599 Original change's description: > [ios] Add FindInPageManager Inttests > > Creates FindInPageManagerTest to test FindInPageManager and FindInPageManagerDelegate. > > Bug: 919685 > Change-Id: Ia9b680582677f984dd9b775155f8f21b0285b768 > Reviewed-on: https://chromium-review.googlesource.com/c/1448912 > Commit-Queue: Chris Lu <thegreenfrog@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Mike Dougherty <michaeldo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634434} TBR=eugenebut@chromium.org,michaeldo@chromium.org,thegreenfrog@chromium.org Change-Id: I4c1829451a7e68e2fbde2a9e8badbfe644389048 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919685 Reviewed-on: https://chromium-review.googlesource.com/c/1482951Reviewed-by:
-
Daniel Bratell authored
https://chromium-review.googlesource.com/c/chromium/src/+/1474976 introduced a BstrToUTF8 which in jumbo builds collided with an existing (but different) BstrToUTF and broke Windows builds. This renames one of the conversions to "BstrToPrettyUTF8" since it not only converts but also makes the string readable for logs. If the methods had been indentical it would have been suitable to move them to content/browser/accessibility/accessibility_tree_formatter_utils_win.cc I think. TBR=dmazzoni@chromium.org,iapres@microsoft.com Bug: 928949 Change-Id: I33660b867e6a4bcabfd274ba976ef642dd65db3a Reviewed-on: https://chromium-review.googlesource.com/c/1482452Reviewed-by:
Daniel Bratell <bratell@opera.com> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#634594}
-
Christos Froussios authored
This reverts commit 76efdcf8. Reason for revert: Suspected of breaking FileSystemProviderApiTest.RemoveWatcher FileSystemProviderApiTest.AddWatcher in browser_tests on linux-chromeos-rel Example failure https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/20439 Original change's description: > Migrate file_system file manager APIs to UIThreadExtensionFunction. > > BUG=934541 > > Change-Id: Ibd06bda730bd10c270d187d83f68315159fa6a43 > Reviewed-on: https://chromium-review.googlesource.com/c/1482172 > Reviewed-by: Sam McNally <sammc@chromium.org> > Commit-Queue: Anand Mistry <amistry@chromium.org> > Cr-Commit-Position: refs/heads/master@{#634562} TBR=sammc@chromium.org,amistry@chromium.org Change-Id: I56ca79cb7a1d358539d31d3c1156859232e08ce3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 934541 Reviewed-on: https://chromium-review.googlesource.com/c/1482970Reviewed-by:
-
Oystein Eftevaag authored
Tracing clients like devtools will request trace events only for a specific label, like "traceEvents", and the expected output is then just a flat JSON list of corresponding events, with no extra metadata or data from other labels. R=ssid@chromium.org,eseckler@chromium.org Bug: 839084 Change-Id: I39774f9e8798baee64d4416eac2ba67cf734a3f8 Reviewed-on: https://chromium-review.googlesource.com/c/1481122Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#634592}
-
Robbie Gibson authored
Bug: 913958 Change-Id: I6c37831e3ed06d03a4eed468dc7da5f561c2897e Reviewed-on: https://chromium-review.googlesource.com/c/1474759Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#634591}
-
Sylvain Defresne authored
Change client code to work as if IdentityManager::GetPrimaryAccount where returning a CoreAccountInfo instead of an AccountInfo. Method will be updated in a followup CL. Bug: 926204 Change-Id: Id94473af07c7050ad813475ba045421c1f2c1a36 Reviewed-on: https://chromium-review.googlesource.com/c/1470700Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
