- 24 Apr, 2018 40 commits
-
-
https://webrtc.googlesource.com/src.git/+log/e987f2b76567..b04e5cae08b8 $ git log e987f2b76..b04e5cae0 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:835281 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibeab77c208c3cd82d21d932a61ae55fc97ea7c4d Reviewed-on: https://chromium-review.googlesource.com/1025397Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#553010}
-
John Budorick authored
Bug: 731978 Change-Id: I191bfcec4d626cc7c6174f8916edfedbbd1122dc Reviewed-on: https://chromium-review.googlesource.com/1025272Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#553009}
-
Xiaocheng Hu authored
VisibleUnitsLine uses RenderedPosition instances without using the bidi-related functionalities. Since RenderedPosition is a wrapper of InlineBoxPosition with bidi utility functions added, this patch changes VisibleUnitsLine to use InlineBoxPosition directly for simplicity. Bug: 822575 Change-Id: I158ddfb3dec1ead3f8b66e1255f3465f3f0353a2 Reviewed-on: https://chromium-review.googlesource.com/1024645Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#553008}
-
Kent Tamura authored
TBR=dcheng@chromium.org NOTRY=true Bug: 836090 Change-Id: I156e7f460eed823d2dfeb4fbd5298c62eddbff4d Reviewed-on: https://chromium-review.googlesource.com/1025591 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#553007}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib29c988fd4fc82de8d61ece772c98501c9c0905b Reviewed-on: https://chromium-review.googlesource.com/1025273Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#553006}
-
Sam McNally authored
PluginDocument uses a hard-coded background color; for a brief window between the plugin document loading and the mime handler loading (and replacing the background with its own content), that background color is visible, producing a background color flash during plugin loading. To avoid this, for plugins with fixed background colors (PDF and QO [QuickOffice]), use their background color for the plugin document. Bug: 819761 Change-Id: I38943d900073f7fb150476d9bf159a5e547804d1 Reviewed-on: https://chromium-review.googlesource.com/1023770Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#553005}
-
Joshua Bell authored
* Use range-based for loops * Use auto (sparingly) to replace ugly iterator naming * using instead of typedef * Trust RVO for returning temp vectors Change-Id: Ieb7fc93592624149991364205e933b6612dd8a0d Reviewed-on: https://chromium-review.googlesource.com/930140Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#553004}
-
Ned Nguyen authored
TBR=eyaich@chromium.org NOTRY=true # PRESUBMIT testing Bug: chromium:835295 Change-Id: I3f9af4e737fc3a9d7aa7f2bd47f84b1d3d5bad11 Reviewed-on: https://chromium-review.googlesource.com/1025263 Commit-Queue: Ned Nguyen <nednguyen@google.com> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#553003}
-
Dale Curtis authored
There's no gaurantee on what thread OnData() is called from and the way the thread checker is used ends up only checking OnData() instead of OnData() and OnSetFormat() since it always detaches in OnSetFormat. BUG=823403 TEST=none Change-Id: I5665ca4a2b5ffa8472404102d88dcf37604d83d2 Reviewed-on: https://chromium-review.googlesource.com/1022472Reviewed-by:
Henrik Grunell <grunell@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#553002}
-
Daniel Cheng authored
WebContentsImpl now tracks the last time it received an input event that could be considered user interaction. When the browser process receives a WebUI message that requires a user gesture, it checks the WebContents hosting the WebUI to make sure that the user recently interacted with it. This also cleans up a few incidental bits of code: - RenderWidgetHost no longer prefilters events before notifying the delegate. This exposed some broken event filtering, tracked at https://crbug.com/827659. - Since the delegate method no longer prefilters input events, RenderWidgetHostDelegate::OnUserInteraction() is now named RenderWidgetHostDelegate::DidReceiveInputEvent(). - The IPC message used to pass WebUI messages from the renderer to the browser sends the source URL. However, this requires trusting the untrustworthy renderer to not lie about the URL. Instead, just use GetLastCommittedURL(). Bug: 823864 Change-Id: I687776c8c7f7f93f78c968dd432b1674d65629c0 Reviewed-on: https://chromium-review.googlesource.com/1023174 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#553001}
-
Steven Holte authored
ukm::UkmRecorder::GetNewSourceID may return negative ids. Bug: 833028 Change-Id: If4f8c3668524baa791b9b3895f95f19d135664b3 Reviewed-on: https://chromium-review.googlesource.com/1020669 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Cr-Commit-Position: refs/heads/master@{#553000}
-
Xiaocheng Hu authored
ComputeInlineBoxPosition() handles after-BR positions by looking into the first leaf child of the next line, which crashes if the next line has no leaf child. This patch changes the function to iteratively check the succeeding lines until we find a line with leaf child, to stop the crash and make the behavior saner. Bug: 835779 Change-Id: Iafd04aaf467a8e53c92cb0d36ab291ff3627e67e Reviewed-on: https://chromium-review.googlesource.com/1024799Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#552999}
-
Jonathan Metzman authored
https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/ba2c1cd6f87a..fda403cf93ec $ git log ba2c1cd6f..fda403cf9 --date=short --no-merges --format='%ad %ae %s' 2018-04-23 morehouse [libFuzzer] Add feature to not use AFL's deferred forkserver. 2018-04-20 delcypher [LibFuzzer] Report when custom counters are available. 2018-04-20 delcypher [LibFuzzer] Try to unbreak the `FuzzerMutate.ShuffleBytes1` unit test. 2018-04-20 delcypher [LibFuzzer] Unbreak the `trace-malloc-unbalanced.test` when using Python 3. 2018-04-20 phosek [Fuzzer] Add a missing header in Fuchsia implementation 2018-04-19 phosek [Fuzzer] Make InterruptHandler non-blocking for Fuchsia 2018-04-13 phosek [Fuzzer] Avoid C++ compiler checks for fuzzer C++ library 2018-04-09 vitalybuka libFuzzer, OpenBSD support 2018-04-06 morehouse [libFuzzer] Print a correct error message when a directory can't be opened. 2018-03-20 mgrang Revert "[compiler-rt] Change std::sort to llvm::sort in response to r327219" 2018-03-20 mgrang [compiler-rt] Change std::sort to llvm::sort in response to r327219 2018-03-16 phosek [Fuzzer] Build the shared memory hooks for Fuchsia 2018-03-13 sylvestre fix some user facing typos / in the comments 2018-03-10 phosek [Fuzzer] When building for Fuchsia, add an explicit libc++ dependency 2018-03-07 phosek [Fuzzer] Avoid the unnecessary rebuild of the custom libc++ 2018-02-22 morehouse [libFuzzer] Include TEMP_MAX_LEN in Fuzzer::PrintStats. 2018-02-13 morehouse [libFuzzer] Set -experimental_len_control=1000 as default. 2018-02-07 phosek [Fuzzer] Use Zircon's public API on Fuchsia 2018-02-01 hahnfeld [CMake] Remove -stdlib= which is unused when passing -nostdinc++ 2018-01-30 phosek [fuzzer] Update and enable libFuzzer on Fuchsia 2018-01-30 morehouse [libFuzzer] Fix sizeof(ptr) bug. 2018-01-21 phosek Reland "[Fuzzer] Parametrize add_custom_libcxx" 2018-01-20 phosek Revert "[Fuzzer] Parametrize add_custom_libcxx" 2018-01-20 phosek [Fuzzer] Parametrize add_custom_libcxx 2018-01-17 phosek Reland "[libFuzzer] Support using libc++" 2018-01-17 phosek Revert "[libFuzzer] Support using libc++" 2018-01-17 phosek [libFuzzer] Support using libc++ 2018-01-12 kamil Switch from Bourne shell to simply base shell to build libfuzzer 2018-01-12 kamil lib Fuzzer FreeBSD support 2017-12-20 dor1s [libfuzzer] Fix UB when calculating Log(0) in StackDepthStepFunction(). Created with: roll-dep src/third_party/libFuzzer/src Change-Id: I91e676e96fe023ea6e6885488d0cd38b9ef8591a Reviewed-on: https://chromium-review.googlesource.com/1025312Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552998}
-
Timothy Loh authored
This patch removes a DCHECK in CrostiniRegistryService::GetRegistration that checks the id is a valid extension id. While app list ids are currently expected to be extension ids, this is incidental and it's better to not have more checks for this. Change-Id: I46c252c047780cafd5be7eb8cd4296fe0d01989f Reviewed-on: https://chromium-review.googlesource.com/1025331Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#552997}
-
Xiaocheng Hu authored
LayoutObjectFromPosition() is a hacky utility function to set |RenderedPosition::layout_object_| when |inline_box_| is nullptr. With previous refactoring, there is no usage of |layout_object_| when |inline_box_| is nullptr, so we no longer need to set a non-null |layout_object_| for null |inline_box_|. Hence, this patch removes the call sites in RenderedPosition. Note: the function cannot be removed because it is still indirectly called by AX via LayoutObjectContainsPosition(). A follow-up patch will move it to AX. Bug: 822575 Change-Id: I720193c9926212153c56552115b5be9619ea20bc Reviewed-on: https://chromium-review.googlesource.com/1025034Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#552996}
-
Jianzhou Feng authored
Set the VK Aura Window to be transparent. Otherwise WindowOcclusionTracker will set the Web Page Aura Window state to be occluded and user can not see the committed input texts after VK turns fullscreen. See conditions defined in VisibleWindowIsOpaque. Bug: 826617 Change-Id: Idd8c525f205e608fe53fb59f85d302175b7a6246 Reviewed-on: https://chromium-review.googlesource.com/1023380 Commit-Queue: Jianzhou Feng <jzfeng@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#552995}
-
Noel Gordon authored
Move private parts of the FileManagerBrowserTestBase API to the class private: area. Add TODO comments or for other work needed. Bug: 833834 Change-Id: I1070df30a09adbdec24dc6dfa4d0168777f92dca Reviewed-on: https://chromium-review.googlesource.com/1025432Reviewed-by:
Stuart Langley <slangley@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#552994}
-
Xianzhu Wang authored
With it we no longer need to save backface_hidden in PaintChunkProperties thus paint chunks can use RefCountedPropertyTreeState as their properties. Also make the flag tri-state to implement the current SPv1*'s behavior that we ignore backface visibility values on some non-plane-creating elements. The kInherited value means that the transform node doesn't create a new backface visibility context. For now only ObjectPaintProperties::Transform() will create a new backface visibility context (using kHidden or kVisible values of BackfaceVisibility). Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I89a1327a96b991b3c2e1714dad23390b20b1f4e3 Reviewed-on: https://chromium-review.googlesource.com/1014192 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#552993}
-
Xiaocheng Hu authored
SelectionMofidierWord uses RenderedPosition instances without using the bidi-related functionalities. Since RenderedPosition is a wrapper of InlineBoxPosition with bidi utility functions added, this patch changes SelectionModifierWord to use InlineBoxPosition directly for simplicity. Bug: 822575 Change-Id: I96d7294814e425fc17ae9d774b68019dca974400 Reviewed-on: https://chromium-review.googlesource.com/1025021Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#552992}
-
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:fuchsia_arm64_cast_audio;master.tryserver.chromium.linux:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: I790f32af9bc563089695e92d609298a1e1d11b23 Reviewed-on: https://chromium-review.googlesource.com/1025120Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552991}
-
rbpotter authored
Adds the "more settings" action link, and shows and hides sections based on the link and their availability. Note: This CL does not add the height animation used to show and hide sections in the existing UI. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I09ddc9239ad252e151f973a793d0f57884cba5e3 Reviewed-on: https://chromium-review.googlesource.com/1019571Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#552990}
-
David Valleau authored
GetPrinterInfo was omitting the autoconf field which was causing a "NOTREACHED" to be hit when attempting to edit an autoconf printer. This change adds this field and also moves the GetPrinterInfo function to be a free function in printer_translator so that it can be tested more easily. BUG=chromium:834911 R=michaelpg@chromium.org, skau@chromium.org Change-Id: I37145b71228afdeb6de9628365bf311d2e98b190 Reviewed-on: https://chromium-review.googlesource.com/1023118 Commit-Queue: David Valleau <valleau@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#552989}
-
Dmitry Gozman authored
Instead, we have a MainThreadFetchers() collection directly in ResourceFetcher. This also allows to remove singleton behavior from leak detector and migrate it to StrongBinding. Bug: none Change-Id: I9ae638c8feec9f4fab7275ec73c5c0f30c6fb008 Reviewed-on: https://chromium-review.googlesource.com/1014343Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552988}
-
James Zern authored
rolls up local cherry-picks and adds a few more sse4 optimizations for lossless Bug: 834150 Change-Id: Ic05c47407fa873b22744bb1af41729c076ee9ad2 Reviewed-on: https://chromium-review.googlesource.com/1018361 Commit-Queue: James Zern <jzern@google.com> Reviewed-by:
Urvang Joshi <urvang@chromium.org> Cr-Commit-Position: refs/heads/master@{#552987}
-
Malay Keshav authored
This patch replaces ui scales for zoom factors to allow the clients to compute the ideal content scale. This patch also adds more scale factor enums to aura shell interface. Bug: 835030,836054 Component: aura shell Change-Id: Id5abd8b2d572365e27f453efd53e1ad46d327424 Reviewed-on: https://chromium-review.googlesource.com/1024920 Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552986}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I31e4c60a1ab888d8e368b199694be93dcaf05914 Reviewed-on: https://chromium-review.googlesource.com/1025057Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#552985}
-
Chris Harrelson authored
Bug:826189 Change-Id: Iba551320694d12c63ed352e9cf55f19471a75f59 Reviewed-on: https://chromium-review.googlesource.com/1025219Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#552984}
-
https://pdfium.googlesource.com/pdfium.git/+log/4e4147eccd25..2dca1cbf5956 $ git log 4e4147ecc..2dca1cbf5 --date=short --no-merges --format='%ad %ae %s' 2018-04-23 dsinclair Cleanup CFX_XMLParser initialization 2018-04-23 rharrison Pre-allocate more string buffers in barcode code Created with: roll-dep src/third_party/pdfium BUG=chromium:834630 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: If2eb29c9bd23bb4d07f64549fcf72626d3c6bff6 Reviewed-on: https://chromium-review.googlesource.com/1025226 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552983}
-
Yoichi Osato authored
This patch fixes the regression that was introduced by crrev.com/c/890574 ([LayoutNG] Refactor RenderedPosition::ComputeCompositedSelection) We should consider text affinity so that we show selection handles at appropriate position. Bug: 815099 Change-Id: I7796933ee8cbcc70e80c9fa373aab9cc08a6f138 Reviewed-on: https://chromium-review.googlesource.com/1023358Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#552982}
-
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:fuchsia_arm64_cast_audio;master.tryserver.chromium.linux:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Change-Id: Ia577756f3468bbc975afb8b3ed1e91aaffe3b02b Reviewed-on: https://chromium-review.googlesource.com/1025266Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552981}
-
sczs authored
- Makes the VC conform to UISearchResultsUpdating and UISearchBarDelegate. - Migrates the filter and delete logic from the LegacyHistory implementation. - Removes isSearching property since we can directly ask the SearchController. Screenshots: https://drive.google.com/open?id=1fYgO7PiJ0tKZgAKXAnt2vzW7Exlcz0En https://drive.google.com/open?id=160AsFrm8Z71JUc5ADpvIsaT4YKYVigNd Bug: 805192 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I74f0465ee3aff13a4cbe3d72277e10c6d1f87b19 Reviewed-on: https://chromium-review.googlesource.com/1022529 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#552980}
-
Dominick Ng authored
BUG=782120,811578 Change-Id: I24d1129b61bf16b800331e1c512191bce529f5b1 Reviewed-on: https://chromium-review.googlesource.com/1020620 Commit-Queue: Patti <patricialor@chromium.org> Reviewed-by:
Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#552979}
-
Scott Chen authored
This CL does a couple things to match design mock: - when not signed in, the account row should always show banner and text prompt (with regular font-size) on top of the account row. - when signed in, the turn-off button is not present within the sync-page. - use an optimized .svg for banner instead. Bug: 800972 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I70be2803e3abecbc5cf127b657740d793bc0db55 Reviewed-on: https://chromium-review.googlesource.com/986983 Commit-Queue: Scott Chen <scottchen@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#552978}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6267b449..8fecf0ef Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ia901a5cd2f18672b9acbeae97bb02e77ff9ab2c7 Reviewed-on: https://chromium-review.googlesource.com/1024811Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#552977}
-
siyua authored
Right now the autofill upstream save credit card promp explanation is "save this card". To clarify what is actually being saved, we would like to change it to "save your card and billing address" Bug: b/78175540 Change-Id: I8169f48e9e83b0f5e3025b0effcb748ff6f82355 Reviewed-on: https://chromium-review.googlesource.com/1025114 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#552976}
-
Zhiling Huang authored
Bug: 790520 Change-Id: Ic4cbdc04d22f9d266022a734a0344c7816875912 Reviewed-on: https://chromium-review.googlesource.com/1025044Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Zhiling Huang <hzl@chromium.org> Cr-Commit-Position: refs/heads/master@{#552975}
-
Nick Harper authored
TBR=elawrence@chromium.org Change-Id: I904bb128c562a93c29e6c48104ebd498d354d398 Reviewed-on: https://chromium-review.googlesource.com/1024726Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#552974}
-
Adam Rice authored
WebSocketEndpointLockManager has a comment about being thread-incompatible. This was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1009962, so the comment no longer applies. Remove it. BUG=450518 Change-Id: I4753ea735842cbe92402afc954a24bb380141260 Reviewed-on: https://chromium-review.googlesource.com/1023573Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#552973}
-
Xiaohui Chen authored
Test: build locally with upreved libassistant Bug: None Change-Id: I3db67f5a77824fcf0831447f353baba6167b0801 Reviewed-on: https://chromium-review.googlesource.com/1025268Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#552972}
-
Xi Cheng authored
This is a reland of 850001f3, which caused a pre-submit deadlock for chrome/browser/notifications/OWNERS. This is now safe to land as the following CL has been landed: https://chromium-review.googlesource.com/c/chromium/src/+/1024633 Original change's description: > Move notification_helper/ to chrome/notification_helper/ > > ... plus all the necessary code migration. A follow-up CL will be used > to update relevant comments. > > Bug: 734095 > Change-Id: I8516c750518e10a366bdc1496e75a3c2f4f0898b > Reviewed-on: https://chromium-review.googlesource.com/1022957 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Commit-Queue: Xi Cheng <chengx@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552762} Bug: 734095 Change-Id: Id4e0818d7e3ea2b0ea7633e883bc5cea42705167 Reviewed-on: https://chromium-review.googlesource.com/1024744 Commit-Queue: Xi Cheng <chengx@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#552971}
-