Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 17 Apr, 2013 38 commits
  3. 16 Apr, 2013 2 commits
    • tonyg@chromium.org's avatar
      Revert 194475 "Revert 194260 "Revert 194220 "[Telemetry] Make pa..." · fe07dda9
      tonyg@chromium.org authored 
      Still hanging on the bots

> Revert 194260 "Revert 194220 "[Telemetry] Make page cyclers more..."
> 
> Re-landing. Should work now that a race has been fixed by r194470.
> 
> > Revert 194220 "[Telemetry] Make page cyclers more telemetric."
> > 
> > Caused page cycler to hang on bots.
> > 
> > > [Telemetry] Make page cyclers more telemetric.
> > > 
> > > This causes the page cyclers to use page_sets instead of just navigating to the
> > > start page and letting the pages cycle themselves. This means we'll be using
> > > Telemetry "properly" which will allow us to record new page sets to update the
> > > page cyclers and it means that page cycler page sets are interchangeable with
> > > other benchmarks.
> > > 
> > > The page cyclers still measure the same thing as they measured previously: the
> > > time to load the page and perform a layout. However, they measure it differently
> > > now. Instead of setting a new Date().getTime() in the cookie immediately before
> > > navigating and then grabbing the finish Date in the onload handler, this now
> > > just grabs performance.now() in the onload handler. This returns the number of
> > > milliseconds since navigationStart where navigation start is the same as the
> > > immediately before navigation time marked before. I've verified locally that the
> > > times reported are consistent, and will monitor the bots to verify.
> > > 
> > > This involved moving the serving_dirs property up from the page to the page_set.
> > > 
> > > BUG=None
> > > TEST=All page cyclers on linux and morejs on windows
> > > NOTRY=True
> > > 
> > > Review URL: https://codereview.chromium.org/13817009
> > 
> > TBR=tonyg@chromium.org
> > 
> > Review URL: https://codereview.chromium.org/14048008
> 
> TBR=tonyg@chromium.org
> 
> Review URL: https://codereview.chromium.org/14119007

TBR=tonyg@chromium.org

Review URL: https://codereview.chromium.org/14222013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194489 0039d316-1c4b-4281-b951-d872f2087c98
      fe07dda9
    • jamiewalch@chromium.org's avatar
      Fixed missing CONNECTED state transition. · 668a7901
      jamiewalch@chromium.org authored 
      Previously, the state stansition was CONNECTING->CONNECTED, but r194079 introduced the AUTHENTICATED state without updating the expectation in ConnectionToHost::NotifyIfChannelsReady

BUG=231997

Review URL: https://codereview.chromium.org/14308012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@194488 0039d316-1c4b-4281-b951-d872f2087c98
      668a7901