- 25 Jul, 2014 40 commits
-
-
thestig@chromium.org authored
BUG=349436 Review URL: https://codereview.chromium.org/399593003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285686 0039d316-1c4b-4281-b951-d872f2087c98
-
tdresser@chromium.org authored
Previously we were using real time for event timestamps. Switch to using fake timestamps. BUG=396387 Review URL: https://codereview.chromium.org/415043005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285685 0039d316-1c4b-4281-b951-d872f2087c98
-
holte@chromium.org authored
BUG=372911 Review URL: https://codereview.chromium.org/290103005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285684 0039d316-1c4b-4281-b951-d872f2087c98
-
bartfab@chromium.org authored
This is a fix for a regression introduced by CL 358183004. On desktop, small avatar images should not be centered but stretched to fill the entire available space of 180px x 180px. BUG=214904, 241790 TEST=Manual Review URL: https://codereview.chromium.org/396193002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285683 0039d316-1c4b-4281-b951-d872f2087c98
-
vasilii@chromium.org authored
It's confusing because it prevents the bubble activation. As a side effect on Windows the bubble doesn't get LBUTTON_DOWN messages. The reason for that is in HWNDMessageHandler::OnMouseActivate(). It asks the bubble if it can be activated. It answers "no" due to implementation in BubbleDelegateView::CanActivate(). Windows gets MA_NOACTIVATEANDEAT and MouseDown event isn't dispatched. This is definitely unexpected. The bubbles which indeed always inactive should use set_can_activate(false) at construction time. The bubbles which can be active but created without focus by default should use ShowInactive() instead. BUG=392734 Review URL: https://codereview.chromium.org/413433002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285682 0039d316-1c4b-4281-b951-d872f2087c98
-
qyearsley@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/420583002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285681 0039d316-1c4b-4281-b951-d872f2087c98
-
holte@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/419143002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285680 0039d316-1c4b-4281-b951-d872f2087c98
-
qyearsley@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/413363003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285679 0039d316-1c4b-4281-b951-d872f2087c98
-
davidben@chromium.org authored
BoringSSL does not support AES-192. No current consumer uses AES-192, so remove the test which asserts it works. This fixes crypto_unittests in the Mac OpenSSL port. Blacklist AES-192 in the NSS implementation so that we do not accidentally grow a new dependency on it. BUG=338885 Review URL: https://codereview.chromium.org/420883003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285678 0039d316-1c4b-4281-b951-d872f2087c98
-
bradnelson@google.com authored
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3362 R=binji@chromium.org TEST=local Review URL: https://codereview.chromium.org/417323002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285677 0039d316-1c4b-4281-b951-d872f2087c98
-
hwennborg@google.com authored
They were previously enabled in shared_library builds for historical reasons. Turning them off makes things nice and consistent across all build types, and helps the Windows Clang build, which currently doesn't support exceptions. Previous attemps failed due to: - mojo_public_environment_unittests unreachable code warning in DrMemory shared_library Release builds (crbug.com/397465) Fixed in Chromium r285674. - chrome_elf_unittests on x64 (crbug.com/396244) Fixed in Chromium r285377. - blink_platform_unittests:DateTimeFormatTest.CommonPattern et al. Fixed in Blink r176189 BUG=82385 TBR=thakis Review URL: https://codereview.chromium.org/419973003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285676 0039d316-1c4b-4281-b951-d872f2087c98
-
mpearson@chromium.org authored
Causes compile failures on official builders: http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20Win/builds/25600 http://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/70014 FAILED: ninja -t msvc -e environment.x86 -- c:\b\build\goma/gomacc "c:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64_x86\cl.exe" /nologo /showIncludes /FC @obj\chrome\browser\profile_resetter\browser_0.automatic_profile_resetter.obj.rsp /c ..\..\chrome\browser\profile_resetter\automatic_profile_resetter.cc /Foobj\chrome\browser\profile_resetter\browser_0.automatic_profile_resetter.obj /Fdobj\chrome\browser_0.cc.pdb c:\b\build\slave\google-chrome-rel-win\build\src\chrome\browser\profile_resetter\automatic_profile_resetter.cc(109) :error C2039: 'GetVariationParams' : is not a member of 'chrome_variations' c:\b\build\slave\google-chrome-rel-win\build\src\chrome\browser\profile_resetter\automatic_profile_resetter.cc(109) :error C3861: 'GetVariationParams': identifier not found ninja: build stopped: subcommand failed. FAILED: /b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/profile_resetter/browser.automatic_profile_resetter.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DGOOGLE_CHROME_BUILD -DCR_CLANG_REVISION=209387 -DENABLE_RLZ -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_ASH=1 -DUSE_PANGO=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_X11=1 -DUSE_XI2_MT=2 -DIMAGE_LOADER_EXTENSION=1 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DUSE_PROPRIETARY_CODECS -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_PROD_WALLET_SERVICE=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DCLD2_DATA_SOURCE=static -DCLD_DATA_FROM_STATIC -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DNACL_WINDOWS=0 -DNACL_LINUX=1 -DNACL_OSX=0 -DNACL_ANDROID=0 -DNACL_TARGET_SUBARCH=64 -DNACL_TARGET_ARCH=x86 -DNACL_BUILD_SUBARCH=64 -DNACL_BUILD_ARCH=x86 -DFULL_SAFE_BROWSING -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL -DLIBPEERCONNECTION_LIB=1 -DUSE_BRLAPI -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DAUTOFILL_ENABLE_SYNC -DPASSWORD_MANAGER_ENABLE_SYNC '-DPRECACHE_CONFIG_SETTINGS_URL="http://www.gstatic.com/chrome/wifiprefetch/precache_config"' '-DPRECACHE_MANIFEST_URL_PREFIX="http://www.gstatic.com/chrome/wifiprefetch/precache_manifest_"' -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_PICTURE_CLONE -DSK_SUPPORT_LEGACY_GETDEVICE -DSK_IGNORE_ETC1_SUPPORT -DSK_IGNORE_GPU_DITHER -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DLINUX -DPOSIX -DCHROMEOS -DLIBXML_STATIC '-DI18N_ADDRESS_VALIDATION_DATA_URL="https://i18napis.appspot.com/ssl-aggregate-address/"' -DI18N_ADDRESSINPUT_USE_BASICTYPES_OVERRIDE=1 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_LINUX -DWEBRTC_POSIX -DHUNSPELL_STATIC -DHUNSPELL_CHROME_CLIENT -DUSE_HUNSPELL -DRLZ_NETWORK_IMPLEMENTATION_CHROME_NET -DUSE_NSS=1 -DOS_CHROMEOS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DOFFICIAL_BUILD -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../.. -Iobj/chrome/browser.gen -Iobj/chrome/browser.gen/chrome -I../../skia/config -I../../third_party/khronos -I../../gpu -I../../third_party/WebKit/Source -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -I../../third_party/dom_distiller_js/package/proto_gen -Igen/chrome -Igen/components/strings -I../../third_party/WebKit -I../../net/third_party/nss/ssl -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/cacheinvalidation/google/cacheinvalidation -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../third_party/webrtc/overrides -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc -I../../third_party/libxml/linux/include -I../../third_party/libxml/src/include -I../../third_party/zlib -Igen/ui/resources -Igen/ui/strings -I../../third_party/re2 -I../../third_party/leveldatabase/src/include -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase -I../../third_party/libaddressinput/chromium/override -I../../third_party/libaddressinput/src/cpp/include -Igen/third_party/libaddressinput/ -I../../third_party/libyuv/include -I../../third_party/libyuv -I../../third_party/npapi -I../../third_party/npapi/bindings -Igen/ui/gl -I../../third_party/mesa/src/include -I../../v8/include -Igen/webkit -Igen/policy -Igen/ui/chromeos/resources -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-reserved-user-defined-literal -Wno-deprecated-register -Xclang -load -Xclang /b/build/slave/google-chrome-rel-chromeos/build/src/tools/clang/scripts/../../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.so -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -g -B/b/build/slave/google-chrome-rel-chromeos/build/src/third_party/binutils/Linux_x64/Release/bin -pthread -I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include -I/usr/include/nss -I/usr/include/nspr -Wno-header-guard -I/usr/include/dbus-1.0 -I/usr/lib/x86_64-linux-gnu/dbus-1.0/include -Wexit-time-destructors -m64 -march=x86-64 -O2 -fdata-sections -ffunction-sections -fno-slp-vectorize -fno-unwind-tables -fno-asynchronous-unwind-tables -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare -std=gnu++11 -c ../../chrome/browser/profile_resetter/automatic_profile_resetter.cc -o obj/chrome/browser/profile_resetter/browser.automatic_profile_resetter.o ../../chrome/browser/profile_resetter/automatic_profile_resetter.cc:109:3:error: no member named 'GetVariationParams' in namespace 'chrome_variations'; did you mean 'variations::GetVariationParams'? chrome_variations::GetVariationParams(kAutomaticProfileResetStudyName, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ variations::GetVariationParams ../../components/variations/variations_associated_data.h:110:6: note: 'variations::GetVariationParams' declared here bool GetVariationParams(const std::string& trial_name, ^ 1 error generated. ninja: build stopped: subcommand failed. > Move variations component code to variations namespace. > > BUG=284540 > TBR=sky@chromium.org, mathp@chromium.org > > Review URL: https://codereview.chromium.org/412943002 TBR=asvitkine@chromium.org Review URL: https://codereview.chromium.org/416333008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285675 0039d316-1c4b-4281-b951-d872f2087c98
-
hwennborg@google.com authored
The test would fail to compile (warning treated as error) in certain build configurations (GYP_DEFINES=component=shared_library build_for_tool=drmemory, with exceptions disabled). Instead of having NotCalled() call abort(), which doesn't return, just use a variable to check that the function doesn't get called. BUG=397465 R=viettrungluu@chromium.org Review URL: https://codereview.chromium.org/419933002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285674 0039d316-1c4b-4281-b951-d872f2087c98
-
mpearson@chromium.org authored
Revert of mojo: fix little bug in DynamicServiceLoader/Runner (https://codereview.chromium.org/414173004/) Reason for revert: One of the test this adds fails on linux clang bog: http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/62568 Original issue's description: > mojo: fix little bug in DynamicServiceLoader/Runner > > If the Runner wasn't actually told to Start(), the DelegateSimpleThread would > DCHECK for not having been Started. This patch makes it so we don't allocate > a DST unless we need to. > > Also adds basic unittest files for DynamicServiceLoader and Runner. > > BUG= > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285650 TBR=darin@chromium.org,tim@chromium.org NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/419683006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285673 0039d316-1c4b-4281-b951-d872f2087c98
-
jrummell@chromium.org authored
The EME spec is now using ArrayBuffer/ArrayBufferView instead of Uint8Array as the type for data buffers. Calls from JavaScript aren't affected as Uint8Array is an ArrayBufferView. However, "message" events now pass back an ArrayBuffer and the tests expect Uint8Array. This converts the returned message to a Uint8Array to keep the code working. This change works with and without the upcoming changes. If Uint8Array is passed back, then the result is that another copy of the view is made. BUG=358271 TEST=encrypted media browser_tests pass Review URL: https://codereview.chromium.org/405733003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285672 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285671 0039d316-1c4b-4281-b951-d872f2087c98
-
rsesek@chromium.org authored
BUG=393594 TBR=mark@chromium.org Review URL: https://codereview.chromium.org/420723006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285670 0039d316-1c4b-4281-b951-d872f2087c98
-
lucinka.brozkova@gmail.com authored
This CL turns const by value return values into const by ref. Replacing const value by a const ref when a member variable is returned is safe, because the member variable will live at least as long as the temporary object returned now. It can also be more efficient, because returning a ref can spare copying. BUG=393155 Review URL: https://codereview.chromium.org/420603008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285669 0039d316-1c4b-4281-b951-d872f2087c98
-
darin@chromium.org authored
(Also fixes a regression in the wget app.) Review URL: https://codereview.chromium.org/414633003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285668 0039d316-1c4b-4281-b951-d872f2087c98
-
zty@chromium.org authored
BUG=329102 R=qyearsley@chromium.org Review URL: https://codereview.chromium.org/410033002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285667 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
This includes some changes to the Fake Shill implementation to support enabling sim lock to test the UI. (Was also tested using pseudomodem). BUG=279351 For c/b/resources TBR=xiyuan@chromium.org Review URL: https://codereview.chromium.org/399303003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285666 0039d316-1c4b-4281-b951-d872f2087c98
-
grt@chromium.org authored
app_host.exe was removed in r220555. This change removes some dead code that was left behind. Specifically: - chrome_launcher_support no longer exposes any methods related to the AppHost. - Chrome's uninstall prompt no longer has a special case to handle suppressing the "delete your profile" checkbox. - Chrome and its installer no longer have a dependency on launcher_support. - The installer no longer supports installing items from the webstore. - GetUntrustedDataValue no longer has consumers and is gone. BUG=297647 R=benwells@chromium.org,huangs@chromium.org,gab@chromium.org Review URL: https://codereview.chromium.org/422453004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285661 0039d316-1c4b-4281-b951-d872f2087c98
-
jiayl@chromium.org authored
TBR=pfeldman@chromium.org for content/shell/renderer/test_runner BUG=https://code.google.com/p/webrtc/issues/detail?id=3282 Review URL: https://codereview.chromium.org/396193005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285659 0039d316-1c4b-4281-b951-d872f2087c98
-
pkotwicz@chromium.org authored
BUG=382126 TEST=Manual, see instructions below Test steps: 1) Run Chrome in the Gnome Classic window manager (this is very important) 2) Maximize a browser window 3) Fullscreen the browser window via F11 4) Press escape to exit fullscreen 5) Unmaximize the window 6) Verify that the window can be resized Review URL: https://codereview.chromium.org/405743004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285658 0039d316-1c4b-4281-b951-d872f2087c98
-
asvitkine@chromium.org authored
BUG=284540 TBR=sky@chromium.org, mathp@chromium.org Review URL: https://codereview.chromium.org/412943002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285657 0039d316-1c4b-4281-b951-d872f2087c98
-
ajuma@chromium.org authored
Layers with a scale animation are currently rasterized at the animation's maximum scale when the animation starts. However, for large layers, this approach consumes an excessive amount of memory. This CL restricts the 'rasterize at maximum scale' approach to layers that grow no larger than the viewport at maximum scale. BUG=395760 Review URL: https://codereview.chromium.org/420523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285656 0039d316-1c4b-4281-b951-d872f2087c98
-
dfalcantara@chromium.org authored
BUG=385485,396884,396806 Review URL: https://codereview.chromium.org/418223005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285655 0039d316-1c4b-4281-b951-d872f2087c98
-
courage@chromium.org authored
Previously login access token requests were always made for the primary account ID of the profile. Starting in r275173, the ID is computed and saved in a member variable. This change makes sure the member is updated after the user signs in, which allows getAuthToken requests that trigger a sign-in to succeed. BUG=396883 Review URL: https://codereview.chromium.org/418393003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285654 0039d316-1c4b-4281-b951-d872f2087c98
-
jkarlin@chromium.org authored
To disable prefetch with Finch use a new experiment named Prefetch/ExperimentDisabled. BUG=327419 Review URL: https://codereview.chromium.org/385173002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285652 0039d316-1c4b-4281-b951-d872f2087c98
-
kelvinp@chromium.org authored
After this CL, SetupTestForMe2Me will ensure that the host is up and running with the pin specified from the command line argument --me2me-pin on every Me2Me test run. Review URL: https://codereview.chromium.org/398823005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285651 0039d316-1c4b-4281-b951-d872f2087c98
-
tim@chromium.org authored
If the Runner wasn't actually told to Start(), the DelegateSimpleThread would DCHECK for not having been Started. This patch makes it so we don't allocate a DST unless we need to. Also adds basic unittest files for DynamicServiceLoader and Runner. BUG= Review URL: https://codereview.chromium.org/414173004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285650 0039d316-1c4b-4281-b951-d872f2087c98
-
robliao@chromium.org authored
The chrome.notifications.update will reasonably not update notifications that do not exist. Previously, the console would log that the update failed to occur since there was no update. This gives the wrong impression of an error. This delta relaxes the wording to "not updated". BUG=396881 Review URL: https://codereview.chromium.org/416913002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285649 0039d316-1c4b-4281-b951-d872f2087c98
-
noamsml@chromium.org authored
1. Update GCDPrivate to be on dev mode, with whitelist for approved extensions 2. Fix the tests to match BUG=394124 Review URL: https://codereview.chromium.org/411143006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285648 0039d316-1c4b-4281-b951-d872f2087c98
-
dtrainor@chromium.org authored
BUG=394898 R=aurimas@chromium.org Review URL: https://codereview.chromium.org/412403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285647 0039d316-1c4b-4281-b951-d872f2087c98
-
jchaffraix@chromium.org authored
This was seen with dgozman who agreed to look into the failure (probably related to one of their change). BUG=397648 TBR=dgozman@chromium.org NOTRY=True Review URL: https://codereview.chromium.org/417123004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285646 0039d316-1c4b-4281-b951-d872f2087c98
-
vmpstr@chromium.org authored
This patch adds construct as well as construct and iterate perftests for the eviction tile priority queue. Initial runs (from my macbook): [ RUN ] TileManagerPerfTest.EvictionTileQueueConstruct *RESULT tile_manager_eviction_tile_queue_construct: 2= 412610.25 runs/s *RESULT tile_manager_eviction_tile_queue_construct: 10= 48552.328125 runs/s *RESULT tile_manager_eviction_tile_queue_construct: 100= 1245.8426513671875 runs/s [ OK ] TileManagerPerfTest.EvictionTileQueueConstruct (6185 ms) [ RUN ] TileManagerPerfTest.EvictionTileQueueConstructAndIterate *RESULT tile_manager_eviction_tile_queue_construct_and_iterate: 2_16= 3109.413818359375 runs/s *RESULT tile_manager_eviction_tile_queue_construct_and_iterate: 2_32= 2810.639404296875 runs/s *RESULT tile_manager_eviction_tile_queue_construct_and_iterate: 2_64= 2365.239990234375 runs/s *RESULT tile_manager_eviction_tile_queue_construct_and_iterate: 2_128= 1793.8878173828125 runs/s [ OK ] TileManagerPerfTest.EvictionTileQueueConstructAndIterate (8358 ms) R=reveman Review URL: https://codereview.chromium.org/410523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285645 0039d316-1c4b-4281-b951-d872f2087c98
-
stevenjb@chromium.org authored
This fixes how we translate the Device properties to ONC instead of just copying the Shill properties. BUG=279351 Review URL: https://codereview.chromium.org/402953004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285642 0039d316-1c4b-4281-b951-d872f2087c98
-
vasilii@chromium.org authored
After the password bubble became focusless we need additional code to close it by clicking the "key" icon. BUG=394680 Review URL: https://codereview.chromium.org/394403003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285641 0039d316-1c4b-4281-b951-d872f2087c98
-
spang@chromium.org authored
BUG=none TBR=dnicoara, kpschoedel NOTRY=true Review URL: https://codereview.chromium.org/422533003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285640 0039d316-1c4b-4281-b951-d872f2087c98
-
qyearsley@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/418113003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@285639 0039d316-1c4b-4281-b951-d872f2087c98
-