- 11 Mar, 2020 40 commits
-
-
John Chen authored
While dispatching an event to a child frame, place a hold on the WebView of the child frame to prevent it from getting deallocated. Bug: chromedriver:3375 Change-Id: I0ff52f6476a2e6767d27c0755a012bdf16dc9c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097538Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#749276}
-
Alexander Cooper authored
https://crrev.com/c/2085847 began showing an appropriate string to users when they denied camera access after granting AR permissions; but missed a few other places to indicate to the user that additional permissions are missing. This change ensures that these warnings appear, similar to the behavior with the camera permission. Note that crrev.com/c/2087704 handles ensuring that the user is prompted for the OS permission when attempting to use the site permission. Bug: 1058055 Change-Id: I26f427c874100b4bfbe52925c3bcded2729591bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090499 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#749275}
-
Clark DuVall authored
The PermissionManagerFactory is kept in //chrome, and an equivalent will be added in //weblayer to initialize permission contexts. The map of permission contexts are now injected into the constructor of PermissionManager. Some unit tests were kept in //chrome which relate to chrome-specific logic in GetCanonicalOrigin(). Bug: 1025609 Change-Id: Id56c6233a65714cb5c68a13223bfc5020d9ac98a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095870 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#749274}
-
Misha Efimov authored
Bug: 1058889 Change-Id: Ie7a3b809c12fcf562332b8723231129fe282c2b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095335 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Auto-Submit: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#749273}
-
Ken Rockot authored
This is strictly a formatting change, generated by manually running yapf over the affected files. It's a precursor to a subsequent move and minor refactoring of this code, as modified files will always get yapf applied and that would otherwise create a lot of noise in the coming CLs. Bug: 1060467 Change-Id: I188ac6cc71fda2cd08a6f4695f67c5c0f04d2737 Tbr: oksamyt@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098265Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#749272}
-
Jeff Yoon authored
ios13-beta-sim has moved to Chromium and utilizes mb_config.pyl. Adding ios_use_goma_rbe=true there. Change-Id: I504bb005e77d7e1b4818e54179a1c46aee3389c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098331Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Commit-Queue: Jeff Yoon <jeffyoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#749271}
-
Frank Li authored
This CL contains MediaFoundationProtectionManager to be used by MediaFoundationRenderer. MediaFoundationProtectionManager implements IMFContentProtectionManager and ABI::Windows::Media::Protection::IMediaProtectionManager Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/Media/MFCdm/explainer.md Design Doc: https://docs.google.com/document/d/1kXMdmfsSKU3tcwTxG-wFU-MaEA6sN3by45PCGBV8zJU Bug: 999747 Change-Id: Ib6125ac6040798b44c3b10a40851eb852880798f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088682 Commit-Queue: Frank Li <frankli@microsoft.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#749270}
-
Weiliang Chen authored
SkiaOutputSUrface checks the OutputDevice implementation for whether it supports scheduling the primary plane as overlay. This is to match GLOutputSurface's behavior, where only the BufferQueue implementation would return true for IsDisplayedAsOverlay(). This also helps avoid the case where a Surfaceless GLSurface is created for SkiaOutputDeviceGL. R=kylechar Change-Id: Iadfce3551f90e2049db73ed33dfff6ad042c4ccf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095142Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#749269}
-
Rayan Kanso authored
Change-Id: Iab69731e7c7f13d792b64b0caf7e253417fb756c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097994 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#749268}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c095a02a0ee0..79bf811d23f5 git log c095a02a0ee0..79bf811d23f5 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 skyostil@google.com Merge "docs: Add initial documentation for the Client API" Created with: gclient setdep -r src/third_party/perfetto@79bf811d23f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id3c9a5d4d734fb439c50692bbb9047c4936a3078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097823Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749267}
-
Chris Palmer authored
Change-Id: If61501127fe7041b3a1194ef1aad8c56e6920de4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095407Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#749266}
-
Kai Ninomiya authored
https://chromium.googlesource.com/external/github.com/gpuweb/cts/+log/ec18cc3262922e7dcdbe70243c6f40606f979144..84ee597cdeae08bb26e578fc66a35bcf35f633f4 Change-Id: I5174877da818c6228b2bdaa5f06f0ab244251c77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092947 Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#749265}
-
Oksana Zhuravlova authored
This change: - implements the remote method invocation functionality of the WebView addJavascriptInterface API. - adds several browser tests to verify basic cases. When a method is called on the exposed object, the renderer first looks it up in a cache. If not found, it asks the browser to confirm this method exists and adds it to the cache. Design doc: https://docs.google.com/document/d/1T8Zj_gZK7jHsy80Etk-Rw4hXMIW4QeaTtXjy5ZKP3X0/ Bug: 794320 Change-Id: I3838bde1011cc63d4a4b55eedb7f6d27c946be6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023187Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#749264}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/6a14c8da7c4d..ba26b2b503a6 git log 6a14c8da7c4d..ba26b2b503a6 --date=short --first-parent --format='%ad %ae %s' 2020-03-11 tvanderlippe@chromium.org Run ESLint on the scripts directory 2020-03-11 sigurds@chromium.org Implement CookieReference and CookieReference revealer Created with: gclient setdep -r src/third_party/devtools-frontend/src@ba26b2b503a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1060505 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iae0ce5362be31bffc02373fbe0148ac58435a87d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097822Reviewed-by:
-
Alexander Surkov authored
Bug: 1060615 Change-Id: I7219f1b5f0c83c243bf6ccbd407b55ed93960b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098259Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#749262}
-
Junbo Ke authored
retrieved synchronously. Bug: b/150888532 Test: CQ Change-Id: I82f63be44fcb832a5a4ed5c0eccd36211eb15313 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097539Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Junbo Ke <juke@chromium.org> Cr-Commit-Position: refs/heads/master@{#749261}
-
Maksim Ivanov authored
This CL adds unit tests for the C++ code that generates human-readable error messages for the smart card PIN errors. Bug: 1001288 Change-Id: I9ed50272b78237f237e8a6c7834986f7698def81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095014Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#749260}
-
Charlie Hu authored
Previously width attribute on iframe is changed from 440 to 500, but the test expectation png files are not updated in CL(https://chromium-review.googlesource.com/c/chromium/src/+/1531354). This CL updates the expectation files. Bug: 922951 Change-Id: Ibea9a655750d0851e576be67872f6a6d83cea25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090612 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#749259}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6ad2153566cc..72abb04e33fa Created with: gclient setdep -r src-internal@72abb04e33fa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: If91a95d204649bbfdace60368b57738e87d640a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098240Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#749258}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/4d3f93f34813..8f47b27268ea git log 4d3f93f34813..8f47b27268ea --date=short --first-parent --format='%ad %ae %s' 2020-03-11 phoglund@webrtc.org Partial revert: "Hand protos directly to histograms and fix summary." 2020-03-11 titovartem@google.com Fix: don't use recovered packets in UlpFEC recovery Created with: gclient setdep -r src/third_party/webrtc@8f47b27268ea If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029452 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I333357a9fc34df424a61d8ec5a616434b55f5c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098243Reviewed-by:
-
Vincent Boisselle authored
Don't test the other platforms because they now enable the experimented features by default. Change-Id: I08fb048e73d4508a4e9155cb1d5e6307db83c47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095370 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#749256}
-
Joshua Pawlicki authored
TBR=kmilka@chromium.org Bug: 1060667 Change-Id: I40290bd8030770f04258072de9e062813dd663a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097826Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#749255}
-
Guido Urdaneta authored
Switch the additional_data_vector_ field to WTF::Vector for better compliance with Blink practices. While this implies a copy of the data, this vector is normally small and we plan to change it to a structured format in the near future. Bug: 1059912 Change-Id: I0fdeb5fefd4aac9c85712bf246866e5826b5f2c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094311 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#749254}
-
Richard Knoll authored
Shows the current progress while downloading an image received via remote copy. The notification will be updated during the download and at the end to show the image. Implemented behind the #remote-copy-progress-notification flag. Bug: 1059290 Change-Id: Iee18f7d1781eaa4d15f21f78453f706d2b897dc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089685 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#749253}
-
Charlie Hu authored
The test was testing UnsizedMedia feature working properly when images got resized on screen after they initially got loaded. Initially the test worked fine, but after certain optimization made by rendering team, window.onload no longer guarantees that images are painted on the screen. This CL introduces a timeout to force the script to execute after initial images are painted on screen first. Bug: 591099 Change-Id: I1a11e1b5b8c87ba2bd3d5c64c9d5477a73ee0d5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090457 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
-
Amr Aboelkher authored
This CL is doing the following: - Rename DeviceLoginScreenChromeVariations into DeviceChromeVariations and that'll be fine, as that hasn't been done yet from server side - Setting ChromeVariations only for any platform other than ChromeOS and Android - Adding a new pref kDeviceVariationsRestrictionsByPolicy which is writing its state in local state, and controlling the variations in ChromeOS -- That workaround is being used in order to retrieve the device policy value, on ChromeOS, and to update the actual value of kVariationsRestrictionsByPolicy. In order to be able to reflect that in the variations service according to the pref value. Bug: 1047683 Change-Id: I3a835ef4098ca26dfc791a3c66206afb2b63e1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2089737 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#749251}
-
Sammie Quon authored
As requested in [1]. Idea is make it less needed to code-search for examples. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2068305/10/ui/compositor/animation_metrics_recorder.h#16 Test: none Bug: 1051490 Change-Id: I4a8bb4bc04e8f745913f215952daab90a54deafc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097236 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#749250}
-
Andrew Grieve authored
Seems that some emulators require this even when just on Android P. Bug: 946194 Change-Id: Iad5811a54404bfcf46267d5c3f3a5f565f399ac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098236 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#749249}
-
Sam Bowen authored
This is a reland of d828e2eb * I added the BUILD dependency to the wrong target in the previous reland. It needed to be on generate_schema_org_code. https://crrev.com/c/2097359 Original change's description: > Reland: "Add validator for schema org entities and types in doc metadata mojo." > > " > * Add a validator that removes properties that are not the right type. > * Add double, time, and timedelta types in the document metadata mojo > structure. > * Use the new mojo types in document metadata extractor. > " > > This is a reland of https://crrev.com/c/2062907 which was reverted in > https://crrev.com/c/2095670. > > The substantial changes are two-fold: > (1) add build dep on base in schema_org_properties. This should fix the > try bot issue which was somehow skipped. > (2) Rebase on top of https://crrev.com/c/2073337 which was submitted and > contains some changes to the mojo structure. > > Change-Id: I7f47d74e8833f76d4077028eac0dcb43790a1d26 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097059 > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Becca Hughes <beccahughes@chromium.org> > Commit-Queue: Sam Bowen <sgbowen@google.com> > Cr-Commit-Position: refs/heads/master@{#748945} Change-Id: Ibc7124d5a779d663048315a2697c9c050c1c00c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097452Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sam Bowen <sgbowen@google.com> Cr-Commit-Position: refs/heads/master@{#749248}
-
Xi Han authored
Bug: 1056327 Change-Id: I490f176ae56d5fc08b76df0777e0d5af1529b0f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082317Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#749247}
-
Gang Wu authored
Like getCoercedText and getHTMLText in Clipboard.java, if another app did something incorrectly when they put content into the clipboard, getPrimaryClip may crash. For example, if the another app didn't set permissions correctly this may crash. There are also some devices where hasPrimaryClip returns true but calling getPrimaryClip causes an NPE. Bug: 1059946 Change-Id: Idf5d64f86f7d85cd2723aeac3a1d4868fb579317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097019 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#749246}
-
Mikhail Khokhlov authored
Change-Id: I007c0d8224522346d252f7703e78b6487a679d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096961Reviewed-by:
Stephen Nusko <nuskos@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#749245}
-
sauski authored
Given that individual navigations to various routes with settings are already logged via UMA, the additional UMA logging provided by the SettingsPageInteractions enum/histogram was of little value. Additionally supporting this logging required restrictive code on the site_settings_page. This CL deprecates the existing enum/historgram and replaces it with one focusing on interactions with elements that do not trigger a route change. Bug: 1059098 Change-Id: I9130836da821eae1aa0ac40ae0e96dcb4f398054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090795 Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#749244}
-
David Bokan authored
Bug: None Change-Id: I1bbe76e767d532ceeb6b94d0dc1608a63fcbe618 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098176Reviewed-by:
-
W. James MacLean authored
These tests are failing when features::kOutOfBlinkCors is not turned on, but the feature is turned on by default, so we just early-out of these tests on bots that have the feature turned off. Bug: 1060046 Change-Id: I1ef843d1b0cde163cf38b7e704a78c308251470d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2098105Reviewed-by:
Daniel Vogelheim <vogelheim@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#749242}
-
Mitchel Herman authored
Change-Id: I7b9300b0260cc734d955a59c11df8551fbfb1d04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080865 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#749241}
-
Sean O'Brien authored
ChromeOS devices currently do not have styluses with buttons, and there is no support for handling stylus button events. In the long term, we will want to make stylus button clicks act as a right mouse click button (open context menu). In the short term, we want to use the stylus button to accelerate the long press gesture. If the user has the stylus button pressed when touching the screen, or presses it before the long press timeout, generate a long press gesture. Bug: b:139781900 Change-Id: I3869989f3f731de18ecec480577eb209c08b9c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076663Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
-
Joshua Pawlicki authored
This is a reland of 9fcd7541 Original change's description: > Revert "Cros: Report metrics for the animation of traslucent background" > > This reverts commit 64465df5. > > Reason for revert: Speculative revert to fix use-of-uninitialized member flake / crash; see https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8886180914914709040/+/steps/browser_tests/0/logs/Deterministic_failure:_PublicSessionOobeTestImpl__x2f_PublicSessionOobeTest.NoTermsOfService__x2f_4__status_CRASH_/0 > > ==18002==WARNING: MemorySanitizer: use-of-uninitialized-value > #0 0x5640af44e1e6 in ui::AnimationMetricsRecorder::OnAnimationEnd(base::Optional<int>, float) ./../../ui/compositor/animation_metrics_recorder.cc:64:14 > #1 0x5640af4e4b37 in ui::LayerAnimationElement::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_element.cc:669:34 > #2 0x5640af4fbb95 in ui::LayerAnimationSequence::ProgressToEnd(ui::LayerAnimationDelegate*) ./../../ui/compositor/layer_animation_sequence.cc:147:35 > #3 0x5640af513c54 in ProgressAnimationToEnd ./../../ui/compositor/layer_animator.cc:476:13 > #4 0x5640af513c54 in ui::LayerAnimator::FinishAnimation(ui::LayerAnimationSequence*, bool) ./../../ui/compositor/layer_animator.cc:622:5 > #5 0x5640af519c6d in ui::LayerAnimator::StopAnimatingInternal(bool) ./../../ui/compositor/layer_animator.cc:533:5 > #6 0x5640af489c93 in StopAnimating ./../../ui/compositor/layer_animator.h:198:26 > #7 0x5640af489c93 in ui::Layer::CompleteAllAnimations() ./../../ui/compositor/layer.cc:1128:12 > #8 0x5640af3c6ff1 in aura::Window::~Window() ./../../ui/aura/window.cc:124:14 > #9 0x5640af3ca7ac in aura::Window::~Window() ./../../ui/aura/window.cc:119:19 > #10 0x5640a9a51655 in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:0:0 > #11 0x5640a9a51b9c in views::NativeWidgetAura::~NativeWidgetAura() ./../../ui/views/widget/native_widget_aura.cc:1054:39 > #12 0x5640a99ba714 in views::Widget::~Widget() ./../../ui/views/widget/widget.cc:185:5 > #13 0x5640b72c7e39 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1 > #14 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33 > #15 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #16 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #17 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19 > #18 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11 > #19 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19 > #20 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3 > #21 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17 > #22 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #23 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #24 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19 > #25 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29 > #26 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32 > #27 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13 > #28 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17 > #29 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16 > #30 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 > #31 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 > #32 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 > #33 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29 > #34 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #35 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 > #36 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20 > #37 0x5640960c6b50 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0 > #38 0x5640960c6b50 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2663:3 > #39 0x5640960cb24d in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2845:11 > #40 0x5640960cd5f9 in testing::TestSuite::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2977:28 > #41 0x564096106f6e in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5518:44 > #42 0x5640961053fd in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest-internal-inl.h:0:10 > #43 0x5640961053fd in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:5105:10 > #44 0x5640a5902835 in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2472:46 > #45 0x5640a5902835 in base::TestSuite::Run() ./../../base/test/test_suite.cc:458:16 > #46 0x5640a5393dd1 in BrowserTestSuiteRunnerChromeOS::RunTestSuite(int, char**) ./../../chrome/test/base/browser_tests_main_chromeos.cc:37:23 > #47 0x5640a773a27e in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:375:31 > #48 0x5640a5394f45 in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:246:10 > #49 0x5640a5393bb8 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:52:10 > #50 0x7f194b36282f in __libc_start_main /build/glibc-LK5gWL/glibc-2.23/csu/../csu/libc-start.c:291:0 > #51 0x56408b4293c9 in _start ??:0:0 > > Uninitialized value was created by a heap deallocation > #0 0x56408b497790 in operator delete(void*) /b/s/w/ir/cache/builder/src/third_party/llvm/compiler-rt/lib/msan/msan_new_delete.cpp:74:44 > #1 0x5640b72c7d74 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #2 0x5640b72c7d74 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #3 0x5640b72c7d74 in ~unique_ptr ./../../buildtools/third_party/libc++/trunk/include/memory:2587:19 > #4 0x5640b72c7d74 in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:354:1 > #5 0x5640b72c7f9c in ash::HotseatWidget::~HotseatWidget() ./../../ash/shelf/hotseat_widget.cc:350:33 > #6 0x5640b7319b53 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #7 0x5640b7319b53 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #8 0x5640b7319b53 in ash::Shelf::ShutdownShelfWidget() ./../../ash/shelf/shelf.cc:377:19 > #9 0x5640b724c95f in ash::RootWindowController::CloseChildWindows() ./../../ash/root_window_controller.cc:659:11 > #10 0x5640b741f9c5 in ash::Shell::CloseAllRootWindowChildWindows() ./../../ash/shell.cc:1269:19 > #11 0x5640b741532a in ash::Shell::~Shell() ./../../ash/shell.cc:720:3 > #12 0x5640b741fd3c in ash::Shell::~Shell() ./../../ash/shell.cc:589:17 > #13 0x5640b9be4d75 in operator() ./../../buildtools/third_party/libc++/trunk/include/memory:2378:5 > #14 0x5640b9be4d75 in reset ./../../buildtools/third_party/libc++/trunk/include/memory:2633:7 > #15 0x5640b9be4d75 in ChromeBrowserMainExtraPartsAsh::PostMainMessageLoopRun() ./../../chrome/browser/ui/ash/chrome_browser_main_extra_parts_ash.cc:245:19 > #16 0x5640a5abe85d in ChromeBrowserMainParts::PostMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1721:29 > #17 0x564094a9d525 in chromeos::ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:1136:32 > #18 0x56409b175e3f in content::BrowserMainLoop::ShutdownThreadsAndCleanUp() ./../../content/browser/browser_main_loop.cc:1095:13 > #19 0x56409b17ea9a in content::BrowserMainRunnerImpl::Shutdown() ./../../content/browser/browser_main_runner_impl.cc:178:17 > #20 0x56409b165bd4 in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:49:16 > #21 0x5640a3b3284b in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:529:10 > #22 0x5640a3b3284b in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:978:10 > #23 0x5640a3b311b2 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:878:12 > #24 0x5640b1028f28 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:455:29 > #25 0x56409f705fd0 in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10 > #26 0x5640a762696a in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:513:3 > #27 0x5640a53fb49d in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:299:20 > > Original change's description: > > Cros: Report metrics for the animation of traslucent background > > > > This animation happens during transition between hotseat states. > > > > Bug: 1058609 > > Change-Id: Iff1f81625e6de2bf6dc6dcfee09225c4d16cc53e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2088641 > > Reviewed-by: Robert Kaplow <rkaplow@chromium.org> > > Reviewed-by: Manu Cornet <manucornet@chromium.org> > > Reviewed-by: Alex Newcomer <newcomer@chromium.org> > > Commit-Queue: Ana Salazar <anasalazar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#748806} > > TBR=rkaplow@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org > > Change-Id: I28dfaa49cae6e27801975a2863c013b9f9a5edca > Bug: 1058609 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097507 > Reviewed-by: Joshua Pawlicki <waffles@chromium.org> > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#749146} TBR=rkaplow@chromium.org,newcomer@chromium.org,manucornet@chromium.org,anasalazar@chromium.org Bug: 1058609 Change-Id: Id247b5b669d149031543336702585c6e2bbccd50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097509 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
-
Benoît Lizé authored
The linker tests don't run on bots (and likely not locally either) and do not support the latest library loading patterns. This is the first step to remove them, as they add non-trivial complexity in the codebase. More specifically, this removes the build rules and the test APK. Bug: 1059707 Change-Id: I12102d59116ad1f0a152d3110cf3346471c8f390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2093606Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#749238}
-
Jan Wilken Dörrie authored
Fixed: 1060581 Change-Id: Iba1504630546197dbcd4228a4155feb6f496b3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2096686 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#749237}
-
