GitLab

Cr-Commit-Position: refs/heads/master@{#327276}

When resetting notification permission for web pages to the default value
from the toast's context menu, only the notifier's name would be
considered, but that's empty for the context menu code-path.

Instead, like the derive-from-default case, also consider the notifier's
URL when changing whether the notifier should be enabled.

BUG=481001

Review URL: https://codereview.chromium.org/1103203002

Cr-Commit-Position: refs/heads/master@{#327275}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2abb865..714fdfc

TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/1113533002

Cr-Commit-Position: refs/heads/master@{#327274}

Blink API files.

update the content side usage of the Blink WebDevice{Motion|Orientation}
related API headers to match the new locations of these files.

This is part of the 3 sided patch:
 [1] https://codereview.chromium.org/1079983003/
 [2] This patch
 [3] https://codereview.chromium.org/1106933002/

BUG=453032

Review URL: https://codereview.chromium.org/1093433005

Cr-Commit-Position: refs/heads/master@{#327273}

This is in preparation of crrev.com/1105143003 which simplifies
the MemoryAllocatorDump attributes model with a more generic
one.

BUG=466141

Review URL: https://codereview.chromium.org/1104413002

Cr-Commit-Position: refs/heads/master@{#327272}

Looks like these were accidentally removed when the scheduler was turned into
a component.

BUG=477690

Review URL: https://codereview.chromium.org/1112523003

Cr-Commit-Position: refs/heads/master@{#327271}

Please take look at
https://codereview.chromium.org/1090213002/patch/40001/50001

for details

BUG=

Review URL: https://codereview.chromium.org/1059333004

Cr-Commit-Position: refs/heads/master@{#327270}

Revert of Classify navigations without page id in parallel to the existing classifier. (patchset #35 id:680001 of https://codereview.chromium.org/1002803002/)

Reason for revert:
Very flaky on ChromeOS debug bots. See crbug.com/481910

Original issue's description:
> Classify navigations without page id in parallel to the existing classifier.
>
> For now, this only happens in debug builds.
>
> BUG=369661
> TEST=NavigationControllerBrowserTest.NavigationTypeClassification_*
> TEST=Every other test on the planet.
>
> Committed: https://crrev.com/d8d93348bbd8c646c337bdaa40fc0c64204fc5ff
> Cr-Commit-Position: refs/heads/master@{#327122}
>
> Reverted: https://crrev.com/5348e920f4119aff9a4eb76c0965725dc85a66cc
> Cr-Revert-Position: refs/heads/master@{#327152}
>
> Committed: https://crrev.com/5671403d44971669e4d81aecf3f002188ce0e95f
> Cr-Commit-Position: refs/heads/master@{#327214}

TBR=phajdan.jr@chromium.org,clamy@chromium.org,creis@chromium.org,hajimehoshi@chromium.org,isherman@chromium.org,jeremyim@chromium.org,mattm@chromium.org,mnaganov@chromium.org,mvanouwerkerk@chromium.org,nasko@chromium.org,stevenjb@chromium.org,bengr@chromium.org,cpu@chromium.org,avi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=369661

Review URL: https://codereview.chromium.org/1110943003

Cr-Commit-Position: refs/heads/master@{#327269}

Rename MergeSession in SigninTracker.

Further cleanup as part of the MergeSession/GCMS rework. https://docs.google.com/document/d/1FfmSS7M87L_2tkVuHO3NuruborFm6qHXe2VdktZg-HQ

BUG=466799, 471210

Review URL: https://codereview.chromium.org/1104153002

Cr-Commit-Position: refs/heads/master@{#327268}

BUG=476496

Review URL: https://codereview.chromium.org/1109483003

Cr-Commit-Position: refs/heads/master@{#327267}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/70655e7..2abb865

TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/1108973003

Cr-Commit-Position: refs/heads/master@{#327266}

This ensures 'cr prepare' does the right thing even if run in a subdirectory of
src/.

Review URL: https://codereview.chromium.org/1108133004

Cr-Commit-Position: refs/heads/master@{#327265}

Revert of [Sync] Erase sync DB when corrupted (patchset #4 id:60001 of https://codereview.chromium.org/1082893003/)

Reason for revert:
Test fails on Win7 bots. see crbug.com/481895

Original issue's description:
> [Sync] Erase sync DB when corrupted
>
> Directory now registers to be notified of catastrophic sync DB errors.
> Upon notification, Directory triggers an unrecoverable sync error which
> causes ProfileSyncService to delete the sync DB.
>
> Add integration test that verifies the sync DB is deleted when DB
> corruption is detected.
>
> Remove unused member variable allow_failure_for_test_ from
> DirectoryBackingStore.
>
> Add MockUnrecoverableErrorHandler to assist in writing tests for
> Directory.
>
> BUG=470993
>
> Committed: https://crrev.com/90a7f8d3e3b3a2aac43e71a93eac2731f084945c
> Cr-Commit-Position: refs/heads/master@{#327120}

TBR=zea@chromium.org,pvalenzuela@chromium.org,maniscalco@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=470993

Review URL: https://codereview.chromium.org/1104423005

Cr-Commit-Position: refs/heads/master@{#327264}

FixupURL calls FixupPath who then calls FilePathToFileURL, in which adding
current directory in specific cases (details below) was removed.
That caused DCHECK because getting cwd is protected with AssertIOAlolowed.
Code being removed was reachable from autocomlete, which resulted in
DCHECK. So it was responsible for some "functionallity", but not useful.
I examined, which functionality we will lose: specific paths like "c:",
"с::foo", "c:foo" are recognized as not absolute paths on Windows and cwd
is added. What happens for those URLs: AutocompleteInput::Parse calls
FixupURL, in there SegmentURLInternal recognizes them as having file
scheme on Windows at the same time segmenting to parts is not successful
(url::Parsed is not valid). This functionality is only reachable on
Windows and it is not useful, because those paths with ":" are not valid
relative paths on Windows. For example, autocomlete result like
file:///C:/Users/me/chromium/src/out/Debug/C: (cwd added before C:)
isn't useful.

For other paths of that style cwd-adding code was not called:
  "file://c:", "file://./foo" are segmented successfully
    by SegmentURLInternal, so, no current dirrectory adding here.
  "c:/foo", "c:\foo" - are recognoized as absolute paths, no CWD added
  "./foo.txt", "foo.txt" "foo\foo.txt" - not recognized as having "file"
    scheme, no CWD added.
  ~/directory_or_file URLs - don't need CWD.

Regarding existing functionality working with relative paths:
GetURLsFromCommandLine and ProfileImpl::GetHomePage that can get
relative path(or homepage URL) from command line both use
not FixupURL, FixupRelativeFile function.
FilePathToFileURL is documented in it's comment as taking absolute path
as argument. Also FixupURL (which indirectly calls FilePathToFileURL),
by it's name and description, is not intended to fixup relative file paths.
Not to mention, resolving relative paths to absolute via FixupURL is broken.

Regarding client code that could use functionality being removed
in this fix. Adding cwd was introduced in commit
0135aa17
https://codereview.chromium.org/137233006
that time FilePathToFileURL was in net_util.cc.
Client code mentioned there is content_shell
Code working with startup URL from there:
 src\content\shell\browser\shell_browser_main_parts.cc(75):
   return net::FilePathToFileURL(base::FilePath(args[0]));
Now this code is not included in project (don't know why).
This particular client code needs CWD adding, it was fixed to use right
function for adding cwd.

R=davidben@chromium.org,pkasting@chromium.org,alekseys@chromium.org,gunsch@chromium.org
BUG=60641
TEST=entering "c:" url will not cause debug version to fail on DCHECK
on Windows, and launching content_shell with argument like foo.html
(this html shouldexist in current diroctory) results in foo.html
contents shown in content_shell and absolute path to foo.html
displayed in addres bar.

Review URL: https://codereview.chromium.org/1068793002

Cr-Commit-Position: refs/heads/master@{#327263}

WebRTC 9084:9094
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/324d972..e361d8e

Libjingle 9081:9093
Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/d8bca77..b11169a

TBR=
BUG=

Review URL: https://codereview.chromium.org/1114483002

Cr-Commit-Position: refs/heads/master@{#327262}

This can help autotest to parse the performance data.

BUG=345181
TEST=Enable this option, see FPS info in log.
TEST=Unittest program exits if it cannot create the file.

Review URL: https://codereview.chromium.org/1097793006

Cr-Commit-Position: refs/heads/master@{#327261}

If reading the SW resources from the disk cache fails, we should evict
the worker or else we will keep getting the same failure.

This patch unsets the worker from the live registration, and then
deletes the registration if the SW was the stored version.

This relands the original commit (64e3ffb1), and fixes a problem where
the test terminated before the eviction, which starts on the IO thread,
then hops to the database task runner, finishes. Now the test ends by
looking up the registration in storage, which hops to the database task
runner, so it can only finish once eviction finishes.

Original patch: https://codereview.chromium.org/1098083003/

BUG=448003

Review URL: https://codereview.chromium.org/1108253002

Cr-Commit-Position: refs/heads/master@{#327260}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4a9537f..70655e7

TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/1107323002

Cr-Commit-Position: refs/heads/master@{#327259}

BUG=476496

Review URL: https://codereview.chromium.org/1099243004

Cr-Commit-Position: refs/heads/master@{#327258}

- Rename DumpInto(PMD*) into OnMemoryDump(PMD*)
- Make the MemoryDumpProvider interface pure abstract.
- Move the task_runner argument to MDM.RegisterDumpProvider().
- Remove the awkward DeclareAttribute() logic
- Rename the useless MemoryDumpProvider.GetFriendlyName() method.
- Adapt the existing allocators dump providers to the changes.

BUG=466141

Review URL: https://codereview.chromium.org/1107093004

Cr-Commit-Position: refs/heads/master@{#327257}

Now failing with:
  'MarkerMismatchError: Number or order of timeline markers does not match
   provided labels'

TBR=sullivan
BUG=479048
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1104413004

Cr-Commit-Position: refs/heads/master@{#327256}

This patch makes the banner & focus code robust with promise. And make sure the banner existences before test runs.

BUG=478640
TEST=run TabindexFocusDownloads/FileManagerBrowserTest.Test/0 100 times

Review URL: https://codereview.chromium.org/1105333003

Cr-Commit-Position: refs/heads/master@{#327255}

BUG=472067

Review URL: https://codereview.chromium.org/1066863004

Cr-Commit-Position: refs/heads/master@{#327254}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1fa112a..4a9537f

TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/1110083002

Cr-Commit-Position: refs/heads/master@{#327253}

This makes it possible to use the JUnit library from
Java code on Linux.

BUG=webrtc:4499

Review URL: https://codereview.chromium.org/1106973002

Cr-Commit-Position: refs/heads/master@{#327252}

The actual code was added in https://codereview.chromium.org/909893003
and enabled downstream, but not in ChromeShell.

BUG=458216

Review URL: https://codereview.chromium.org/1029583006

Cr-Commit-Position: refs/heads/master@{#327251}

BUG=466848

Review URL: https://codereview.chromium.org/1107863002

Cr-Commit-Position: refs/heads/master@{#327250}

Review URL: https://codereview.chromium.org/1103293002

Cr-Commit-Position: refs/heads/master@{#327249}

CopyFromCompositingSurface should return
immediately if the frame is not available.

Bug=472457

Review URL: https://codereview.chromium.org/1103233002

Cr-Commit-Position: refs/heads/master@{#327248}

BUG=388560

Review URL: https://codereview.chromium.org/1093153003

Cr-Commit-Position: refs/heads/master@{#327247}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/80927b2..1fa112a

TBR=pdr@chromium.org

Review URL: https://codereview.chromium.org/1110893002

Cr-Commit-Position: refs/heads/master@{#327246}

Fixing two errors:
 - ERROR Unresolved dependencies.
   //:gn_only(//build/toolchain/linux:mipsel)
   needs //third_party/libjpeg_turbo:simd_asm(//build/toolchain/linux:mipsel)
 by including //third_party/libjpeg_turbo:simd_asm target
 only for x86 and x64, where it exists
 - incompatible pointer types in usrsctp
 by ignoring warnings for this module

TEST=gn gen out/mips-linux --args="is_debug=false target_os=\"linux\" target_cpu=\"mipsel\" is_clang=false"
     ninja -C out/mips-linux/ chrome

Review URL: https://codereview.chromium.org/1094793004

Cr-Commit-Position: refs/heads/master@{#327245}

I introduced this change in http://crrev.com/324246 but I now
think it's incorrect based on the fact that the UI thread
should already have COM initialized.

BUG=422522
TEST=audio plays

Review URL: https://codereview.chromium.org/1103383003

Cr-Commit-Position: refs/heads/master@{#327244}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ef7cfd7..80927b2

TBR=tkent@chromium.org,pdr@chromium.org

Review URL: https://codereview.chromium.org/1103403003

Cr-Commit-Position: refs/heads/master@{#327243}

Original: https://codereview.chromium.org/1101733005/

CacheStorageListener and CacheStorageDispatcher are now in a 1:1 relationship
and the indirection is no longer necessary. As a first step of merge, this CL
moves message handlers for CacheStorage API from the listener to the dispatcher.

BUG=474233
TEST=content_unittests --gtest_filter=CacheStorage*
TEST=run-webkit-tests http/tests/cachestorage/

Review URL: https://codereview.chromium.org/1111713002

Cr-Commit-Position: refs/heads/master@{#327242}

Bescause base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/1093823005

Cr-Commit-Position: refs/heads/master@{#327241}

Bescause base/strings/string_split.h defines:
typedef std::vector<std::pair<std::string, std::string> > StringPairs;

BUG=412250

Review URL: https://codereview.chromium.org/1062803009

Cr-Commit-Position: refs/heads/master@{#327240}

This CL turns const by value return values into const by ref

BUG=393155

Review URL: https://codereview.chromium.org/1105093002

Cr-Commit-Position: refs/heads/master@{#327239}

This would be useful in cases when on the same platform due to different version, AX tree may vary.
Please check below mentioned bug id for such kind of example.

BUG=423675

Review URL: https://codereview.chromium.org/844273002

Cr-Commit-Position: refs/heads/master@{#327238}

MessageLoopProxy is deprecated.
This basically does a search and replace:

MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get().

BUG=391045

Review URL: https://codereview.chromium.org/1107013002

Cr-Commit-Position: refs/heads/master@{#327237}