GitLab

BUG=none

Review URL: https://codereview.chromium.org/517103003

Cr-Commit-Position: refs/heads/master@{#292848}

The underlying issue is that by the time we get around to processing a live
region node from a mutation observer, the node may no longer be part of
the DOM, in which case we should treat it as invisible.

To fix it, fix cvox.DomUtil.hasInvisibleAncestor_ so that it returns
true (invisible) if passed an element that's not actually part of the
document.

BUG=408821

Review URL: https://codereview.chromium.org/517853002

Cr-Commit-Position: refs/heads/master@{#292847}

The field is not used, so it should be removed.

NOTRY=True
TEST=Tested manually that Files app works correctly.
BUG=408017

Review URL: https://codereview.chromium.org/522533003

Cr-Commit-Position: refs/heads/master@{#292846}

When a user starts to drag an item before they haven't selected any item yet,
FileTable.lastSelection_ can be undefined and this ends up an incorrect drag image.
The existence of lastSelection_ should be checked.

BUG=409514
TEST=manually

Review URL: https://codereview.chromium.org/532453002

Cr-Commit-Position: refs/heads/master@{#292845}

This is causing problems when a function that returns an array of
nav descriptions returns more than one item, they're not all processed
correctly.

BUG=408821

Review URL: https://codereview.chromium.org/517843002

Cr-Commit-Position: refs/heads/master@{#292844}

PaginationController abstracts over mouse wheel, touch screen and
touchpad event handling for updating the PaginationModel. This allows
any client of PaginationModel (ie, ContentsView) to properly handle
scrolling events. It also removes the code duplication in OnMouseWheel
and OnScrollEvent.

BUG=406222

Review URL: https://codereview.chromium.org/524503003

Cr-Commit-Position: refs/heads/master@{#292843}

TBR=ygorshenin@chromium.org
BUG=381584
NOTRY=true

Review URL: https://codereview.chromium.org/526013002

Cr-Commit-Position: refs/heads/master@{#292842}

Cr-Commit-Position: refs/heads/master@{#292841}

Previously, thumbnails were generated from full size images, which in case of
cloud providers would invoke downloading the entire file.

This CL adds an ability to provide a thumbnail as a data URI, so:
(1) We can have thumbnails for other file types than images.
(2) Thumbnails are shown fast.
(3) Resource consumption is significantly reduced.

Note, that the thumbnails are not wired to Files app yet. That will be done in
a separate patch.

TEST=unit_tests: *FileSystemProvider*GetMetadata*
BUG=407954

Review URL: https://codereview.chromium.org/513683002

Cr-Commit-Position: refs/heads/master@{#292840}

This is a preparation to support AXObject in PagePopup.
PagePopup doesn't have WebLocalFrame, and it's difficult to provide it. We can
remove WebLocalFrame dependency of BlinkAXTreeSource by using
WebDocument::scrollOffset, minimumScrollOffset, and maximumScrollOffset.

This CL has no functionality changes.

BUG=123896

Review URL: https://codereview.chromium.org/510123003

Cr-Commit-Position: refs/heads/master@{#292839}

This change...

(a) updates the install sequence based on the latest spec. Before this
patch, the installing version is set after resolving the register promise.
After this patch, the installing version is set before resolving the promise.

(b) fills registration's version attributes before resolving the register
promise. This should fix the problem mentioned c#5 in the issue and should
absorb the change of the timing to set the installing version due to (a).

(c) adds a separate IPC for updatefound event to adjust the timing to fire
the event. Before this patch, the event shares SetVersionAttributes message.

[1] Blink: https://codereview.chromium.org/524193003/
[2] Chromium: THIS PATCH
[3] Blink: https://codereview.chromium.org/517223002/

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#installation-algorithm

BUG=406240
TEST=content_unittests --gtest_filter=ServiceWorker*
TEST=run_webkit_tests.py http/tests/serviceworker/

Review URL: https://codereview.chromium.org/517493002

Cr-Commit-Position: refs/heads/master@{#292838}

OnBufferingUpdate does not work for local resources. Because of this
the buffered range does not get updated. This patch updates the bufferd
range atleast untill the video has played so that media controls can be
painted properly.

TBR=abarth@chromium.org
BUG=405474

Review URL: https://codereview.chromium.org/496683002

Cr-Commit-Position: refs/heads/master@{#292837}

https://skia.googlesource.com/skia/+log/700a78d72fdf4f09b28446818028b39f31e26b38..eb2662c08f07764491a17e0a397cdbeb0e2c05c1

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/529613002

Cr-Commit-Position: refs/heads/master@{#292836}

BUG=309681

Review URL: https://codereview.chromium.org/514363002

Cr-Commit-Position: refs/heads/master@{#292835}

https://chromium.googlesource.com/chromium/blink/+log/559a6d4ab7a84c539a58fbc8d8dbc64c97994359..78807df2ce8a43f50941cee9ae05458df0cc05bf
TBR=

Review URL: https://codereview.chromium.org/529633002

Cr-Commit-Position: refs/heads/master@{#292834}

Note: This only runs pylint and tests for the auto_bisect directory (this was much simpler than picking and choosing particular files from the parent tools directory).

I think the next step is to move bisect-perf-regression.py and related files into the auto_bisect directory.

BUG=

Review URL: https://codereview.chromium.org/529593002

Cr-Commit-Position: refs/heads/master@{#292833}

Previously, the error message was 'An error occurred.' This patch changes it to "This file could not be displayed."

BUG=405860
TEST=manually tested
TBR=fukino@chromium.org

Review URL: https://codereview.chromium.org/523663002

Cr-Commit-Position: refs/heads/master@{#292832}

If a service is enabled after initialization failed,
 SyncEngine didn't try initializing SyncWorker again, and that makes SyncFS stuck.

BUG=402356

Review URL: https://codereview.chromium.org/470403004

Cr-Commit-Position: refs/heads/master@{#292831}

- rename WebRtcBrowserTest.TwoCallsWithAecDump to WebRtcAecDumpBrowserTest.*CallWithAecDump*

TBR=phoglund@chromium.org
BUG=389132
NOTRY=true

Review URL: https://codereview.chromium.org/523123003

Cr-Commit-Position: refs/heads/master@{#292830}

MetadataCache is soon going to be generalized from Drive to also FSP file
systems. So, in the Files app layer, we should not have Drive specific code.

TEST=Tested manually.
BUG=408017

Review URL: https://codereview.chromium.org/517213002

Cr-Commit-Position: refs/heads/master@{#292829}

https://chromium.googlesource.com/chromium/blink/+log/332a56a9d8e5d800e3a1fb8aa69c241d0ce59912..559a6d4ab7a84c539a58fbc8d8dbc64c97994359
TBR=

Review URL: https://codereview.chromium.org/525693003

Cr-Commit-Position: refs/heads/master@{#292828}

Now that the Files.app uses default system header, the own profile badge is redundant.

BUG=408816
TEST=confirmed manually, ran browser_tests

Review URL: https://codereview.chromium.org/520623002

Cr-Commit-Position: refs/heads/master@{#292827}

Scrolling remains horizontal in the normal (and centered) app lists.

BUG=406222
TEST=Run with --enable-experimental-app-list --show-app-list. Apps grid
view should scroll vertically. Normal app list should still scroll
horizontally.

Review URL: https://codereview.chromium.org/491973004

Cr-Commit-Position: refs/heads/master@{#292826}

TBR=phoglund@chromium.org
BUG=389132
NOTRY=true

Review URL: https://codereview.chromium.org/518173004

Cr-Commit-Position: refs/heads/master@{#292825}

TBR=henrika@chromium.org
NOTRY=true
BUG=409485

Review URL: https://codereview.chromium.org/528653002

Cr-Commit-Position: refs/heads/master@{#292824}

This replaces usage of NPObject in pepper with gin-backed V8 objects. It is unfortunate that this CL is so large, but there isn't a nice way to have the old implementation and the new one side-by-side.

There are 4 major parts to this CL:
1) Changing the HostVarTracker to track V8ObjectVars rather than NPObjectVars (host_var_tracker.cc).
2) Changing plugin elements (in plugin_object.cc) to be gin-backed objects.
3) Changing postMessage bindings (message_channel.cc) be gin-backed objects.
4) Changing the implementation of PPB_Var_Deprecated (ppb_var_deprecated_impl.cc) to call directly into V8.

BUG=351636

Committed: https://chromium.googlesource.com/chromium/src/+/21f446ae855d60cc896b40cb9a3249ed07f150b3

Committed: https://chromium.googlesource.com/chromium/src/+/ee49e63baf57e503bd71dfe61c8a80df63eac9aa

Review URL: https://codereview.chromium.org/459553003

Cr-Commit-Position: refs/heads/master@{#292823}

Use registry virtualization so that stale data on the test machines
don't interfere with the tests.

BUG=375739

Committed: https://chromium.googlesource.com/chromium/src/+/6d6ac988d6a7a311876f3b0d0257086ac58c8181

Review URL: https://codereview.chromium.org/521703002

Cr-Commit-Position: refs/heads/master@{#292822}

Suppresses

In file included from ..\..\remoting/host/verify_config_window_win.h:10:
..\..\third_party\wtl\include\atlapp.h(1683,17) :  warning(clang): using namespace directive in global context in header [-Wheader-hygiene]
using namespace WTL;
                ^

BUG=5027,82385
TBR=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/526863002

Cr-Commit-Position: refs/heads/master@{#292821}

Applying new styling, with some refactoring and bug fixes. Details:

- Sizing and positioning tweaks.
- Change of assets for "X" and for default favicon (if it's missing).
  - Using image as mask, and setting color by CSS (since design uses
    solid colors).
- The new PNG files have been minimized.
- Fixed bug: "Undo" and "Restore All" links continue to be selectable
  via tab after they fades out.
- Alternative Google logo (white): using image as mask and setting
  background color to #eee.  Will delete old image for M39.
- Theme title color in title.html <iframe>: now injecting it from local
  NTP in "c=RRGGBBAA" format. The old behavior of reading it from
  <iframe> and using it to override "c=RRGGBB" are kept, for
  compatibility with server-side NTP.

BUG=407943
NOTRY=1
R=mathp@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/512583002

Cr-Commit-Position: refs/heads/master@{#292820}

https://skia.googlesource.com/skia/+log/21e613505562368e7719215f824fa8b3b4be652d..700a78d72fdf4f09b28446818028b39f31e26b38

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/525973002

Cr-Commit-Position: refs/heads/master@{#292819}

Revert of Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #1 id:1 of https://codereview.chromium.org/519463003/)

Reason for revert:
Reland, wasn't the reason for the redness. (https://codereview.chromium.org/521703002/ was.)

Original issue's description:
> Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/)
>
> Reason for revert:
> Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481
>
> InstallerStateTest.InitializeTwice (run #1):
> [ RUN      ] InstallerStateTest.InitializeTwice
> c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
>   Actual: false
> Expected: true
> [  FAILED  ] InstallerStateTest.InitializeTwice (219 ms)
>
> InstallerStateTest.InitializeTwice (run #2):
> [ RUN      ] InstallerStateTest.InitializeTwice
> c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
>   Actual: false
> Expected: true
> [  FAILED  ] InstallerStateTest.InitializeTwice (109 ms)
>
>
> Original issue's description:
> > clang/win: Fix a few warnings in targets not in chromium_builder_tests.
> >
> > Also don't use "default" as a variable name, as it's a keyword.
> > Also fix a bug where a wstring was passed to %ls.
> >
> > No real behavior change.
> >
> > BUG=82385
> > R=hans@chromium.org
> > TBR=cpu, vitalybuka
> >
> > Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09
>
> TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=82385
>
> Committed: https://chromium.googlesource.com/chromium/src/+/dae20dafcfd3ccc439ccc5b3d5e21ad611d13c23

TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385

Review URL: https://codereview.chromium.org/525013003

Cr-Commit-Position: refs/heads/master@{#292818}

Cr-Commit-Position: refs/heads/master@{#292817}

Revert of EasyUnlock: Work around the ghost overlay from CSS animation. (patchset #3 id:40001 of https://codereview.chromium.org/487373002/)

Reason for revert:
No longer needed since underlying blink issue http://crbug.com/405250 is fixed.

Original issue's description:
> EasyUnlock: Work around the ghost overlay from CSS animation.
>
> BUG=404779
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=290743

TBR=tbarzic@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=404779

Review URL: https://codereview.chromium.org/521343002

Cr-Commit-Position: refs/heads/master@{#292816}

Cr-Commit-Position: refs/heads/master@{#292815}

https://chromium.googlesource.com/chromium/blink/+log/a00905c53f2a7e9c79d324b3ac36dc8b05fb0e7f..332a56a9d8e5d800e3a1fb8aa69c241d0ce59912
TBR=

Review URL: https://codereview.chromium.org/525163002

Cr-Commit-Position: refs/heads/master@{#292814}

https://skia.googlesource.com/skia/+log/9e19ce1641422857b850cdedaee40927643b2f42..21e613505562368e7719215f824fa8b3b4be652d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/524263002

Cr-Commit-Position: refs/heads/master@{#292813}

Revert of Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes. (patchset #4 id:80001 of https://codereview.chromium.org/521703002/)

Reason for revert:
Breaks InstallerStateTest.InitializeTwice on XP:
http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481

Original issue's description:
> Fix ProductTest.ProductInstallBasic and InstallerStateTest.InitializeTwice flakes.
>
> Use registry virtualization so that stale data on the test machines
> don't interfere with the tests.
>
> BUG=375739
>
> Committed: https://chromium.googlesource.com/chromium/src/+/6d6ac988d6a7a311876f3b0d0257086ac58c8181

TBR=robertshield@chromium.org,grt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=375739

Review URL: https://codereview.chromium.org/520863005

Cr-Commit-Position: refs/heads/master@{#292812}

https://chromium.googlesource.com/chromium/blink/+log/244a450e5891380a808296994588063b762f2a63..a00905c53f2a7e9c79d324b3ac36dc8b05fb0e7f
TBR=

Review URL: https://codereview.chromium.org/520383005

Cr-Commit-Position: refs/heads/master@{#292811}

OpenGL/gl.h is required to be included to make the build pass.

BUG=
TEST=

Review URL: https://codereview.chromium.org/522533002

Cr-Commit-Position: refs/heads/master@{#292810}

Revert of clang/win: Fix a few warnings in targets not in chromium_builder_tests. (patchset #3 id:40001 of https://codereview.chromium.org/526513002/)

Reason for revert:
Speculative, might have broken InstallerStateTest.InitializeTwice on XP: http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32481

InstallerStateTest.InitializeTwice (run #1):
[ RUN      ] InstallerStateTest.InitializeTwice
c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
  Actual: false
Expected: true
[  FAILED  ] InstallerStateTest.InitializeTwice (219 ms)

InstallerStateTest.InitializeTwice (run #2):
[ RUN      ] InstallerStateTest.InitializeTwice
c:\b\build\slave\win_builder\build\src\chrome\installer\util\installer_state_unittest.cc(639): error: Value of: wcsstr(installer_state.target_path().value().c_str(), BrowserDistribution::GetSpecificDistribution( BrowserDistribution::CHROME_BINARIES)-> GetInstallSubDir().c_str())
  Actual: false
Expected: true
[  FAILED  ] InstallerStateTest.InitializeTwice (109 ms)

Original issue's description:
> clang/win: Fix a few warnings in targets not in chromium_builder_tests.
>
> Also don't use "default" as a variable name, as it's a keyword.
> Also fix a bug where a wstring was passed to %ls.
>
> No real behavior change.
>
> BUG=82385
> R=hans@chromium.org
> TBR=cpu, vitalybuka
>
> Committed to pending queue: https://chromium.googlesource.com/chromium/src/+/d7efa09

TBR=hans@chromium.org,robertshield@chromium.org,gab@chromium.org,vitalybuka@chromium.org,cpu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=82385

Review URL: https://codereview.chromium.org/519463003

Cr-Commit-Position: refs/heads/master@{#292809}