- 15 Dec, 2016 40 commits
-
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2644e367..5ba6e0d1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2581563002 Cr-Commit-Position: refs/heads/master@{#438726}
-
mcasas authored
This CL : - s/CanvasImageSource/ImageBitmapSource/ in the idl following https://wicg.github.io/shape-detection-api/#face-detection-api and https://wicg.github.io/shape-detection-api/#barcode-detection-api CanvasImageSource [1] is almost a subset of ImageBitmapSource [2] (the former can be a CSSImageValue, but we don't care much about it for this Spec), so this CL is small in that sense. - Adds support for ImageData as a source for detect()ion, and adds a LayoutTest for it. [1] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.idl?q=file:%5C.idl+CanvasImagesource&sq=package:chromium&l=33&dr=C [2] https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/imagebitmap/ImageBitmapFactories.idl?type=cs&q=file:%5C.idl+Imagebitmapsource&sq=package:chromium&l=38 BUG=670975 Review-Url: https://codereview.chromium.org/2550413005 Cr-Commit-Position: refs/heads/master@{#438725}
-
sanjoy.pal authored
BUG=669585 Review-Url: https://codereview.chromium.org/2545693002 Cr-Commit-Position: refs/heads/master@{#438724}
-
napper authored
Moved -webkit-print-color-adjust property to be generated, so now the getter/setter methods for print-color-adjust are generated. This means that getPrintColorAdjust() has been renamed to printColorAdjust(). Also renamed PrintColorAdjust enum to EPrintColorAdjust for consistency with other generated enums. BUG=628043 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2570463002 Cr-Commit-Position: refs/heads/master@{#438723}
-
tbansal authored
NetworkQualityEstimator::TestEffectiveConnectionTypeObserver is disabled on ios-simulator until it is clear why it is flaky. BUG=641708 Review-Url: https://codereview.chromium.org/2559373005 Cr-Commit-Position: refs/heads/master@{#438722}
-
lgarron authored
BUG=647822 ================================ TEST=Use an iPhone, not an iPad. First, enable the proper flag: -------------------------------- 1. Open the Settings app 2. Scroll to Chrome Beta/Dev/Canary and press 3. Scroll down to Experimental Settings and press 4. Scroll to EXTRA FLAGS (ONE PER LINE) 5. Toggle "Append Extra Flags" to ON 6. Set Flag1 to "--mark-non-secure-as=show-non-secure-passwords-cc-ui" (without the quotes) -------------------------------- Test 3 URLs: 1) Visit https://badssl.com/input/login/ and verify that the omnibox security has a green lock security indicator to the left of the URL. 2) Visit http://http-login.badssl.com/ and verify that the omnibox security has a grey info icon ⓘ security indicator to the left of the URL. 3) Visit http://http.badssl.com/ and verify that the omnibox does *not* have a security indicator to the left of the URL. -------------------------------- 4) Set Flag1 (see above) to "--mark-non-secure-as=neutral" (without the quotes) and check that http://http-login.badssl.com/ does *not* have a security indicator to the left of the URL. ================================ Review-Url: https://codereview.chromium.org/2466143002 Cr-Commit-Position: refs/heads/master@{#438721}
-
kinaba authored
It didn't properly detach from the input method when ARC lost focus and no other text input client took focus until shutdown. BUG=673809 TEST=ArcImeServiceTest.WindowFocusTracking Review-Url: https://codereview.chromium.org/2570623005 Cr-Commit-Position: refs/heads/master@{#438720}
-
rohitrao authored
This CL adds an early return rather than DCHECKing when the plist is missing. BUG=666375 Review-Url: https://codereview.chromium.org/2551423002 Cr-Commit-Position: refs/heads/master@{#438719}
-
yusukes authored
It is slightly weird for ArcServiceManager to handle (only) one of the ArcService instances it has in a special way with inheritance, and this CL fixes that. ArcServiceManager looks more neutral now and no longer has to #include arc_intent_helper_observer.h on the header side. This removes all virtual member functions from ArcServiceManager too. Instead, do the same thing with a pair of member variable and its getter function, which is more consistent with the existing ArcServiceManager code. All the implementation details go to the .cc side. This is a follow-up CL for https://codereview.chromium.org/2487623002/. BUG=672840 TEST=try Review-Url: https://codereview.chromium.org/2538263005 Cr-Commit-Position: refs/heads/master@{#438718}
-
tsergeant authored
This was a feature of all previous WebUI pages (as part of chrome_shared.css), but had been lost with the switch to Material design. All interactive elements still show a hand cursor, but text will show a pointer cursor instead of a text selection cursor. BUG=672764 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2577923002 Cr-Commit-Position: refs/heads/master@{#438717}
-
allada authored
This patch removes some old code that was not used any more. BUG=None R=dgozman,lushnikov Review-Url: https://codereview.chromium.org/2576203002 Cr-Commit-Position: refs/heads/master@{#438716}
-
hubbe authored
Add histograms recording color gamut information about images and screens. BUG=667431 Review-Url: https://codereview.chromium.org/2567983004 Cr-Commit-Position: refs/heads/master@{#438715}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/788644ef37e7..ab7345371ad0 $ git log 788644ef3..ab7345371 --date=short --no-merges --format='%ad %ae %s' 2016-12-14 aiolos Fix TimeDisplayModes and add a test to avoid future breakage. 2016-12-14 benjhayden Fix ChartJsonConverter handling empty list_of_scalar_values. 2016-12-14 benjhayden Rename IterationInfo to TelemetryInfo. Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2577873002 Cr-Commit-Position: refs/heads/master@{#438714}
-
carlosk authored
In the development of patch to move mixed-content checks to the browser (https://crrev.com/1905033002) a few minor changes were made that are unrelated to its core purpose. So I created this change to simplify the original one. They are: - Add missing forward declaration. - Updated a comment referring to an IPC that doesn't exist anymore. - Adds newline. BUG=576270 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation Review-Url: https://codereview.chromium.org/2576613003 Cr-Commit-Position: refs/heads/master@{#438713}
-
skia-deps-roller authored
https://skia.googlesource.com/skia.git/+log/56ff9a1c9dfd..c2ba75b50750 $ git log 56ff9a1c9..c2ba75b50 --date=short --no-merges --format='%ad %ae %s' 2016-12-14 bungeman Remove Mac 10.6 - 10.8 work arounds for fonts. 2016-12-14 bungeman Remove strange 'write' overload on SkDynamicMemoryWStream. 2016-12-14 bsalomon Some more batch->op renaming 2016-12-14 msarett Reenable 16-bit png brd decode tests 2016-12-14 bsalomon Bring sk_sp to oval GrDrawOps and rename batch->op 2016-12-14 brianosman Make picture backed images sRGB by default 2016-12-14 robertphillips Demote savePixels to save_pixels Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel TBR=msarett@google.com Review-Url: https://codereview.chromium.org/2580623002 Cr-Commit-Position: refs/heads/master@{#438712}
-
abhishekbh authored
BUG=665983 TEST=try Review-Url: https://codereview.chromium.org/2571143003 Cr-Commit-Position: refs/heads/master@{#438711}
-
dbeam authored
It should only open the learn more link. R=tommycli@chromium.org BUG=621702 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2575743002 Cr-Commit-Position: refs/heads/master@{#438710}
-
estade authored
In some cases, Mac still uses old assets, so those are included on just that platform. BUG=522168 Review-Url: https://codereview.chromium.org/2575733002 Cr-Commit-Position: refs/heads/master@{#438709}
-
amaralp authored
Previously we were hiding the paste menu even when the page didn't scroll at all. Moving the hiding to update ensures that the menu is only cleared if we actually scrolled. BUG=673209 Review-Url: https://codereview.chromium.org/2580583002 Cr-Commit-Position: refs/heads/master@{#438708}
-
yhirano authored
No one is using the code any more. BUG=None R=tyoshino@chromium.org Review-Url: https://codereview.chromium.org/2568723006 Cr-Commit-Position: refs/heads/master@{#438707}
-
jamescook authored
Ash is only compiled on Chrome OS so it doesn't need OS_WIN or OS_CHROMEOS ifdefs. BUG=666773,665960 TEST=ash_unittests R=msw@chromium.org Review-Url: https://codereview.chromium.org/2576133002 Cr-Commit-Position: refs/heads/master@{#438706}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b55ff5c9..2644e367 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2579553002 Cr-Commit-Position: refs/heads/master@{#438705}
-
wangxianzhu authored
BUG=645667 TEST=virtual/spinvalidation/fast/dynamic/static-to-relative-with-absolute-child.html etc. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2574293003 Cr-Commit-Position: refs/heads/master@{#438704}
-
tkent authored
BUG=667236 TBR=keishi@chromium.org Review-Url: https://codereview.chromium.org/2572993002 Cr-Commit-Position: refs/heads/master@{#438703}
-
dgozman authored
BUG=673678 Review-Url: https://codereview.chromium.org/2580513002 Cr-Commit-Position: refs/heads/master@{#438702}
-
sky authored
DesktopWindowTreeHostMus needs WindowTreeHost::window() to only be shown when Show is called. This is important as the visibility of window() is mirrored in the server. To enable that this patch moves the responsibility of calling InitHost() and Show from DesktopNativeWidgetAura to DesktopWindowTreeHost. InitHost() must be called before Show(), hence the need to move InitHost in addition to Show(). BUG=672932 TEST=covered by tests R=erg@chromium.org Review-Url: https://codereview.chromium.org/2575243002 Cr-Commit-Position: refs/heads/master@{#438701}
-
estade authored
More stuff left over from mac pre-MD code. BUG=648281, 522168 Review-Url: https://codereview.chromium.org/2572983002 Cr-Commit-Position: refs/heads/master@{#438700}
-
lushnikov authored
Currently, the Common.FormatterWorkerPool provides two methods: - runTask - runChunkedTask This is very low-level. In fact, FormatterWorkerPool is a front-end for formatter workers; it makes sense to introduce an API which will describe functionality of the worker. BUG=none R=dgozman Review-Url: https://codereview.chromium.org/2570263002 Cr-Commit-Position: refs/heads/master@{#438699}
-
jdufault authored
This is currently behind a feature flag and not enabled by default. - The lock screen webview will be saved and reused across lock sessions. - The lock screen webview will be preloaded after the user has not generated any input events for 8 seconds. See https://codereview.chromium.org/2512473004/ for additional context. BUG=669638 Review-Url: https://codereview.chromium.org/2553863002 Cr-Commit-Position: refs/heads/master@{#438698}
-
asargent authored
There's a DCHECK in ExtensionUpdater::ScheduleNextCheck that tries to ensure we aren't scheduling the next check unreasonably soon (<= 1 second). But we serialize the "scheduled next check time" in prefs and read that on next startup, and use it as long as it isn't in the past or too far in the future, but if you get unlucky it can be < 1 second in the future, and you'll hit this DCHECK. BUG=654804 Review-Url: https://codereview.chromium.org/2562963003 Cr-Commit-Position: refs/heads/master@{#438697}
-
alph authored
BUG=259297 Review-Url: https://codereview.chromium.org/2570673005 Cr-Commit-Position: refs/heads/master@{#438696}
-
einbinder authored
There is no longer a link to the DevTools security panel in the url bar. BUG=646465 Review-Url: https://codereview.chromium.org/2570423002 Cr-Commit-Position: refs/heads/master@{#438695}
-
estade authored
BUG=522168 Review-Url: https://codereview.chromium.org/2576583003 Cr-Commit-Position: refs/heads/master@{#438694}
-
estade authored
BUG=522168,672669 Review-Url: https://codereview.chromium.org/2573903003 Cr-Commit-Position: refs/heads/master@{#438693}
-
estade authored
These are not needed because the pre-MD find bar code was removed. BUG=648281,522168 TBR=oshima@chromium.org Review-Url: https://codereview.chromium.org/2571143002 Cr-Commit-Position: refs/heads/master@{#438692}
-
amaralp authored
When a user scrolls we need to generate fake mouse moves since the cursor is moving relative to the page (for example you might scroll over an element that has an mouseover event listener). Currently Android and blink have separate code-paths for generating these fake mouse moves. This CL removes the Android specific code-path and makes Android use the Blink code-path. In order to make the Blink codepath activate on Android, delete the deviceSupportsMouse websetting which was exclusively used to disable this fake-mouse-move codepath. It's sufficient to rely on mousePositionUnknown instead, which disables the codepath if no mousemove event was ever received. BUG=492738 Review-Url: https://codereview.chromium.org/2536723007 Cr-Commit-Position: refs/heads/master@{#438691}
-
lukasza authored
After the changes, the generated code (e.g. out/gn/gen/blink/core/dom/TouchInit.h) will contain a comment similar to: // This file has been generated from the Jinja2 template in // third_party/WebKit/Source/bindings/templates/dictionary_impl.h.tmpl BUG=673936 Review-Url: https://codereview.chromium.org/2569923003 Cr-Commit-Position: refs/heads/master@{#438690} -
varkha authored
The CL implements sticky section header rows in VPN page. Care is taken to stack the rows with child controls that have layers below the sticky section header rows. BUG=664244 TEST=Run with --material-design-ink-drop-animation-speed=slow Touch a Wi-Fi connection row and while ripple is growing drag-scroll the list of connections up. Verify that the ripple is stacked below the Wi-Fi header row. Review-Url: https://codereview.chromium.org/2557333003 Cr-Commit-Position: refs/heads/master@{#438689} -
dbeam authored
Revert of Give automation extension api owners ownership of externs (patchset #2 id:20001 of https://codereview.chromium.org/2576053002/ ) Reason for revert: Manually editing generated files is not the right way to change things in this folder. https://codereview.chromium.org/2563013003/ https://codereview.chromium.org/2544203004/ Please either fix the tools, report bugs, or remove generation steps (or move these externs to somewhere else), then resubmit this CL. Original issue's description: > Give automation extension api owners ownership of externs > > BUG= > > Committed: https://crrev.com/484e132178179990a45f6c74c218d12bee61f094 > Cr-Commit-Position: refs/heads/master@{#438680} TBR=redevlin.cronin@chromium.org,dtseng@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2579603002 Cr-Commit-Position: refs/heads/master@{#438688}
-
twellington authored
Revert of Implement GetDisplayed on android M+ (patchset #3 id:60001 of https://codereview.chromium.org/2536313003/ ) Reason for revert: Tests on Android's Marshmallow Tablet Tester started failing. See crbug.com/674335 Original issue's description: > Implement GetDisplayed on android M+ > > BUG= > > Committed: https://crrev.com/6cfe928c1b1b7fda6c4b1ae07df28bb924037961 > Cr-Commit-Position: refs/heads/master@{#438527} TBR=peter@chromium.org,miguelg@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2579513003 Cr-Commit-Position: refs/heads/master@{#438687}
-