- 26 Nov, 2019 34 commits
-
-
rbpotter authored
When autogenerating Polymer 3 JS files, add <!--_html_template_start_--> to the beginning of the template and <!--_html_template_end_--> to the end. This will be used to identify HTML start and end locations for performing i18n replacements in a followup CL. Adding the tags allows the replacement code to search for only one set of markers, instead of needing to handle multiple syntaxes. Bug: 1023841 Change-Id: Ie70638095f5a0bf631028052ab5f2165ccc41ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935038Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#718932}
-
Brandon Wylie authored
Bug: 1020774 Change-Id: I48b32fdfbcf4dc2a20ba047ee3f93783f4fa2a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918047 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#718931}
-
Wei-Yin Chen (陳威尹) authored
Decrease the number of iterations in StartSurfaceLayoutTest and StartSurfaceLayoutPerfTest to make them run faster on bots. Bug: None Change-Id: Ib0d10c913ca0fb7f5a8d06e200f8f5b96d510def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935427Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718930}
-
Owen Min authored
Disable the test due to multiple platforms flakiness. Bug: 1028357 Tbr: rdevlin.cronin@chromium.org Change-Id: Id1bab60748b0a3a8de1fb2a352754a3584427a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935169Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718929}
-
David Bertoni authored
This change uses code that is compatible with both Service Worker-based extensions and background/event page-based extensions to implement the browserAction.setIcon() JavaScript code. Bug: 1015136 Change-Id: I1bc55cd5da2cc106e8d74dba172122d2bf943d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921640Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#718928}
-
nancy authored
BUG=1016159 Change-Id: I17381ed839025b621600b8cd2395e95c8d035f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919533 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718927}
-
Collin Baker authored
Bug: 989131 Change-Id: I532dc7bf6bc2539a40ee8be480d77fbf276d85a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931225 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#718926}
-
Ted Choc authored
With the past deflake attempt, it ensured the menu was present except when in the overview mode. This made tests that enter/exit the overview mode (e.g. tab switcher) prone to continued flakes. This removes the broad menu ID checks with explicit checks on the browsing mode toolbar button, which is the same logic the TabModalPresenter uses internally. Now, the tests should not have any dependencies on the toolbar visibility based on browser controls offsetting logic. BUG=1026908 Change-Id: I420d6700148abf57098ab3f88d0187cef2133bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934773 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e7ce4e53915d..f2637d0dd7eb git log e7ce4e53915d..f2637d0dd7eb --date=short --first-parent --format='%ad %ae %s' 2019-11-25 jonahr@google.com Present should return OUT_OF_DATE if the window size outdated Created with: gclient setdep -r src/third_party/swiftshader@f2637d0dd7eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:140 Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic810b370da68f82f9e277b167ca711fd3ff23677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935148Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718924}
-
Sara Kato authored
Mouse events should not be forwarded to ChromeVox,if called from ARC++. This is what leads to "jumpy" and unexpected focus behaviour, as described in the bug. This CL checks if an arc window is active, and does this by adding an activation observer to wm_helper. TEST=manual (follow repro steps in bug, and observed expected behaviour) BUG=b:141597151 Change-Id: I3d1da3801c1b826164e73a97fd639523b21202ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905038 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#718923}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0e927af80636..bee6bf4cd336 git log 0e927af80636..bee6bf4cd336 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 abennetts@google.com Revert "Add origin-trial tokens to pinpoint's index.html for prod and local dev (localhost:8080)." Created with: gclient setdep -r src/third_party/catapult@bee6bf4cd336 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1026356 Tbr: skyostil@google.com Change-Id: Ied53ffe3c8a22ec45e88df040c2d9455c4f0094d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935149Reviewed-by:
-
Caleb Rouleau authored
Make the unittests exercise this by adding args.multiple_dimension_script_verbose = True which makes verbose be true everywhere so that we can make sure the print statements work. Also add in some additional print statements to clarify what is happening. Also fix a couple easy formatting issues. Bug: 984504, 956637 Change-Id: Ib4dc4236e57f47f0c92eba84db5ae4d9cc969309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934526 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:John Chen <johnchen@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#718921}
-
Benjamin Beaudry authored
In AXPlatformNodeTextRangeProviderWin, nodes with role kInlineTextBox should never be exposed to UIA. This CL introduces a simple fix. In GetEnclosingElement(), if the enclosing node is an inline text box, we simply return its parent. I also updated a unit test for this case. Bug: 928948 Change-Id: I31a31566461c3091bed36ebad626c4f51afc55a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931753 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#718920}
-
Devlin Cronin authored
SerialExtensionHostQueue is now the only implementation of ExtensionHostQueue. Combine them into a de-virtualized ExtensionHostQueue. TBR=halliwell@chromium.org (trivial //chromecast change) Bug: 1028334 Change-Id: I214596d57ccc1edbd6ba4e9ece266b7845baa954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934265 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#718919}
-
Ted Meyer authored
check to see if decoder name is not the same when setting fallback Bug: 1027783 Change-Id: I7a8e9b6eb3b15c2d1f3a702474d35cf0e094c123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931648Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#718918}
-
Brian Sheedy authored
Enables the standard BrowserMinidumpTests on Android and removes the Android-specific testGetStackTrace. Android now supports the standard set of minidump-related methods, so it can use the same tests as other platforms. Also removes a special casing of Android in the GPU test code that was also caused by Android not implementing the standard methods. Bug: 1008075 Change-Id: Iaaa7f14ecee81be4ffa16c5db3418cbbe7de51f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934842 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#718917}
-
Anand K. Mistry authored
Bug: 1007645 Change-Id: Ie5bb04e446051089e45e6be3d0f0683f8395d3f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930249 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#718916}
-
Kevin Babbitt authored
While working on tuning which nodes we include in the UI Automation control and content views, I discovered that our tree dumper was only dumping nodes in the control view. This CL applies a filter to dump the raw view, which is a superset of the control view, giving us dumps that are more complete. R=iapres@microsoft.com Bug: 1028345 Change-Id: I98d53285abb77eb8490903f85a2c21e63e1f8c33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935027Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#718915}
-
Stephen Nusko authored
These macros allow users to write small lambda functions that get direct access to the protozero TrackEvent. They can then access and fill in the values as needed. This seems to have no noticeable performance impact: https://docs.google.com/spreadsheets/d/1YBB7V2hinQ-lcf9WBFrdMzxakosJHou0B3U10Gzpme0/edit?usp=sharing And binary size is slightly negative (probably more zero like). Change-Id: I2e9266daad902ac64bdaa1a1f1bf5678dc48ac9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921984 Commit-Queue: Stephen Nusko <nuskos@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#718914}
-
Tomasz Wiszkowski authored
This change ensures suggestions using BaseSuggestionView are using the light gray color as a tint color for suggestion fallback icons. Bug: 1027694 Change-Id: I073c019a57180843ce703abff16828ce9db74680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935029Reviewed-by:
-
Lan Wei authored
Because we can use pause action for touch points that do not move, but Devtool will generate a touch end event if we do not pass the paused touch point in the touch point list. https://cs.chromium.org/chromium/src/content/browser/devtools/protocol/ input_handler.cc?type=cs&q=InputHandler::DispatchWebTouchEvent&g=0&l=825 Therefor, for the paused touch points that are not released, we should set type of touch move. Bug: 1020674 Change-Id: I01358b3534a8dde6b2651495034b9ad31a5f13ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933206Reviewed-by:
-
Kent Tamura authored
for timestamps obtained by FileUtilitiesHost. Bug: 1027959 Change-Id: Ib3c12e44b2fdeb028bcb6856943525425351e510 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933838 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718911}
-
Chih-Yu Huang authored
The client of video decoder would pass the initial resolution when calling VideoDecoder::Initialize(). However, V4L2SVD could still get the resolution by AcceleratedVideoDecoder parsing the header. Therefore, V4L2SVD don't need to set the resolution at Initialize(). Moreover, at the next CL we will implement an adapter from VDA to VD. Setting the resolution at Initialize() cannot be fit with VDA api. This CL removes V4L2SVD setting resolution at Initialize(). Bug: b:136716838 Test: pass vda_tests on Kevin Change-Id: I7957bf23574ad47d3666f39b05371182f2b37301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923877Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718910}
-
Erik Staab authored
Bug: 1007791 Change-Id: Ia2eee33ff64d82c3a18abf217d1edc51a225363d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932236Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#718909}
-
Etienne Bergeron authored
The static method RectangleText::Elide(...) is only call once. There is no point to have a static method to abstract it. Follow up from: https://chromium-review.googlesource.com/c/chromium/src/+/1924882/ R=pkasting@chromium.org Bug: 1025561 Change-Id: I1aabb25116fbc2f709e442e909034bfc7c83c2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928791 Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#718908}
-
David Tseng authored
Change-Id: I050e4fe94f3bcb3d9d4d01166a577998e1ec9fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931256 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#718907}
-
Tomasz Wiszkowski authored
This change ensures children with LayoutParams.height set to MATCH_PARENT are actually sized to match the height of BaseSuggestionView. Bug: 1027697 Change-Id: I89b0c40aa5246b0f4fa5c251bcb8a995caafc466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934836Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Also enabled ReturnToChromeTest on tablets as regression tests. Bug: 1027801 Change-Id: Ie73cea1eb4ab23e725b327442b80c657489f73c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931943Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718905}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c028b427175c..32d6c8d02436 git log c028b427175c..32d6c8d02436 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 egdaniel@google.com When wrapped, store ref to GrVkSecondaryCommandBuffer on GrVkRenderTarget. 2019-11-25 jvanverth@google.com Revert "Rename GLRTFBOIDIs0 to WrapsSwapchainSurface and use for Metal." 2019-11-25 michaelludwig@google.com Lift TextureSampler's proxy to SurfaceProxy 2019-11-25 csmartdalton@google.com Reland "Reland "Enable msaa ccpr on vulkan"" Created with: gclient setdep -r src/third_party/skia@32d6c8d02436 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: bungeman@google.com Change-Id: Ic6173ae8459fb943504599d0c3cb2930e06e82fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934830Reviewed-by:
-
Andrey Kosyakov authored
Bug: 1018108 This still retains a copy of protocol.json for compatibility with devtools front_end. Also, remove a presubmit for front-end compilation upon a change to PDL since the front-end is in another repository now. Change-Id: I2faea62feca80776d2fc0a0b4ea00a90439ae005 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1898538 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#718903}
-
Xiaocheng Hu authored
crrev.com/c/1922919 added a stylesheet sanitizer for clipboard, but left a loophole for SVGStyleElement. This patch also strips it. Bug: 1017871 Change-Id: Icc6c513f79597c191f732cd63a98cc59afe1fc69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931412 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718902}
-
Wei Li authored
Add 'use_color_pipeline' build flag to enable building with color pipeline feature. Excluding color_unittests so it can continue running on buildbots without config changes. BUG=1003612 Change-Id: Ie90fe5da6671a0f0d3d0f93bdbb5dc1df8497ce0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928308Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#718901}
-
nancy authored
AppServiceAppModelBuilder is used to replace ExtensionAppModelBuilder. AppService integration to ui/app_list has been enabled for a couple of months, so it should be safe to remove ExtensionAppModelBuilder. ChromeAppIconWithModelTest.IconsTheSame unit test is removed, because we don't use ExtensionAppModelBuilder to load icon any more. ExtensionAppModelBuilderTest's unit tests are replaced to use AppServiceAppModelBuilder. A separate CL will be used to move ExtensionAppModelBuilderTest, CrostiniAppModelBuilderTest and InternalAppModelBuilderTest to src/chrome/browser/ui/app_list/app_service/ directory, then we can move the common functions, e.g. RemoveNonBuiltInApps, to app_service_test. Add PrefChangeRegistrar to ExtensionApps to handles profile prefs changes, the same as ExtensionAppModelBuilder. BUG=1016159 Change-Id: I03ae3aded435b8763444d9c6aea76d01b12ccb58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928517Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Jeevan Shikaram <jshikaram@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#718900}
-
Manu Cornet authored
Bug: 1011130 Change-Id: I4ac437f1e6e4bbfc831c50edb06359824b25bc62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935039Reviewed-by:
-
- 25 Nov, 2019 6 commits
-
-
Fei Ling authored
Bug: 958627 Change-Id: I8c16b53dc62bc2aad8b70749a0d6f28d96d80e53 Fixed: 958627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934318 Commit-Queue: Fei Ling <feiling@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/15be5282e91b..6620506591b7 git log 15be5282e91b..6620506591b7 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e0dd604c..bdce3460 (718623:718772) Created with: gclient setdep -r src/third_party/webrtc@6620506591b7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7cdc5f72e30c288e8b61944a14abfa3819430e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934693Reviewed-by:
-
Xiaocheng Hu authored
This reverts commit f6953a5e. Reason for revert: Manually destroyed the dummy page to ensure no leak Original change's description: > Revert "Sanitize style elements in clipboard markup" > > This reverts commit d96236b5. > > Reason for revert: This may cause "WebKit Linux Leak" failure > First failure: https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Linux%20Leak/7276 > > Original change's description: > > Sanitize style elements in clipboard markup > > > > This patch sanitizes clipboard markup before pasting it into document > > by removing all pasted style elements and serializing them onto > > elements as inline style. In this way, we stop stylesheets in clipboard > > markup from being applied to the original elements in the document. > > > > This patch follows the same approach as in WebKit [1]: > > - First create a dummy document to insert the markup > > - Then computes style and layout in the dummy document > > - Re-serialize the dummy document as the markup to be inserted. This > > reuses the code path that we serialize a selection range into > > clipboard, where we need to serialize element computed style into > > inline styles so that the element styles are preserved. > > - Make sure all style elements are removed before inserting markup > > into document > > > > This patch also adds a complete test to ensure that content pasted from > > Excel is still properly styled, which is the main reason we used to > > preserve style elements in clipboard markup [2]. > > > > [1] https://trac.webkit.org/changeset/223440 > > [2] http://crbug.com/121163 > > > > Bug: 1017871 > > Change-Id: I3bb5a4ae7530a3fdef5ba251975e004857c06f1e > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922919 > > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > > Reviewed-by: Kent Tamura <tkent@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#718281} > > TBR=yosin@chromium.org,tkent@chromium.org,xiaochengh@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1017871, 1027386 > Change-Id: I1d500647d6227c9be3ae14d9604ba702e9c29834 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933452 > Reviewed-by: Owen Min <zmin@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Commit-Queue: Owen Min <zmin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#718778} TBR=yosin@chromium.org,tkent@chromium.org,zmin@chromium.org,xiaochengh@chromium.org Cq-Include-Trybots=luci.chromium.try:layout_test_leak_detection Bug: 1017871, 1027386 Change-Id: Ia56ee941979cad71e2bac06998c7ac417b4731bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934650Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#718896}
-
Sahel Sharify authored
This cl enables web based payment handlers on Android to notify the merchant about shipping address/option changes and wait for updated payment details. Bug: 984694 Change-Id: I2dec41e5d3b8b2a8628c9fa22ee1feb5e5a161fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932894 Commit-Queue: Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718895}
-
Tao Bai authored
Related downstream change: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2172237 Binary-Size: all added code was from downstream, the size increase is expected. Bug: 951275 Change-Id: Ibf56135e2a7d2f437f167dc0cdb7761bce447e86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1922603Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#718894}
-
Ahmed Mehfooz authored
This change removes a previous feature which caused system priority notifications to pop back up even if the system tray was opened and closed. Bug: 1007031 Change-Id: Iddf1f233cd20c256db2a48adf025881bf511a717 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929448 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
-
