- 20 May, 2014 40 commits
-
-
tfarina@chromium.org authored
This first prefix action_names with 'generate' to differentiate them from the target names. This also collapses theme_resources_gen into theme_resources as there is no reason to separate them. It also removes a second declaration of grit_out_dir variable. We don't need to declare it twice in the same file. BUG=None TEST=None R=thestig@chromium.org TBR=brettw Review URL: https://codereview.chromium.org/290773004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271579 0039d316-1c4b-4281-b951-d872f2087c98
-
pavely@chromium.org authored
When GenericChangeProcessor calls AttachmentService::StoreAttachments AttachmentService invokes AttachmentUploader to upload attachments. When attachment gets uploaded AttachmentService invokes AttachmentService::Delegate::OnAttachmentUploaded. GenericChangeProcessor implements AttachmentService::Delegate for now. When attachment is uploaded it call WriteTransaction to update entries referring this attachment with new attachment id. R=maniscalco@chromium.org BUG=371629 Review URL: https://codereview.chromium.org/272043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271578 0039d316-1c4b-4281-b951-d872f2087c98
-
erg@chromium.org authored
BUG=374651 Review URL: https://codereview.chromium.org/292853002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271577 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
Disable PrintPreviewTest tests under asan. They started failing after PDF was open sourced. They must not have been doing anything interesting before since the bots didn't have access to the PDF plugin. BUG=375126 TBR=thestig@chromium.org Review URL: https://codereview.chromium.org/293993003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271576 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271572 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
The PDF plugin is now part of the open source project. R=ericwilligers@chromium.org Review URL: https://codereview.chromium.org/293983002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271570 0039d316-1c4b-4281-b951-d872f2087c98
-
tedchoc@chromium.org authored
BUG=318769 Review URL: https://codereview.chromium.org/286353002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271569 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
BUG=None Review URL: https://codereview.chromium.org/286933003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271568 0039d316-1c4b-4281-b951-d872f2087c98
-
reveman@chromium.org authored
BUG= Review URL: https://codereview.chromium.org/286333006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271567 0039d316-1c4b-4281-b951-d872f2087c98
-
gcasto@chromium.org authored
This module still doesn't compile as there are certain dependencies (mainly random number generator) that need to be replaced first, but all necessary third_party code should now included. BUG=165318 Review URL: https://codereview.chromium.org/285263002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271566 0039d316-1c4b-4281-b951-d872f2087c98
-
bajones@chromium.org authored
Removal request as part of chrome-wide flag cleanup. See: https://docs.google.com/a/chromium.org/spreadsheet/ccc?key=0ArH-w4dboLrgdGRqNU5FUm1Za2VieTFHOE91MW9hUVE&usp=sharing#gid=0 BUG=315429 Review URL: https://codereview.chromium.org/291013002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271565 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-admin@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271564 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=369973 TEST=ctrl + p does not crash. Review URL: https://codereview.chromium.org/270553003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271563 0039d316-1c4b-4281-b951-d872f2087c98
-
eseidel@chromium.org authored
http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174243:174310&mode=html TBR= BUG= Review URL: https://codereview.chromium.org/297483004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271562 0039d316-1c4b-4281-b951-d872f2087c98
-
oshima@chromium.org authored
This sets the standard directory structure for Athena. BUG=362288 Review URL: https://codereview.chromium.org/287163009 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271561 0039d316-1c4b-4281-b951-d872f2087c98
-
zork@chromium.org authored
Add a ChromeOS implementation of VideoCaptureDevice that is aware of the rotation of the internal display, and updates the rotation of captured frames to match. BUG=360048 Review URL: https://codereview.chromium.org/270263008 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271560 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
The PDF plugin is now part of the open source project. R=ericwilligers@chromium.org Review URL: https://codereview.chromium.org/299613002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271559 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
BUG=375103 TBR=ncbray@chromium.org Review URL: https://codereview.chromium.org/292123002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271558 0039d316-1c4b-4281-b951-d872f2087c98
-
jgraettinger@chromium.org authored
A non-exclusive root dependency is always emitted, and parsed dependencies are ignored. Weights are mapped to existing SPDY priorities, and vice versa. BUG=345769 Review URL: https://codereview.chromium.org/287003011 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271555 0039d316-1c4b-4281-b951-d872f2087c98
-
jgraettinger@chromium.org authored
BUG=345769 Review URL: https://codereview.chromium.org/265823019 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271554 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome-release@google.com authored
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271552 0039d316-1c4b-4281-b951-d872f2087c98
-
haven@chromium.org authored
When writing to a drive with mounted volumes, Chrome OS will recreate the partition table if it is observe to be missing and the volumes are accessed after writing. This only occurs when erasing just the partition table because enough of the volume information is still present. We also expand the amount of data erased when destroying partitions to 8k to account for 4k block sizes. This has the side effect of overwriting the LBA for 512-byte-block drives, which only increases the effect of destroying partitions. BUG=284834 BUG=335390 Review URL: https://codereview.chromium.org/282853003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271551 0039d316-1c4b-4281-b951-d872f2087c98
-
gauravsh@chromium.org authored
This flag is no longer used. BUG=352747 Review URL: https://codereview.chromium.org/292683002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271550 0039d316-1c4b-4281-b951-d872f2087c98
-
rch@chromium.org authored
QuicClientSession::CloseSessionOnErrorInner. Review URL: https://codereview.chromium.org/284303007 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271548 0039d316-1c4b-4281-b951-d872f2087c98
-
hirono@chromium.org authored
This CL starts to use the new separated gallery without specifying the file-manager-enable-new-gallery flag. BUG=358698 TEST=none Review URL: https://codereview.chromium.org/285373015 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271546 0039d316-1c4b-4281-b951-d872f2087c98
-
https://codereview.chromium.org/263643005/rdevlin.cronin@chromium.org authored
https://codereview.chromium.org/263643005/ removed the ExtensionService::ReportExtensionLoadError() method, but apparently I forgot to remove it from the .h file. Whoops. BUG=351891 TBR=yoz@chromium.org Review URL: https://codereview.chromium.org/292893002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271545 0039d316-1c4b-4281-b951-d872f2087c98
-
dalecurtis@chromium.org authored
BUG=none TEST=none Review URL: https://codereview.chromium.org/293883002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271544 0039d316-1c4b-4281-b951-d872f2087c98
-
courage@chromium.org authored
BUG=374973 Review URL: https://codereview.chromium.org/291043002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271542 0039d316-1c4b-4281-b951-d872f2087c98
-
jdduke@chromium.org authored
Currently, overscroll notifications are always sent as a separate IPC message, regardless of the causal event. Instead, bundle the overscroll metadata with the event ack if the event caused the overscroll, saving an IPC message in the most common overscroll case. BUG=328503 Review URL: https://codereview.chromium.org/281723010 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271541 0039d316-1c4b-4281-b951-d872f2087c98
-
chrome://net-internals/#quicrch@chromium.org authored
* Display the connection id correctly * Display the number of packets sent, lost, and received * Display the set of active stream ids Review URL: https://codereview.chromium.org/293763002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271539 0039d316-1c4b-4281-b951-d872f2087c98
-
davidben@chromium.org authored
Currently, navigations within the child frame remain attached to the child frame while it signals the parent to change path and title. This doesn't quite work because location.replace and history.replaceState affect all back/forward list entries which reference that frame's history entry, rather than just the current one. Chrome is currently inconsistent about which of the two behaviors it implements. Fix the settings page to not rely on the bug so it is future-proof. Instead, when embedded, all pushState and replaceState calls are proxied up to the parent which manages history for the child. The child converts all pushState calls to replaceState calls locally. This adds uber.setTitle, uber.replaceState, and uber.pushState calls along with a popState message to uber_utils.js. When running standalone, they call the standard equivalents. When running within the uber page, they delegate to the parent as appropriate. In doing so, this fixes places where chrome://settings-frame and chrome://settings do not set the same URL and title the same. Notably on the search page and treating the default "settings" page as having a path of "" rather than "settings". BUG=317614 TEST=Go to chrome://settings. Open 'Manage search engines...'. Press back. Press refresh. Should stay on search page. Review URL: https://codereview.chromium.org/298553002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271538 0039d316-1c4b-4281-b951-d872f2087c98
-
sashab@chromium.org authored
In the case where there is no 'view in webstore' link, place the version number on the following line. In the case where there is no version _or_ 'view in webstore' link, allow the title to take up multiple lines. BUG=373053 Review URL: https://codereview.chromium.org/274443005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271537 0039d316-1c4b-4281-b951-d872f2087c98
-
xians@chromium.org authored
BUG=337096 TEST=bots Review URL: https://codereview.chromium.org/293673004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271536 0039d316-1c4b-4281-b951-d872f2087c98
-
fukino@chromium.org authored
What this CL do: If there is an item at the drag's starting position and the item is not selected, select the item. Why this handling is needed: If the drag operation is initiated by mouse, the 'mousedown' event eventually selects the pointed item, but there is no such chance when the drag operation is initiated by touch. BUG=373839 TEST=manually tested Review URL: https://codereview.chromium.org/288883004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271535 0039d316-1c4b-4281-b951-d872f2087c98
-
jgraettinger@chromium.org authored
Unstalled pending streams now check that a slot is still available, after posting. A unit-test is added to detect regressions. BUG=373858 Review URL: https://codereview.chromium.org/295823002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271534 0039d316-1c4b-4281-b951-d872f2087c98
-
tedchoc@chromium.org authored
BUG=374176 Review URL: https://codereview.chromium.org/298523002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271533 0039d316-1c4b-4281-b951-d872f2087c98
-
rdevlin.cronin@chromium.org authored
UserScriptSlave was responsible for too much, and the logic was getting cluttered (which also made changes in, e.g. https://codereview.chromium.org/288053002/ difficult to read, write, and review). Refactor the logic to inject the scripts into a new class, so that UserScriptSlave is pretty much just responsible for containing them. BUG=373961 Review URL: https://codereview.chromium.org/284153006 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271532 0039d316-1c4b-4281-b951-d872f2087c98
-
jam@chromium.org authored
I've updated gypi files to not use internal_pdf variable anymore, which was brought in from pdf repo's supplemental.gypi. R=thestig@chromium.org TBR=darin Review URL: https://codereview.chromium.org/294793003 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271531 0039d316-1c4b-4281-b951-d872f2087c98
-
achuith@chromium.org authored
BUG= TEST=trybot, manual. NOTRY=True Review URL: https://codereview.chromium.org/282303013 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271530 0039d316-1c4b-4281-b951-d872f2087c98
-
thestig@chromium.org authored
BUG=348761 NOTRY=true Review URL: https://codereview.chromium.org/296663002 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@271529 0039d316-1c4b-4281-b951-d872f2087c98
-