GitLab

The cu_id_web_contents_map_ can be mutated by observers and can make
the iterator in NotifyObserversIfKnownCu invalid.

See the comment of the regression test for the description of the
scenario that can happen with tab discarding.

Change-Id: I90a7f1710655573fa059bf3f12bf40013ebc7743
Reviewed-on: https://chromium-review.googlesource.com/1107798
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569205}

They are only used for storing an extra ComputedStyle for
display:contents pseudo elements as the ComputedStyle for rendering uses
a display:inline with only properties inherited for the parent element.

Bug: 854563
Change-Id: I4dd3d99b0dee0b538645d005b36347b469799244
Reviewed-on: https://chromium-review.googlesource.com/1107802Reviewed-by: Anders Ruud <andruud@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569204}

Add the @RetryOnFailure annotations. These tests rely on the keyboard
which seems to have massive troubles on some trybots only.

I am still looking for a better way to ensure the keyboard is up and
will try to replace this. If this doesn't improve the tests, the next,
sad step is to disable them temporarily.

Bug: 854326
Change-Id: I7d1bba9a5efa6213fc53c1d84e0fcf88ec3ba9dd
Reviewed-on: https://chromium-review.googlesource.com/1109679Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569203}

Another test that relies on the keyboard to work. Disabling it for now.

(If more tests in this directory flake, feel free to disable them right
away - they are not testing live code. A big rework for all of them is
likely in a forseeable future.)

TBR: bauerb@chromium.org
Bug: 854224
Change-Id: I3b27fd0e500f282ef71d7206ee1ef774edcbe4a5
Reviewed-on: https://chromium-review.googlesource.com/1109682Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569202}

This CL adds IdentityTestEnvironment APIs to interact with the refresh
token state of secondary accounts; these APIs will be needed in an
upcoming CL. In this CL we also change all such test APIs that return
the account ID of a newly-set account to instead return the AccountInfo;
for the upcoming use case, this will be convenient.

Bug: 798699
Change-Id: I9deceae9fb016147fce6206c263acf638d21ef6e
Reviewed-on: https://chromium-review.googlesource.com/1107984
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569201}

Mainly for https://github.com/web-platform-tests/wpt/pull/11344

Rebaselined some affected infra tests.
(Note: a SAB test in html/infrastructure is now failing instead of
timing out because of the wptserve change. The failure is expected
because SAB is currently disabled, so we change the expectation
accordingly.)

Bug: 854473
Change-Id: I0f3218328992141033a593be0882c436ec7ff7a6
Reviewed-on: https://chromium-review.googlesource.com/1108744
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569200}

This patch inttroduces |MoveToParent()| and |MoveToPrevious()| in
|NGPaintFragmentTraversal| class for the patch[1], which uses |MoveToPrevious()|
to find text fragment in same line.

This patch also utilize |MoveToParent()| in |MoveToNext()| to share code for
improving code health.

[1] http://crrev.com/c/1104082 [LayoutNG] Adapt accessibility module to
LayoutNG;

Bug: 774229
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: If65e3015b8f4ed768325c0e13df121c0bc378580
Reviewed-on: https://chromium-review.googlesource.com/1109609Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569199}

Remove accidentely added CHECK in the popup wrapper v6.
added in https://chromium-review.googlesource.com/107530

TBR=rjkroege@chromium.org

Bug: 578890
Change-Id: I375668380a91b71665873bd682c909dad9e7f50a
Reviewed-on: https://chromium-review.googlesource.com/1109516Reviewed-by: Maksim Sisov <msisov@igalia.com>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#569198}

This CL fixes a clipping issue on the focus ring of a folder node in the
MD Bookmark manager sidebar.

Bug: 845736
Change-Id: I12fd4b6b01c11485d7d334c2567d76f750f568a7
Reviewed-on: https://chromium-review.googlesource.com/1107521
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569197}

Using wpt-import in Chromium f4859e36.
With Chromium commits locally applied on WPT:
03ef65db "Update existing WebUSB WPT to be multi-global"
89102421 "Reland "Multi-global WebUSB WPT for window and worker""


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19944

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
ecobos@igalia.com:
  external/wpt/css/css-display

TBR=robertma

No-Export: true
Change-Id: I20fdf09cac1c046629d6e1d009e42de75b256153
Reviewed-on: https://chromium-review.googlesource.com/1109504
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569196}

LayoutBlockFlow::UpdateBlockLayout() has a specialized
positioning for HTML <dialog> element when it is out-of-flow.

This patch implements the logic by sharing the code in
LayoutBlockFlow.

Bug: 635619
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I16870f926dc0ad6fbb6bee4787f3f6d5e30b31c7
Reviewed-on: https://chromium-review.googlesource.com/1108240
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569195}

Also legacy supervised profiles.

Bug: 853198
Change-Id: I8a42363f3f28476f4882605517eac9b1b3512200
Reviewed-on: https://chromium-review.googlesource.com/1103984
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569194}

This CL implements the UI changes for blacklisted WiFi networks.

DesignDoc: http://go/cros-blacklist-ssids

Bug: 837205
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I2e830c5d25a756b7e20fcc9b75f79e8d24f7c6f3
Reviewed-on: https://chromium-review.googlesource.com/1101204
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569193}

Change-Id: I25c5dc28b1080804e569232790aebc2a132c7193
Reviewed-on: https://chromium-review.googlesource.com/1031990
Commit-Queue: Blake O'Hare <blakeo@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569192}

Story has been flaky in system_health.memory_mobile when running as
smoke test on N5X.

NOTRY=true
TBR=nednguyen@google.com

Bug: 852888
Change-Id: I8f82f42d50c6bf5f34bfda1cc42d147444921c05
Reviewed-on: https://chromium-review.googlesource.com/1109512Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569191}

This reverts commit 448f72d0.

Reason for revert: This CL may trigger sizes failing on chromium/Mac, and the failure prevents builds on Mac. So let me try to revert this.

Bug: 854896

Original change's description:
> Add the about flags for the TabManager/RC features.
> 
> Change-Id: Id68cad067bb35f3b11bd8828806860110e8aaf79
> Reviewed-on: https://chromium-review.googlesource.com/1103304
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: François Doray <fdoray@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569094}

TBR=chrisha@chromium.org,fdoray@chromium.org,sebmarchand@chromium.org

Change-Id: I3aa871436e096af1fb4583634b338a139d32c31f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1109321Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569190}

This test is the same as testSucessfullDownload, but downloads in
Incognito.

Also renamed DownloadManagerEGTest to DownloadManagerTestCase.

Bug: 854232
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I873ec4ccad2911702a26b09028ef4e1478731bb2
Reviewed-on: https://chromium-review.googlesource.com/1108935
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569189}

TBR=hayato@chromium.org
NOTRY=true

Bug: 854599
Change-Id: I11a7f53c65992274b9a4f0ce832749a76421b049
Reviewed-on: https://chromium-review.googlesource.com/1109665
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569188}

Fixing "gn check" errors can be frustrating after a coding
session as it only reports the first #include violation in
each file.

Change HeaderChecker to instead record all errors that are
found when checking a file and report all of them.

Bug: none
Change-Id: I2e077090ad176300c570583acecbf34192a9963e
Reviewed-on: https://chromium-review.googlesource.com/1107992Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569187}

Picture-in-Picture API is now enabled by default on Chrome OS, Linux,
Mac, and Windows. Android will come later.

Intent to ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ibVPbqBQapU/rUZIrPPLAQAJ

Bug: 806249
Change-Id: I32fb2b491406e5592e57f64a5483bebf887ebdc0
Reviewed-on: https://chromium-review.googlesource.com/1090728Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#569186}

Adds video formats to the list of files that the CrOS Gallery app
loads and adds support for loading them into <video> element using
stock controls.

Disable editing (crop, rotate, etc.). Pressing 'e' will have no effect
if a video is showing.

Disable most transitions and transforms used for layout of images. They
look silly on video controls.

Remaining follow-ups:
 - add margins when the bottom ribbon overlaps the scrubber,
 - add play icon overlays in the thumbnail view,
 - grey-out/hide the edit and print buttons
 - autoplay video in slideshow (maybe).

Bug: 850372
Test: GalleryJsTest.ImageViewTest
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: Idb582960ccd4141102ff44a70d34a320185853e1
Reviewed-on: https://chromium-review.googlesource.com/1082186
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569185}

This reverts commit 52104cbd.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 569136 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzUyMTA0Y2JkYmE3OGYwMDUwMzU5MjQxNDRhYWIyMDFkY2U2MTViMTUM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/10528

Sample Failed Step: components_unittests

Original change's description:
> [AF] Add CTR and save rate metrics split out by security level.
> 
> This Cl adds autofill metrics based on the security level. The
> goal is to see whether the security level impacts the CTR of
> autofill suggestions or the card save rate.
> 
> Bug: 853347
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: I75ce8c6b924d7fd90e80e518af46509bb6bccde2
> Reviewed-on: https://chromium-review.googlesource.com/1103218
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Christopher Thompson <cthomp@chromium.org>
> Reviewed-by: Tao Bai <michaelbai@chromium.org>
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#569136}

Change-Id: I16e9c57d18fbb81e37742bee5269816e7be377a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 853347
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1109618
Cr-Commit-Position: refs/heads/master@{#569184}

compile_db.py needs to split commands in non-posix mode on Windows.

Bug: 844348
Change-Id: I5fdcb84fb8ddca7765d5d96b66ee1c54236b9265
Reviewed-on: https://chromium-review.googlesource.com/1107812
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569183}

css_selector.h is included by element.h, which is one of most popular
header in Blink.  This CL reduces pre-processed size of element.h from
3.78MB to 2.98MB.

Change-Id: I8a3ca9dca94bfcfbabf2e7467f64484c35d93a6e
Reviewed-on: https://chromium-review.googlesource.com/1109584Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569182}

Duplicated header caused Visual Studio error when opening platform.vcxproj
project.

error : Cannot load project with duplicated project items:
../../../../../../../third_party/blink/renderer/platform/graphics/compositor_mutator.h
is included as 'None' and as 'None' item types.

Change-Id: Iee35d7ef24dce3083c291858546fbe5b80428ee9
Reviewed-on: https://chromium-review.googlesource.com/1107921Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Cr-Commit-Position: refs/heads/master@{#569181}

This is for some slow tryjob due to long compile step in win7_chromium_rel_ng builder

examples from last 1 day
5384s https://ci.chromium.org/b/8943206699896945232
4334s https://ci.chromium.org/b/8943216691368144464
3743s https://ci.chromium.org/b/8943167746216898688
3628s https://ci.chromium.org/b/8943196039037892016

Bug: 804251
Change-Id: I5ae7a42e38aa143975034ee2da9b1f377feac7d3
Reviewed-on: https://chromium-review.googlesource.com/1109605Reviewed-by: Erik Staab <estaab@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569180}

This CL replaces MockTimer with MockOneShotTimer or MockRepeatingTimer
as a preparation of OnceCallback support of base::Timer.

Bug: 850247
Change-Id: I85e43788e923593dab7ad43794cf9289fc788fcd
Reviewed-on: https://chromium-review.googlesource.com/1107531Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569179}

Updating the done button behavior to follow these rules:
- If I'm looking at something, that's where I end up when I press done.
- If I'm looking at recent tabs, then ending up where I began is least
surprising.

Bug: 836312
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Idcac4af078aa0e8ca658aec8601db212b21585c0
Reviewed-on: https://chromium-review.googlesource.com/1108749Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569178}

Bug: 842171
Change-Id: I225a5a3a5c23a7c0878f352f53a5e6dcec3c0df7
Reviewed-on: https://chromium-review.googlesource.com/1108741Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569177}

Another update to annotations.xml as annotation tests were not active
on Windows for a few days.

Change-Id: I668239db1ba577b04850e0833d6c16e4319e0dcf
TBR: msramek@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1109506Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569176}

Previously, model changes and table updates were not synchronized for
handling "Hide for now" on long presses in recent tabs.

This CL moves the model changes into the same block as table updates
so that they are fed together into |-performBatchUpdates:| in iOS 11
and |-beginUpdates| in iOS 10.

This was only crashing in iOS 10 iPad, but theoretically, it is wrong
and would crash in other configurations.

Bug: 851946
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I4fe35eb06cf77d1fb6097a5508d72dd1e93fc6ee
Reviewed-on: https://chromium-review.googlesource.com/1108346Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569175}

Check all the members of WebStatePolicyDecider::RequestInfo instead of only checking
the target frame in NavigationAndLoadCallbacksTest.


Bug: 850760
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7be2bc81f613a2a4d7d052634ab3a96edb8bf267
Reviewed-on: https://chromium-review.googlesource.com/1101499
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569174}

Test: keyboard_unittests
Change-Id: If0144253d227b3d46813fa2e7f339359fd70874c
Reviewed-on: https://chromium-review.googlesource.com/1109602Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Yuichiro Hanada <yhanada@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569173}

In order to ensure media files can enter fullscreen mode, manually
handle fullscreen states. Basically, a compositor sends configuration
events on each request for state changes from clients asynchronously,
which is unefficient for media files when they enter a fullscreen mode.

For example, when a youtube video file is being set to fullscreen, a
WaylandWindow is also set to a fullscreen mode, but the return value from
the WaylandWindow::GetPlatformWindowState still contains an old value until
the compositor calls with a configuration event. This short race is
enough for a media content to be placed in a forever "entering fullscreen"
state, which never results in a fullscreen state for media files.

Bug: 843018
TEST: XdgVersionV5Test/WaylandWindowTest.SetFullscreenAndRestore/0
XdgVersionV6Test/WaylandWindowTest.SetFullscreenAndRestore/0

Change-Id: Ib9bc8c0ce09412c36437d165efc6a0cad60c4d17
Reviewed-on: https://chromium-review.googlesource.com/1107636Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#569172}

This CL adds support for launching Crostini apps from the File Manager.
For the moment, we only support files which are already in the Crostini
container, but in the future we will support external files as well.

Support for display app icons will be added in a separate patch, but as
it will require FindCrostiniTasks to be asynchronous, it is made to take
a callback to run upon completion.

Bug: 822513
Change-Id: I257b482991ab8cf2e4d0ef5be18d0e33205df4e3
Reviewed-on: https://chromium-review.googlesource.com/1100606
Commit-Queue: Timothy Loh <timloh@chromium.org>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569171}

This CL merges EventQueue and EventQueueImpl into one class.

Design Doc: https://docs.google.com/document/d/1BBtBPTarOF4NeVKSWZe3XaDHo4yTGhdlqYm35yVzPs4/edit#

Bug: 846618
Change-Id: I302f99848ec59f16e7c8c2f1a5ca14aa0896a21a
Reviewed-on: https://chromium-review.googlesource.com/1107527Reviewed-by: Hayato Ito <hayato@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569170}

We tried running incremental marking from a normal task but noticed it could cause large delays when there are many queued tasks.

This moves incremental marking step/finalize to RunScheduledGC where we run after every task.

Change-Id: Ibdd4ee0f7fa3a2ac1245c37581c0109f0206f94a
Reviewed-on: https://chromium-review.googlesource.com/1109455Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Keishi Hattori <keishi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569169}

SelectionPaintRange::Iterator iterated LayoutObjects using layout order
but we marks SelectionStatus on flat tree order.
This causes invalidation leak if they are not same order.
Ruby element is a reported example for that.

This patch changes SelectionPaintRange::Iterator iterate on a flat tree
considering first-letter.

Bug: 843144
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I02cbad86e64d0a7781f8fb37e2d13c7aa00228fb
Reviewed-on: https://chromium-review.googlesource.com/1063521
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569168}

SandboxedUnpacker::ReportUnpackingError posts a task on the
|unpacker_io_task_runner_| to report unpacking failures. However, all its
callers are on |unpacker_io_task_runner_| itself. Prevent unnecessarily posting
a task by merging ReportUnpackingError and UnpackExtensionFailed methods.

BUG=None

Change-Id: Id229392333d0236fd60a5cce0cf642f3aa436ab8
Reviewed-on: https://chromium-review.googlesource.com/1108574
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#569167}

https://webrtc.googlesource.com/src.git/+log/db6af36979b6..5b8dd4d75ec3


git log db6af36979b6..5b8dd4d75ec3 --date=short --no-merges --format='%ad %ae %s'
2018-06-20 qingsi@google.com Fix a dangling-pointer bug in P2PTransportChannel unit tests.
2018-06-20 steveanton@webrtc.org Remove unused/deprecated DTMF methods
2018-06-20 deadbeef@webrtc.org Removing some TSan suppressions around Thread class.


Created with:
  gclient setdep -r src/third_party/webrtc@5b8dd4d75ec3

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Iabc7455f5f50a84a3a1ba22e51ef45ba67bc6121
Reviewed-on: https://chromium-review.googlesource.com/1109517Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#569166}