GitLab

Enterprise.DevicePolicyInvalidations can take the values [0, 1, 3, 4],
not [0, 1, 2, 3] as erroneously specified in histograms.xml.

BUG=None
TEST=None

Review URL: https://codereview.chromium.org/1067323002

Cr-Commit-Position: refs/heads/master@{#324408}

BUG=444203

Review URL: https://codereview.chromium.org/1063413002

Cr-Commit-Position: refs/heads/master@{#324407}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ec58772..eb1578b

TBR=keishi@chromium.org

Review URL: https://codereview.chromium.org/1069983003

Cr-Commit-Position: refs/heads/master@{#324406}

R=posciak@chromium.org, wuchengli@chromium.org
BUG=none
TEST=play h264 html5 video

Review URL: https://codereview.chromium.org/1048773002

Cr-Commit-Position: refs/heads/master@{#324405}

Revert of Make ui/gl depend on the necessary runtime targets on Windows. (patchset #3 id:40001 of https://codereview.chromium.org/1070933002/)

Reason for revert:
This CL introduces a typo to the GN build file, so that Windows GN builds fail.

It should be possible to reland after below line is changed from appending to assignment.

ERROR at //ui/gl/BUILD.gn:203:5: Undefined variable for +=.
    data_deps += [
    ^--------
I don't have something with this name in scope now.

See: http://build.chromium.org/p/chromium.win/builders/Win8%20GN

Original issue's description:
> Make ui/gl depend on the necessary runtime targets on Windows.
>
> Committed: https://crrev.com/f4a6e44ff20c29a6410a698a06a45dd11666ef53
> Cr-Commit-Position: refs/heads/master@{#324320}

TBR=brettw@chromium.org,scottmg@chromium.org,jam@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1071113002

Cr-Commit-Position: refs/heads/master@{#324404}

Addressing comments from CL 1004733003.

Review URL: https://codereview.chromium.org/1038203003

Cr-Commit-Position: refs/heads/master@{#324403}

We now stream deferred and parsing blocking scripts too, so some obsolete
histograms are no longer obsolete. Added new histograms.

R=isherman@chromium.org
BUG=

Review URL: https://codereview.chromium.org/1068203002

Cr-Commit-Position: refs/heads/master@{#324402}

This moves the image IDRs used on the chrome side back from IDR2_ to the
IDR_ versions. (The next and final patch will remove the IDR2_s from
webkit.)

BUG=471609, 467176

Review URL: https://codereview.chromium.org/1073523004

Cr-Commit-Position: refs/heads/master@{#324401}

In some cases we encounter situation when in processing onSubmit of password form we didn't receive information from password store yet. For example this can happen when JavaScript creates password form after submission and submit it (as for nytimes.com).

To process such situation this CL postpones checking if password form fetched from store until moment when we are going to decide if we should save it.

In order to process this correctly creating pending credentials in PasswordManager was moved to separate method and it is called only when both events happen - form submission and fetching from store finished.

Tests are not added yet

BUG=470322

Review URL: https://codereview.chromium.org/1050903002

Cr-Commit-Position: refs/heads/master@{#324400}

Replace the struct workaround for forward-declaring ChromeViewHostMsg_GetPluginInfo_Status with a proper enum class.

Review URL: https://codereview.chromium.org/1069703002

Cr-Commit-Position: refs/heads/master@{#324399}

It should mention that Windows is the only supported platform.

BUG=474961

Review URL: https://codereview.chromium.org/1069753002

Cr-Commit-Position: refs/heads/master@{#324398}

BUG=475377
TEST=manually

Review URL: https://codereview.chromium.org/1071033003

Cr-Commit-Position: refs/heads/master@{#324397}

BUG=475328

Review URL: https://codereview.chromium.org/1071603006

Cr-Commit-Position: refs/heads/master@{#324396}

Immediately select through the edge on external drags.
Fix minor OBO for external bounds checking.

BUG=415907
TEST=Quickly dragging outside the textfield immediately selects visible text.
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/1073523005

Cr-Commit-Position: refs/heads/master@{#324395}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/7557b3f..ec58772

TBR=cbiesinger@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/1071103002

Cr-Commit-Position: refs/heads/master@{#324394}

The cryptauth component also uses base64url encoding, but cannot depend on
proximity_auth.

BUG=420316

Review URL: https://codereview.chromium.org/1063323002

Cr-Commit-Position: refs/heads/master@{#324393}

The patterns are internally sorted from the lowest precedence to highest (i.e.
from the less specific pattern to the most specific, though the rules are more
complicated than that), and they were shown to the user in this order too,
which was confusing and making them think it's not sorted at all. Showing the
highest precedence patterns first should be more intuitive and also sort the
equivalent patterns more-or-less alphabetically.

BUG=450580

Review URL: https://codereview.chromium.org/1047153002

Cr-Commit-Position: refs/heads/master@{#324392}

BUG=475313
TEST=manually

Review URL: https://codereview.chromium.org/1077513002

Cr-Commit-Position: refs/heads/master@{#324391}

Follow-up CL for https://codereview.chromium.org/1045173003/

BUG=472006
R=vabr@chromium.org

Review URL: https://codereview.chromium.org/1066423002

Cr-Commit-Position: refs/heads/master@{#324390}

Currently LTHI "background ticks" animations once every second. This background
ticking doesn't have any js detectable effect, nor user visible effects, which
means it is just wasting CPU cycles (and thus power).

BUG=371747
R=jdduke,brianderson,danakj

Review URL: https://codereview.chromium.org/1050833002

Cr-Commit-Position: refs/heads/master@{#324389}

Cr-Commit-Position: refs/heads/master@{#324388}

This test (for unknown reasons) depends on the frame being visible and
currently only passes because of an artificial delay in the compositor when
going invisible. This is probably way it is already disabled on Mac and
Windows.

The patch at http://crrev.com/1051123002 removes this delay causing this test
to become extremely flaky. See http://crbug.com/282116

BUG=282116
R=lazyboy,fsamuel

Review URL: https://codereview.chromium.org/1069803003

Cr-Commit-Position: refs/heads/master@{#324387}

BUG=455366
TBR=mmenke@chromium.org,gunsch@chromium.org

Review URL: https://codereview.chromium.org/1070893002

Cr-Commit-Position: refs/heads/master@{#324386}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a6ad902..7557b3f

TBR=cbiesinger@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/1071763004

Cr-Commit-Position: refs/heads/master@{#324385}

This adds tests for a search in Downloads. It first performs a basic search,
it then checks that the search is case-insensitive and performs a search that
should match no files and checks the correct error string is displayed.

TEST=browser_tests --gtest_filter="*FileDisplay/FileManagerBrowserTest/{4,5,6}*"
BUG=None

Review URL: https://codereview.chromium.org/1067983002

Cr-Commit-Position: refs/heads/master@{#324384}

When becoming invisible we are going to abort any pending draw / activate. We
should do that right now rather then waking up sometime in the future and doing
it. This increases the speed at which we become idle after going invisible.

A minor side effect is we will do more work if we become invisible and then
visible within a single frame, but this case is extremely unlikely while the
case compared to becoming invisible for a longer period.

Related to http://crrev.com/1050833002

BUG=371747
R=brianderson,jdduke

Committed: https://crrev.com/c7c617b8619518568d2267015a5ee32aed7df883
Cr-Commit-Position: refs/heads/master@{#323397}

Review URL: https://codereview.chromium.org/1051123002

Cr-Commit-Position: refs/heads/master@{#324383}

zero-copy: Clarify to allocate/destroy GpuMemoryBuffer on any thread and use it on the main thread only

Add many thread check to clarify it.

BUG=473125

Review URL: https://codereview.chromium.org/1050923003

Cr-Commit-Position: refs/heads/master@{#324382}

Change the name and move it to a more generic place so that it can be used
by ChromeMobileApplication.

BUG=428860

Review URL: https://codereview.chromium.org/1063033002

Cr-Commit-Position: refs/heads/master@{#324381}

This CL refactors VideoCaptureBufferPool, and in
particular its inner class Buffer, to allow pooling
GpuMemoryBuffers. For that, Buffer is renamed to
Tracker, and turned into a base class, where SharedMemory
specifics are implemented in SharedMemoryTracker.

In ToT, VideoCaptureDeviceClient calculates the
linear size in bytes needed for holding the captured
VideoFrame. This responsability is shifted into the
VCBPool, so in the inmediate future, GpuMemoryBuffers
can be allocated. To support this, VCBP::ReserveForProducer()
gets the pixel format and dimensions.

VideoCaptureDevice::Client::ReserveOutputBuffer()
goes through the same parameter upgrade.

(In the next CL, a GpuMemoryBufferTracker class
is introduced, allowing VCBP::ReserveForProducer()
will allocate GMBs if so instructed via the pixel
format.)

BUG=440843

Review URL: https://codereview.chromium.org/1064703002

Cr-Commit-Position: refs/heads/master@{#324380}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b06aa90..a6ad902

TBR=cbiesinger@chromium.org,keishi@chromium.org

Review URL: https://codereview.chromium.org/1073703002

Cr-Commit-Position: refs/heads/master@{#324379}

Tested on Linux with the following command lines:

$ rm -rf out/
$ ./build/gyp_chromium
$ ninja -C out/Debug sandbox_linux_unittests
$ out/Debug/sandbox_linux_unittests

BUG=138542
TEST=see above
R=jln@chromium.org,mdempsky@chromium.org

Review URL: https://codereview.chromium.org/1062223002

Cr-Commit-Position: refs/heads/master@{#324378}

Stop the daemon process from repeatedly starting up and shutting down the network process when the host has been unregistered.

We have two bugs in the chromoting host that caused the repeated startup and shutdown of the network process when the host has be unregistered:
1. The host process never exits naturally. As a result, the WorkerProcessLauncher in the daemon process never receives the exit code and thus isn't aware that a "permanent" error occured.
2. If a host has service account enabled, it gets kInvalidOauthCredentialsExitCode instead of kInvalidHostIdExitCode if the host has been unregistered in the service directory. But we only disable the service upon the latter.

Issue 1 is a regression from https://codereview.chromium.org/891663005 which added a dangling reference to the UrlRequestContextGetterin HostProcessMain. This leaked object will also keep the Network task runner, and thus the UI task runner alive. So the message loop in HostProcessMain never quits.

I created crbug.com/475213 to track the original DCHECK.

BUG=472884

Review URL: https://codereview.chromium.org/1061903002

Cr-Commit-Position: refs/heads/master@{#324377}

This currently breaks at runtime both cast_shell and cast_shell_apk
and I wasn't able to find an easy fix. I'd like to unblock our other development in the meantime.

Half-revert of https://codereview.chromium.org/1019123002/

TBR=jochen@chromium.org
R=rmcilroy@chromium.org,lcwu@chromium.org
BUG=421063

Review URL: https://codereview.chromium.org/1073583004

Cr-Commit-Position: refs/heads/master@{#324376}

- DRP NetworkDelegate/BypassStats are no longer aware of the UI thread.
- Add thread hopping functionality to DRP IOData/Service, using the
  correct WeakPtr to post tasks safely.
- Construct BypassStats in the IOData constructor.

BUG=472290

Review URL: https://codereview.chromium.org/1054363002

Cr-Commit-Position: refs/heads/master@{#324375}

BUG=469409
TEST=Test on Nyan, which has both H.264 and VP8 HW encoder.
     It should choose VP8 instead of H.264.

Review URL: https://codereview.chromium.org/1034433002

Cr-Commit-Position: refs/heads/master@{#324374}

BUG=474876

Review URL: https://codereview.chromium.org/1064393002

Cr-Commit-Position: refs/heads/master@{#324373}

Both cmake310_Linux.tgz and cmake310_Darwin.tgz exist now.
I'll remove the poorly named cmake310.tgz when this has landed.

BUG=452726

Review URL: https://codereview.chromium.org/1073673002

Cr-Commit-Position: refs/heads/master@{#324372}

The header is included for __NR_SYSCALL_BASE and __ARM_NR_BASE.
Some toolchain (in particular, PNaCl toolchain) does not provide
asm/unistd.h (so that neither __NR_SYSCALL_BASE nor __ARM_NR_BASE
is provided).
This CL removes the dependency to asm/unistd.h from linux_syscall_ranges.h,
instead define the values if necessary.

Also, this CL removes the include from syscall.cc, too, which is
unused.

TEST=Ran bots.
BUG=358465

Review URL: https://codereview.chromium.org/1071653002

Cr-Commit-Position: refs/heads/master@{#324371}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/a0219f1..35f5576

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1068243004

Cr-Commit-Position: refs/heads/master@{#324370}

This is safe to do because the custom action is only executed if the startup type was already auto at the beginning of the installation.

BUG=472887

Review URL: https://codereview.chromium.org/1071013002

Cr-Commit-Position: refs/heads/master@{#324369}