- 09 May, 2018 40 commits
-
-
chromeos-commit-bot@chromium.org authored
BUG=762641 TBR=sammiequon@google.com Change-Id: I427347e23b428da6344f13de9c826e2858ffb975 Reviewed-on: https://chromium-review.googlesource.com/1051947 Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#557157}
-
Hans Wennborg authored
Bug: 837440 Change-Id: I216c457b53e795d229228e03df8dad42ac78dc07 Reviewed-on: https://chromium-review.googlesource.com/1049654Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#557156}
-
Pavol Marko authored
The TabUnderProtectionEnabled policy was renamed to TabUnderAllowed in CL:995632. Rename the value in enums.xml too. Bug: b/77374536 Change-Id: I0eede70c436b4e5260cb02e19838f2d22528594c Reviewed-on: https://chromium-review.googlesource.com/1035322Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#557155}
-
Mohamed Amir Yosef authored
This CL implements the remote creation of bookmarks on the server. It take many shortcuts that will be addressed in later patches such as a naive ordering algorithm that assumes all bookmarks are created under the bookmarks bar directly. Bug: 516866 Change-Id: I10059fd3b7521927fb4db6b9ce0284f33fadead8 Reviewed-on: https://chromium-review.googlesource.com/1017201 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557154}
-
kylechar authored
EmbeddedFrameSinkImpl enforced that it only created a CompositorFrameSink one time. This doesn't work well with OOP-D and isn't the approach taken for CompositorFrameSinks, so just remove that condition. This will destroy the old CompositorFrameSinkImpl and create a new CompositorFrameSinkImpl. Bug: 768565 Change-Id: I7dcfdc35bd33fcb20544c22baa7417eaf84011b7 Reviewed-on: https://chromium-review.googlesource.com/1050436Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#557153}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I30970fd51dd869abd73b1b16109e44178fbcee2e Reviewed-on: https://chromium-review.googlesource.com/1051688 Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557152}
-
Yoshifumi Inoue authored
This patch changes |CharacterIterator::CurrentContainer()| to return |const Node&| instead of |const Node*| since it always non-null for improving code health. This patch is a follow-up of the patch[1]. [1] http://crrev.com/c/1050053 Make TextIterator::CurrentContainer() to return const Node&. Change-Id: If2dc187244e4e8a489b56f9855b786c191579d9b Reviewed-on: https://chromium-review.googlesource.com/1051138 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#557151}
-
Yoshifumi Inoue authored
This patch changes |DocumentMarkerController::AddMarkerToNode()| to take |const Node&| instead of |const Node*| since it always non-null for improving code health. This patch is a follow-up of the patch[1]. [1] http://crrev.com/c/1050053 Make TextIterator::CurrentContainer() to return const Node&. Change-Id: I7041a969f730d07fcccaa8d745b6f2cb02ecbaab Reviewed-on: https://chromium-review.googlesource.com/1051068 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#557150}
-
Maksim Sisov authored
This cl adds an initial support for Ozone (Linux) builds by utilizing DekstopWindowTreeHostPlatform design. Actually, it looks very similar to DesktopWindowTreeHostX11 with a difference that this design in this CL uses Ozone abstraction layer to communicate with Wayland and other backends. In overall, BrowserDesktopWindowTreeHostPlatform, which is actually DesktopWindowTreeHostPlatform, is created and initialized, which triggers creation of a PlatformWindow, which can be either Wayland, or X11, or other ozone platform. Also, DesktopScreenOzone class is added. This object inherits ScreenBase and is meant to fetch displays data from underlaying ozone backends and provide aura with necessary data. Bug: 578890 Change-Id: I2d203cd6d1a6ddea0afe062059c6c1f9eecdafd3 Reviewed-on: https://chromium-review.googlesource.com/1039567 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#557149}
-
Yoshifumi Inoue authored
This patch changes |DocumentMarkerController::RemoveMarkersInternal()| to take |const Node&| instead of |const Node*| since it always non-null for improving code health. This patch is a follow-up of the patch[1]. [1] http://crrev.com/c/1050053 Make TextIterator::CurrentContainer() to return const Node&. Change-Id: I246eedf7cc4bb651d50ff0b6d50065e89f2312a3 Reviewed-on: https://chromium-review.googlesource.com/1051137 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
vitaliii authored
TBR=tommycli@chromium.org Bug: 841195 Change-Id: If5dca6a78dba27e63a01acd0ef7606f7e9eb78ea Reviewed-on: https://chromium-review.googlesource.com/1051648Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557147}
-
Stuart Langley authored
This updated takes any stored changestamps for directories and for the ResourceMetadataHeader and convers them to startPageTokens, which essentially just adds 1 to the current value and writes it out as a string. Bug: 840211 Change-Id: I0e5d736daae632a85d55fa549bae3ffdf81f0584 Reviewed-on: https://chromium-review.googlesource.com/1051213Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#557146}
-
Gauthier Ambard authored
This CL fixes the animation occuring when opening a new tab in background when the flag to enable BrowserContainer fullscreen. Bug: 836730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifa1abee606888938fe3b551903e16f92c7c60698 Reviewed-on: https://chromium-review.googlesource.com/1032772Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#557145}
-
Yoshifumi Inoue authored
This patch changes |TextIterator::CurrentContainer()| to return |const Node&| instead of |const Node*| since it always non-null for improving code health. Change-Id: Idb0a827d78afe7a8b27e398db7023527a2f2380a Reviewed-on: https://chromium-review.googlesource.com/1050053 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Josh Karlin authored
Bug: 793025 Change-Id: I433fd34af2ef79c5f29761c9f0aea8a794682842 Reviewed-on: https://chromium-review.googlesource.com/1047827Reviewed-by:
-
Wez authored
The AutoRoll server is located here: https://fuchsia-sdk-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio TBR=cr-fuchsia+bot@chromium.org Bug: 841171 Change-Id: I4c23bacf4f44799b63cebefe51a5f94965408bd8 Reviewed-on: https://chromium-review.googlesource.com/1051263 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557142}
-
Vadym Doroshenko authored
This CL implements UniqueRendererFormId and UniqueRendererFormControlId methods in forms and form control elements correspondingly, which return consecutive numbers of the current form and the form control element in the current renderer process. Hence these ids are unique in the same Renderer process modulo unsigned int overflow (which is not the problem for Password Manager and Autofill). Details go/blink-form-stable-ids Bug:831119 Change-Id: Ie0c54363bc069b0f8953a3238ccd08262c7efd3c Reviewed-on: https://chromium-review.googlesource.com/1002847 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#557141}
-
Wez authored
ReadIfReady() either completes synchronously, or notifies the caller when it should be called again, rather than completing asynchronously. Bug: 841180 TBR: xunjieli Change-Id: I70258381380feea49279cb81a7f285f2b1d11f01 Reviewed-on: https://chromium-review.googlesource.com/1051447 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
-
Yoichi Osato authored
This patch expands ComputeSelectionType at call site because if selection is none can be caught more early and logic is now simple. Change-Id: I6d5c7a7279097fbe0312d29cbf009d7424ff519b Reviewed-on: https://chromium-review.googlesource.com/1051211 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557139}
-
https://chromium.googlesource.com/chromiumos/chromite.git/+log/9520b5b98bd3..7aaefdbb734f $ git log 9520b5b98..7aaefdbb7 --date=short --no-merges --format='%ad %ae %s' 2018-04-30 cmtice Re-enable CFI on caroline and terra release builders. 2018-05-08 ayatane sysmon: Fix error reference Created with: roll-dep src/third_party/chromite BUG=chromium:838428,chromium:840873 The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If6a4c93d5ee5c6ce8af44cb19895b5ce12b72dcb Reviewed-on: https://chromium-review.googlesource.com/1051325Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#557138}
-
Stuart Langley authored
This cl adds start_page_token to ResourceMetadataHeader and DirectorySpecificInfo for supporting change list retrival based on startPageToken instead of largestChangeId. Bug: 840211 Change-Id: Ib498276b48b28dc1876fc9a70a4a1356b60ddeb9 Reviewed-on: https://chromium-review.googlesource.com/1050052Reviewed-by:
-
Wez authored
This adds the necessary SDK library dependency for the Fuchsia build to compile in component mode. Bug: 756269 TBR: dpranke Change-Id: I110a4599273967aa99709ed20f187f2e2713b05a Reviewed-on: https://chromium-review.googlesource.com/1048633Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#557136}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 6bb87810. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17180 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=danyao No-Export: true Change-Id: Ic649836c332f5c8c982594cc7ae682df3588b391 Reviewed-on: https://chromium-review.googlesource.com/1050453 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#557135}
-
Christian Dullweber authored
On every history deletion or expiration, both SiteEngagementService and MediaEngagementService request an OriginCountAndLastVisitMap from history_service. This map is expensive to create, so we prepopulate history::DeletionInfo with it to only do this calculation once. This CL will also remove the DeletionTimeRange for deletions due to expiration as these are not handled anyway and cause some unneccessary observer calls if deleted_rows is empty. Bug: 808031 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia31384dce4115b90d725279d2847ec118a952643 Reviewed-on: https://chromium-review.googlesource.com/1046945 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#557134}
-
tzik authored
libc++ starts using aligned new operator when it's in C++17 mode, but system libc++ on Mac doesn't have it, and that causes a link error. This CL turn on _LIBCPP_HAS_NO_ALIGNED_ALLOCATION to avoid using the unavailable aligned allocation. Bug: 752720 Change-Id: I89be50bcc26d23a43da3b807109a1271fcf141f0 Reviewed-on: https://chromium-review.googlesource.com/1049186 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
-
Erik Luo authored
Expanding an ElementsTreeElement used to immediately set a populated flag to true before requesting getChildNodes(). If a ChildNodeCountUpdated event arrives before the children are set, we may call updateModifiedParentNode() and try to create visibleChildren when they are null, breaking the tree. This CL moves the place where 'populated' is set, so that updateModifiedParentNode() does not update tree children before they are available. Bug: 829884 Change-Id: Id68e71fb7a58336d781207b298a53354af3e5cfc Reviewed-on: https://chromium-review.googlesource.com/1049113 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#557132}
-
David 'Digit' Turner authored
This modifies the internal crazy::SearchPathList class to support looking up libraries inside zip archives, in two ways: - First, by supporting paths with an exclamation mark, used as a delimiter between zip archive paths, and file sub-paths within it. For example, looking for: /path/to/archive.zip!libs/libfoo.so Will search the zip archive at /path/to/archive.zip for a file named libs/libfoo.so. Note that path items added through AddPaths() can also contain an exclamation mark. - Second, automatically support zip files stored with a 'crazy.' prefix (e.g. /path/to/archive.zip!libs/libfoo.so will match a file named 'libs/crazy.libfoo.so' in the archive too. This is useful to store uncompressed libraries inside Android APKs while preventing the system from extracting them when the application is installed or updated. Note that this does not modify the rest of the crazy linker to use this for now (e.g. to implement LoadLibraryFromZipFile()), since this will require more work (to be provided in a future CL). BUG=802068 R=agrieve@chromium.org,pasko@chromium.org,lizeb@chromium.org Change-Id: Ic8661332e4e4537a472e325b74c8c001ea2bc113 Reviewed-on: https://chromium-review.googlesource.com/1042394 Commit-Queue: David Turner <digit@chromium.org> Reviewed-by:agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#557131}
-
Gauthier Ambard authored
This CL allows the toolbar to have non-zero height in fullscreen. It can be used with the UI Refresh and the Browser Container being fullscreen. Bug: 807572, 836730 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If292c787596be8d543142cdf75c5b1d27eb66e4c Reviewed-on: https://chromium-review.googlesource.com/1030393Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#557130}
-
Koji Ishii authored
The new approach to apply the 'text-transform' property to ::first-line pseudo element[1] has a known issue that, since it transforms at paint time, line breaking is measured against non-transformed text. The test fast/text/transform-text-first-line.html relies on line breaking is measured against small letters, but this issue does not exist in LayoutNG. This patch fixes the test by using Ahem. Because Ahem has different glyph but the same width for small letter 'p', it can test which letters are capitalized without line breaking being affected by the issue. [1] https://chromium-review.googlesource.com/603855 TBR=eae@chromium.org Bug: 129669, 644733, 636993 Change-Id: Ie0a14652c43d4b863ea0fd9bf40d8ab17f39d0ea Reviewed-on: https://chromium-review.googlesource.com/1051067Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#557129}
-
Hirokazu Honda authored
Always output thumbnails in thumbnail testcase. the output thumbanils file name contains "good" if the thumbnail test case is passed, and on failure it contains "bad." BUG=chromium:834170 TEST=VDA unittest on kevin TEST=VDA unittest on non-Chrome OS platforms in CQ. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I428793cd6428420495be9a3ab60170669e5f51fe Reviewed-on: https://chromium-review.googlesource.com/1039104 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Cr-Commit-Position: refs/heads/master@{#557128}
-
John Rummell authored
Add code so that media encrypted in 'cbcs' encryption scheme can be handled by AesDecryptor. This adds 2 new classes: aes_cbc_crypto.* handles AES-CBC-128 decryption using the BoringSSL code to allow for decryption without padding and to avoid extra copies of the data. cbcs_decryption.* supports pattern decryption. Both classes have unit tests to verify their basic functionality. BUG=657957,658026 TEST=content_browsertests pass Change-Id: Ia0a8db2859ff4f815a0cfcc705f7ea50d77a115c Reviewed-on: https://chromium-review.googlesource.com/1038725 Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:Kongqun Yang <kqyang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#557127}
-
Kunihiko Sakamoto authored
This is a preparation for the CBOR certificate chain support, in which the CBOR parser requires input of type base::span<const uint8_t>. Bug: 803774 Change-Id: I16f96544b3accbf365a826d5c767e479aa7ef11b Reviewed-on: https://chromium-review.googlesource.com/1051187Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#557126}
-
Greg Thompson authored
This reverts commit 933cf169. Reason for revert: Handle leak causing test failures. Original change's description: > Win Native Notifications: Fix window activation. > > This fixes the issue with window activation not functioning correctly > when notifications are activated while Chrome is running but in the > background. > > Bug: 837796, 734095 > Change-Id: I8eac14403850a13d60e7a50c3c795fed96205d7e > Reviewed-on: https://chromium-review.googlesource.com/1049984 > Reviewed-by: Greg Thompson <grt@chromium.org> > Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556955} TBR=finnur@chromium.org,grt@chromium.org Change-Id: Ib0e0d132867555f822dc13061b63bca123c16df9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 837796, 734095 Reviewed-on: https://chromium-review.googlesource.com/1051385Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#557125}
-
Mikel Astiz authored
Tab sync entities are expected to have a valid |tab_id| field over the sync protocol, but clients should not crash if the received data is corrupt, e.g. committed by a buggy client. Prior to this patch, foreign sessions received in SessionsSyncManager, processed via UpdateTrackerWithSpecifics(), could trigger a CHECK failure in SyncedSessionTracker::GetTab(). Bug: 840876 Change-Id: Ie59cfb9c24934695a1b7b6187dbad48451f8c8ea Reviewed-on: https://chromium-review.googlesource.com/1051233Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#557124}
-
Patrik Höglund authored
This didn't end up quite right. I didn't realize chromium.webrtc doesn't have any debug bots, so I removed that category. Also sorted fyi debug-release consistently. Bug: chromium:840277 Change-Id: Ie8d174fa99504e576a78c75363bed8f10bb854ac Reviewed-on: https://chromium-review.googlesource.com/1049687Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#557123}
-
Pavol Marko authored
Bug: none Change-Id: Iac34093a83534359bcdad650a3475198a9fc576e Reviewed-on: https://chromium-review.googlesource.com/1050525Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#557122}
-
Farah Charab authored
Upon task queue instantiation, populate frame_scheduler when task queue is associated to a frame. Bug: 839485 Change-Id: Iea60faf8dd5f015240a866e7189f252216982ce8 Reviewed-on: https://chromium-review.googlesource.com/1042577 Commit-Queue: Farah Charab <farahcharab@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#557121}
-
Fredrik Söderquist authored
This reverts commit 3431b89c. Reason for revert: Tickled fuzzers Original change's description: > [CI] Convert SVG resources to use SVGResource > > From using AtomicString (for 'mask', 'marker-*', 'fill' and 'stroke') or > the string representation of SVGResources ('filter' and 'clip-path'), > convert to using SVGResources. > Add an implementation of SVGResourceClient (SVGElementResourceClient) > and register it with the existing resources. Invalidation code is moved > here. This makes the invalidation code slightly more homogeneous between > the various code-paths. > > The new SVGResourceClient implementation is stored in SVGElementRareData > as needed. > The various computed style representations are converted to use the new > StyleSVGResource, which is a ref-counted wrapper around an SVGResource > and its underlying string representation (which is needed for > serialization.) Style building is changed to produce this new wrapper > (rather than an AtomicString.) A helper for serialization is added to > ComputedStyleUtils. > The kHasPendingResources flag is removed since it no longer used, and > the hook in Element is removed. > All LayoutSVGResource* subclasses are changed to take SVGResourceClients > instead of LayoutObjects, and the |clients_| set is removed in favor of > the set in SVGResource. > A bunch of helpers are added for updating (adding/removing) the client > registrations. The various LayoutSVG subclasses are updated to call > these helpers. > > TBR=junov@chromium.org > > Bug: 769774 > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > Change-Id: I62418465251532240c4e895e5c4d253ed9e53b9a > Reviewed-on: https://chromium-review.googlesource.com/977965 > Commit-Queue: Fredrik Söderquist <fs@opera.com> > Reviewed-by: Fredrik Söderquist <fs@opera.com> > Reviewed-by: Philip Rogers <pdr@chromium.org> > Reviewed-by: Stephen Chenney <schenney@chromium.org> > Cr-Commit-Position: refs/heads/master@{#556743} TBR=pdr@chromium.org,fs@opera.com,junov@chromium.org,schenney@chromium.org Change-Id: I695b3eed793bb000b057bca52364265d201f0bae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 769774 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Reviewed-on: https://chromium-review.googlesource.com/1051345Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#557120}
-
Martijn Croonen authored
This updates from revision 0f3b07d9aab6d6c9fe74990af98316468d40f488 (2018-01-25) to revision 649d6339ff2748e94d076b44e2aecc047795a607(2018-05-08) Bug: 834407 Change-Id: I62d38242a534ff2d941d0320c5cd454b9ff8f955 Reviewed-on: https://chromium-review.googlesource.com/1023411Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 9d15c6b6. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/17179 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jinho.bang@samsung.com, mathp@chromium.org, rouslan@chromium.org: external/wpt/payment-handler TBR=danyao No-Export: true Change-Id: I3d196d1b9d0089616241e204ab5ca0273fdd3a15 Reviewed-on: https://chromium-review.googlesource.com/1050452 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
