- 10 Jul, 2018 40 commits
-
-
Jennifer Apacible authored
MacOS and other OS have slightly different formats, where: - MacOS: "Picture in Picture" - Non-MacOS: "Picture in picture" - Instructional (non-menu/titles): "...picture-in-picture mode..." Bug: 859670 Change-Id: I424bb618b9b337bf944d2f082522b9539d25e43c Reviewed-on: https://chromium-review.googlesource.com/1123321 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#573963}
-
bsheedy authored
Regular roll to most recent production APKs. TBR=bajones@chromium.org Change-Id: Idad64a50473bc6438e06dd46f9d59aa28802c4ad Reviewed-on: https://chromium-review.googlesource.com/1132393Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#573962}
-
Jun Choi authored
Complete dialog view for very first step of WebAuthN request UI flow. That is, when a user first invokes WebAuthN Make/Get request, show a initial welcome screen and then show "activate usb device view" once the user clicks the continue button. Bug: 849323 Change-Id: I89c961c6278a68082675fe5a024a51bd9d1d15bb Reviewed-on: https://chromium-review.googlesource.com/1130829Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#573961}
-
Wez authored
- Migrate Chromium call-sites to appropriate libzx containers. - Mojo / IPC callers still often need to use generic zx::handle. - Redefine ScopedZxHandle as a typedef to zx::handle, for Crashpad code to build against. Bug: 852541 Change-Id: Idc317a91e718c680de7d01e53c92e83b5950b146 Reviewed-on: https://chromium-review.googlesource.com/1130540Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#573960}
-
Joshua Peraza authored
Bug: crashpad:30 Change-Id: I1a85d5d3428b5f801c570dc1add043f0697ba0e3 Reviewed-on: https://chromium-review.googlesource.com/1119383 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#573959}
-
Danyao Wang authored
With WKBasedNavigationManager, repost dialog is presented before isLoading becomes false. Bug: 807428 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I82eedbeeeb31a3f2d3ae120c040c0a7eff4b0ab1 Reviewed-on: https://chromium-review.googlesource.com/1127450Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#573958}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/b77822b4442d..c69c4410be7d git log b77822b4442d..c69c4410be7d --date=short --no-merges --format='%ad %ae %s' 2018-07-10 brianosman@google.com Remove matrixconvolution GM hacks for linear blending 2018-07-10 mtklein@google.com update (non-sprite) image shader color management 2018-07-10 mtklein@google.com transform paint color to dst colorspace 2018-07-10 bungeman@google.com Make SkTypefacePlayback use smart pointers. 2018-07-10 brianosman@google.com Merge "All" and "Default" path renderer options in viewer 2018-07-10 herb@google.com Add field to directly pass glyphs when using glyph encoding 2018-07-10 fmalita@chromium.org [skottie] Fix polystar points distribution 2018-07-10 fmalita@chromium.org [skottie] Misc cleanup 2018-07-10 borenet@google.com [infra] Determine Android device location based on bot ID 2018-07-10 fmalita@chromium.org [skottie] Log (unsupported) layer effects 2018-07-10 fmalita@chromium.org [skottie] Fix spurious gradient error messages 2018-07-10 borenet@google.com [infra] Remove Nexus 5x from CQ Created with: gclient setdep -r src/third_party/skia@c69c4410be7d The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: I120170c20d5efc9969b68e28c3d6848d9462ae9d Reviewed-on: https://chromium-review.googlesource.com/1131961Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573957}
-
Ken Rockot authored
This replaces use of ReadOnlyBuffer with a new mojom Message type specific to //ipc. This type maps to another new C++ MessageView type which in turn wraps a BigBufferView. This allows us to transparently fall back onto shared memory for large IPC messages without increasing the number of copies during send or receive in any (small- or large-message) cases. In order to avoid introducing more mojo-base targets, this also removes the remaining [Native] structs from mojo_base mojom (LOGFONT and FileInfo) and replaces them with real mojom structures + StructTraits, thus allowing //ipc to depend on mojo/public/*/base in its entirety. Also fixes random missing public_deps entries for a chrome/services/file_util typemap, because it decided to start breaking all of my local builds. :3 Bug: 784069 Change-Id: I359b964ffc1fe44ffd6aa704405ea63156f4fbc9 Reviewed-on: https://chromium-review.googlesource.com/1131685 Commit-Queue: Ken Rockot <rockot@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#573956}
-
Sebastien Marchand authored
Follow up on https://chromium-review.googlesource.com/c/chromium/src/+/1131556 Bug: 773382 Change-Id: Idddda163085d58aa4a351ae528544dd9968daaf1 Reviewed-on: https://chromium-review.googlesource.com/1132107Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#573955}
-
May Lippert authored
Add a new policy that will allow administrators to specify a schedule for slowly updating their fleet. BUG=chromium:858621 Change-Id: Ie21e538660a2d8d71c263a0f04397720820ce12a Reviewed-on: https://chromium-review.googlesource.com/1119162 Commit-Queue: May Lippert <maybelle@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#573954}
-
Kyle Milka authored
Correct alignment of elements in the dialog title bar. Make the selected check mark larger. Split the check icon and the colored background into two elements to make this work properly. Add a background color to image tiles. This will be seen before the images fully load. Bug: 852462 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3ae7d925acddc5968f45d31c06cb7d358156b819 Reviewed-on: https://chromium-review.googlesource.com/1132090Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#573953}
-
Evangelos Foutras authored
ffmpeg_features is the target used in src/media/ffmpeg and elsewhere. The target appears to have been accidentally renamed in: https://chromium-review.googlesource.com/935296 Fixes the following dependency errors when configured with system ffmpeg: ERROR Unresolved dependencies. //chrome/services/media_gallery_util:lib needs //third_party/ffmpeg:ffmpeg_features //chrome/services/media_gallery_util/public/cpp:browser_tests needs //third_party/ffmpeg:ffmpeg_features //chrome/services/media_gallery_util/public/cpp:cpp needs //third_party/ffmpeg:ffmpeg_features //media/base:base needs //third_party/ffmpeg:ffmpeg_features //media/ffmpeg:ffmpeg needs //third_party/ffmpeg:ffmpeg_features //media/filters:filters needs //third_party/ffmpeg:ffmpeg_features Change-Id: I2218c1dfb20de87958eeb8c23b18eebbea384c36 Reviewed-on: https://chromium-review.googlesource.com/1131941 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#573952}
-
Ryan Hansberry authored
This log is not informative, and spams dozens of lines in the logs. R=khorimoto@chromium.org Bug: 824568, 752273 Change-Id: Ied74c5747977719a63a698fb687f0415d8a5bc3b Reviewed-on: https://chromium-review.googlesource.com/1102980Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#573951}
-
Scott Violet authored
HostContextFactoryPrivate shouldn't have reconnection logic, instead DefaultGpuHost should. TEST=none BUG=855613 TBR=sadrul@chromium.org Change-Id: I23b927997b0be98268123acd4cc09015cf12bc8e Reviewed-on: https://chromium-review.googlesource.com/1132295Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#573950}
-
Mike Frysinger authored
On macOS, Command-Enter is available via the ⌘ key, but Windows & Linux can trigger this equivalent functionality via the Windows ⊞ key, and Chrome OS has a search
🔍 key. Support passing this disposition in the omnibox on all platforms. Bug: None Change-Id: I9a477678abbb8b369bee0eb9352f769d6b5d8fd8 Reviewed-on: https://chromium-review.googlesource.com/1132102Reviewed-by:Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Mike Frysinger <vapier@chromium.org> Cr-Commit-Position: refs/heads/master@{#573949}
-
Mina Almasry authored
AvSync also needs to know the start_pts. Only then can it actually correctly log the a/v start error when starting in the middle of playback. Also, driveby fix to the unittests to tighten their checks and use the updated audio pipeline API. Now they pass within 16ms error. Bug: b/110569201 Test: cast_media_unittests Mp4Playback test case on device. Change-Id: I0dd13e3fc58e4d3ae0fe398a469c6fb1be43192f Reviewed-on: https://chromium-review.googlesource.com/1125527 Commit-Queue: Mina Almasry <almasrymina@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#573948}
-
Toni Barzic authored
For offline demo mode sessions, skip account auth, and pass empty user credentials to ARC. BUG=b:110276688 Change-Id: Ibefbde51831a82f2bf6a3a6bad80395c9227a544 Reviewed-on: https://chromium-review.googlesource.com/1125505 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#573947}
-
Dirk Pranke authored
It looks like the test started becoming flaky across most platforms yesterday afternoon (9-Jul, somewhere between r573370..r573480, though there's not an obvious regression window). TBR=kvitekp@chromium.org, pfeldman@chromium.org BUG=860123 Change-Id: I144073f934cf6571d6864f858710cbd07c667059 Reviewed-on: https://chromium-review.googlesource.com/1132375Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#573946}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/81804d1c4bab..5571a97fd12b git log 81804d1c4bab..5571a97fd12b --date=short --no-merges --format='%ad %ae %s' 2018-07-10 dproy@google.com Fix bundle names Created with: gclient setdep -r src/third_party/perfetto@5571a97fd12b The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: Ie6bec136cccba19579e08e6595466498701a6c73 Reviewed-on: https://chromium-review.googlesource.com/1132034 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573945}
-
Amos Lim authored
Generate java constants from C++ Enums and remove manually defined popup item ids in AutofillSuggestion.java and AutofillPopup.java. Bug: 666529 Change-Id: If25e3a52385a8b9cee12bd96c80d8ece4df4e568 Reviewed-on: https://chromium-review.googlesource.com/1131355Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Amos Lim <eui-sang.lim@samsung.com> Cr-Commit-Position: refs/heads/master@{#573944}
-
Xi Han authored
Introduce StartupData in /content/public/browser, and StartupDataImpl in /content/browser. This is a precursor CL for: https://crrev.com/c/1108178. In the follow up CL, StartupData* will be plumbed via MainFunctionParams to create the browser main loop. Bug: 846846, 853308 Change-Id: Ic192cfa696439996dec07435f1980d78282f15db Reviewed-on: https://chromium-review.googlesource.com/1117471 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#573943}
-
Nate Fischer authored
No change to logic. This adds trace events to better capture events during WebView's Safe Browsing startup. R=torne@chromium.org Bug: 859696 Test: N/A Change-Id: I13d59093c2bf80bc11f59197732c97a2be9a1cbe Reviewed-on: https://chromium-review.googlesource.com/1123401Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#573942}
-
Kevin McNee authored
Touchpad pinch updates may be prevented by a page which cancels the synthetic wheel events. We now delay the sending of the begin event until we have an unconsumed update event. If the begin event has not been sent by the time we see the end event, we can elide the begin and end events. Bug: 787924 Change-Id: Ib50c6d55d416fb4bed10bcaa09a37e528ebb81bb Reviewed-on: https://chromium-review.googlesource.com/1113940Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#573941}
-
Yi Gu authored
We used to have Compositing.[Renderer|Browser].LayersUpdateTime.X (where X is the bucket number) to determine how the layer update time is related to number of layers. Given that this is no longer needed, remove the bucketed version and keep the regular ones for future reference. Bug: 862016 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I6618bc1974df174a5c79b3afa48216cb3f9a826f Reviewed-on: https://chromium-review.googlesource.com/1131843Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#573940}
-
Francois Doray authored
Fixing comments as requested by fmeawad@ at https://chromium-review.googlesource.com/c/chromium/src/+/1131845 TBR=fmeawad@chromium.org Bug: 775644 Change-Id: Ie6851852a80a11efbf6281ee29e8e46f3622e600 Reviewed-on: https://chromium-review.googlesource.com/1132243 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Fadi Meawad <fmeawad@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#573939}
-
Jennifer Apacible authored
These tests have been moved and the test expectations are no longer relevant. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I287dd7387b4972d64522eec6eb3c0be23f3b438f Reviewed-on: https://chromium-review.googlesource.com/1131677Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#573938}
-
Patrick Hulce authored
BUG=https://github.com/GoogleChrome/lighthouse/issues/5633 Change-Id: I58fc3d6541bfab6305936f5e5f5034b4bcfdaae1 Reviewed-on: https://chromium-review.googlesource.com/1132136Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Patrick Hulce <phulce@chromium.org> Cr-Commit-Position: refs/heads/master@{#573937}
-
Theresa authored
* Require the user to be signed in for EoC to be enabled. * Require either anonoymized URL collection or personalized URL collection for EoC to be enabled. BUG=829457 Change-Id: I6d516a25970bee7f827dacc64dc5956bc07ab1a5 Reviewed-on: https://chromium-review.googlesource.com/1131823 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#573936}
-
Shimi Zhang authored
Removing unused |IntentType|, the usage was removed due to new P API. Bug: 826581 Change-Id: Ic279cbda662df73300bf1eaf6496614767da8abf Reviewed-on: https://chromium-review.googlesource.com/1131925Reviewed-by:
Pedro Amaral <amaralp@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#573935}
-
yucliu authored
Bug: None Test: git status doesn't show speex and grpc Change-Id: Ibcd02491cde56dc82a4eeffa9081f71b2dc61ea9 Reviewed-on: https://chromium-review.googlesource.com/1125282Reviewed-by:
Bailey Forrest <bcf@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#573934}
-
kristipark authored
Also fixed the incorrect 'text-shadow' param. Bug: 854009 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ia8ed4d8207afe18720b98539e9886e29d59bb67e Reviewed-on: https://chromium-review.googlesource.com/1124940 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#573933}
-
Kurt Horimoto authored
Since we no longer are useing the GLIF "talking dots" animations after enabling the UI refresh flag, there are no UI elements waiting for TTS notifications. This CL introduces a KeyedService that handles listening for TTS notifications, starting playback, and cancelling playback for WebState and WebStateObserver changes. Bug: 846769 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I09f5143b26951bb3db4dad58f1a61ee94434785b Reviewed-on: https://chromium-review.googlesource.com/1095817 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#573932}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/b5cabcb3b24f..416cbeab1d93 git log b5cabcb3b24f..416cbeab1d93 --date=short --no-merges --format='%ad %ae %s' 2018-07-10 thestig@chromium.org Make CPDF_StreamContentParser::m_pResources a const pointer. Created with: gclient setdep -r src/third_party/pdfium@416cbeab1d93 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ic1c7b52b62f418831a9b81d506b417c27d168c5c Reviewed-on: https://chromium-review.googlesource.com/1131955Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573931}
-
Andrey Kosyakov authored
This is an implementation detail that should not be exposed. Change-Id: I9b1b630001c7c3677c6b4bc4ea1fc20a4c8c19c6 Reviewed-on: https://chromium-review.googlesource.com/1132134 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#573930}
-
Chris Bentzel authored
Change-Id: I7b36fe52ca319b1f0d5dfe0a7725eeca28809c3a Reviewed-on: https://chromium-review.googlesource.com/1120741Reviewed-by:
Chris Bentzel <cbentzel@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Chris Bentzel <cbentzel@chromium.org> Cr-Commit-Position: refs/heads/master@{#573929}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/985295aafdbf..3b1c86144cc8 git log 985295aafdbf..3b1c86144cc8 --date=short --no-merges --format='%ad %ae %s' 2018-07-10 benjhayden@chromium.org Allow unauthorized /api/alerts requests. Created with: gclient setdep -r src/third_party/catapult@3b1c86144cc8 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ifca3189f3b72a85f032fa63ea33d36b6ae6873ab Reviewed-on: https://chromium-review.googlesource.com/1131957Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#573928}
-
Mathieu Perreault authored
Bug: 658609 Change-Id: I62c043f7e52dc1061de79d3a484722efecbb11ee Reviewed-on: https://chromium-review.googlesource.com/1132149Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#573927}
-
Sidney San Martín authored
This is a reland of 330fc4a1 with some changes: - |[super mouseDown:]| is called from each subclass rather than the shared NSView category, so that it uses the direct superclass implementation instead of NSResponder :/. - If a mouse event would result in a resize, don't start a drag. I verified that this method exists back to 10.9. NSThemeFrame does this check, too, when movableByWindowBackground is set on its window, but it's missing from the frame view class which borderless windows use. For simplicity, I'm using the workaround for both. - Our theme frame subclasses override -usesCustomDrawing to return NO to avoid AppKit breakage (like the title not redrawing when it should). Original change's description: > Make all MacViews windows potentially draggable. > > This fixes the PiP window not being draggable on Mac. > > Bug: 849983 > Change-Id: I1b0f503de1a1f154f23afd1870943a6b7009be75 > Reviewed-on: https://chromium-review.googlesource.com/1121145 > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#572038} Bug: 849983, 844417, 859820, 859829 Change-Id: I3e596bed04312617edf658e0e652e1491374b9aa Reviewed-on: https://chromium-review.googlesource.com/1125099Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#573926}
-
akaba authored
Zoom in per-tab mode was broken after https://chromium.googlesource.com/chromium/src/+/c6bd1218e88d15c43a495a638c8cd65105c146e4 because RenderWidget::UpdateZoom and RenderViewImpl::UpdateZoomLevel were not updating the zoom level when temporary zoom level is enabled in both the visual properties and RenderWidget. This is not the intended behavior and this CL addresses this issue by removing temporary zoom as part of visual properties and handling temporary zoom settings in the browser side instead. Bug: 860511 TBR: kenrb@chromium.org Change-Id: Ic4326438cdec27936fee59d9384a71e7d1e9a238 Reviewed-on: https://chromium-review.googlesource.com/1127465 Commit-Queue: Andre Kaba <akaba@google.com> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#573925}
-
Robbie McElrath authored
Change-Id: I74cb6d526c92b2f134e749e2fde1837f3f64200e Reviewed-on: https://chromium-review.googlesource.com/1129848Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#573924}
-