- 29 May, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/82c5fe1de06e..24c961c98efd Created with: gclient setdep -r src-internal@24c961c98efd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: Ice27c73408614377953589b7afcc84fc2c2b7624 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1635190Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664229}
-
Mikel Astiz authored
This also makes some unreachable paths more obvious and now simplified or, if actually reachable, handled better. Bug: 967417 Change-Id: I63f9c129497d845d149b9549b411de3c4ffa3c83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631405 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#664228}
-
Miyoung Shin authored
This is a part of moving manifest implementation to blink. This CL cleans up the temporary code added for the usage of non-Blink. Bug: 704441 Change-Id: Ib6fcce07dfdd1b817b75d52fe15290ba990da03e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633893Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#664227}
-
Caitlin Fischer authored
Bug: 958333 Change-Id: Ia750d141ca4104f57d33a77bf253878d03d97379 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632389 Commit-Queue: Caitlin Fischer <caitlinfischer@google.com> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#664226}
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=finnur@chromium.org Bug: 887407 Change-Id: Ia80c2e7d7f09a976239c9325c7fcf5d190b5dd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631702 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#664225}
-
BUG=762641 TBR=mukai@google.com Change-Id: I2c68d7e6aea3357dfa6a467712cc6a557740fc95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634710Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664224}
-
Dominik Röttsches authored
After clarifying with the Mojo team, the initial approach of waiting for a WaitableEvent before running the asynchronous Mojo callback, this was identified as the incorrect approach. Instead, store the callbacks until the font table builder is ready, then run them on the same sequence on which the Mojo call came in. Bug: 960263, 889864 Tbr: wfh, rsesek Change-Id: Ief3fe6a21df28f5aa27a4daa6d65540bddf2b43e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605985Reviewed-by:
Dominik Röttsches <drott@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#664223}
-
Mark Cogan authored
This CL consolidates the public/app and public/global_state directories into a single /init directory, and groups the corresponding private implementation files to match in //ios/web/init/. Additionally: - ios_global_state.mm was in public/; it's now moved to //ios/web/init. - network_context_owner.h is moved into init/; it was previously in the root public/ directory. - The inexplicable dependency loop in //ios/web/public/app is resolved. - Three TODOs without bugs had bugs created and the TODOs were updated accordingly. - README.md files were added to the public and private init/ directories. Bug: 942244, 728161 Change-Id: I52af0101d1a2f75be8a5b502485f32fbed0763a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624327 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#664222}
-
Richard Knoll authored
We enabled NotificationViewMD by default on M75, so the legacy NotificationView can be removed with all its dependencies. Bug: 967666 Change-Id: Ie81450d001026fea092541d3fb0c5849eb98493d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632074 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#664221}
-
Rune Lillesveen authored
Override the base background color with black for the dark color scheme, but use the base background color with the light color scheme, even if it's not white. Bug: 939811, 925935 Change-Id: I19615387aeb6e1cce42de6ee8e5ed8a024fbd989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631660Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#664220}
-
Jeevan Shikaram authored
This CL adds a back button to the main view of App Management which leads to the settings page and removes the referrer field when opening App Management. Bug: 958733, 966359 Change-Id: Ib579af755eb785c1415f1ad9ebc6844d3ff446bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1626924 Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#664219}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I7e819a372f523cabe9ea4ef2f69db4a0f791012c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634380Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664218}
-
Stephane Zermatten authored
from server. The goal of this change is to allow configuring hardcoded client behavior that can impact execution speed and reliability from the server, so we can experiment with values and choose good ones. Bug: b/129665463 Change-Id: Iea26a703cd3c9181b372d49b4ec317dc18913e90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1611687 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#664217}
-
Arthur Hemery authored
When navigating back to a frame that has subframes, we should try to restore the subframes to their latest history item. This is currently done by OpenURL and should be done by BeginNavigation instead. Design doc: https://docs.google.com/document/d/13Rqdg1HBmtfnYMUXvg7SpUl3bJisTElfyMc1Ze8hLdE/edit# This is patch 1/2. This patch only modifies the behavior for IsPerNavigationMojoInterface off. Bug: 962518 Change-Id: I40c38663f964d3b4e0b09dcbab887d91a2faf282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1578740 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#664216}
-
Eric Willigers authored
Check that border-inline-... properties match spec grammar. https://drafts.csswg.org/css-logical/#propdef-border-inline-width https://drafts.csswg.org/css-logical/#propdef-border-inline-style https://drafts.csswg.org/css-logical/#propdef-border-inline-color Shorthands border-inline, border-inline-start, border-inline-end are not yet tested. Change-Id: I60d91a47e94852512f50495c6ea5d0f153541bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1633690 Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a2dee8aa..bd353500 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I20e995431aa5cc4859abbcc47f2a1f8014f329f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634929Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664214}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e9944e4e052c..82c5fe1de06e Created with: gclient setdep -r src-internal@82c5fe1de06e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=ricea@google.com,jeffreycohen@google.com,seblalancette@google.com,mkwst@google.com Change-Id: I931145d9ba3723b8e3b7bac3fad0b16c4eeef473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634379Reviewed-by:
-
Yutaka Hirano authored
Bug: None Change-Id: I738423988eee4b5547019e6e01fb2ed2caa0d039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627838 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#664212}
-
Roman Aleksandrov authored
Use RelaunchHeadsUpPeriod as time delta between first notification and Recommended / Relaunch deadline. Cover by tests new behavior and different types of policies changes. Bug: 963883 Change-Id: Icf4044c2399666fa3d9a1ed16b604006cb2a22f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630469Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Cr-Commit-Position: refs/heads/master@{#664211}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f007b805. With Chromium commits locally applied on WPT: e90c6ef0 "NG/DL: Implement size containment (and display lock) for NG fieldset algo" be76d09e "[ServiceWorker] Reject update() from within installing workers" abf2ac5e "webrtc wpt: avoid race conditions" d9a6ec05 "[MediaStreamTrack] Remove tests and existing support for the 'volume' property." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I0975df8620e1e6f77bfde48f69e194fce8484758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634789Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#664210}
-
Mike West authored
This reverts commit 19c977cb. Reason for revert: This crashes on http://www.onlinedown.net/, which calls something like `window.addEventListener("devicemotion",...)`. Fortunately(?), this means that it's also crashing our perf bots https://ci.chromium.org/p/chromium/builders/ci/Leak%20Detection%20Linux/41983. Original change's description: > Mark Device Orientation API event handlers as [SecureContext]. > > This CL concludes the work to restrict the API to secure browsing contexts. > It removes the `RestrictDeviceSensorEventsToSecureContexts` flag that could > previously be disabled manually to re-enable the API in non-secure contexts, > tests that verified the behavior with this flag disabled, as well as all > deprecation warnings. > > Bug: 932078 > Change-Id: I742ab162e97017e47b44dfe72e99ef9c24178b36 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632329 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Balazs Engedy <engedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#664180} TBR=engedy@chromium.org,reillyg@chromium.org,haraken@chromium.org Change-Id: I1fc9b9ee4e6a6614665702285743b5e7915d4185 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 932078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634832Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#664209}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f5a5c539a5ee..903755a1f84b git log f5a5c539a5ee..903755a1f84b --date=short --no-merges --format='%ad %ae %s' 2019-05-29 dberris@chromium.org Dashboard: Add the chromium gpu builders to the whitelist Created with: gclient setdep -r src/third_party/catapult@903755a1f84b The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:967970 TBR=zhanliang@google.com Change-Id: I340685aa5ca17a39320ce1bc199d309dc28f39be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634372Reviewed-by:
-
Staphany Park authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/f71fb4f9a912..f5edb4f542e1 $ git log f71fb4f9a..f5edb4f54 --date=short --no-merges --format='%ad %ae %s' 2019-05-27 gennadiycivil Update CONTRIBUTING.md 2019-05-27 gennadiycivil Update CONTRIBUTING.md 2019-05-22 gennadiycivil Update README.md 2019-05-22 misterg removing msvc 2019-05-22 misterg removing msvc 2019-05-22 misterg removing codegear 2019-05-22 lfy unbreak windows build 2019-05-19 yaneurabeya Fix typo introduced in 63be3dcc245 (maintaners -> maintainers) Created with: roll-dep src/third_party/googletest/src Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel,mac_optional_gpu_tests_rel,linux_chromium_cfi_rel_ng;luci.chrome.try:win_chrome_official Change-Id: Ifdf75edb58ac84edf9209511ce0579257aa1a797 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634610 Commit-Queue: Victor Costan <pwnall@chromium.org> Auto-Submit: Staphany Park <staphany@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#664207}
-
Harald Alvestrand authored
This ensures that if the PC iceConnectionState should change because unused transports are discarded, the state is updated. Bug: chromium:966798 Change-Id: I09d945f5e70eec813f33c3131fbe889825613652 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632254Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#664206}
-
Leszek Swirski authored
Add a flag to enable streaming small (<30kB) scripts. With the improved streaming capabilities and reduced background parsing costs, it may be beneficial to stream all scripts, not just the large ones. Bug: 865098 Change-Id: I211bbbc8491050041ebcbb4e9d6019263fcfd4eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632430 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#664205}
-
Leszek Swirski authored
Currently, in-order scripts (i.e. <script> tags that are inserted dynamically instead of by the parser) never request streaming. Given recent streaming improvements, we can now afford to stream these scripts. As a drive-by, also allow async scripts encountered while the script runner is suspended to also be streamed, since otherwise they will never stream. Bug: 865098 Change-Id: I095deb4ac8ceab86c8db0473357b093822cb3b61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630159Reviewed-by:
-
Carlos Caballero authored
BEST_EFFORT tasks will not run until after startup and only if there is no critical work pending. This patch should not change the current behaviour. Please double check whether the task being posted via BrowserThread::PostAfterStartupTask really cares about being run after startup or just wants to run after any critical work was completed. If you are fine with it just running after critical work has completed LGTM and keep on with your life. If that is not the case let me know and please explain your reasoning in a comment. More details: https://docs.google.com/document/d/1P8PV1qX2cOR2WRFD6v9CjygJkE_mftCtJ7BoqQHCKZI This CL was uploaded by git cl split. R=delphick@chromium.org Bug: 887407 Change-Id: I975ea43fcad5ec7a39963ad864fea24bcd5c9f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632160Reviewed-by:
Dan Elphick <delphick@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#664203}
-
Richard Knoll authored
Notification title and message should both have a line height of 17px. Multiline labels inside a nested BoxLayout has issues with the size calculation, so using the same fix for the title that is used for the message view too: https://codereview.chromium.org/2638163002. Also fixes a small bug where the close button disappears if there is an update while in inline settings. This change removes the dependency to BoundedLabel, which can now be removed together with NotificationView, as it's the only user. Bug: 937863, 941662 Change-Id: Idf682799b3518813d83d124f6e4915632dec0bc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1524270 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#664202}
-
Yves Arrouye authored
Add the ability to request and receive secure remote commands. Also add new statuses for those and for commands that cannot maintain state during their execution (e.g. powerwashing). See go/cros-secure-commands for design. Bug: chromium:967383 Test: N/A Change-Id: I763b2981a4b015827197c4bcaea55117968a551a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1630854Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#664201}
-
Yutaka Hirano authored
Add the function so as to platform/loader can use it. Bug: 963306, 914739 Change-Id: I0b0b980449c56786316ae5b244bb7f05ca0b5dce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634594Reviewed-by:
-
arthursonzogni authored
This test is flaky on low end devices like the Marshmallow Tablet Tester. This is caused by the subframe unload timeout to be reached before the end of the test. This increase the timeout from 0.5s to 30s. TBR=alexmos@chromium.org Bug: 968037 Change-Id: I49387dedcf76ea156911c1af3035d00c67109d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634830Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#664199}
-
Maciej Pawlowski authored
Before, the code would use kInvalid as an index for an array, which would cause UB. This would happen whenever we've asked for properties of a Schema that didn't have that sort of properties, ex due to being empty. So, GetKnownProperty("x") would cause UB if there was no property named "x" in the schema, GetRequiredProperties() would cause UB if there were no required properties specified in the schema, etc. Bug: 966774 Change-Id: If1d6c9f84d2b25b482ed594b547e203a232274d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1628720 Commit-Queue: Maciej Pawlowski <mpawlowski@opera.com> Reviewed-by:Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Cr-Commit-Position: refs/heads/master@{#664198}
-
Alexander Hendrich authored
This CL allows extensions of type login_screen_extension to use the "persistent" field in the "background" manifest field. Bug: 957573 Change-Id: If61a2b826ba2a818cc0f91ebff56c74c439b91e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631287 Auto-Submit: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#664197}
-
Kuo Jen Wei authored
Bug: 960292 Change-Id: I30ae586d1bddf6d6421f03377015787c1bc9c7ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1629894Reviewed-by:
Sheng-hao Tsao <shenghao@chromium.org> Commit-Queue: Kuo Jen Wei <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#664196}
-
Raphael Kubo da Costa authored
This option was removed in 0.12.1 (July 2017). TBR=mlamouri@chromium.org Change-Id: Ifc97cc258af2f00f64c6defa0ab6ced5d8ee8158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634732Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#664195}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ded5f903261a..1ad4771e88a5 git log ded5f903261a..1ad4771e88a5 --date=short --no-merges --format='%ad %ae %s' 2019-05-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 6c7db9c63098..f051812343eb (3 commits) Created with: gclient setdep -r src/third_party/angle@1ad4771e88a5 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@google.com Change-Id: I7fa38391e72656d0627e0a615e502e0af1bb7363 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1634378Reviewed-by:
-
Alex Ilin authored
This CL replaces all occurences of "Glowplug" in c/b/predictors with "LoadingPredictor". Namely, following classes are renamed: GlowplugKeyValueData -> LoadingPredictorKeyValueData GlowplugKeyValueTable -> LoadingPredictorKeyValueTable Glowplug was initially a project codename for the LoadingPredictor. It was later decided, that it's better to use the explicit LoadingPredictor in the code. The CL also renames c/b/p/resource_prefetch_common.{h,cc} containing only NavigationID struct declaration to c/b/p/navigation_id.{h,cc}. TBR: ryansturm@chromium.org Bug: 882895 Change-Id: I86d1d25177d8bcb3df29f5969bfe98fa14e15e58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624917Reviewed-by:Alex Ilin <alexilin@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#664193}
-
Daniel Lee authored
Bug: 964279 Change-Id: Ib6e05db7b5adb5b5523681fb8713d7b5e6a8f02b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632233Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Daniel Lee <dklee@google.com> Cr-Commit-Position: refs/heads/master@{#664192}
-
Sylvain Defresne authored
Uses of base::Callback<...> is deprecated in favor of either base::OnceCallback<...> or base::RepeatingCallback<...> (the former is preferred if possible). This is part 5 of a multi-CL refactoring and does: - use PostTaskAndReplyWithResult in HistoryService::QueryRedirects* thus removing a naked "new" and the use of base::Unretained and base::Owned - change QueryRedirectsCallback to be invoked with RedirectList passed by value instead as a const pointer thus allowing to remove an helper function - change QueryRedirectsCallback to be a base::OnceCallback<...> - change HistoryBackend::QueryRedirects* to return the result by value instead of via an out parameter Bug: 812523, 714018 Change-Id: I7c99df407d1f496f3cfd704466364ddfa80bba6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632429 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#664191}
-
Henrik Grunell authored
These are still used. Bug: 960080, 960086, 960088, 960089, 960094 Change-Id: I8aafe3a0325ccdcd61b476367f582058d46bb2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632232 Commit-Queue: Henrik Grunell <grunell@chromium.org> Reviewed-by:
-
