- 03 Sep, 2019 40 commits
-
-
James Forshaw authored
This CL changes the StartupInformationTest.InheritStdOut test so that it should no longer be flaky. As an added bonus as it no longer runs code inside a child process it's always significantly faster to execute. Bug: 996357 Change-Id: I904a00dab629c2bb3d47bc9a82fe4423b97f5870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1768895 Commit-Queue: James Forshaw <forshaw@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#692890}
-
Sergey Ulanov authored
This is a reland of 74c69a75 Original change's description: > [Fuchsia] Handle VULKAN feature flag in WebEngine > > Now WebEngine will enable Vulkan only when ContextFeatureFlags::VULKAN > is specified for web::Context. Also Context process now explicitly > disables hardware-accelerated compositing when VULKAN is not enabled > (otherwise it restarts the GPU process several times before it falls > back to software compositing). > > Bug: 962617, fuchsia:35009 > Change-Id: I74a463a1514df99134d929981fe44151c1d9dd17 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774967 > Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Jonathan Backer <backer@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#691856} TBR: backer@chromium.org Bug: 962617, fuchsia:35009 Change-Id: Ia284d035deb396c57684ef069d54ddb9b7d5b15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779064 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#692889}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/24a3df72b959..8df216c09227 git log 24a3df72b959..8df216c09227 --date=short --no-merges --format='%ad %ae %s' 2019-09-03 vapier@chromium.org import builtins from six.moves Created with: gclient setdep -r src/third_party/chromite@8df216c09227 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ifeaa19cc8e3e5127beb53324c8e8867dfe50fb1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782760Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692888}
-
Andrew Xu authored
Move the code block that updates the layout strategy of OverflowBubble- View from CalculatePreferredSize to Layout. It makes preparations for landing the CL of focus rings for OverflowBubbleView Bug: 918024 Change-Id: I1a032e21d1a7b0fe307d62da9d94e7fa7fe3395b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783479Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#692887}
-
Mehran Mahmoudi authored
This removes touchless-specific code from the AddToHomescreen, which is required for the AddToHomescreen refactoring (More info in the bug). Bug: 994759 Change-Id: Ic74720cceb140ab58f32cea809848e30d663f57d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781774Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#692886}
-
Robert Ogden authored
Bug: 1000431 Change-Id: I384efcd3fc30de6723bdaf777763b4bfb4291695 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783111Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#692885}
-
Dan Harrington authored
This has been verified to work with the updated server. Bug: 984787 Change-Id: Ie65f593fa885e759f62550fa53f53d2370124cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782972Reviewed-by:
Dmitry Titov <dimich@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#692884}
-
Erik Chen authored
Async IPCs can be invoked from re-entrant contexts in Blink. This means that we can't synchronously destroy objects that may still be references on the stack. Bug: 992315 Change-Id: Ie5fd5f1554c85181518c36aeb8645c843c072be6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783062Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#692883}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e9d9a3278fdf..7ffef1e8cc2e git log e9d9a3278fdf..7ffef1e8cc2e --date=short --no-merges --format='%ad %ae %s' 2019-09-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-03 brianosman@google.com Move SkSL caching out of GR_TEST_UTILS, trim persistent cache options 2019-09-03 reed@google.com update gm to better show the unclipped layers 2019-09-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-09-03 jvanverth@google.com Fix argument path for dsymutil Created with: gclient setdep -r src/third_party/skia@7ffef1e8cc2e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jlavrova@google.com Bug: None Change-Id: Ie711afa76cf720d42389192070f573c6be855539 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783069Reviewed-by:
-
Theresa authored
This reverts commit d713f160. Reason for revert: Appears to have broke compilation Original change's description: > Reland #2: ProGuard: Move -checkdiscard for Log.* into @RemovableInRelease annotation > > This reverts commit 1595330c. > > Reason for reland: Tweaked rules & ensured all targets compile locally. > > Bug: 987226, 986693 > Change-Id: I6987ca442089db80b7f4b8f44d51e1fda923bb3b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726230 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Sam Maier <smaier@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692815} TBR=agrieve@chromium.org,smaier@chromium.org Change-Id: I88c50b9e48bea3b7342fe9f402964c6c3209c25e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 987226, 986693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783558Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#692881}
-
Daniel Rubery authored
Now that we know the WebProtect URL and SenderID, we can hard-code them. Bug: 980777 Change-Id: Id55fcc478b894f402ade865a1011a9708798c053 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782672 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#692880}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1db68ea0ba17..a877ee62b1fc git log 1db68ea0ba17..a877ee62b1fc --date=short --no-merges --format='%ad %ae %s' 2019-09-03 ehmaldonado@chromium.org depot_tools: Run some tests on Python 3 on the bots. Created with: gclient setdep -r src/third_party/depot_tools@a877ee62b1fc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:984182 Change-Id: Ieb8001faf0fd1c3787579dc58182d05b0df0bb1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783067Reviewed-by:
-
Piotr Pawliczek authored
Two bugfixes to the new policy ExternalPrintServers: - Unnecessary definition of kExternalPrintServers was removed from pref_names.*. - The type of the policy was set to 'external'; the previous value 'dict' was incorrect. Also activating this policy in M78 (by removing 'future' field in policy_templates.json) and updating an entry for this policy in the file policy_test_cases.json. BUG=chromium:902085 TEST=on local chrome build Change-Id: I087318282f43b46ea3772295aba223519f4a6065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779723 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#692878}
-
Joshua Peraza authored
726ab2a65539 Integrate Crashpad with Chrome OS db6f51d3fca8 fuchsia: Check results of Initialize() subcalls in ProcessReaderFuchsia 50aa576622fd Disable implicit fallthrough warning for zlib 1c7023875b74 [build] //zircon/public/fidl --> //zircon/system/fidl 7b5a55c3b188 Move whitelist ownership to ProcessSnapshotSanitized 10a1d2d87743 [fuchsia] Use the appropriate separator for FIDL library names b71f61f8e31f fuchsia: Defer initialization of memory map 23a1be41ce3a linux: refactor snapshotting into CaptureSnapshot() 80473094a4d2 linux, compat: add a memfd_create wrapper cd92fba233d3 linux: Move Cros crash handling to CrosCrashReportExceptionHandler e1e55e224627 linux: initialize crash_loop_before_time member Change-Id: I077b0a81ec3aceab3271c1dc5e5b7bcea1ab3a1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781773Reviewed-by:Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#692877}
-
minch authored
See https://docs.google.com/document/d/1DFKZsXCU4GySB9Ry8Bhd8k8sB7pO5wOz0GBcFmAq5B4/edit?pli=1#heading=h.9enkedn5nlfe for details. Bug: 982950 Change-Id: Ie1a83a9adff24b2fd56416bf5a11c153b3d21bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1772307 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#692876}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/543a3b939df5..3fa35aa420ee git log 543a3b939df5..3fa35aa420ee --date=short --no-merges --format='%ad %ae %s' 2019-09-03 wl@gnu.org * src/sfnt/sfwoff2.c (compute_ULong_sum): Fix undefined shift. Created with: gclient setdep -r src/third_party/freetype/src@3fa35aa420ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel TBR=bungeman@google.com,drott@google.com,thestig@google.com Bug: None Change-Id: I983c3eb8fddf19c801b7fb9947e4760e211058f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783246Reviewed-by:
-
Marijn Kruisselbrink authored
Actually being able to add/edit the list of blocked sites (other than removing existing blocks) from chrome://settings/content/filesystem behaves weirdly and doesn't actually match what other settings are doing. So instead use a read-only list. Bug: 999753, 999754 Change-Id: Ic06129dcaeda380cc734154dbf6926fb19618968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779577Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#692874}
-
Robert Ma authored
Regardless of with or without subtest names TBR=lpz Bug: 1000441 Change-Id: I9aa9c773e796b07e4447c6b107f38bea692048a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783109Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#692873}
-
Kai Ninomiya authored
Bug: 986808 No-Try: True Change-Id: Ic6460697f1f64f822c550ad21ae04700446116d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783107 Commit-Queue: Kenneth Russell <kbr@chromium.org> Auto-Submit: Kai Ninomiya <kainino@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#692872}
-
François Doray authored
TBR=carlosil@chromium.org Bug: 1000446 Change-Id: Ie1b37cecf27ea6b4e6ea8e77ba8b057e036b6b6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783404Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#692871}
-
Sasha McIntosh authored
When ScopedImageDecodeTasks complete, metrics will be uploaded for WebP, JPEG and "Other" images types. The additional UMAs were added in a previous commit. Renderer4.ImageDecodeTaskDuration.Jpeg.{Software, Gpu} Renderer4.ImageDecodeTaskDuration.Other.{Software, Gpu} Bug: 995934 Change-Id: Ica1ce76ef96e6a490fb10022c6c4ffa5f3d51abc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769182 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:Eric Karl <ericrk@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#692870}
-
Lucas Furukawa Gadani authored
Bug: 997835, 881099 Change-Id: I1fca272f48d11dce7897229f1c2259998d1f6d85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1780337Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#692869}
-
Michael Crouse authored
Fixes browertest failures that relied on the default mock network state to be online by explicitedly setting it to online. Bug: 999319 Change-Id: Iaff1cb156f9c913a6d09da3ca8c552a2adde46e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783141Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
-
Matt Wolenetz authored
This change prepares for relaxing MSE addSourceBuffer and changeType codec specificity per the non-normative guidance in the MSE codec-switching incubation spec at [1], especially sections 3.5.7 and 10, whose text change for codec-switching is best viewed via the W3C diff of the MSE REC spec vs the codec-switching incubation spec [2]. This preparation will allow later CLs to also enable implicit codec switching (e.g., without explicitly calling changeType) in Chrome MSE. Such implicit codec switching would still require the bytestream format to remain the same (explicit changeType can be used to switch bytestream formats). It updates StreamParserFactory to understand and report one of media::SupportsType values instead of boolean for support, and updates usage of the updated implementation such that no behavioral change should yet be observed with just this change. Forthcoming change(s) will allow addSourceBuffer and changeType to succeed for incompletely specified parameters (e.g. kMayBeSupported SupportsType value), while retaining strictness throughout of MediaSource.isTypeSupported's requirement for codec specificity. This change also fixes a previous code style issue where MIMETypeRegistry::IsSupportedMediaSourceMIMEType cast a boolean to an enum and then implicitly converted that result back to a boolean. BUG=535738 [1] https://github.com/WICG/media-source/tree/codec-switching [2] https://services.w3.org/htmldiff?doc1=https%3A%2F%2Fwww.w3.org%2FTR%2Fmedia-source%2F&doc2=https%3A%2F%2Frawgit.com%2FWICG%2Fmedia-source%2Fcodec-switching%2Findex.html Change-Id: I444e0f60c04e15df7299af0df932f4fa20b2e747 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776902Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#692867}
-
David Black authored
This reverts commit 22c7b0a0. Reason for revert: Causing b/140266795. Original change's description: > Synchronize NavigableContentsView's LocalHostView focus w/ window focus. > > Previously, if the user clicked into the WebContents of an > AssistantCardElementView, the corresponding RenderWidgetHostViewAura > would become focused. However, the focused view in the Assistant view > hierarchy (usually the Textfield in the Assistant Dialog Plate) wouldn't > receive a blur event. As such, the user would think they could keep > typing because of the blinking caret in the Textfield. When typing, > they would find nothing entered and think keyboard was broken. > > Now, we synchronize the focus state of NavigableContentsView's > LocalHostView with the associated native window so that as the native > window subtree takes focus, so does the LocalHostView. > > This fixes AssistantCardElementView further upstream. > > Bug: b:134170714 > Change-Id: I03d67a3d9fbc779a87449065c97d7e4a877fe10a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1649084 > Commit-Queue: David Black <dmblack@google.com> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Ken Rockot <rockot@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#668077} TBR=xiyuan@chromium.org,rockot@google.com,xiaohuic@chromium.org,dmblack@google.com,wutao@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:134170714, b:140266795 Change-Id: I4de99b2ef2c18bb503277fc4a528866b2c832764 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778989Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#692866}
-
Cliff Smolinsky authored
Years ago code was added to remove WS_MAXIMIZE property on dpi changes as part of changes to workaround some fullscreen issues. That was done in https://codereview.chromium.org/1707233002. Unfortunately, this one piece of that change has some negative side effects in which the browser window is incorrectly removed from maximize state and the restore size is lost. Removing this property breaks the OS' knowledge of the maximize state and prevents the OS from doing the right thing. Bug: 951119 Change-Id: I9d594461b9b429b45ed219c28a3156009910ad45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778708Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbaff379d261..bb6fc83a0777 Created with: gclient setdep -r src-internal@bb6fc83a0777 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: I5e81b80cccecf74916c023520976d5822776aaa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783337Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#692864}
-
Mark Pearson authored
Claims that histogram as well as the sync-related histograms. Claiming means becoming co-owner, adding warning about being a co-owner, and setting expiration date to never. Explicitly does not claim WithAccount and WithoutAccount, as we don't need those. Bug: 961157 Change-Id: I4f571c4efce4dc8d7031548ebfbd73cf977983b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754497 Commit-Queue: Mark Pearson <mpearson@chromium.org> Auto-Submit: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#692863}
-
Erik Chen authored
The implementation was assuming that |local_frame_| was a local frame root. Bug: 1000035 Change-Id: I6e42c49c740ac4dce62775dd5af8c14b7dc59cc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782512 Commit-Queue: Erik Chen <erikchen@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Antonio Gomes authored
This is a reland of f8ab5df9 The original (reverted CL) https://crrev.com/c/1778671 had one mistake: it missed to remove the includes of the autogenerated file <out>/gen/content/public/common/buildflags.h in chrome/. ... that is now gone. Given that the bots do not do a full rebuild (remove <out>/), CQ did not catch it. This reland CL should fix it. Original change's description: > Move definition of kWebRtcH264WithOpenH264FFmpeg to Blink > > This is a precursor CL to Onion soup'ing > content::RtcVideoEncoderFactory (phase 2.3 in the design document [1]). > > [1] https://docs.google.com/document/d/1AJKVA5U4nDkyDB9p4ROrggWXadCxyy-grKaE9KS5vOU/ > > Basically, it merged the definition and declaration of > content/public/common/feature_h264_with_openh264_ffmpeg.cc|h > into Blink's features.h. More specifically, to > third_party/blink/public/common/features.h (declaration) and > third_party/blink/common/features.cc (definition). > > This allows rtc_video_encoder_factory.cc|h to move to Blink in a > follow up step. > > BUG=787254 > R=guidou@chromium.org, haraken@chromium.org, jam@chromium.org > > Change-Id: I4ba7c59da0f799e1d30053923fb1e692202223b6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1778671 > Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#692757} TBR=guidou@chromium.org Bug: 787254 Change-Id: I479b07d13802e3cad25b57e8c7dbeee048db0fd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782514 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
-
Cathy Li authored
Bug: 977713, 987301 Change-Id: I7e0be3b3f8367be2f5f1e3d42f7b46a7f6b79b66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775188 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#692860}
-
Joe DeBlasio authored
This CL drops the "Safety tip: " prefix from the safety tip bubble to get us closer to our new mocks. Bug: 996731 Change-Id: I1dfb629378e0becdeaf7222d78fb2e9616b42a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782128Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#692859}
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I417640eee3feba3ca2205b20376a6d8b808d6f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1781534 Commit-Queue: Nick Harper <nharper@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#692858}
-
Ahmed Mehfooz authored
Mirror highlight path if a view has canvas flip for RTL enabled. Remove unneeded inkdrop highlight code in system tray. Bug: 997843 Change-Id: I4df02654d1fc25f5c8a93c59f36abe092fdf4f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1771041 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#692857}
-
Kyle Milka authored
These actions are no longer recorded. Bug: None Change-Id: I163d0ec558f57efd753cdd2d0f2cc3ff7906f14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775361 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#692856}
-
Maksim Ivanov authored
Avoid letting the focus jump from the password/PIN input field to the "1" PIN keypad button when both fields are about to be hidden. This case occurs when entering a security token PIN at the login/lock screen into the user pod that uses challenge-response (a.k.a. smart card) authentication. Without this CL, this quick focus jump led to unexpected effect that the accessibility screen reader was saying "ONE". Fix this by swapping the visibility manipulation of the textfield and the keypad, so that the keypad is hidden before the textfield and therefore doesn't receive the focus during this UI update. Bug: 990391 Test: enable ChromeVox, click on the smart card user's pod on the login screen, enter valid PIN, check that ChromeVox didn't say "one" Change-Id: I2c3fa26580cb94f97b6f98290b2003b226929552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783138Reviewed-by:
-
Connor Clark authored
Bug: 1000409 Change-Id: I2917f7d8a63b14fc8f13e692ed12551f437e9c9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783245Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Connor Clark <cjamcl@google.com> Cr-Commit-Position: refs/heads/master@{#692854}
-
arthursonzogni authored
It turns out the process used to load about:srcdoc was not always correct. For instance, when starting from A(B), if B navigates to about:srcdoc, it was sometimes loading in B's process instead of A's process. This is now fixed and enforced. This is not a regression. The previous code about srcdoc in RenderFrameHostManager::CanSubframeSwapProcess() isn't really effective when the about:srcdoc navigation happens AFTER a cross-process one. Bug: 996044, 996725 Change-Id: I670ee6dc917cfe4cb02721a58a79a1a415b45e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1773264Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#692853}
-
Christian Biesinger authored
Always set the override size instead of checking whether we need to, no downside to doing that and code is a bit simpler, and move this setting to *before* calling CanAvoidLayoutForNGChild, so that it actually does the right thing. Also make the code in the condition not overwrite whether we need layout, just add to it. This may have been a bug but I don't have a broken testcase. R=dgrogan@chromium.org, eae@chromium.org Change-Id: If5b1d69a4307720c40f620d7a76b2e5222f1719c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1779129 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#692852}
-
Jérôme Lebel authored
Adding accessibility identifier in the link in the user consent view. Updating ChromeSigninViewControllerTest to use this identifier. Bug: 1000357 Change-Id: I327a93f2da0e79ed7bd300bb943b323bf3ae21e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782804 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#692851}
-
