- 21 Nov, 2020 37 commits
-
-
Chris Thompson authored
Manually tested that the crash is fixed and no negative effects. Bug: 1150751 Change-Id: Id46097e62f3e826fb42abb4d65f0e7f0c2691570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553004Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Chris Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#829905}
-
Olivier Yiptong authored
This implements the blink portion of the API to trigger a font chooser. This extends the previous stub to communicate with the Browser process. The content/embedder side will be extended in a future CL to complete the implementation end-to-end. Bug: 1138621 Change-Id: I0d5206b10566eed6a40227f994523cabaf3e0913 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538143 Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#829904}
-
James Cook authored
After discussion with security team and the files team, we want to avoid using hard-coded /home/chronos/user/MyFiles paths in lacros. Instead, have ash-chrome pass the paths to lacros-chrome at startup over mojo. This also avoids making the exact path an implicit API contract between ash and lacros. If a future Chrome OS release moves the directories to new locations, lacros will follow along. Ash currently uses /home/chronos/u-<hash> for paths. The security folks would like to switch to /home/user/<hash>, but ash doesn't use those yet. Once ash switches, lacros will automatically follow. We have to leave a few references to /home/chronos/user in lacros for now, until we drop support for Chrome OS M89 and can be sure that ash always sends the default paths. crbug.com/1150702 tracks clean up. Because unit tests are not launched by ash, we override the default paths for documents and downloads in the test harness, to simulate how ash launches lacros in production. Bug: 1150575 Test: added to unit_tests Change-Id: Ifcf637dcbdcb91fa5bb7f3b81c161e3ce87c7e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495961 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#829903}
-
Max Moroz authored
R=inferno@chromium.org TBR=dpranke@chromium.org Change-Id: I56d6684addf8e7f9c16dca2d963e01c0c8020b99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553147Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#829902}
-
Tom Anderson authored
The old code used dlsym(RTLD_DEFAULT), which will attempt to obtain the symbol from libraries already loaded. This works most of the time because Xlib gets loaded by eg. GTK, but in cases where Xlib is not already loaded (eg. certain ChromeOS setups), XFree will not be found, leading to a crash. The fix is to switch to the existing xlib_support which internally does dlopen("libX11.so.6") so it shouldn't have this issue. R=sky Bug: 1150918 Change-Id: I82d28cf86e187cc1213b607482f7bd1f4a8e2287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552209 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by: -
Dominic Mazzoni authored
This is a quick fix for a performance issue that we've seen in several cases but is particularly bad for one Android app on Android TV. Whenever a node in the accessibility tree changes, we fire a TYPE_WINDOW_CONTENT_CHANGED accessibility event, which is needed for Android to clear its accessibility cache. However, when a major change to a web page happens and a lot of events are fired on different nodes, the overhead of firing an event on every single node is much too high and just ends up slowing the device to a crawl or causing an ANR. The alternative is to just fire TYPE_WINDOW_CONTENT_CHANGED on the root, invalidating the whole WebView. This is inefficient compared to invalidating just one node, but much more efficient than individually updating hundreds of nodes. What this patch does is add some really simple and quick logic to count how many WINDOW_CONTENT_CHANGED events we're firing within a single accessibility tree atomic update, and when we reach some maximum it fires an event on the root and then suppresses further events of this type until the next update. It might be cleaner to move this logic to AccessibilityEventDispatcher instead in the future, but for now this is the most straightforward fix and it results in a big performance improvement in practice. is changing Bug: b/159131746 Change-Id: Ic04f5e87a205e80f460715de14f99de70a0cf90e AX-Relnotes: improves performance on some Android pages when lots of content Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552897 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Mark Schillaci <mschillaci@google.com> Cr-Commit-Position: refs/heads/master@{#829900}
-
Alison Maher authored
Forced colors should now happen at used value time. This change adds an internal property to store the forced colors value of border-color. This internal value is then applied to the visited /unvisited border-bottom-color, border-top-color, border-right-color and border-left-color at used value time when appropriate. The other forced color properties will be moved in follow up changes. Bug: 970285 Change-Id: If2da52205595edf38b5009adaedcb0008c87d0e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511858 Commit-Queue: Alison Maher <almaher@microsoft.com> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#829899}
-
Sinan Sahin authored
This CL also includes a bug fix for the show/hide animations so that the "message dismissed" callback isn't called for animations that don't actually hide the message. Bug: 1137941 Change-Id: I8286feacf03196879642870ce5d582910d8df01e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538338Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#829898}
-
Yue Li authored
Bug: 1149455 Test: None Change-Id: Ibf022a85132defcbbda53326da21d13287cb3210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546171 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#829897}
-
Kyle Horimoto authored
WireMessage protocol v3 used an unsigned 16-bit integer to represent the message length. Unfortunately, when big messages are sent (e.g., images sent through Phone Hub), the size can exceed the maximum value of a 16-bit int, so the protocol breaks down. This CL introduces v4, which uses an unsigned 32-bit integer to represent the message size. For backward compatibility, we still use v3 to send messages used for authentication, Smart Lock, and Instant Tethering. If a message is sent for any other feature type, we use v4. Bug: 1150565, 1106937 Change-Id: I2e074505f8efa8a6a7ba355229e8cd0adf7e7c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552250 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#829896}
-
Ryan Heise authored
Remove x86 Chrome on ARM Mac perf tests (no longer relevant) Change sharding to 7 to take advantage of https://chromium-review.googlesource.com/c/chromium/src/+/2548360 Bug: chromium:1138953 Change-Id: I626d9c43a02290afdd592e58c11c9bba1cc6054a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548360Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Ryan Heise <heiserya@google.com> Auto-Submit: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#829895}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/aeb3616301c8..6d612051c083 2020-11-20 amaiorano@google.com Kokoro: add Windows x86 (Win32) debug builds If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I40ea318aa1faab2242b58077f8c642e9b2c48c44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552176Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829894}
-
Adam Whiteside authored
Given |GetMaxBufferedFrames| runs during attribute initialization, the thread checker this DCHECK looks for doesn't exist yet causing crashes. This check is unnecessary as the only member variables that are accessed by the method are const. Bug: internal 173625018 Test: Build eng build and check no crash. Change-Id: I34e8b1b51ba75a3325466c1383a7000f039463b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553221Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Adam Whiteside <awhiteside@google.com> Auto-Submit: Adam Whiteside <awhiteside@google.com> Cr-Commit-Position: refs/heads/master@{#829893}
-
Mohammad Refaat authored
Updated the browsing_data_remover_impl to call a different method on session service which will get all session directories and remove them. Bug: 1151388 Change-Id: I21f62b6d5f6ccbf3279383d872e1a2b5fbaee954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551849 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/361d02972a3d..929fc7c79f0c 2020-11-20 bmeurer@chromium.org [wasm] Introduce unregisterLanguageExtensionPlugin API. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1041362,chromium:1083146,chromium:1151280 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I98c3743e2556c5854fe76b6c39be1f3bbef2263a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552809Reviewed-by:
-
Jesse Schettler authored
Instead of displaying scanned images in a preview area with a fixed height, let the scanned images extend to the bottom of the app window. Bug: 1059779 Change-Id: I0b004a9d758fa5a164dab43148d46df3fd3400ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553024 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#829890}
-
Gordon Seto authored
Create eSIM setup flow navigation state machine and connect to Mojo API, add unit tests Bug: 1093185 Change-Id: I8160f01f4d2c46e00512b9f0bbb8395533b19e34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544905 Commit-Queue: Gordon Seto <gordonseto@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#829889}
-
Aleks Totic authored
Small change to ComputeGridMinMax was necessary. 0% width cells are treated as "no percentage". This is a common pattern in table algorithms: "Zeroes are special!" The fix for LayoutNGTable::AddVisualEffectOverflow was good. It made 11 more invalidation tests pass. The old visualoverflow was too large. Bug: 958381 Change-Id: Ie6eec7f749ebd4400674e581f1dc128e4c3f81ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551540Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#829888}
-
James Cook authored
Some code has behavior differences when run on real Chrome OS hardware versus in the linux "emulator". That code uses base::SysInfo::IsRunningOnChromeOS() to check where it is running. Tests override this with base::SysInfo::SysInfo::SetChromeOSVersionInfoForTest(). For tests, we provide chromeos::ScopedIsRunningOnChromeOSForTest. However, this lives in //chrome/browser/chromeos/ and can't be used by Lacros (go/lacros). //c/b/chromeos is actually ash-specific code, and will be renamed to //c/b/ash shortly. To work around this, some tests have rolled their own scoped helper classes. We need test helpers that can be shared across ash-chrome and lacros-chrome. Since these test helpers are overriding the behavior of base::SysInfo, I think it should live in //base/test. Split the class into two parts, one to handle the common case of just overriding IsRunningOnChromeOS and another to override the version info. Also, use the helpers in a few more places for tests that were not resetting the Chrome OS version when they were done (a potential source of flake for subsequent unit tests). Bug: 1148904 Test: existing unit_tests Change-Id: I1442e54155c008e6447cd147f23a1dfd5ebfbb97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538285Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#829887}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/16973d613fed..8f8e2dc7d50f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I73111b94db4d1be54d6713d288203be19e3119f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553036Reviewed-by:
-
Patrick Noland authored
Testing a smaller (included) fix for a crash in updateMicButtonState revealed a few other post-destruction issues that were previously hidden by LocationBarLayout never being nulled out. So this CL * Null checks VoiceRecognitionHandler in updateMicButtonState * Guards against post-destruction callback/delegate invocation in URLBar * Prevents a post-destruction call to onSuggestionsReceived in AutocompleteMediator (and fixes incorrect documentation) Bug: 1151225, 1151080, 1146585 Change-Id: Iae295a7629c35aeae8ce357e414b05e6847d62e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552570Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Commit-Queue: Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#829885}
-
Stephen Roe authored
and Linux distro. This supports running tests on x64 Ubuntu and on arm64 Ubuntu 16.04 and arm64 Ubuntu 18.04. Bug: 1131647 Change-Id: Ie75adcb775bc32601fb4001720e960b17607edee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517991 Commit-Queue: Stephen Roe <steveroe@google.com> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#829884}
-
Adam Langley authored
Add support version=2 caBLE extensions with a sessionPreKey that carries the same information that would be sent via a QR code. This allows a server to create a caBLEv2 link. BUG=1002262 Change-Id: I0dc1e40a2beee927f4fa4faef243b350e017cc9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2548123 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#829883}
-
Sophie Chang authored
Bug: 1146151 Change-Id: If63c626ce0ef01d86d7465a0715cfea7470a3ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552886Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#829882}
-
Sorin Jianu authored
This change is just renaming files, changing header guards, include directives, and build files to match the new names. Bug: 1151106 Change-Id: Ia52ff972d3cee0d6623cfd051be7cababafbdce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551852Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829881}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2f47910c9ce3..8f8e2dc7d50f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie497ccb48973ce970c63471df0cbe68c3d90826f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552207Reviewed-by:
-
Steven Bennetts authored
This property is unused in Shill and Chrome. Bug=b:173635024 Change-Id: Ie28c18a959ec9a279794ecf5c30d8f856aeea89f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552891Reviewed-by:
-
Andrew Xu authored
This CL implements the menu item presenting the copied file, called `ClipboardHistoryFileItemView`. This new menu item is applied to the clipboard history data whose display format is `kFile`. Bug: 1134392 Change-Id: I48ad2b8e88ae8a6a5fa56b4c1f31af1e5a5ebea8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552082 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#829878}
-
Ahmed Fakhry authored
If the muxer expects audio frames, and doesn't get any, it will discard video frames. This causes tests to be flaky on the bots as no audio is captured there. See https://crbug.com/1151167. This CL adds the ability to tell the service not to record audio. There are plans to expose this in the UI too (See https://crbug.com/1145273). BUG=1151418 TEST=Manually, existing tests. Change-Id: I9f5552e54cecb949f6ceb746de56b9fee7d7e879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552921 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#829877}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/afaca889d46b..ce4be1e64050 2020-11-20 mbonadei@webrtc.org Revert "Enable FlexFEC as a receiver video codec by default" 2020-11-20 natim@webrtc.org Defining API result types on VoIP API 2020-11-20 philipel@webrtc.org Don't use VP9 specific concepts to combine spatial layer frames in FrameBuffer2. 2020-11-20 philipel@webrtc.org Remove unused includes from RtpFrameReferenceFinder. 2020-11-20 alessiob@webrtc.org AGC2 limiter stats + config ToString missing param 2020-11-20 asapersson@webrtc.org Enable initial frame drop for one active simulcast layer. 2020-11-20 philipp.hancke@googlemail.com dont allocate a payload type for rtp data channels when using sctp 2020-11-20 mbonadei@webrtc.org Trigger bots for FYI waterfall. 2020-11-20 mbonadei@webrtc.org Reland "Add protobuf-py2_py3 3.13.0 to .vpython." 2020-11-20 mbonadei@webrtc.org Revert "Add protobuf-py2_py3 3.13.0 to .vpython." 2020-11-20 jonaso@webrtc.org Add feature to not discard candidates after connection is established 2020-11-20 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 98d2d358..7ffc87db (829346:829478) 2020-11-19 tommi@webrtc.org Remove dependency on AsyncInvoker in SctpTransport 2020-11-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3e59a753..98d2d358 (829209:829346) 2020-11-19 philipel@webrtc.org Removed superfluous check in FrameBuffer2. 2020-11-19 mbonadei@webrtc.org Add protobuf-py2_py3 3.13.0 to .vpython. 2020-11-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9e2395c8..3e59a753 (829108:829209) 2020-11-19 nisse@webrtc.org Delete objc RTCRtpFragmentationHeader 2020-11-19 hmaniar@nvidia.com Enable FlexFEC as a receiver video codec by default 2020-11-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 20d9ad23..9e2395c8 (828982:829108) 2020-11-19 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 80346697..20d9ad23 (828632:828982) 2020-11-18 landrey@webrtc.org Reduce test flakiness because of upload issues 2020-11-18 mbonadei@webrtc.org Reland "Rename FATAL() into RTC_FATAL()." 2020-11-18 landrey@webrtc.org Fix address of checking the Dashboard upload status 2020-11-18 mbonadei@webrtc.org Disable flaky test. 2020-11-18 landrey@webrtc.org Log responce of the Dashboard before start using it at upload script 2020-11-18 philipel@webrtc.org Make video scalability mode configurable from peerconnection level. 2020-11-18 jakobi@webrtc.org Allow temporal based switch if temporal layers are undefined. 2020-11-18 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 921d7ed3..80346697 (828216:828632) 2020-11-18 phancke@nvidia.com guard flexfec usage with fieldtrial 2020-11-18 mbonadei@webrtc.org Revert "Rename FATAL() into RTC_FATAL()." 2020-11-17 bradpugh@google.com Add support for turn logging id in ios sdk. 2020-11-17 jonaso@webrtc.org Add TURN server to Emulated Network infrastructure 2020-11-17 natim@webrtc.org Locating input audio level before TaskQueue. 2020-11-17 jakobi@webrtc.org Remove resolution limited max bitrate for simulcast screenshare. 2020-11-17 garth.judge@8x8.com Fixed incorrect assertion when performing iLBC decoder packet loss concealment 2020-11-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 27f19de5..921d7ed3 (828088:828216) 2020-11-17 mbonadei@webrtc.org Rename FATAL() into RTC_FATAL(). 2020-11-17 nisse@webrtc.org Add transition define RTC_OBJC_HAVE_LEGACY_RTC_RTP_FRAGMENTATION_HEADER 2020-11-17 philipp.hancke@googlemail.com stats: add transportId to codec stats 2020-11-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 3a3815b9..27f19de5 (827982:828088) 2020-11-17 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 20a633fc..3a3815b9 (827865:827982) 2020-11-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 32410c4f..20a633fc (827734:827865) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1024965 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9d721597ac3deac4005f47ba1c1f3613ad7477c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552808Reviewed-by:
-
Leo Zhang authored
Store connector instances inside a map of InputMethodManager then remove the instance of ime service connector from InputMethodManager::State. Test: Test IME service on VM (betty). Bug: 1139328 Change-Id: I32057af4ac75fa5f3392741e87004559290f4494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509071Reviewed-by:
Keith Lee <keithlee@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#829875}
-
Kramer Ge authored
linux_explicit_synchronization can cause crash due to a bug in earlier exo version. Underlying issue can be fixed from lacros side. Re-enable once fix is landed. Change-Id: I54c9b07d48d29e5ed091831483152e2e4e6e5b38 Bug: 1151012 TBR=rjkroege@chromium.org Change-Id: I54c9b07d48d29e5ed091831483152e2e4e6e5b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552854Reviewed-by:
Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#829874}
-
Bo Liu authored
Currently viz is using the LocalSurfaceId in RenderWidgetHostViewAndroid as the surface to submit a root renderer frame to. This doesn't always work because renderer side change to LocalSurfaceId may not have been committed yet for that frame, which then can cause a mismatch in viz. Due to webview having a shortcut to resize the root renderer compositor viewport without commit [1], it's also not ok to use the LocalSurfaceId of the renderer compositor, since renderer can resize before the new Id is committed. This technically breaks surface sync, though it doesn't matter to webview in practice. However this does need to be solved for IsUsingVizFrameSubmissionForWebView. Instead, just generate LocalSurfaceId in HardwareRendererViz and check the frame size and scale to generate new Ids instead. [1] https://source.chromium.org/chromium/chromium/src/+/master:cc/trees/layer_tree_frame_sink_client.h;drc=7cfc49943853b0c361223b47ddeb01f7e9fa7ff3;l=73 Bug: 1145412 Change-Id: I0ac5934e214ca2667bf71fc610dceddc343d0e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551788 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#829873}
-
Matt Menke authored
Instead, use the shiny new one that takes net::SchemefulSites instead of url::Origins. Bug: 1145294 Change-Id: Id552fdb5f7711c5835d2551d5851d01d111c8b9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545484Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#829872}
-
Curt Clemens authored
Instead of a generic failure message, show a specific error string that depends on the TransferMetadata::Status. Change-Id: I86b6549c4f6de0477f9a63ef71f9298796f10065 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551078Reviewed-by:
-
Daniel Cheng authored
This ensures that the speculative RFH is deleted even when it is already ready to commit and has sent a CommitNavigation() IPC to the renderer. Bug: 838348 Change-Id: Id834274219c3f8b4d837cce2a3d54148e938a0c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2536794 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#829870}
-
Xianzhu Wang authored
This reverts commit 6b916224. Reason for revert: Caused crbug.com/1150781. Original change's description: > Check Layer::SafeOpaqueBackgroundColor() is opaque when contents_opaque() > > Bug: 936906 > Change-Id: Ibbb8fad9bd4680a91e0a595e10db9b752c1450a5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2538330 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#828829} TBR=wangxianzhu@chromium.org,vmpstr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 936906, 1150781 Change-Id: I6a880b97b48a5842ef00008d6ac75c00731024b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552986Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829869}
-
- 20 Nov, 2020 3 commits
-
-
Haiyang Pan authored
If it runs fine, it will be removed from MM-arm64-rel & MM-x86-rel-non-cq, and run on MM-x86-rel formally. Bug: 1127110 Change-Id: I55bdfece736a2ce00864be4b42e2ee1df1a6b777 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552676Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#829868}
-
Christoph Schwering authored
Bug: 1142413, 1150277 Change-Id: I19a5f90933e5da7e9d2ea79e7c1fff7c48002cd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550383Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Matthias Körber <koerber@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#829867}
-
Kurt Catti-Schmidt (SCHMIDT) authored
This change is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/2340291. After that change went in, we are still seeing crashes in BrowserAccessibility::AccessibilityPerformAction where the anchor and/or focus nodes are not found, stemming from setSelectionRanges. Based on code inspection, I was able to come up with this variation, where the anchor and focus nodes are in the same tree as each other, but in a different tree than the caller. The crash dumps I have available not have enough data to prove that this is the root cause of those specific crashes, but the unit test added here is sufficient to show that this crash is possible. Rather than returning an error in this scenario, when the anchor and focus nodes are in in the same tree as each other, but a different tree than the node calling setSelectionRanges, the tree that the anchor and focus nodes reside in is used for looking up the manager and setting the selection. AX-Relnotes: n/a Bug: 1110522 Change-Id: I28cb18e87bcd0cfa2abd3220878d4b04ac70f96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504630 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#829866}
-
