- 08 Feb, 2019 40 commits
-
-
Peter Boström authored
This adds text to better highlight that the current window is an Incognito one. It does not apply when the Incognito window-counter experiment is active. Bug: chromium:929842 Change-Id: I11eb7ae8cd18b62e6cbc5be46c027dccf5f12040 Reviewed-on: https://chromium-review.googlesource.com/c/1459790 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#630182}
-
Robbie McElrath authored
In ChromeOS chrome/ browser tests, a NetworkChangeManagerClient gets created, which initializes the network connection state. This initialization was also happening in BrowserTestBase, which meant that for chrome/ tests it was happening twice. This CL moves the initialization logic into ContentBrowserTest, which isn't used in chrome/ tests. Bug: 927293 Change-Id: If506d90b1fe074e49b795a2e206b9ced68c5b9ba Reviewed-on: https://chromium-review.googlesource.com/c/1457478Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#630181}
-
Kenneth Russell authored
In the Telemetry-based GPU tests, the most common reason the renderer process hangs is that the GPU process has hung, and the renderer's waiting for it. In order to debug hangs like these, it's necessary to be able to crash the GPU process on demand. In these situations the GPU process's main thread is hung, but its IO thread is very likely still responsive. Add an experimental crashGpuProcess method to DevTools' Browser domain. (Other existing facilities like the GpuBenchmarkingExtension won't work because the target renderer process's main thread is hung.) Separately, handle GpuChannelMsg_CrashForTesting earlier in the GPU process, on its IO thread. The fact that the GpuBenchmarkingExtension's CrashGpuProcess API wasn't robust to GPU process hangs was discovered during development of this CL. Tested by manually injecting a GPU process hang in one WebGL conformance test, decreasing the timeouts, and verifying that the GPU process's symbolized minidump showed up in the logs. Bug: 911772 Change-Id: Id41e3168c1f9411411755c92b6e20717813f7c71 Reviewed-on: https://chromium-review.googlesource.com/c/1459328 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#630180}
-
Ken Rockot authored
This converts the following service manifests from JSON to C++: - Mirroring service - NaCl broker service - NaCl loader service - Heap profiling service - Patch service - Unzip service - PDF compositor service These are the last of the JSON manifests under src/components/ NOPRESUBMIT=true (to bypass TBR vs OWNERS change restriction since this is mechanical beyond security review) Bug: 895616 Change-Id: Ic5be4bb8cf5ee589961b3741a32cdbd87348295e TBR: miu@chromium.org,dschuff@chromium.org,eseckler@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1457416 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#630179}
-
Martin Kreichgauer authored
Add my own @google.com account which I tend to use more. Also move Jan and Jun to the Emeriti list. Change-Id: Ifd478f68a08b8bbdf413c5bdd9242c9be7f6cd33 Reviewed-on: https://chromium-review.googlesource.com/c/1455684 Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#630178}
-
Daniel Ng authored
This reverts commit 4d5a709c. Reason for revert: Due to refactoring coming from CL:1447912, we need to update the protos involved, therefore we need to revert this change so that changes to the proto don't break chrome. Original change's description: > Installation functionality for Crostini App search > > CL updates the Crostini Repository Search Results in the app launcher > to install Linux packages when clicked. This contains the relevant > app launcher and crostini manager changes. This feature is still behind > a flag and there are plans to incorporate an installation dialogue > into the installation process. > > Bug: 921429 > Change-Id: I17eeb6af488e56be2d9eb34edefb0194975839c8 > Reviewed-on: https://chromium-review.googlesource.com/c/1444901 > Commit-Queue: Daniel Ng <danielng@google.com> > Reviewed-by: Timothy Loh <timloh@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#628648} Change-Id: Ia2cecd862b947ee8b6b29b4acaef8b4fccb434fe TBR=xiyuan@chromium.org Change-Id: Ia2cecd862b947ee8b6b29b4acaef8b4fccb434fe Reviewed-on: https://chromium-review.googlesource.com/c/1459864 Commit-Queue: Daniel Ng <danielng@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#630177}
-
Gyuyoung Kim authored
As a step to make to use IdentityManager, this CL replaces all uses of ATS with IdentityManager in arc_auth_service.h/cc except for the use of AccountMapperUtil. The use of AccountMapperUtil should be replaced by crbug.com/922744. Bug: 922745, 922746, 922747 Change-Id: I4f5bbb545e7bf5bb31f1ba4bec30414752ae8401 Reviewed-on: https://chromium-review.googlesource.com/c/1436421 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#630176}
-
Daniel Libby authored
Currently ETW logging for TraceArguments uses TraceValue.AppendAsJSON, which ends up emitting surrounding quotes and escaping certain characters, which harms readability. This change introduces an AppendAsString method on TraceValue, which doesn't do the typical munging for JSON. Bug: 781991 Change-Id: Ia9d0f795f85819f0cee630f460fe82a373ffe337 Reviewed-on: https://chromium-review.googlesource.com/c/1448981Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#630175}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ff3805a63456..248eabeb7086 Created with: gclient setdep -r src-internal@248eabeb7086 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:929520 TBR=mmoss@chromium.org Change-Id: Icd634ace7cb8aa8960917b1c9e5518cbf1076c95 Reviewed-on: https://chromium-review.googlesource.com/c/1459943Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630174}
-
Dmitry Gozman authored
This is incompatible with binary protocol plans. Bug: 929862 Change-Id: I3d1a26ebd2cc173544df67a69c5642740ea7a1f4 Reviewed-on: https://chromium-review.googlesource.com/c/1459807 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
-
Lei Zhang authored
Delete code that assume it can be. Change-Id: I2e2344d4c04ff957cf403698bdfa17bffdd602b6 Reviewed-on: https://chromium-review.googlesource.com/c/1457431Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#630172}
-
Tien Mai authored
Bug: 909722 Change-Id: I2edde2a592f5e2528574076b86ab37d5bcebe185 Reviewed-on: https://chromium-review.googlesource.com/c/1458682 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#630171}
-
danakj authored
This API was for notifying the WebWidgetClient about invalidations back when we did not use a compositor. Now it has only one use which is for notifying WebViewPlugin of invalidation each frame. The path that is used is: ChromeClient->WebView->WebWidgetClient->WebViewPlugin This removes other paths, documents it as WebViewPlugin-specific. And removes Apis in fullscreen pepper that were for plumbing through to the WebWidgetClient, since pepper is not used in WebViewPlugin. Then we move the API from WebWidgetClient to WebViewClient since WebViewPlugin only uses one widget and the API through ChromeClient and WebViewImpl is all widget-agnostic. TBR=dcheng@chromium.org Bug: 912193 Change-Id: Ibd6f7ab3aee48bebf37a311dfd1f31609d406acc Reviewed-on: https://chromium-review.googlesource.com/c/1456999 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Kyle Milka authored
Add browser_tests for search suggestion. Also fix a bug introduced in https://crrev.com/c/1446789 causing a impression to be counted even if it contained no suggestions. Change-Id: I1a2395eb0e1e7be988609f9c45945c7a8e6de5c4 Reviewed-on: https://chromium-review.googlesource.com/c/1460103Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#630169}
-
Evan Stade authored
DesktopWidgetTestInteractive.WindowModalWindowDestroyedActivationTest works with a slight tweak. To provide full coverage, we will probably want to add more unit tests to WindowTreeClient (a lot of which are disabled right now). Bug: 916272 Change-Id: I0e04a651ea7cadbce4a96c060cc9cc762ca56400 Reviewed-on: https://chromium-review.googlesource.com/c/1457118 Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#630168}
-
Anand K. Mistry authored
MDnsTransaction keeps a pointer to MDnsClient and accessed it on destruction. Therefore, it needs to be destroyed before MDnsClient. On the same note, destroy MDnsClient before MDnsSocketFactory because MDnsClient uses MDnsSocketFactory. This isn't strictly necessary, but keeping dependency order helps to prevent future UAF bugs. BUG=929467 Change-Id: I22af0ffa91b5bc2ce6533a8c0d85bfa351e8e9e4 Reviewed-on: https://chromium-review.googlesource.com/c/1459861Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#630167}
-
Lei Zhang authored
Change-Id: I9ca2e8106ae2f9e35d841709137b3906d007f589 Reviewed-on: https://chromium-review.googlesource.com/c/1457433Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a29dd9d0cb8b..50e24d7d5f52 git log a29dd9d0cb8b..50e24d7d5f52 --date=short --no-merges --format='%ad %ae %s' 2019-02-08 csmartdalton@google.com Add a mechanism for GMs to silently exclude themselves from Gold 2019-02-07 benjaminwagner@google.com [infra] Update Win10 in Skolo. 2019-02-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-07 csmartdalton@google.com Reland "Add a GpuGM class for GPU-only tests" 2019-02-07 bsalomon@google.com Track separate texure binding states for each OpenGL texture target. 2019-02-07 halcanary@google.com SkQP: new tool: tools/skqp/find_commit_with_best_gold_results 2019-02-07 brianosman@google.com Check for single owner and abandoned context in createMipMapProxyFromBitmap 2019-02-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-07 jvanverth@google.com Fix Metal bots. 2019-02-07 halcanary@google.com SkQP: update tools/skqp/gn_to_bp.py, add release script 2019-02-07 bsalomon@google.com Cache CPU memory buffers used for client side arrays. 2019-02-07 bungeman@google.com Don't include .cpp file in SampleCCPRGeometry.cpp 2019-02-07 brianosman@google.com Give ImGui the correct DeltaTime 2019-02-07 djsollen@google.com Remove colorspace restrictions for 565/FP16 configs in Android Codec. 2019-02-07 mtklein@google.com skvx wip 2019-02-07 bsalomon@google.com Default init GrGpuResource::UniqueID to invalid id. 2019-02-07 robertphillips@google.com Move "matches" from GrContextThreadSafeProxy to GrContext_Base 2019-02-07 robertphillips@google.com Make room for shifting GrContext to GrDirectContext 2019-02-07 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2019-02-07 brianosman@google.com Support building mips when creating cross context images Created with: gclient setdep -r src/third_party/skia@50e24d7d5f52 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:926017,chromium:b/123377741 TBR=fmalita@chromium.org Change-Id: Ib89a98cfe7ceb4eedff7c99ea6fe34030867a6f8 Reviewed-on: https://chromium-review.googlesource.com/c/1460338Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630165}
-
Li Lin authored
Package name alone is not enough for resolving the activity. Set the default activity name if there is no intent data for resolving the activity. Test: Manual Bug: b/120867066 Change-Id: I38fea46006c7324b88570b9b971ba5bda9aca2a9 Reviewed-on: https://chromium-review.googlesource.com/c/1455273 Commit-Queue: Li Lin <llin@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#630164}
-
Sam McNally authored
Calling |on_disconnected_| is necessary for detecting remote-initiated disconnects, but for local-initiated disconnects, the code responsible for disconnecting is already doing its own cleanup - notifying it of its own action causing a disconnect is unnecessary. Change-Id: I7ee7cf35140517f7849c30de704bd1a1fda62566 Reviewed-on: https://chromium-review.googlesource.com/c/1460199 Commit-Queue: Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Auto-Submit: Sam McNally <sammc@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#630163}
-
Noel Gordon authored
The Providers test fixtures run with the Smb provider feature enabled. However, policy can be used to disable the Smb provider feature and so we should browser test that case. Add a test enable/disable for the native Smb provider feature, and run the Providers tests with the feature enabled and disabled. Test: browser_tests --gtest_filter="Providers/FilesAppBrowserTest*" Bug: 879404 Change-Id: I34153efbbbf6a1c5028eb7ec3b61332d7dd45215 Reviewed-on: https://chromium-review.googlesource.com/c/1458398 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Eric Orth authored
As far as I can tell, these resolves were just an overcomplicated way to build AddressList objects. Bug: 922699 Change-Id: I53092a4000edb1829688daa0853dc7fafd05a59c Reviewed-on: https://chromium-review.googlesource.com/c/1460099 Commit-Queue: Eric Orth <ericorth@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Auto-Submit: Eric Orth <ericorth@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#630161}
-
Luciano Pacheco authored
CL 1 of 4, CLs: 1. Convert var to const/let. 2. Convert arrow functions. 3. Convert to ES6. 4. Reformat files. Bug: 778674 Change-Id: I4c9bae5f47ffe89380936c37e3fef950d5a3dbde Reviewed-on: https://chromium-review.googlesource.com/c/1460198 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#630160}
-
Alexandre Courbot authored
The jobs queue management code is currently very messy, with jobs queue management done all over the place. This CL moves jobs queue management to be done entirely in ProcessTask() and ProcessJobsTask(). On top of making the code easier to read, this has the side-effect of letting jobs be queued before deciding the output buffer of the job. This change will be necessary to let V4L2IP manage its own output buffers instead of relying on the client to do it. Bug: 792790 Test: Ran VDA unittest on Hana and VEA unittest on peach_pit. Change-Id: I2ee2575287a123c5ade8796e4d13a02427529900 Reviewed-on: https://chromium-review.googlesource.com/c/1454350 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#630159}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/cf21146137cf..10a7def6c03e git log cf21146137cf..10a7def6c03e --date=short --no-merges --format='%ad %ae %s' 2019-02-07 dj2@everburning.com Smoketest should use KhronosGroup glslang (#2363) 2019-02-07 dj2@everburning.com Make spvParseTargetEnv public (#2362) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@10a7def6c03e The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ie0198d62012c918d227790804c5743297a2983f7 Reviewed-on: https://chromium-review.googlesource.com/c/1460336Reviewed-by:
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I4fadf2193b42928cf49b5787bb0be4fd64103bec Reviewed-on: https://chromium-review.googlesource.com/c/1459950Reviewed-by:
-
chaopeng authored
Will remove TargetData in RenderWidgetHostInputEventRouter. Bug: 923560 Change-Id: Id3a0945f86bb6eeb3f1e1bf300763413049da250 Reviewed-on: https://chromium-review.googlesource.com/c/1456942Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
-
Ken Rockot authored
This converts the following service manifests from JSON to C++: - Chrome OS assistant service - Chrome OS assistant audio decoder service - Chrome OS device sync service - Chrome OS IME service - Chrome OS multidevice setup service - Chrome OS secure channel service These are the last of the JSON manifests under src/chromeos/. Bug: 895616 Change-Id: Ia1c345d9b2acafec59eaa1a3ba3344c7f8180c17 Reviewed-on: https://chromium-review.googlesource.com/c/1456955 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Rahul Chaturvedi <rkc@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#630155}
-
Collin Baker authored
This makes testing the UI easier: in in-product help demo mode, the first call to ShouldTriggerHelpUI() will always return true. Previously to test the UI you still had to meet the triggering conditions handled by ReopenTabInProductHelpTrigger, which meant leaving a tab open for a duration of time. Now in demo mode the UI should always show upon opening a new tab. Change-Id: I4e1e47dd5ae3c8b1a07eb8f3cfafa37f3279b8e0 Reviewed-on: https://chromium-review.googlesource.com/c/1460416 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#630154}
-
Luciano Pacheco authored
Change-Id: Ib5f588376e29dcde496c941d670369afa49fe849 Reviewed-on: https://chromium-review.googlesource.com/c/1459859Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#630153}
-
rbpotter authored
Using isScalingDisabled to set the availability disabled the scaling section for all PDFs. This CL restores the previous behavior of ignoring this value and showing the scaling section for all documents. Bug: 929830 Change-Id: Ibab11edaa68d839aa40dac988d997acbac24e0fc Reviewed-on: https://chromium-review.googlesource.com/c/1459776 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#630152}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: Ia222fec8b2e2cc1e6cf4512b379dd990f80569e0 Reviewed-on: https://chromium-review.googlesource.com/c/1460315Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#630151}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dd39fc4a..054df48c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I151c2f76fe02e58b527bd31d28e64521eab5ce9b Reviewed-on: https://chromium-review.googlesource.com/c/1459811Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#630150}
-
Maggie Cai authored
Currently, after clearing data for a Etld+1, the origins that had permission settings and data or cookies will be left in a state where the usage or cookie display element is not hidden. This is due to the fact that Polymer was not notified about the change of the element. This CL ensures that the Polymer is notified about the change. Bug: 835712 Change-Id: Icf2c20643e0a63992e295e2c347a99d7a586ec80 Reviewed-on: https://chromium-review.googlesource.com/c/1457807Reviewed-by:
Patti <patricialor@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#630149}
-
Leonard Grey authored
Bug: 928311 Change-Id: I743e399fd34d23352c53069d382ac6a47d4b71b3 Reviewed-on: https://chromium-review.googlesource.com/c/1459997Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#630148}
-
Charlie Harrison authored
The recent tab helper tests swap out the main thread with their own custom task runner (used for fast forwarding time). However, this doesn't work well with the NavigationSimulation, which internally uses base::RunLoop to pump tasks. Any code that adds an async action that delays navigation commit will hang these tests, and the AsyncNavigationIntercept experiment does just this. To fix, disable NavigationSimulator from pumping / waiting for task completion internally, by setting AutoAdvance to false. Then within the test, manually run tasks on the task runner after start. This is a bit of a hacky fix (since it is special casing nav start). But there are three possible paths forward: 1. RenderViewHostTestHarness tests can support fast forwarding natively, as well as pumping tasks with base::RunLoop by having its type be kBoundToThread. Not sure how much work this would entail. 2. RecentTabHelper can be refactored to use mock timers rather than PostDelayedTasks. 3. NavigationSimulator can be improved by allowing callers to inject their task runner before starting the navigation, so the simulator can pump tasks correctly. Bug: 793053 Change-Id: I43edda78a0236d8357d8ecf9a8f7db55c421b422 Reviewed-on: https://chromium-review.googlesource.com/c/1458477Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Auto-Submit: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#630147}
-
calamity authored
This reverts commit 9a0ad6e5. Reason for revert: Compile failure on linux-chromeos-rel https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/linux-chromeos-rel/19683 Original change's description: > Adds AssistantNotificationView. > > This view provides the UI for in-Assistant notifications. Currently the > labels/buttons for this view are stubbed in but a follow up CL will wire > this view up to actual mojom::AssistantNotifications. > > Screenshot: http://shortn/_MYjBlqDoku > > Bug: b:118654460 > Change-Id: I1a436c33466aff9db0c92595a988170c99456e0f > Reviewed-on: https://chromium-review.googlesource.com/c/1453547 > Commit-Queue: David Black <dmblack@google.com> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#630144} TBR=xiaohuic@chromium.org,dmblack@google.com Change-Id: I90a8a9b28ff2414e504806d92a30fb58d51daea7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:118654460 Reviewed-on: https://chromium-review.googlesource.com/c/1460204Reviewed-by:
-
Darren Shen authored
The opt-in assistant menu is interfering with some tast tests. Tast tests use --oobe-skip-postlogin to skip dialogs that appear after a new user has logged in, so let's just use that flag too. Bug: 929396 Change-Id: I16dd55a68f6e68ed4780e99d68afdc24a1b0002e Reviewed-on: https://chromium-review.googlesource.com/c/1459865Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#630145}
-
David Black authored
This view provides the UI for in-Assistant notifications. Currently the labels/buttons for this view are stubbed in but a follow up CL will wire this view up to actual mojom::AssistantNotifications. Screenshot: http://shortn/_MYjBlqDoku Bug: b:118654460 Change-Id: I1a436c33466aff9db0c92595a988170c99456e0f Reviewed-on: https://chromium-review.googlesource.com/c/1453547 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
Caleb Rouleau authored
This reverts commit 6c2e6729. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=929793#c6 Original change's description: > Third try of ResourceLoadViaDataPipe > > Flipping the flag revealed a couple of issues which were fixed: > - OnTransferSizeUpdated(): https://crrev.com/c/1454344 > - One more PostTask() made tests more flaky: https://crrev.com/c/1454345 > > I hope third try will go well. > > Bug: 894819 > Change-Id: Icc6159622aacd5c4a4c250a0834bf4c3641d916a > Reviewed-on: https://chromium-review.googlesource.com/c/1454062 > Commit-Queue: Makoto Shimazu <shimazu@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Auto-Submit: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#629089} TBR=kinuko@chromium.org,shimazu@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 894819 Change-Id: I9aca1329997e4f2517cd72bc79020bf2d147af35 Reviewed-on: https://chromium-review.googlesource.com/c/1459584Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#630143}
-
