- 03 Jun, 2019 40 commits
-
-
Yann Dago authored
Bug: 969889 Change-Id: I0df8a98a007691a2153b67caeaea3e22ea7ccadd TBR: pastarmovj@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641988 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:
Yann Dago <ydago@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#665672}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I0c9d9fc86ee7f86267649b4326fb5aba528d3ce2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642007Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665671}
-
Esmael El-Moslimany authored
Change-Id: I074a7ff55bda151c56bd7ab4f971517bbd84ae73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636564Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#665670}
-
Sergey Ulanov authored
rebaseline_cl tool wasn't rebaselining test expectations for fuchsia because the fuchsia try bot wasn't listed in builders.json. Bug: 958017 Change-Id: I7968b22d3cc0a31f3e4a5083b7017af982100cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640796 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#665669}
-
Nina Satragno authored
Add a "Retry" button that lets the user start the WebAuthn flow over after tapping a key that was not registered. Bug: 920464 Change-Id: I01e5ce9219153c5c23f55399d5fcc9374cabd306 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1627933 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#665668}
-
Kelvin Jiang authored
Add the function skeleton for getMatchedRules along with types required for it in the .idl. Once again, skipping presubmit as the idl parser fails weirdly as seen in crbug.com/956368 NOPRESUBMIT=true Bug: 967942 Change-Id: I76c79e3de1c008d43474dec4cbec3a7b476f5374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639518 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#665667}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1c7a411305c5..72240f63d231 git log 1c7a411305c5..72240f63d231 --date=short --no-merges --format='%ad %ae %s' 2019-06-03 benjhayden@chromium.org Migrate spa to LitElement Created with: gclient setdep -r src/third_party/catapult@72240f63d231 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:950011,chromium:892932,chromium:953441,chromium:965442 TBR=charliea@google.com Change-Id: Iafda08047b2b989c74b2a51664ce392aed04fd17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641509Reviewed-by:
-
Mike Wasserman authored
Move the mojo interfaces to pure virtual C++ interfaces. Add a static Get() function; defined in impl w/Shell usage. Rename the implementation to *Impl; minor cleanup. Disable SpokenFeedbackTest.SpeakingTextUnderMouseForShelfItem (see Issue 921182 for more details) TBR=dtseng@chromium.org Test: No ChromeVox or other Chrome OS a11y regressions. Bug: 958199, 921182 Change-Id: I3609b83a7fc10eaa34cbe1ad3228bb42ea77909f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636857 Commit-Queue: Michael Wasserman <msw@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#665665}
-
Esmael El-Moslimany authored
The issue https://github.com/Polymer/polymer/pull/3668 was fixed in Polymer 2. We can now wrap the <style> include attribute value if the 80 character line limit has been reached. Change-Id: I77d992e260d8ce203759b9cd1015438ac427990a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639043Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#665664}
-
Christian Biesinger authored
In the block axis, we do have to do layout for {min,max,fit}-content so we can determine the intrinsic size. MainAxisLengthIsDefinite here is called from ConstructAndAppendFlexItem via ChildHasIntrinsicMainAxisSize (which needs a better name). Bug: 968940 Change-Id: If74e6098280077fefe607e2c5b1f70f133ca1032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641510Reviewed-by:Emil A Eklund <eae@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#665663}
-
Christian Biesinger authored
Change-Id: Id653fc50ffa05b4f3e9da4415cf944c6bcbc7aad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1642009 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
-
Erik Chen authored
Previously, memory metrics were collected at each UMA upload interval. This timing is context dependent. The new logic samples Chrome's memory using a poisson process, with mean interval 5 minutes on Android and 30 minutes on desktop. Bug: 895474 Change-Id: I08482648996fde7c05ab8d957479c30a4e353a3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637938Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665661}
-
Khushal authored
Ping the watchdog thread for Gpu_main during strike deletion to avoid hangs on mac. R=piman@chromium.org Bug: 969623 Change-Id: I36faa00db502e1b1cf0bbda262e5aaadd96f2cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641602 Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#665660}
-
Jun Mukai authored
Two methods in AssistantClient interface is actually for the communication between ash and the browser (and the comment also said so). This CL replaces those two methods by C++ along with removing the comment. - OpenAssistantSettings(); this can be replaced as a single function. - SetDeviceActions(); this comes up with the idea of having an interface for holding browser-owned objects which are used by Ash. This is the superclass of AssistantClient so it's named so. Since AssistantImageDownloder and AssistantSetup are owned by AssistantClient, this CL makes the new ash::AssistantSetup own them. With that, the static GetInstance()s are removed. TBR=stevenjb@chromium.org Bug: 958193 Test: trybot Change-Id: I2d308e1d59777b952409f0c2c9bda1392d9b5154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638179 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Cr-Commit-Position: refs/heads/master@{#665659}
-
Brian Sheedy authored
Ports the remaining WebXR browser tests that are currently OpenVR-only but make sense for WMR over to also run with WMR. As a result, also properly copies texture data and provides it back to the test in WMR like OpenVR does. Bug: 926048 Change-Id: I12841f4adc8876089592020493cb371e38214a73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637610 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#665658}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6e0b92527131..4c5f9b2027a6 Created with: gclient setdep -r src-internal@4c5f9b2027a6 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harringtond@google.com,orphis@google.com,shend@google.com Change-Id: I2dcaebbfad73c8b532223529acd94345ef83d3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641745Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#665657}
-
Yuwei Huang authored
This CL fixes a few memory leak issues found in crrev.com/c/1639052 Bug: 961064 Change-Id: I3746dab3300233f2965a2784f700481250d1abd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639730 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#665656}
-
yilkal authored
Bug: 969227 Change-Id: Ide1703ae4e37a22535c6d1f4034f7d55d716e635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1638963Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#665655}
-
Marina Ciocea authored
Create infobars on all tabs when sharing a tab using the desktopCapture() API, to make it easy for the user to quickly change the sharing tab. Bug: 927949 Change-Id: I929724a200cb37c81693b5d0afb82c554cbd1175 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617498 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#665654}
-
Martin Kreichgauer authored
The credential IDs of the Touch ID authenticator are basically an AEAD of the associated PublicKeyCredentialUserEntity (= (id, name, display name), with the RP ID as the AD. While the user ID is bounded to 64 bytes, the user name and display name are not. Instead, CTAP authenticators are supposed to truncate them at any length larger than 64 bytes as they see fit. The spec doesn't define an upper limit for credential IDs, but I suspect some RPs will limit what they accept based on what they observe in security keys from large manufacturers. Also storing potentially unbounded IDs in attribute fields of the macOS keychain items might not be the best idea. Hence, let's impose some (arbitrary) limit. Bug: 1631393 Change-Id: I43cbbf3daa6e926baba7007ff99223b5666773e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631655 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
-
Chase Phillips authored
Following up on a drive-by from mek@ at https://crrev.com/c/1252912, this change updates our IndexedDB code to comply with Chromium's C++ dos/don'ts where it says to avoid std::pair and prefer a struct when defining an alias to the std::pair return result. Bug: 717812 Change-Id: I74755d832b1bc34c17fbdf769a54adf5cac406bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601821Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
-
Chris Harrelson authored
Bug: 935529 Change-Id: I6844597a562c761d6000d16a34cffc85ad79985a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639041 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#665651}
-
Joe Downing authored
BUG: 969857 Change-Id: I9ba74d64e9bc3a6400f9a504ccedb105c4b90452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606763 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#665650}
-
Avi Drissman authored
There are lots of files that pull in Aura headers on the Mac. Many have header includes that are easy to fix. The other is hosted_app_button_container.cc, which includes native_widget_aura.h in order to access GetWindowTitleFontList(). Move GetWindowTitleFontList() to custom_frame_view.h and file a bug to move it elsewhere. BUG=968860 Change-Id: I944a9c4016b65c5b10e5faead4e06aaafe71155c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636230Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
-
Ben Pastene authored
This is a reland of ad780388 Fix includes moving the '!' into its proper place. And crrev.com/c/1638777 was uploaded to prevent this type of regression from slipping in again. Original change's description: > Skip 'dep:chrome_internal' Tast tests if we're not building w/ is_chrome_branded. > > So that no dep:chrome_internal tests are ran if they don't have the > needed internal bits. > > Bug: 947531 > Change-Id: I060734d2fe05c878d16f2c6a63815bd0abbb554c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637644 > Reviewed-by: Dan Erat <derat@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665158} Bug: 947531 Change-Id: I8acc782fb8a926a628e7531b7df73cc6029be6d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637672Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#665648}
-
Jared Saul authored
We've moved away from having separate IsXYZFlagEnabled() functions in favor of just having the flag-checking code at the calling points themselves. I believe these are the last three stragglers. Change-Id: I8060cacd962851dc22691ef95437b7aa72b6fbd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639051Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#665647}
-
Asanka Herath authored
Use of GSSAPI libraries is gated on a complicated condition that's repeated in multiple locations. In reality it simplifies greatly since there are only two exceptions to the "Use an external POSIXish GSSAPI library if supporting Kerberos" rule. Bug: 927182 Change-Id: I6e3b514cdddb857409e90ee9fd0460d8d7836404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640782 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#665646}
-
Manas Verma authored
Bug: 969257 Change-Id: Ic24c32bc581a7a5aa2b84b3755ef313afb55c410 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639821 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#665645}
-
Caleb Raitto authored
See crrev.com/c/1590404 and the linked bug for context -- the goal is to fix the broken memory-leak checking in Chromium's ASAN (AddressSanitizer) trybots, which are supposed to also run LSAN (LeakSanitizer). Currently-leaking tests must be fixed or disabled before leak checking can be enabled in the ASAN trybot. WARNING: This will result in a loss of ASAN coverage for the affected tests given that LSAN runs as part of the ASAN trybot. If that's not acceptable, we can wait until the leaks are fixed before fixing leak detection in trybots, but keep in mind that newly-introduced leaks Chromium-wide won't be caught until then. Bug: 968302 Change-Id: Ic5a0341b41596cef91ffcce72f467bf26c01c244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1636452 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#665644}
-
Tomasz Wiszkowski authored
Bug: 969093, 968951 Change-Id: Ibc88bcc667d8035c49f58c3c0cd0f98651595acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1637669Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Ender <ender@google.com> Cr-Commit-Position: refs/heads/master@{#665643}
-
Rohan Pavone authored
With completion of NewWindow API and Execute[Async]Script APIs, WebDriverExpectations have been updated to expect affected tests to pass. This should include all webdriver/tests/new_window tests, all webdriver/tests/execute_async_script tests, and all webdriver/tests/execute_script tests (except json_windowproxy_serialize.py). Change-Id: I95ea32d727996f40d18816e7198b40c34cd4acbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641802 Auto-Submit: Rohan Pavone <rohpavone@chromium.org> Commit-Queue: Rohan Pavone <rohpavone@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#665642}
-
James Cook authored
After PM/UX discussion, we don't want to duplicate the search engine drop-down between browser and OS settings. Instead, OS settings uses an info label with a link to browser settings. Screenshots on bug: https://bugs.chromium.org/p/chromium/issues/detail?id=960937#c7 Bug: 960937 Change-Id: I622558c4c7238dc8f3d36d3a63305e7abc0f473a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1640601Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#665641}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/102b7289a9f2..e86af2c75fe6 git log 102b7289a9f2..e86af2c75fe6 --date=short --no-merges --format='%ad %ae %s' 2019-06-03 eladalon@webrtc.org Allowing buffering a LNTF (loss notification) feedback message in RTCPSender 2019-06-03 barrerap@webrtc.org Check input file extension is not wav Created with: gclient setdep -r src/third_party/webrtc@e86af2c75fe6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Icd16aa13c3aa587e8e5495c91c7d6b39d512c194 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641505Reviewed-by:
-
John Budorick authored
Causing a lot of flakes on android-marshmallow-arm64-rel. Also removes the suite-specific shard timeout. Tbr: perezju@chromium.org No-Try: true Bug: 964804 Change-Id: I79878f447cb3206416eedc51a69c0cbf381ae953 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639347 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#665639}
-
Yuwei Huang authored
We saw a crash report in MuxingSignalStrategy (see the bug) that OnWaitForAllStrategiesConnectedTimeout seems to try reading address 0x0. The callstack seems a bit confusing and incomplete but one failure pattern I can see is that when MuxingSignalStrategy is destroyed, it will first call Core::Invalidate() then schedule to delete Core asynchronously. Invalidate() doesn't stop the timer so the timer may kick in any time before the Core is actually destroyed. Then OnWaitForAllStrategiesConnectedTimeout may access the signal strategies after they have been deleted in Invalidate(). This CL stops the timer in Core::Invalidate, which should fix this particular failure pattern. Bug: 969825 Change-Id: I448eee26173e4cb6d976803b7f4e9e08f3dda4b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641372 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
-
Peter Boström authored
Turns on a new tab-loading animation by default. This animation displays the favicon earlier in the loading process to communicate where a user is navigating to even while the page is still loading. Bug: chromium:941039 Change-Id: I8a117243d963b87e75a875832529bcb35e9af035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1639565Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#665637}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/062420146dfd..4867952e90e7 git log 062420146dfd..4867952e90e7 --date=short --no-merges --format='%ad %ae %s' 2019-06-03 dgagnon@google.com Update gen_luci_scheduler with R76 branch Created with: gclient setdep -r src/third_party/chromite@4867952e90e7 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Change-Id: I739ff396f20c8a62d20fa5bc59fd5538ef11051b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641504Reviewed-by:
-
Stephen Chenney authored
TBR=foolip@chromium.org BUG=968164 Change-Id: Id5bf236dfd3a3e716ebfb88a1b6f8e6302c3060d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641327Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#665635}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d167c5b89a42..6e0b92527131 Created with: gclient setdep -r src-internal@6e0b92527131 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=harringtond@google.com,orphis@google.com,shend@google.com Change-Id: I9b899a7d3362b1ba6cad4d7efd9221b67758acd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641503Reviewed-by:
-
Findit authored
This reverts commit 400c3bba. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 665601 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNDAwYzNiYmE5YmEwMTRiYmJmODk5YzA3YzVjOTllNjJkZTliYWVjYgw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win7%20Tests%20%281%29/92132 Sample Failed Step: content_browsertests Sample Flaky Test: WebContentsViewAuraTest.DragDropOnOopif Original change's description: > Use async targeting to find drag and drop targets > > Add callback supports to the RenderWidgetTargeter > and use the async targetting in drag and drop code > and register a callback to send drag events using > the callback. Note that since drag and drop events > aren't WebInputEvent it is not possible to use > FindTargetAndDispatch function of RenderWidgetTargeter > at this time. > > The original CL > https://chromium-review.googlesource.com/c/chromium/src/+/1596840 > was reverted due the added test being flaky. This CL is the same > as the original CL expect it has the same test with another > way of checking the logic. > > TBR=sadrul@chromium.org > > Bug: 804633 > Change-Id: I46f15a2b694c3ad9d3574473c2a46ba13dcbfb79 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641383 > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#665601} Change-Id: Ib44e431fa894a33ce908c2f7defb2ae80d399e8d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 804633 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641515 Cr-Commit-Position: refs/heads/master@{#665633}
-
