- 13 Aug, 2019 40 commits
-
-
Benoît Lizé authored
This test fails on CFI bots, see attached bug. This is due to it being too strict. It would be correct if there are no PA allocations triggered elsewhere in the process, which is an assumption that can break with test harness changes. Make the assert more tolerant to these changes, by asserting that memory is reduced, instead of having a strict value. Bug: 993219 Change-Id: I1e5e3b1f7e1f14357171a06a31a2eba9380babfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751183Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#686357}
-
Vasilii Sukhanov authored
Bug: 986298 Change-Id: Idbac7135d6ed958529bea6968d4405f5e689c84b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746476Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#686356}
-
Julian Watson authored
BUG=992293 Change-Id: Id54f0b0f26e06b1ce5c2c7c4e725889867e88334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750516 Commit-Queue: Julian Watson <juwa@google.com> Auto-Submit: Julian Watson <juwa@google.com> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#686355}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: I90311089fd94cae99be12b4b3261555f83bcadd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750900Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#686354}
-
Nathan Rogers authored
Address the previous TODO by replacing the iterator based loop with a range-based for loop. Change-Id: I1f68e03233fc0a37b91aa6c8e29c29660a3a1abb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750932Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Nathan Rogers <nathanrogers@google.com> Cr-Commit-Position: refs/heads/master@{#686353}
-
Julie Jeongeun Kim authored
This CL converts DevToolsSessionHost and DevToolsSession to new Mojo types. The changes are two CLs and it is the first CL and the second on is [1]. It updates AttachDevToolsSession and ChildWorkerCreated from devtools_agent.mojom It also converted methods and members which take these DevToolsAgent and DevToolsAgentHost to new Mojo types. SharedWorkerDevToolsAgentHost::WorkerReadyForInspection and ServiceWorkerDevToolsAgentHost::WorkerReadyForInspection still keep old types and these are handled at [1] with the rest of code which still uses old types. [1] https://crrev.com/c/1748906 Bug: 955171, 978694 Change-Id: I2d67a390b3299bfd71d4539857973481f349849e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745944Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#686352}
-
Dominik Röttsches authored
Previously this test relied on font fallback and broke up runs unnecessarily. Make font selection for the Devanagari tests explicit. Rephrase test expectations to rely less on font-selection-induced run splitting, but rather create assertions that test for the script properties independent of run layout. Preparation for moving font fallback on Windows to an OOP call instead of hardcoding our fallback tables. Unit tests cannot perform such OOP calls as the browser side fallback Mojo service is not available. Bug: 976737 Change-Id: I7126979efe40848325b1859c2e0b8ecfef64d775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748946 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#686351}
-
Hiroshige Hayashizaki authored
As a preparation for adding parser-related tests. Bug: 990561 Change-Id: I8fdb07059514fe088438e8499cd4ac20e1c0b528 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1734328 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
-
Christopher Gunadi authored
Add test to ensure the "Install with Linux" context menu option is hidden/shown when Crostini root access is allowed or disallowed by kUserCrostiniRootAccessAllowedByPolicy policy preference control. Feature flag kCrostiniAdvancedAccessControls is enabled for file manager browser tests to test this functionality which is hidden behind the flag. Follow up CL to crosreview.com/1730907 Bug: 983997 Change-Id: I12f70ea516528275b327525119587d0f0742a50d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1738686 Commit-Queue: Christopher Gunadi <chrisgunadi@google.com> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#686349}
-
Mario Sanchez Prada authored
We can't construct a WTF::String using the default constructor when running the GetTextSurroundingSelectionCallback directly for those cases where the SurroundingText is empty, since that will construct a null string instead of an empty string, causing a crash at the Mojo level due to trying to send a null message over the wire, which is not permitted. To avoid this crash in Mojo, make sure we create a WTF::String out of an empty string, instead of using the default constructor. Last, this CL also incorporates the required changes to address Daniel's comments after the original patch landed in CL 1696968 [1], to rename the newly added Mojo interface to become blink::mojom::Frame. [1] https://crrev.com/c/1696968/11/third_party/blink/public/mojom/editing/editing.mojom#9 Original change's description: > Move this method from the content.mojom.Frame Mojo interface into Blink, > as part of a new blink.mojom.SurroundingText Mojo interface, and add a new > class there to implement such interface (i.e. blink::SurroundingTextImpl), > to replace usages of content.mojom.Frame's GetTextSurroundingSelection() > from the browser process. > > Note that this SurroundingTextImpl class still relies on WebSurroundingText > and WebLocalFrame to keep the change smaller, but this is a temporary step > that will be corrected once WebSurroundingText has been moved out of the > public API and into renderer/core, which will happen on a follow-up CL. > > Bug: 980151 > Change-Id: I62fb2d5b24a98773c1acddbe1c58217c1a2d53e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696968 > Commit-Queue: Mario Sanchez Prada <mario@igalia.com> > Reviewed-by: Mike West <mkwst@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Cr-Commit-Position: refs/heads/master@{#679981} Bug: 980151, 987214, 987191, 989438 Change-Id: Ia32be36c1a7524930ddcecc79e7fac5bcb514a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735459Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
-
Daniel Bratell authored
33bits.org is a pointer that is supposed to load 33bits.wordpress.com but the mapping isn't there anymore so point directly to 33bits.wordpress.com. Change-Id: Ia423858d5d59c8a0195fd0c69143faae64be55fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749186 Auto-Submit: Daniel Bratell <bratell@opera.com> Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#686347}
-
Yang Guo authored
R=szuend@chromium.org Change-Id: Ibef42325a778acd4d513e3c038a76fbb266a36c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748890 Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#686346}
-
Yi Su authored
TabGridNewTabButton is inited with page=TabGridPageIncognitoTabs, and depends on "setPage:" method to set the image of button. However this "setPage" has an early return for same page value, so when app is launched in incognito mode, the image will be missing. Bug: 991994 Change-Id: I7fd4f90a57486392f12ffab339f81517dbf25bcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746262 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#686345}
-
Fergus Dall authored
Tests: external/wpt/fetch/cross-origin-resource-policy/fetch.https.any.worker.html virtual/blink-cors/external/wpt/fetch/cross-origin-resource-policy/fetch.https.any.worker.html At time of writing, the findit flake score for these tests is 704. Mark them as timing out on more platforms. TBR=guidou@chromium.org TBR=qyearsley@chromium.org TBR=kojii@chromium.org TBR=jsbell@chromium.org TBR=dpranke@chromium.org TBR=foolip@chromium.org Bug: 626703 Change-Id: I7749eecaaafee8e0a3bc3167a60005616ea6f4e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750538Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#686344}
-
Joanmarie Diggs authored
Text leaf nodes and line breaks were being exposed as ATK_ROLE_TEXT. However, the definition of ATK_ROLE_TEXT is: An interactive widget that supports multiple lines of text and optionally accepts user input, but whose purpose is not to solicit user input. In contrast, ATK_ROLE_STATIC is defined as: A generic non-container object whose purpose is to display a brief amount of information to the user and whose role is known by the implementor but lacks semantic value for the user. Thus text leaf nodes and line breaks should be exposed with the latter role; not the former. Bug: 984590 Change-Id: I4dfbf8d8d90a3f894803a62914a6d9882828957e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749145 Commit-Queue: Martin Robinson <mrobinson@igalia.com> Auto-Submit: Joanmarie Diggs <jdiggs@igalia.com> Reviewed-by:
Martin Robinson <mrobinson@igalia.com> Cr-Commit-Position: refs/heads/master@{#686343}
-
Rika Fujimaki authored
In a precious CL(1743245), I added LocalRecord() temporarily to return v8::Local<v8::Module> instead of ModuleRecord. Now is the time to replace all Record() with LocalRecord() to remove ModuleRecord. And, I renamed Record() into V8Module() for a conventional reason. Bug: 991863 Change-Id: I34f57226ab5d471a4909794fe3d43e1748fb020b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746209 Commit-Queue: Rika Fujimaki <rikaf@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Virender Singh authored
This CL updates the Link structure to include the underlying text range. The underlying text range is being populated using the newly added FPDFLink_GetTextRange() API. This would enable us to position links along with text in the accessibility tree. Bug: 981448 Change-Id: I4551f70c21e2846f9a85c19c982f17dc52e0b25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710275 Commit-Queue: Virender Singh <virens@microsoft.com> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#686341}
-
Fergus Dall authored
TBR=dom-dev@chromium.org Bug: 993238 Change-Id: Id1b55d9a908ffd38094e33dd4dea261153b72e40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750473Reviewed-by:
-
Gayane Petrosyan authored
This is a partial revert of https://chromium-review.googlesource.com/c/chromium/src/+/1702769 TBR=estade@chromium.org Bug: 988055 Change-Id: Id6e67a5a69fa97c23083f44b9054526792cb58ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750790Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#686339}
-
Hajime Hoshi authored
This CL adds a new test for BackForwardCache with another isolated world. Multiple worlds are used by extensions. Bug: 980111 Change-Id: Ifdff84fb52679ed010b38cd54933481edd45e955 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709793 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#686338}
-
Eric Willigers authored
inset is one to four values, each auto or a length-percentage. https://drafts.csswg.org/css-logical/#propdef-inset Change-Id: I3f1599e200fec16a709cc6404246a28c404805b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747488Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#686337}
-
Fergus Dall authored
Test: http/tests/devtools/indexeddb/live-update-indexeddb-list.js This test has been observed flaking on Windows, and on release builds. Mark this as expected behaviour. At time of writing, the findit score for this test was 714 TBR=dmurph@chromium.org Bug: 989860 Change-Id: Id6f4815867e0d33322c52289bad5393784961876 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750472Reviewed-by:
-
Fergus Dall authored
virtual/scalefactor200/css3/filters/effect-reference-zoom-hw.html This test currently has a findit flake score of 844, apparently entierly from timeouts. TBR=fs@opera.com, liberato@chromium.org TBR=mlamouri@google.com, yhirano@chromium.org Bug: 658305 Change-Id: I120323bb81c8e8e6b62ae059ebcba664f77a5388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750471Reviewed-by:
-
Sophie Chang authored
Bug: 993156 Change-Id: Ie6dfc9269805104d3a48fe96e48477ca700cbac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750924Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#686334}
-
Fergus Dall authored
This reverts commit e3121f99. Reason for revert: Looks like it broke Win10 (Debug|Release) (NVIDIA) See https://ci.chromium.org/p/chromium/builders/ci/Win10%20Debug%20%28NVIDIA%29/23156 for example failure. Original change's description: > Switch Windows 10 GPU testing to 64-bit. > > See > https://chromium-review.googlesource.com/c/chromium/tools/build/+/1750303 > > Bug: 988833 > Change-Id: If6082a035eec474d3299afb89bd78ca225d95ed6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747005 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#686321} TBR=ynovikov@chromium.org,kbr@chromium.org,tikuta@chromium.org Change-Id: If0922864c7beaa2209933d47c1bf7385c3b39a42 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 988833 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750470Reviewed-by:
-
Fergus Dall authored
Tests changed: virtual/gpu/fast/canvas/canvas-composite-stroke-alpha.html This test has been observed timing out on all platforms TBR=fserb@chromium.org Bug: 984467 Change-Id: Iaa0fda0cfd0f3ca314c184ccc2c9efcd5cacf532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750532Reviewed-by:
-
Christian Biesinger authored
R=eae@chromium.org, sajos@microsoft.com Change-Id: I4ca39e7299b400d9a34e41d3b0909bbee2e1222d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750386 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Emil A Eklund <eae@chromium.org> Reviewed-by:
-
Rika Fujimaki authored
Add v8::Local<v8::Module> argument to Evaluate and V8Namespace to make ModuleRecord's functions static. It leads to remove ModuleRecord. Bug: 991863 Change-Id: I4470413d3107d2427eb9cc1f4977dad100d4e66c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746115 Commit-Queue: Rika Fujimaki <rikaf@google.com> Reviewed-by:
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I785d8a0e0836e72156c85661b8f44d8386dcda85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748975 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#686329}
-
Luciano Pacheco authored
Bug: 778674 Change-Id: I37b5d58f5f3b5d7cb2f30ada3e383c655ec69978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750464 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#686328}
-
nancy authored
BUG=992839 Change-Id: Ifc4f0674b8509552dca61d07fe1bbb30c654a877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750467Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#686327}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/092dde36abc3..162a1a2b3f15 git log 092dde36abc3..162a1a2b3f15 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 manojgupta@google.com parallel_emerge_old: Do not overwrite ROOT. Created with: gclient setdep -r src/third_party/chromite@162a1a2b3f15 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I18fd4a6a9968cde210fda2b149e8b33f3d51a9c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750851Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3c814957ee53..9fc459b69c78 git log 3c814957ee53..9fc459b69c78 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-08-12 ehmaldonado@chromium.org Revert "depot_tools: Run Python scripts using vpython (Part 1)" 2019-08-12 ehmaldonado@chromium.org Revert "depot_tools: Run Python scripts using vpython (Part 2)" 2019-08-12 ehmaldonado@chromium.org Revert "depot_tools: Include vpython in cipd bundle." 2019-08-12 ehmaldonado@chromium.org depot_tools: Include vpython in cipd bundle. Created with: gclient setdep -r src/third_party/depot_tools@9fc459b69c78 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182,chromium:984182,chromium:984182,chromium:984182 Change-Id: I6ee5f206b86ef5899b30e7cd556031d11f31eb97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750098Reviewed-by:
-
Alexey Baskakov authored
WebApplicationInfo::open_as_window unambiguously determines launch container. Bug: 973288 Change-Id: I85ad1c1d556f5dbba2760c21014f58f3bd3162a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746331 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#686324}
-
Jinsuk Kim authored
Another attempt to makes top corners of the BottomSheet round-shaped using 9-patch drawables. Bug: 985644 Change-Id: I46df9db70bfae274f1c9131f128e3e1c8ae25ded Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743432 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#686323}
-
Chris Davis authored
A recent change made to enable is_multi_dll_chrome = false caused a regression for component builds where the crash export thunks were getting linked into chrome.dll instead of chrome_elf. Chrome.dll pulls in headless_shell_lib which on Windows depends on crash_export_thunks. This has the side-effect of statically linking these thunks into chrome.dll instead of having them be imported from chrome_elf.dll. The result of which is that the crash report database in chrome_elf.dll is never initialized. The bug only impacts component builds where is_multi_dll_chrome is set to false. Regression caused by: http://crrev.com/c/1697368 Bug: 991886 Change-Id: I1170544da9842fc503cc48ffd2cc07f5023a4240 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742400Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Chris Davis <chrdavis@microsoft.com> Cr-Commit-Position: refs/heads/master@{#686322}
-
Yuly Novikov authored
See https://chromium-review.googlesource.com/c/chromium/tools/build/+/1750303 Bug: 988833 Change-Id: If6082a035eec474d3299afb89bd78ca225d95ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747005Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#686321}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5b2f04c4198f..f99631100372 git log 5b2f04c4198f..f99631100372 --date=short --no-merges --format='%ad %ae %s' 2019-08-13 mtklein@google.com extend lifetimes for hoisted used in loop Created with: gclient setdep -r src/third_party/skia@f99631100372 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=scroggo@google.com Bug: None Change-Id: Ic4067caa792932347be1a67a4ed87648469ae25a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750846Reviewed-by:
-
Alexandre Courbot authored
CL 6ddfe0d8 (media/gpu/v4l2svda: use queue of GL fences) added a queue of buffers waiting for a fence, but added a NULL fence if rendering was disabled. This NULL fence was then dereferenced by CheckGLFences(), causing a crash. Fix this by only adding the fence if it actually exists. Bug: b:132589320 Test: vdaunittest passing on Kevin and Kukui with and without --disable_rendering. Change-Id: Ib63dd04be4aca8a65f8906875b0b12d50032225f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750469 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Auto-Submit: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#686319}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9e14a19bb82f..9e4b116ccc40 git log 9e14a19bb82f..9e4b116ccc40 --date=short --no-merges --format='%ad %ae %s' 2019-08-12 jmadill@chromium.org Use official EGL.h. Created with: gclient setdep -r src/third_party/angle@9e4b116ccc40 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: Ide3ba28912702797e4a369d81878d5288f2f77e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749654Reviewed-by:
-
