- 08 Oct, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/46b01401724c..6e9395c6b785 git log 46b01401724c..6e9395c6b785 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision baa7b585..a78cc9b4 (703669:703818) 2019-10-08 srte@webrtc.org Makes render time > decode time in VideoFrameMatcher. Created with: gclient setdep -r src/third_party/webrtc@6e9395c6b785 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I133e1df9c2994a8ad70dcb4caa7e008385991d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847940Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703933}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/352808fa158d..b7a7f1c05edb git log 352808fa158d..b7a7f1c05edb --date=short --no-merges --format='%ad %ae %s' 2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-08 ehmaldonado@chromium.org Revert "git-cl: Set legacy properties." 2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-08 ehmaldonado@chromium.org git-cl: Run using vpython Created with: gclient setdep -r src/third_party/depot_tools@b7a7f1c05edb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1004447,chromium:1002153 Change-Id: Ie576ec800f7d8a7e94ac03a642aadb17653d8f6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847936Reviewed-by:
-
Reilly Grant authored
The high water mark for the count queuing strategy used for a SerialPort's WritableStream needs to be at least one or else the desiredSize property of the writer will always be zero. This prevented methods like pipeTo() from working. New tests for piping readable and writable through a TransformStream have been added. Bug: 893334 Change-Id: Ie7dc63e3a3272aab369c510a82b6b1fb9cd65f64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846074 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#703931}
-
Jon Mann authored
This matches the actual folder structure. Bug: 966270 Change-Id: Ib5bfaccd3d8e71367048021d22bdcc6ba1c632f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846882 Commit-Queue: Jon Mann <jonmann@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#703930}
-
Wez authored
Migrate the FeatureListTest suite to use ScopedFeatureList to ensure that the process-global FeatureList instance is replaced & restored consistently. Change-Id: Ia9dd5bf7269ab05d00780c25c8f3154d663546e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1848354Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#703929}
-
Peter Boström authored
Removes view::ButtonListener from class hierarchy. Bug: None Change-Id: If85024b175c5944b5facd4a5aeccc8065b189b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846565 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703928}
-
Luigi Santivetti authored
BUG=b:1010121 BUG=b:139031464 BUG=b:141951482 TEST=manual R=drinkcat@chromium.org R=ihf@chromium.org R=bhthompson@chromium.org R=michael.green@imgtec.com Change-Id: I4b421494934b246d9cbc46ca52fd496c352363ac Signed-off-by:
Luigi Santivetti <luigi.santivetti@imagination.corp-partner.google.com> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1836500Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703927}
-
Yuwei Huang authored
This CL implements a basic dialog-based notification UI for Android client. Bug: 1001291 Change-Id: If7df03179ad7a143a6c805c66595dbf7815eb074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846048 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#703926}
-
Dirk Pranke authored
This patches in a patch from crbug.com/1009688 in order to add support for a soft-float sysroot on ARM. This should have no effect on the normal Chromium builds. Bug: 1009688 Change-Id: Ibe89efc9b28411ef040efba5e0b1621431e8ab44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846083Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#703925}
-
John Lee authored
This CL begins the migration of the calls to get tab data from the Extensions API to the UI handler such that the data can be supplemented with additional data that the Extensions API does not provide, such as TabAlertStates. This CL attempts to keep all data mostly the same, so that the custom element TabElement can remain unchanged for now, and does not add any new data that the WebUI Tab Strip does not yet use. Upcoming CLs will update the Tab data to include more data from the TabStripModel and TabRendererData and less from the Extensions API. Bug: 1006946 Change-Id: Icd727416da3ebd1a5118cc49569fb7b649ada4d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846653Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#703924}
-
Nate Fischer authored
This test is consistently failing on the O tester, so disable this for SDK strictly greater than 25 (equivalent to >= O). TBR=peter@chromium.org Bug: 999357 Test: None Change-Id: I66b3844073566296b09e7851620a6b394ab90abe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846730Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#703923}
-
Sophie Chang authored
This feature flag is duplicated in previews_features.h and wasn't being referenced in code or tests. Change-Id: Iffe553bc9359f03745814416cabb1c0d2bdbe0fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845967 Auto-Submit: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Sophie Chang <sophiechang@chromium.org> Cr-Commit-Position: refs/heads/master@{#703922}
-
siyua authored
Add it to (bubble) dialog's parent class so that it can be reused. It is added to the top of the dialog. Add some screenshots in bug comment 17 to visualize this change (It will not be shown in the bubble in the screenshots, just to make it easier to see what it will look like). Bug: 991037 Change-Id: I4b18bfa510efbd585c50154c66613fc9a7c80b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1830092 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#703921}
-
Robert Sesek authored
Using global defines pollutes the build. The preferred method for feature defines are to use buildflags, which are scoped to the targets and files that require them. Change-Id: Id9d749cbbb4f9a1a6847171df1cbc1c903bacdbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803804Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#703920}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5899485b9a87..8a97436f7afd git log 5899485b9a87..8a97436f7afd --date=short --no-merges --format='%ad %ae %s' 2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-10-08 egdaniel@google.com Track gl format bytes per pixel on format table. 2019-10-08 jcgregorio@google.com Revert "cloud-build: set HOME env variable." 2019-10-08 jcgregorio@google.com cloud-build: set HOME env variable. 2019-10-08 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@8a97436f7afd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@google.com Bug: chromium:993053,chromium:993053 Change-Id: I472951ee0cf5c28f36c3aedea3a1a03704898a34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847935Reviewed-by:
-
Sarthak Shah authored
This is a regression from a fix for middle-click auto-scroll for OOPIFs where input events get locked to a single target when moving over OOPIFs (https://crrev.com/c/1773540). When middle-click auto-scroll is in progress and the view is destroyed, we need to clear the state of latched target. However, the previous CL missed this fact. This CL fixes the issue by clearing the state of middle-click latched target when it is destroyed. Bug: 1007983 Change-Id: Ie4d98fdc97b7cf14e193857e61212e193cfd7f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825489 Commit-Queue: Sarthak Shah <sarsha@microsoft.com> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703918}
-
jonross authored
A lot of work has been done on both SkiaRenderer and Vulkan since we debuted vulkan_content_browsertests on Android. I have retriaged the failures, and we can re-enable several tests. This change updates the filter to reflect current failures, with new bugs tracking the specific failure cases. I have also reduced the section of flakes, based on those seen recently. If we encounter further flakes we should triage them as they are found and update this filter. TBR=cblume@chromium.org TEST=vulkan_content_browsertests Change-Id: Ie54c13267ce47e1ee95b56a593b661aee3872dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831981Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#703917}
-
Lily Chen authored
This CL adds a method, GetAllCookiesWithAccessSemantics, to the mojo interface CookieManager. This just directly calls CookieStore::GetAllCookiesWithAccessSemanticsAsync() on the CookieManager's underlying CookieStore. Bug: 978172 Change-Id: Ic26298caf12d34ffd4de5bcf81058f6984528683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845803 Commit-Queue: Lily Chen <chlily@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#703916}
-
James Cook authored
The "late registration" feature was added to support the mustash project, which was running the ash system UI in a separate process. Mustash was cancelled, so we now guarantee that all ash prefs are registered before the sync subsystem starts. Remove the whitelist. This is a manual revert of: https://chromium-review.googlesource.com/c/chromium/src/+/1012788/ The PrefRegistry feature will be cleaned up separately, after resolving the device_sync service and assistant service usage of prefs. Bug: 788918, 1012462 Change-Id: I9811c8f25530d9c0e949ae0675e51aeeb9f583c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845963 Commit-Queue: James Cook <jamescook@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#703915}
-
Aidan Beggs authored
This CL adds an outline for the sensitive keywords safety tip logic that will be implemented later. For now, the heuristic always returns false (no sites are currently triggered by the heuristic, and safety tip behavior should be unchanged). Bug: 984725 Change-Id: I162830c08158358a4697d46441b1d5835e5752b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842500Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Aidan Beggs <beggs@google.com> Cr-Commit-Position: refs/heads/master@{#703914}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/83c4c1c68dbf..fa588881c5b5 git log 83c4c1c68dbf..fa588881c5b5 --date=short --no-merges --format='%ad %ae %s' 2019-10-08 rmhasan@google.com [typ] Create FileManager class which encases logic for handling files Created with: gclient setdep -r src/third_party/catapult@fa588881c5b5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:982208 Change-Id: Ib6f170cd5570f340f36840985f1e5fce5475a591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847932Reviewed-by:
-
Nikita Podguzov authored
* Introduce PrintJobHistoryCleaner component which is responsible for removing expired print jobs from the history. * Add 'PrintJobHistoryExpirationPeriod' policy and corresponding pref. TBR=battre@chromium.org Bug: 992889 Change-Id: Ide1d144e72e457ec298e5c34f11219c5369aa922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810533 Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#703912}
-
Xinghui Lu authored
Bug: 995926 Change-Id: I76ac44526fcf7241b800899810db81dbdd598ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846092Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703911}
-
Andrew Grieve authored
When .dex.jar files are just used as intermediates in the build, there's no advantage to merging all incremental .dex files into a single classes.dex. Instead, we can just store the class-per-dex-file files as classes.dex, classes2.dex, etc. The final dex step runs just as fast with numerous nested dex files as when there is just one. This approach really hurts on-device performance though, so when incremental install is relevant (debug mode), we leave dex merging enabled. For release builds, this reduces incremental dex steps of chrome_java from ~3s -> ~.2s on my machine. Bug: 937874 Change-Id: I4d7511384e4830b883bcc89501f619711788a664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845931 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#703910}
-
Eric Foo authored
See https://tinyurl.com/yxau5sc4 for context. Bug: 977050 Change-Id: Iec67e7ca79e4ff262c61c6f58606a0d746a91f6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846818Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Auto-Submit: Eric Foo <efoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#703909}
-
Xiaocheng Hu authored
Spec requires (https://drafts.fxtf.org/css-masking-1/#priv-sec): > User agents must use the potentially CORS-enabled fetch > method defined by the [FETCH] specification for all > <mask-source>, <clip-source> and <image> values on the > mask-image This patch makes our implementation follow that. Bug: 786507 Change-Id: Id01fcf9eec6adc7b08f8acb21ec551e43f324db6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838592 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#703908}
-
Yves Arrouye authored
Order of definition matters. TBR=ellyjones@chromium.org Bug: N/A Test: Build with target_os="chromeos" and is_chrome_branded=true in args.gn Change-Id: I591ce1d8cd463e6a093b0dcdef1fc14963c6a42e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846465Reviewed-by:
Yves Arrouye <drcrash@chromium.org> Commit-Queue: Yves Arrouye <drcrash@chromium.org> Auto-Submit: Yves Arrouye <drcrash@chromium.org> Cr-Commit-Position: refs/heads/master@{#703907}
-
Chris Lu authored
Screenshot: https://drive.google.com/open?id=1uniLShAvSuHkSeRtczhdgocCDb_kygij Bug: 976901 Change-Id: Ic98e3b4744b8763dde8a32141d49062d215fa71f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847854 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#703906}
-
Sven Zheng authored
Bug: 1010568 Change-Id: I7f360ee361e486451aca2b21138c3a493a7d36a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846474 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#703905}
-
Johannes Henkel authored
This test was originally part of https://chromium-review.googlesource.com/c/chromium/src/+/1783717 and added there because the earlier version of the change introduced a regression; but the test seems worthwhile regardless of where we do the session id surgery and I figure we may as well submit the test now. Change-Id: If7935aa4b4d46f898233d8cee9cadca0b7835f06 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845669Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#703904}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a3b4ceff..8fcfd612 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I58bc6647ad2680eab1c9798256422572255905e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1847735Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#703903}
-
Yue Li authored
The check rules does not work for playing media intent. Update the rule to also check the ref part. Bug: b/142075916 Test: Manual Test Change-Id: I67d4e75efb038bb024560799d6466b7220751c54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838977 Commit-Queue: Yue Li <updowndota@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#703902}
-
Andrew Xu authored
Bug: 1000764 Change-Id: I70ad53d49a5f4f266fe94f58cf2b4b2d35b78f18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843775Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#703901}
-
Owen Min authored
Using 'requests' instead of 'unit'. Change-Id: I01ea466ab5b68b258f769ce373f9c71b7a5c4432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838715Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#703900}
-
Morten Stenshorne authored
This broke for M77 and got fixed again after the branch point. Looks like we had no test coverage for it, but it affected WhatsApp for web. A phantom line [1] was also required to reproduce the bug. [1] https://www.w3.org/TR/CSS22/visuren.html#phantom-line-box Bug: 1003810 Change-Id: I942aea83bbf71a247cf73332dcf62af7c9343106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845759 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#703899}
-
Jesse McKenna authored
This reverts commit 956f8294. Reason for revert: The previous version of this change caused an access violation when sandbox/win/src/target_interceptions.cc:: TargetNtMapViewOfSection() tried to access constant kApplicationVerifierDllName, which was declared in base/win/win_util.h and defined in win_util.cc. This access violation happened because base.dll, from which the constant was imported, is not yet resolved by the time TargetNtMapViewOfSection() is called. This function, as well as the others in target_interceptions.cc, can't reference any non-static variables or functions in other modules besides those exposed via the g_nt structure. To address this, the constant kApplicationVerifierDllName was moved into the base_static build rule, whose source files are statically linked into code that depends on them (rather than dynamically linked via dllexport). Original change's description: > Revert "Use consistent DLL to detect Application Verifier" > > This reverts commit fd8fe93c. > > Reason for revert: this change is causing chrome.exe to crash on > startup. I received a report that chrome.exe looked for the string > constant in memory and encountered some kind of error which caused it > to crash. I will roll back for now to investigate. > > Original change's description: > > Use consistent DLL to detect Application Verifier > > > > To detect whether Application Verifier is running, > > sandbox/win/src/target_interceptions.cc checks if vrfcore.dll is loaded, > > while sandbox/win/src/handle_closer_agent.cc checks for verifier.dll. > > > > This change makes both use verifier.dll, to be consistent and remove any > > confusion around whether these two are checking for the same thing (they > > are). > > > > Open Application Verifier > > File > Add Application > chrome.exe (any chrome.exe binary works) > > Under 'Tests', uncheck everything but Basics > Handles, then Save > > Run chrome.exe with this change; it works normally > > (on versions without lines 176-177, no pages will load) > > Return to Application Verifier > > Right-click chrome.exe > Delete Application, then Save > > (so Chrome runs normally again) > > > > Test: Manual > > Change-Id: If97a1115373c394f0cbbf1d31d3ca7b60549bbee > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1776781 > > Commit-Queue: Jesse McKenna <jessemckenna@google.com> > > Reviewed-by: Greg Thompson <grt@chromium.org> > > Reviewed-by: Will Harris <wfh@chromium.org> > > Reviewed-by: Bruce Dawson <brucedawson@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#700323} > > TBR=brucedawson@chromium.org,wfh@chromium.org,grt@chromium.org,jessemckenna@google.com > > Change-Id: I79f41f6e93813befaf4e49604f7dcc1f8c1ddb48 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1828234 > Reviewed-by: David Bienvenu <davidbienvenu@chromium.org> > Commit-Queue: Jesse McKenna <jessemckenna@google.com> > Cr-Commit-Position: refs/heads/master@{#700493} Change-Id: I0c43a20433dbbb54ebdf8d1a2ec71e09adb8afa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829544Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Auto-Submit: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#703898}
-
Austin Eng authored
This copy was needed because dawn_wire did not previously support volatile pointers. Bug: dawn:230 Change-Id: Ib5baff5c3e5da129086c40ef5b22a6d840f9f65b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846657Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#703897}
-
Dan Beam authored
Fixed: 1010869 Change-Id: I04e05c34e6a2ad163bf61d48ec66736a15972e5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1846712Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Auto-Submit: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#703896}
-
Lei Zhang authored
Use more C++11 features and fix nits. Change-Id: I85f4c34190301cd8117095632430cdc991477567 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843259Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#703895}
-
Hector Carmona authored
Bug: 1008556 Change-Id: If6cdaa711a8fd498652edf980395383b9318abe2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841656 Commit-Queue: Hector Carmona <hcarmona@chromium.org> Reviewed-by:
-
