GitLab

The feature is guarded by a feature flag that is currently disabled by default.

This CL implements a temporarily UI for getting early feedback on product and
data quality while we are figuring out the final UI.

More detail at: go/quick-answers-cros and go/quick-answers

Bug: 1020004
Test: Unit tests
Change-Id: I17dac669c230f5fbd2052cd5683344fa30c41b85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961210Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Li Lin <llin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732713}

There was an extra "and" in between the domains.

Bug: 1037953
Change-Id: I6c8c81f7a1bdd27f5891fe3aa86619038efd5543
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982702
Commit-Queue: Bettina Dea <bdea@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732712}

https://chromium.googlesource.com/catapult.git/+log/251c76530213..91096f77a581

git log 251c76530213..91096f77a581 --date=short --first-parent --format='%ad %ae %s'
2020-01-17 dberris@chromium.org Remove cron.yaml from automatic deployment

Created with:
  gclient setdep -r src/third_party/catapult@91096f77a581

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC rmhasan@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1040775
Tbr: rmhasan@google.com
Change-Id: Ib1bec1381f5618a264bfe1a79e0341fd3ef0b561
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006608Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732711}

This CL converts an unsafe base::Unretained() to target the
MediaStreamTrackMetricsHost object directly which is deleted on the
same thread as the callback.  This comes at the cost of pre-allocating
the object instead of lazily creating it when the first receiver is
bound.  This cost does not seem too great since the object consists of
an empty std::map and mojo::ReceiverSet.

In addition, the CL attempts to document why the remaining
base::Unretained() usage is safe.

Bug: 1040396
Change-Id: I094091c4672c412086059c56804efb3d743a2c11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005291
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732710}

This CL adds a flag to chrome://flags to manually enable/disable the
ChromeosVideoDecoder feature. This Feature enables the new
media::VideoDecoder-based video decoders on ChromeOS.

TEST=enabled/disabled flag in Chrome on nocture, and verified logs

BUG=None

Change-Id: I5df33207f7f2081260a66c8406fc0dceed7a0cc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1997431
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732709}

CTS requires a PIP window to stay at the initial position that
Android calculates. However, Chrome sometimes adjusts the bounds
unexpectedly when always on top is set because setting always on
top triggers UpdatePipBounds, and depending on the density, the
initial bounds is adjusted by one pixel.

With this CL, PIP bounds update is defered while always on top is set.

Other possible ways to fix this issue are:
- Don't update PIP bounds for WM_EVENT_ADDED_TO_WORKSPACE.
- Ignore bounds change for PIP if it's one (or a few) pixel difference.

Note, changing bounds calculation logic on either Android or Chrome
side so there's no gap between the bounds calculated by them doesn't
work because because DP -> pixels is not a surjection and Chrome may
be unable to place the PIP window in the place Android wants (and
vice versa).

BUG=b:147396441
BUG=b:145881485
TEST=atest android.server.am.ActivityManagerPinnedStackTests
TEST=#testEnterPictureInPictureSavePosition

Change-Id: I60bfef4620459c0d3f604d3c1641864fc589c1a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969090Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Kazuki Takise <takise@chromium.org>
Auto-Submit: Kazuki Takise <takise@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732708}

https://swiftshader.googlesource.com/SwiftShader.git/+log/5c6a3c247590..2cb1db08e5f1

git log 5c6a3c247590..2cb1db08e5f1 --date=short --first-parent --format='%ad %ae %s'
2020-01-17 bclayton@google.com SpirvShaderDebugger: Implement OpenCL.Debug.100

Created with:
  gclient setdep -r src/third_party/swiftshader@2cb1db08e5f1

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Ic212aaf520c20bc6d5158abea208f078e76d87cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006476Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732707}

This filters extensions when they are added/removed from the
ToolbarActionsModel. This happens not only on uninstall but also during
reload which is why we need to re-filter on adding extensions.

This leaves a TODO to actually remove pinned-extension IDs when
uninstalling an extension to keep traces of previously-installed
extensions.

For now it'll address a crash where entries in pinned_action_ids() could
refer to extensions that were no longer installed, resulting in a
null-pointer dereference when trying to update their position in the
toolbar.

Bug: chromium:1040856
Change-Id: I3928e931c12d6571c8eb5ad9bd255f0602cfa3d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005373
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732706}

I noticed that both owners of this directory were no longer working
on webrtc, so I thought we should add some more owners.

Bug: none
Change-Id: I4975757aee6d7b51980e360b8420366805387002
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983178
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Harald Alvestrand <hta@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Steve Anton <steveanton@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732705}

When Alt-tab ends, leading to a desk switch, we should query
the traget active desk, not the currently active desk, since
the desk switch animation will be in progress.

BUG=1042486
TEST=Added new tests

Change-Id: I17481169bf9cd1b9a66bec702a9fafafeac6cc85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004059
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732704}

# This is an automated release commit.
# Do not revert without consulting chrome-pmo@google.com.
NOAUTOREVERT=true
TBR=cmasso@chromium.org

Change-Id: I20fc48c994e76947027296a5469b3bac7f71bcae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005863Reviewed-by: Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732703}

This is a reland of e6beeda6

Original change's description:
> [smart-charging] Collect last charge features
>
> Adds code to collect last charge related features.
>
> Bug: 1028853
> Change-Id: I2b152139db0777acbd40534128ed8c92004799b5
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994035
> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org>
> Reviewed-by: Jia Meng <jiameng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#731862}

Bug: 1028853,1042262
Change-Id: I2c868897d2bff653d34c5b9afa55602934543151
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006428
Commit-Queue: Thanh Nguyen <thanhdng@chromium.org>
Reviewed-by: Tony Yeoman <tby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732702}

When we dequeue a buffer on the V4L2 device queue, we will immediately schedule
another poll on the device when there are more buffers left to dequeue. It is
possible however that we're notified of an event while there are no buffers
ready to dequeue. Trying to dequeue a buffer at this time would cause polling to
not be resumed, and we won't be notified when future buffers are ready to be
dequeued.

TEST=./video_encode_accelerator_unittest on hana with CL:1994545

BUG=b:147786740

Change-Id: Ieb2becd246ecbdb632ed930471cbc3fbfcf15e20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2004354
Commit-Queue: David Staessens <dstaessens@chromium.org>
Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732701}

Exo previously dispatched all touch events to one focused surface: the
surface where the first touch point landed. For ARC++, this does not work
for supporting multiple displays because the display for the touch is
determined from the surface of the touch event. Therefore each touch
down event needs to be sent to the correct surface that it was directed
to.

This CL adds two unordered_maps to track the touch pointers and their
target surfaces: one mapping the touch pointer id to its surface, and
mapping the surface to the number of pointers on the surface. The latter
is needed to know when to stop tracking the surface's lifecycle.

Bug: b/145027838
Change-Id: I4121dac9c39bd9fb569df94330107ed382fe7234
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931584
Commit-Queue: Prabir Pradhan <prabirmsp@chromium.org>
Auto-Submit: Prabir Pradhan <prabirmsp@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732700}

Changed from matching UIButton with a11y label to using grey_buttonTitle
API. The new API matches UIButton with titleLabel underneath.

Bug: 1036578
Change-Id: I4db291d8279aba74d6eca3a53a16a8a70784d6f1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006260Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732699}

https://android.googlesource.com/platform/external/perfetto.git/+log/cf0fcdbfc9a0..649f757cc08b

git log cf0fcdbfc9a0..649f757cc08b --date=short --first-parent --format='%ad %ae %s'
2020-01-16 ilkos@google.com Merge "Remove symbols that are definitely not obfuscated"

Created with:
  gclient setdep -r src/third_party/perfetto@649f757cc08b

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Idd6f625ab71b7b186970f43df6403bce66ac140a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006484Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732698}

This CL contains :
1 - Fixed InflateException on Kitkat when it is unable to handle vector drawables.
2 - Fixed an issue with tablets where clicking on 'See more' results in crash.

Bug: 1042459, 1042424
Change-Id: I6981d794e1a44cfbc19da1f990113d54e67dc60d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006075Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732697}

Bug: 1042140
Change-Id: I6bf3b28d21c4f6918fe3dc7af52fb163fa22ec50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2001856
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Francois Marier <francois@brave.com>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732696}

We now have a final mock at go/cros-sync-mock, so update the strings
to match. These strings are used by the consent auditor system, so
add back the consent-description tags. This requires a workaround for
the "Sync your Chromebook" string, since the device type is
set at runtime.

Bug: 1023854
Test: browser_tests
Change-Id: Idddb83ff66a14922a57303f2064cfb4440791977
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006135Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732695}

`gn format` recently changed its formatting behavior
for deps, source, and a few other elements when they
are assigned (with =) single-element lists to be consistent
with the formatting of updates (with +=) with single-element.

Now that we've rolled in a GN binary with the change,
reformat all files so that people don't get presubmit
warnings due to this.

This CL was uploaded by git cl split.

R=marq@chromium.org

Bug: 1041419
Change-Id: I496244536e4d0b7bc5261518276512b5adb14110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994451
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732694}

This reverts commit ae012e64.

Reason for revert: The culprit CL was reverted.

Original change's description:
> [Sheriff] Disable flaky ChromeVoxBackgroundTest.SelectSingleBasic
> 
> TBR=akihiroota
> 
> Bug: 1042673
> Change-Id: Iccf2064ee5b817bc9e7f12c026cd8569e39d22b7
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002816
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#732396}

TBR=jdoerrie@chromium.org,akihiroota@chromium.org

Change-Id: I1c098ec50bd7feb5d3d0c0780bc01a094b087570
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1042673
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006831Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732693}

We correctly handled context loss when using GPU compositing, but
if we transition to software compositing from GPU compositing, we
were not correctly starting the frame sink.

It's possible we also hit this case outside of context loss if the
OnReceivedContextProvider() is delayed until after EnableSubmission();
I was able to reproduce this by adding a delay to when the context
came back. So likely this fixes some broken video playback for some
users on the software compositor!

R=liberato

Bug: 1027518
Test: Updated unittest.
Change-Id: I738a1a36f4d850248730cd61b9ae4adcb5c1cd06
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006193
Auto-Submit: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732692}

This was requested by srahim.

TBR=dpapad@chromium.org

Change-Id: I45d280fd644d5fcd87bbdd5a1b13847cdfca4c68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006424Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#732691}

Fixed: 993658
Change-Id: Ia5bc38bccab5cb83d74d727730b9a0dee8d87f0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006071
Auto-Submit: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732690}

This is a reland of 27453d76

Split out the is_a_target_toolchain change to another change.

Original change's description:
> Add a flag for building HWASAN splits.
>
> The new build_hwasan_splits flag causes HWASAN splits to be created for
> the Monochrome6432 and TrichromeChrome6432 bundles, as well as any of its
> DFMs that contain native code. The intent is that this flag will eventually
> default to true in official builds.
>
> The library is deliberately installed in TrichromeChrome6432 rather than
> TrichromeLibrary6432 (where the regular native library lives) because the
> Android platform does not support splits for the library containing the
> WebView implementation. This means that only Chrome will use the HWASANified
> native library, and WebView will use the regular native library.
>
> Bug: 916828
> Change-Id: Ie92bb36e83df245ab431b0123a44b0f0a3182100
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1769731
> Commit-Queue: Peter Collingbourne <pcc@chromium.org>
> Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#729945}

Bug: 916828
Change-Id: I2c64720b72572a1c718cbd44d79d3fb2a44afcac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1994671Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732689}

https://chromium-review.googlesource.com/c/chromium/src/+/1984717
fixed an issue with the iron-list sometimes setting an infinite
displayed item count by setting the height of iron-list using JS so
that it was always set to something nonzero before the list items were
updated. Unfortunately, this causes the list to never increase in
size if the dialog is resized larger after it has been opened, leaving
an odd empty space between the destinations list and the buttons.

Fix by adding a listener for the resize event that updates the height
of the list.

Change-Id: I7e010293831e5e1459cf1f0f6ba429dd52825b94
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006110
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732688}

The underlying EXO surface should only be resized when the main
RenderFrameHost changes. Embedded RHF (eg: iframes) should not cause the
EXO surface to resize.

Bug: b/147835637
Test: On device
Change-Id: I24cab3f2cb99d0b2a3693adc815d445522c1cec8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006420Reviewed-by: Albert Chaulk <achaulk@chromium.org>
Commit-Queue: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732687}

Prior to this commit, valueMissing() incorrectly returned true for
text-mode inputs that were readonly or disabled. With this CL, this
situation is fixed.

Fixed: 1039149
Change-Id: I0f3d9b5c00e7c4e9e8fa0a9767119a2ab5d6b01f
Bug: 1039149
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003637
Commit-Queue: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Auto-Submit: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732686}

All changes were performed by clang-tidy except for the following:
  * Reverted windows_types.h as they need to appear exactly as they do
    in windows.h and there isn't anyway to exclude files from
    clang-tidy (https://reviews.llvm.org/D26418)
  * clang-tidy doesn't quite handle WINAPI and cdecl rewrites correctly.
    Those are manually fixed up in
      * scoped_handle_unittest.cc
      * win_util.cc
      * wrapped_window_proc.h

BUG=1034666

Change-Id: I20921cd09922072767caaed4a79de179e8bf4819
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1989979
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Auto-Submit: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732685}

Since |service_handle| from Android might be invalid, we need an early
return instead of DCHECK().

BUG=b:147707738
TEST=When Fitbit is installed, no crash in cts test now.

Change-Id: Ia9aa8402960bb40457bd81a3d09b26a41aa27601
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000401Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Commit-Queue: Jie Jiang <jiejiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732684}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/57a0ce4db871..32e07f0513b0


Created with:
  gclient setdep -r src-internal@32e07f0513b0

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1024588,chromium:1035235,chromium:1042439
Tbr: jbudorick@google.com
Change-Id: I489f25aa09d63e86a40e4b60e2eabcd8a25fef14
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005968Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#732683}

Previously, document policy class is designed to hold a field for each
feature's policy value. Those fields are supposed to be generated from
document_policy_features.json5. Such design minimizes both speed and
memory overhead but adds complexity to the system by introducing code
generation.

This CL uses array to represent internal feature state, which still
minimizes speed overhead as indexing into array is the same as indexing
into memory, and adds very little memory overhead(Each PolicyValue
instance contains extra information).

Change-Id: I4bc5e9b4383c628018e2605ad896e31b17c9c0e9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2003436
Commit-Queue: Charlie Hu <chenleihu@google.com>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732682}

Replace the PrintMsg_PrintNodeUnderContextMenu IPC message with a new
Mojo method, and update RenderViewContextMenu to use this method.

Bug: 1008939
Change-Id: I6cf5e4429c7c057b8b48d386177daf3989a3988d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1999322Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732681}

Previously within the cache logic if we had an indefinite initial
block-size we would compute a new final block-size based on the layout
results IntrinsicBlockSize().

For flex-boxes the IntrinsicBlockSize may depend on a previous
fixed-block-size (if present).

This resulted in an incorrect cache-hit.

A slightly more optimal version of this patch would be to set a bit on
this layout result named something like:
IntrinsicBlockSizeDependsOnInitialBlockSize().

This bit would be set if that layout had any child had its size based
on the initial-block-size. e.g. within the flex algorithm:

if (is_column_) {
  if (child.Style().ResolvedFlexGrow(Style()) > 0 ||
      child.Style().ResovledFlexShrink(Style()) > 0)
    container_builder_.SetIntrinsicBlockSizeDependsOnInitialBlockSize();
} else {
  if (DoesItemStretch(child))
    container_builder_.SetIntrinsicBlockSizeDependsOnInitialBlockSize();
}

... and within the cache logic:

if (layout_result.IntrinsicBlockSizeDependsOnInitialBlockSize())
  return NGLayoutCacheStatus::kNeedsLayout;

Bug: 845235
Change-Id: Iad4c5984ed894192a20d02303596d8fb9f71d036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002893
Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: David Grogan <dgrogan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732680}

This cl moves the logic for back gesture from
ToplevelWindowEventHandler to the new created BackGestureEventHandler.
This is done to make sure the gesture events will not be dispatched to
arc apps if they have been handled by back gesture, also make
ToplevelWindowEventHalder clearer.

The gesture events can still be dispatched to arc apps is because
exo::Touch is a PreTargetEventHandler of Shell
(https://cs.chromium.org/chromium/src/components/exo/touch.cc?rcl=74853d8d13a89431bd0ea7e843279f0bcee2ac7f&l=53)
but ToplevelWindowEventHandler is a PreTargetEventHandler of root window
(https://cs.chromium.org/chromium/src/ash/shell.cc?rcl=74853d8d13a89431bd0ea7e843279f0bcee2ac7f&l=1229)
This means the gesture event will be received by arc apps before
ToplevelWindowEventHandler.
This cl creates BackGestureEventHandler, which is also a
PreTargetEventHandler of Shell and being added inside Shell::Init.


Bug: 1026321
Change-Id: Ie7ae2ce7fdfb8e8efa17ffd82f31b8098c01c0d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006012
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732679}

Add shortcut keys AltGr+Left/Right for nagivating back and forth among
pages. This allows users of some European keyboards to navigate with one
hand key operations.

BUG=613201

Change-Id: I5eceeaacf0df8029f2b1d6f7dd6a2d85e1100682
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993845Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732678}

For child users, mature extensions should be force-disabled with a
tool-tip explanation. Commit the required string for the tool-tip
before feature freeze on January 17, 2020, so that the translation
team has adequate time to translate the string.

Bug: 1040614
Change-Id: Ide909d6e4f02ff201e2aa5cfd13d11dde1de2df4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006112
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Auto-Submit: Toby Huang <tobyhuang@chromium.org>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#732677}

Today the code sets a primary account on every login. This should not
be necessary, but there is a comment saying it is done to ensure
the google service username is set. That code dates back to 2012 and
was apparently added for migration to a new pref. All users should be
migrated by now.

Remove the comment and only SetPrimaryAccount() for new logins.
Add CHECKs that a primary account exists for existing logins.

No behavior changes are expected.

See comments on this code review for details:
https://chromium-review.googlesource.com/c/chromium/src/+/2001018

Bug: none
Change-Id: I61e68c38a52a16b11508fb75fe0df8c9391645fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006261
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732676}

Change-Id: I394b76031279554998e5a801970db2e12a6c6cb6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2006250Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732675}

This CL moves the IsCtrlExposed function to the V4L2 device, so it can be
reused at other places. Additionally this reduces the number of IOCTLS executed
directly inside the VEA, to provide a better abstraction of the V4L2 device.

TEST=./video_encode_accelerator_unittest on hana

BUG=None

Change-Id: I37981e0b75adcd386a6065f25560dd89dce41791
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969083Reviewed-by: Alexandre Courbot <acourbot@chromium.org>
Reviewed-by: Hirokazu Honda <hiroh@chromium.org>
Commit-Queue: David Staessens <dstaessens@chromium.org>
Cr-Commit-Position: refs/heads/master@{#732674}