GitLab

WiFiService StartConnect after CreateNetwork will try TKIP encryption if AES encryption fails to connect to newly created network.

BUG=328959

Review URL: https://codereview.chromium.org/197873012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260165 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354160
R=jonross@chromium.org, oshima@chromium.org

Review URL: https://codereview.chromium.org/217033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260164 0039d316-1c4b-4281-b951-d872f2087c98

These APIs are //chrome-specific, and rely on no other state from
SigninManager. As these APIs are per-Profile, ChromeSigninClient is an
appropriate place for them to live.

BUG=334205
TBR=thakis

Review URL: https://codereview.chromium.org/216703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260163 0039d316-1c4b-4281-b951-d872f2087c98

When doing recursive hit testing and the point falls within two children
of the same element, prefer the one that has an indirect descendant
(i.e. grandchild) match.

A better fix would be to send an IPC to the renderer and let Blink do
the hit testing, I filed another bug (357371) for that. This is a stopgap.

Note, though, that we still need this hit testing algorithm for
synchronous APIs (like on Windows), so it's worth improving this.

BUG=357247
R=aboxhall@chromium.org

Review URL: https://codereview.chromium.org/215633003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260161 0039d316-1c4b-4281-b951-d872f2087c98

BUG=355860

Review URL: https://codereview.chromium.org/214593006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260160 0039d316-1c4b-4281-b951-d872f2087c98

Test that a golden version 7 file can be read and updated, in preparation for
version 8.

BUG=351448
R=tsepez@chromium.org

Review URL: https://codereview.chromium.org/211363005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260159 0039d316-1c4b-4281-b951-d872f2087c98

Added a shortcut (Ctrl+Alt+N) for showing network config screen in during kiosk launch even if network connectivity is present. 

BUG=350065
TEST=added KioskTest.LaunchAppWithNetworkConfigAccelerator

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259679

Review URL: https://codereview.chromium.org/209143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260158 0039d316-1c4b-4281-b951-d872f2087c98

The code responsible for detecting similar blocks and merging
them didn't check for the next blocks if the last instruction was
not a JMP or a RET.

The patch to fix this bug (in codegen.cc) is based on a patch by
jld@panix.com, attached to the bug report.

Additional unittests are from jln@chromium.org

BUG=351103

Review URL: https://codereview.chromium.org/215173002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260157 0039d316-1c4b-4281-b951-d872f2087c98

BUG=355797
R=xiyuan@chromium.org

Review URL: https://codereview.chromium.org/203863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260156 0039d316-1c4b-4281-b951-d872f2087c98

This leaves the state in RenderViewHost for now, to make this an easier
first step.

BUG=304341
TEST=No behavior change.
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/208243019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260155 0039d316-1c4b-4281-b951-d872f2087c98

Same deal as issue 172853009:

Auth errors currently show up in the wrench menu as GlobalErrors. This CL
removes auth errors from the wrench menu in Chrome OS and in Windows when
using the Ash shell, showing notifications instead.

The behavior when clicking these notifications should be the same as
when clicking the toolbar menu error -- showing the sync setup dialog in
the Settings page.

The error-checking logic has been refactored into the new SyncErrorController,
which now exposes the error status to the UI classes.

The UI classes, SyncGlobalError and SyncErrorNotifier, are keyed services
instantiated by the UI.

BUG=128948
TEST=unit_tests --gtest_filter=S*n*Error*
R=stevenjb@chromium.org, atwilson@chromium.org, derat@chromium.org, ben@chromium.org

Review URL: https://codereview.chromium.org/207603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260154 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354854

Review URL: https://codereview.chromium.org/208013003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260153 0039d316-1c4b-4281-b951-d872f2087c98

See discussion at chromium issue 338885.

When USE_OPENSSL_CERTS is defined, X509::OSCertHandle is now
typedef'ed to struct X509*. 
 
When USE_OPENSSL is defined, USE_OPENSSL_CERTS will now be
defined for linux and Android, while being off for Mac and 
Windows. This allows OpenSSL to be used while leaving
certificate handling to the OS.
 
OpenSSL cert verifying code will only be used on Linux.

This patch does not change any default behavior.

Bug=none
Test=none

Review URL: https://codereview.chromium.org/206453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260152 0039d316-1c4b-4281-b951-d872f2087c98

This uses the invoker() syntax.

R=scottmg@chromium.org, scottmg

Review URL: https://codereview.chromium.org/212843007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260151 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349158
R=mnissler@chromium.org

Review URL: https://codereview.chromium.org/210063003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260150 0039d316-1c4b-4281-b951-d872f2087c98

Declare a direct dependency on each generated headers target when it's used in source files directly. Add each to export_dependent_settings when it's used in public headers, and ensure that the targets containing files that include those headers have direct dependencies on the target containing those headers.

BUG=355443
R=rsleevi@chromium.org, thakis@chromium.org

Review URL: https://codereview.chromium.org/215633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260149 0039d316-1c4b-4281-b951-d872f2087c98

The LevelDB Chromium environment unit tests (AKA env_chromium_unittests) were
neither compiling for Android, nor was an APK produced that could be run.

BUG=356882
R=jsbell@chromium.org

Review URL: https://codereview.chromium.org/213843002

Patch from Christopher Mumford <cmumford@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260148 0039d316-1c4b-4281-b951-d872f2087c98

The previous IndexedDB implementation only checked for (and reported)
corrupted LevelDB's during open. If they are determined to be corrupted
during use then the database was simply closed. The page would be unaware of
this, and would likely reopen the database at a later time (which would work)
only to fail again during a read/write operation. There was no way for the
page to get out of that corrupted state - the user would have to delete all
origin data.

This change will record the fact that the backing store was corrupted, and
during open this would be read and, if present, result in the same dataLoss
state being reported to the page in the upgradeneeded event.

Also split IndexedDBBackingStore's REPORT_ERROR macro in two:
REPORT_ERROR_UNTESTED (which calls NOTREACHED) and REPORT_ERROR. REPORT_ERROR
is used for errors which are encountered during tests. This was done so that
runtime errors could still be caught during a debug build run.

BUG=322707
R=isherman@chromium.org, jochen@chromium.org, jsbell@chromium.org

Review URL: https://codereview.chromium.org/197333009

Patch from Christopher Mumford <cmumford@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260147 0039d316-1c4b-4281-b951-d872f2087c98

The test wasn't working properly on tablets in landscape mode because double
tap was effectively zooming in instead of zooming out. To fix that, the page
layout has been updated take display width into account.

BUG=357235
R=mkosiba@chromium.org

Review URL: https://codereview.chromium.org/216873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260146 0039d316-1c4b-4281-b951-d872f2087c98

BUG=50298

Review URL: https://codereview.chromium.org/161113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260143 0039d316-1c4b-4281-b951-d872f2087c98

BUG=353192
TEST=manually
R=nkostylev@chromium.org
TBR=scheib

Review URL: https://codereview.chromium.org/216793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260142 0039d316-1c4b-4281-b951-d872f2087c98

BUG=353869
TEST=Visual, Drag a bookmark over bookmark bar and bookmark bar folders.
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/214113003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260140 0039d316-1c4b-4281-b951-d872f2087c98

R=darin@chromium.org

Review URL: https://codereview.chromium.org/216983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260139 0039d316-1c4b-4281-b951-d872f2087c98

We create a cache that holds all XIDs of the menu windows that get created in X. The menus are evaluated for being drop targets before enumerating other windows. The menu XIDs cache gets updated in a root X11DesktopHandler when any menu (and Chrome menu in particular) gets created.

TBR(sky) for OWNERS in ui/base/ui_base.gyp.

BUG=349154, 349156, 344747
R=sadrul@chromium.org
TBR=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=260046

Review URL: https://codereview.chromium.org/196213004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260138 0039d316-1c4b-4281-b951-d872f2087c98

This way, perhaps we can determine how many load-compiler-process
events happen vs load-linker-process events, and see if there is
any drop off in counts between the stages.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=3824
R=teravest@chromium.org

Review URL: https://codereview.chromium.org/215553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260136 0039d316-1c4b-4281-b951-d872f2087c98

BUG=344415
R=rvargas
TBR=rvargas
NOTRY=true

Review URL: https://codereview.chromium.org/215363005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260135 0039d316-1c4b-4281-b951-d872f2087c98

This patch does following.:
- Hide "Open" (open in gallery with movie mode) if a single file is selected
- Hide "Watch" (open in video player) if multiple files are selected

Before the movie player separation, the task menu behaved as above, but it was removed in the previous patch (https://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/chromeos/file_manager/file_browser_handlers.cc?r1=259219&r2=259218&pathrev=259219). This patch changes the behaviour back with the new video player.

BUG=271811
TEST=manually tested
R=hashimoto@chromium.org, hirono@chromium.org
TBR=asargent@chromium.orh
# TBRing for removing the comment.

Review URL: https://codereview.chromium.org/215103003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260134 0039d316-1c4b-4281-b951-d872f2087c98

These were rebaselined in
http://src.chromium.org/viewvc/blink?revision=169987&view=revision.

BUG=352628
R=bsalomon@google.com

Review URL: https://codereview.chromium.org/216693004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260133 0039d316-1c4b-4281-b951-d872f2087c98

EventSource gets a list of EventRewriters, which each get a chance to
rewrite an event before it gets sent to the EventProcessor.

BUG=354033
R=sadrul@chromium.org

Review URL: https://codereview.chromium.org/210203002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260132 0039d316-1c4b-4281-b951-d872f2087c98

TBR=danakj@chromium.org

TESTS=manually compiled and run content_unittests --gtest_filter=SoftwareOutputDeviceOzoneTest.*

Review URL: https://codereview.chromium.org/217003002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260131 0039d316-1c4b-4281-b951-d872f2087c98

Let the sandbox start normally and don't start the sandbox early.
Tegra124 libraries no longer need preloading of libraries or a whitelist
policy.
Add flag --gpu-sandbox-start-after-initialization to prevent the sandbox starting early.

BUG=none
TEST=Boot browser and about:gpu shows sandboxed to be true.

Review URL: https://codereview.chromium.org/179983006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260130 0039d316-1c4b-4281-b951-d872f2087c98

BUG=354423
TBR=asargent

Review URL: https://codereview.chromium.org/206003004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260128 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260124 0039d316-1c4b-4281-b951-d872f2087c98

No doubt we can remove RenderViewObserver::DidFinishDocumentLoad(),
but that can be done separately (there is already a TODO for it).

BUG=none
TEST=none
R=darin@chromium.org

Review URL: https://codereview.chromium.org/212793004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260119 0039d316-1c4b-4281-b951-d872f2087c98

As instructed in base/basictypes.h we should use (u)int{8,16,32,64}_t rather
than the ones without the '_t' suffix.

BUG=333413
R=derat@chromium.org

Review URL: https://codereview.chromium.org/215233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260118 0039d316-1c4b-4281-b951-d872f2087c98

This change introduces the initial deferred (i.e. background) tracer
infrastructure. This allows to start async subprocesses which
periodically trace a given process. At the moment, the tracer will
only dump mmaps and store them into the file archive.
Furthermore, this CL introduces the possibility to dump and classify
mmaps from the storage.

BUG=340294
NOTRY=true

Review URL: https://codereview.chromium.org/216783003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260117 0039d316-1c4b-4281-b951-d872f2087c98

Currently the search provider can be localized. The CL adds localization support of homepage and startup page.

BUG=267510
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/213683006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260116 0039d316-1c4b-4281-b951-d872f2087c98

SaveFlags are being deprecated in Skia. This CL updates the call sites
to use defaults (kMatrixClip_SaveFlag for save(),
kARGB_ClipLayer_SaveFlag for saveLayer()).

R=piman@chromium.org, reed@google.com, sky@chromium.org

Review URL: https://codereview.chromium.org/214603005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260115 0039d316-1c4b-4281-b951-d872f2087c98

(Also split the tests.)

R=darin@chromium.org

Review URL: https://codereview.chromium.org/216073002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260114 0039d316-1c4b-4281-b951-d872f2087c98

Minor refactor to avoid the possibility of accumulating error through
truncation in LayerImpl::MaxScrollOffset().

Review URL: https://codereview.chromium.org/214893005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@260113 0039d316-1c4b-4281-b951-d872f2087c98