GitLab

Problem:
To add polish, SearchController closes the app list view when opening
search results. Newly added Assistant search results (surfaced as
launcher chips) often desire to stay in launcher(-embedded Assistant)
UI which is broken by this behavior.

Solution:
Make it optional whether SearchController should dismiss app list view
eagerly or not.

Bug: b:154152631
Change-Id: Ic37220b4a8bddb45277cbce4544cfae8ac69be56
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163853
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763544}

Bug: 684762
Change-Id: Iba524b75bbceafd69ca0af04461b5badb1a2ebd7
Relnotes: Launch ChromeVox search menus feature.
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168795
Commit-Queue: Akihiro Ota <akihiroota@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763543}

The UMA is sent in session manager daemon when starting ARC fails and we
create backup of ARC bug report.

CL of session manager daemon: https://crrev.com/c/2168746

BUG=b:149874690
TEST=None

Change-Id: I532488eaf068d103cc9f3d718a247d2c5b968d3c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168638
Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org>
Auto-Submit: Muhammad Hasan Khan <mhasank@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763542}

No longer needed after recent R8 roll

Change-Id: I1821bf2335f4da02db5f614361755fef24e9b185
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170559
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Sam Maier <smaier@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Sam Maier <smaier@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763541}

Use SigninTestUtil to add test accounts instead of ChromeSigninController.

Bug: 1074309
Change-Id: Ifa737a5425e348e2ea68f4d80698c94416e5f69b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165785Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763540}

Change-Id: Iac5cbeb49c3de10f9bb77a6d02abc7be50eaebc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163574Reviewed-by: Kristi Park <kristipark@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763539}

These tests should not be flaky after CL:2161032.

Also fix WebviewProxyAuthLoginTest to not crash if it would be
re-enabled, but actually re-enabling it will happen in another CL
because its flakiness may have been due to other issues.

Bug: 830337, 949511, 1022034
Test: browser_tests
Change-Id: Idc66e8516f7c1c381f0c76a8e820500a0a04924e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171097
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763538}

FlatTreeNodeData is cleared on insertion so that nodes moving between
shadow trees do not keep stale parent information since we use the
FlatTreeNodeData ancestor to mark ancestors style dirty without updating
the slot assignment.

This is normally fine since inserting a child node of a shadow host will
mark the host for slot re-assignment, and the slot re-assignment will update
FlatTreeNodeData accordingly. The diffing of flat tree children in
NotifySlottedNodesOfFlatTreeChange will mark the inserted node for style
recalc via FlatTreeParentChanged.

There is however a glitch which can happen if a node is removed from a
shadow host, inserted into a different node, and then moved back into
the original shadow host without having any re-slotting happening in
between. If the node ends up in the same flat tree position, we will not
be able to detect that it needs FlatTreeParentChanged to be marked for
style recalc.

Example:

<div id="host">
  <:shadow-root>
    <slot></slot>
  </:shadow-root>
  <span>PASS</span></div>
<div id="other"></div>
<script>
  // Make everything clean. FlatTreeNodeData ancestor for the span is
  // the slot.
  host.offsetTop;
  let slotted = host.querySelector("span");

  // The span is removed, the layout object is detached, and the
  // ComputedStyle is cleared.
  slotted.remove();

  // Insert span into the #other element, FlatTreeNodeData for the span
  // is cleared. The host is marked for slot re-assignment.
  other.appendChild(slotted);

  // The span is re-added as a child of #host, but nothing is marked
  // style dirty since the #host has a shadow root and the span is not
  // yet part of the flat tree.
  host.appendChild(slotted);

  // Slot re-assignment happens, but the result of slotting is the same
  // as for the last lifecycle update, and nothing is marked dirty. That
  // results in the span not getting a ComputedStyle nor a LayoutObject.
  host.offsetTop;
</script>

The solution is currently to do a FlatTreeParentChanged for the case
where we:

1. Already have a FlatTreeNodeData.
2. The FlatTreeNodeData ancestor is null before the slot assignments.
3. The node is assigned to a slot.

It is definitely correct and necessary that we call
FlatTreeParentChanged in this case, but we end up doing it twice for
other elements which were added to the host, which used to be a child of
another host (FlatTreeNodeData being non-null), and will also have
FlatTreeParentChanged being called in the diffing as well. The question
is if that will cause perf regressions, typically in microbenchmarks.

Bug: 1072475
Change-Id: I5e697570b74599b0a3e01ca869eac022105fc6b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2160930
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763537}

This integrates the PGO build config with the new gclient hooks added in
https://chromium-review.googlesource.com/c/chromium/src/+/2165448

Bug: 1056189
Change-Id: Ie165c3355496ac539836ee36903a51a1e585cbf1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107728Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763536}

This CL replaces the layout mixin uses with just the expanded CSS
properties. See [1] as reference.

[1] https://source.chromium.org/chromium/chromium/src/+/master:third_party/polymer/v3_0/components-chromium/iron-flex-layout/iron-flex-layout.js?originalUrl=https:%2F%2Fcs.chromium.org%2F

Bug: 973674
Change-Id: Ifcbe09ad7f424a6b74a00c304b7101a66e1d5873
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168808Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763535}

Keep GetTiles as async call but return the copies of tile data.

Bug: 1066550
Change-Id: I0b2eddd7063c5f6ded269c4223cd3e67da2aedf8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161479
Commit-Queue: Hesen Zhang <hesen@chromium.org>
Auto-Submit: Hesen Zhang <hesen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763534}

When authors add will-change: transform hints, we expect the transform
to change and should attempt to not change the raster scale unless
higher resolution tilings are needed.

Bug: 1074055
Change-Id: Ica3daff2a093617602aff8785568e5c29d5b6210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164152Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763533}

This adds an about:flag entry for On-focus Suggestions for the
Contextual Web.

Find it here:
chrome://flags/#omnibox-on-focus-suggestions-contextual-web

Bug: NONE
Change-Id: I04d085a4d2416de6df2f1962d250e1e4908d0fea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166382
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763532}

This removes setFindToolbarManager and getActionModeControllerCallback in favor of injecting FindToolbarManager to ToolbarManager's constructor, which is enabled by instantiating ToolbarActionModeCallback in RootUICoordinator.

Bug: 865801
Change-Id: I0c08a63c1576bf3449de8d040a184ca4e8cb059f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165656
Commit-Queue: Patrick Noland <pnoland@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763531}

Add a minimally-privileged sandbox. This is used by the
VideoCaptureService under Fuchsia, but is equivalent to no sandbox on
other platforms.

Bug: 998310
Test: CQ
Change-Id: I418d05b96e7489ab2bb0db6f7c360db7390d7c72
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2161618Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sharon Yang <yangsharon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763530}

https://pdfium.googlesource.com/pdfium.git/+log/784cc7b22b21..88040c56ba07

git log 784cc7b22b21..88040c56ba07 --date=short --first-parent --format='%ad %ae %s'
2020-04-28 tsepez@chromium.org Null check not needed for CFX_GEModule::GetFontMgr() return value.
2020-04-27 thestig@chromium.org Disable deflate TIFF support.
2020-04-27 thestig@chromium.org Replace BIT_INDEX_TO_BYTE and BIT_INDEX_TO_ALIGNED_BYTE macros.
2020-04-27 thestig@chromium.org Disable OJPEG style TIFF support.
2020-04-27 thestig@chromium.org Remove unnecessary fx_string.h usage.
2020-04-27 thestig@chromium.org Add a regression test for bad Type3 font glyphs.

Created with:
  gclient setdep -r src/third_party/pdfium@88040c56ba07

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pdfium-autoroll
Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:1371,chromium:966263
Tbr: pdfium-deps-rolls@chromium.org
Change-Id: I7f9e2e302b8e3dd96c125e8491f26c45d5bbd3a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170803Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#763529}

Otherwise the generated mojom-lite.js files will contain definitions
such as chrome.mojom.AutocompleteMatchSpec = {...} which won't closure
compile since |chrome| is defined as a constant namespace in
third_party/closure_compiler/externs/chrome.js:

/**
 * namespace
 * @const
 */
var chrome = {};

Bug: 1041129
Change-Id: I4c5664f796e029738ec37f519a9345c69f69f12e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167427Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763528}

This patch fixes a DCHECK failure for when hit-testing culled
inlines inside of a column box.

It fails because |NGPhysicalFragment::GetLayoutObject()|
returns |nullptr|. This patch adds
|GetSelfOrContainerLayoutObject()| to return its parent
|LayoutObject| for when the fragment is not a CSS box;
i.e., line box or column box.

Bug: 829028, 1043787
Change-Id: I81098a6969f8c5c2100195e533d7d509a92b2fae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170371Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763527}

Consolidate cookie callbacks (OnCookiesRead and OnCookieChanged) into a
single OnCookieAccess and pack all parameters into a single struct for
easier plumbing.

This removes a bunch of duplicated logic and makes it easier to do clean
up attribution later.

R=kinuko@chromium.org,engedy@chromium.org,csharrison@chromium.org
BUG=1061899

Change-Id: I4616de9b56955fdaadbe8b95205df360e0f8a22c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159430
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Joshua Bell <jsbell@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763526}

Change-Id: I2fd3135e9596d772e384a8d62c6fa84a782fc7c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171316Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763525}

This reverts commit 4ffa6a29.

Reason for revert: Breaking Mac build:
https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests/24148

Original change's description:
> Add unittest for Lax-allowing-unsafe behavior under SameSite-by-default
> 
> Improve test coverage: verify that cookies with the default SameSite
> behavior under SameSite-by-default-cookies can be sent on top-level
> cross-site POST requests if less than 2 minutes old.
> 
> Bug: 953306
> Change-Id: I642f4df702f0cad62310a4d442f69a293096cab6
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2169574
> Commit-Queue: Lily Chen <chlily@chromium.org>
> Commit-Queue: Maksim Orlovich <morlovich@chromium.org>
> Auto-Submit: Lily Chen <chlily@chromium.org>
> Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#763451}

TBR=morlovich@chromium.org,chlily@chromium.org

Change-Id: I18ddfd96efc61555fc99a717f44f1ad4f45706e6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 953306
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170597Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763524}

This cl adds a new os_settings_resources_v3.grdp file, in preparation of migrating
to Polymer 3.

Bug: 1045266
Change-Id: I55103ba896586f7322498449e2c5b2eed7f70a97
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2167803
Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Regan Hsu <hsuregan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763523}

This changes the SlowDCTimerInterruptsWin experiment group name from
"Enabled" to "Enabled_20200424", to match the latest group name in
the .gcl configuration file.

The suffix was added to the .gcl file in cl/308344693.

Change-Id: Ie62db49856d15e0bd9d327d217980fc48edb2340
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166124
Auto-Submit: Jesse McKenna <jessemckenna@google.com>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763522}

Add a new print preview event and log when print preview is initiated.

Bug: b:155084154
Change-Id: I400a97277b5c6d54c0221e52792b4e863feb81a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168191
Commit-Queue: Jesse Schettler <jschettler@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763521}

These are other params that are either:
* Simple to migrate uses of or
* Almost never used

Bug: 1075649
Change-Id: Ice057513c3b8658ffed7e3a5c9c9c7ee999174cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168836
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763520}

This allows internal code to resample without directly depending on
Chromium media code.

Bug: internal b/148569388
Change-Id: I08ecf20daf1be67727a18b7ce6829d28854ccffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170424
Commit-Queue: Kenneth MacKay <kmackay@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763519}

This reverts commit 9781ff27.

Reason for revert: The original CL is completely unrelated to the flaky test; actual culprit CL is https://crrev.com/c/2167751.

Original change's description:
> Revert "Refactor Reader Mode's JavaScript tests to use Mocha."
> 
> This reverts commit 7de90169.
> 
> Reason for revert: Suspicious to have broken DomDistillerViewerSourceBrowserTest.UISetsPrefs in browser_tests.
> https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/37476
> 
> 
> Original change's description:
> > Refactor Reader Mode's JavaScript tests to use Mocha.
> > 
> > The tests did not previously use an established test framework, making
> > tasks like executing certain code before or after every test and testing
> > asynchronous code more difficult. It should also be easier for
> > developers familiar with JavaScript testing in general and WebUI testing
> > in particular to read and write JavaScript tests for DOM Distiller and
> > Reader Mode.
> > 
> > Follow-up work includes replacing the custom assert methods with Chai,
> > as well as writing more tests to cover existing functionality.
> > 
> > Bug: 1027612
> > Change-Id: I39acc923a0424881d2694281d9aa0323c8f9a913
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992504
> > Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> > Commit-Queue: Aran Gilman <gilmanmh@google.com>
> > Cr-Commit-Position: refs/heads/master@{#762551}
> 
> TBR=wychen@chromium.org,gilmanmh@google.com
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1027612
> Change-Id: I78b6b82e98c8f47951ab88e2056595de878f1ab1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166219
> Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
> Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#762720}

TBR=yukishiino@chromium.org,wychen@chromium.org,gilmanmh@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1027612
Change-Id: I8f2faf0eaf6dcaa0e655b5f563874781cdff38fe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170418Reviewed-by: Aran Gilman <gilmanmh@google.com>
Commit-Queue: Aran Gilman <gilmanmh@google.com>
Cr-Commit-Position: refs/heads/master@{#763518}

This CL removes KitKatWebContentsAccessibility.java and moves all
the logic from that class into the parent/base class of
WebContentsAccessibilityImpl.java.

We will no longer support KitKat going forward, so we can move
the KitKat specific code to our parent class since we can be
certain that any user is at least at that API level.

Bug: 1073117
Change-Id: I862a6c39bd618cc7bbc80d9ac5c13e5d590cb3b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159418Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Reviewed-by: Bo <boliu@chromium.org>
Auto-Submit: Mark Schillaci <mschillaci@google.com>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763517}

This reverts commit 9dfaeca2.

Reason for revert: The change doesn't fix the crash, we still get surface lost.

Original change's description:
> Fix crash in gpu::VulkanSwapChain::ScopedWrite::ScopedWrite
> 
> The crash is because the vkAcquireNextImageKHR() fails with
> VK_ERROR_SURFACE_LOST_KHR, probably the platform window is
> closed, or a new swapchain is created with the same platform
> window. Since vkAcquireNextImageKHR() is called just before
> rendering DDL to the vkmage, if there isn't a new vkimage
> is available, it is too late to properly handle it. Fix
> the problem by call vkAcquireNextImageKHR() immemorially after
> vkQueuePresentKHR() call. If vkQueuePresentKHR() call is successful,
> then the surface should be good, and vkAcquireNextImageKHR()
> should be successful too. If surface is lost, vkQueuePresentKHR()
> will return VK_ERROR_SURFACE_LOST_KHR., and then the PresentBuffer()
> will return SWAP_FAILED to caller. Caller should be able to handle it
> properly like it does with GL and glSwapBuffers().
> 
> Bug: 1070754
> Change-Id: I697cca3a282d046e9592d554403f7c10c811cf19
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155197
> Commit-Queue: Peng Huang <penghuang@chromium.org>
> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
> Reviewed-by: Vasiliy Telezhnikov <vasilyt@chromium.org>
> Auto-Submit: Peng Huang <penghuang@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#760555}

TBR=penghuang@chromium.org,vasilyt@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1070754
Change-Id: Ic76b26b30ecb282218ce32701eb3bd143038609b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170978Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763516}

https://swiftshader.googlesource.com/SwiftShader.git/+log/587fbb9ef3a5..71c49f8eab3d

git log 587fbb9ef3a5..71c49f8eab3d --date=short --first-parent --format='%ad %ae %s'
2020-04-28 amaiorano@google.com Run clang-format on renamed headers
2020-04-28 amaiorano@google.com Rename Vulkan-source .h to .hpp

Created with:
  gclient setdep -r src/third_party/swiftshader@71c49f8eab3d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: Ie9cafb569d24b9370fc39e8ae62d316e4d44234c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170792Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#763515}

With this change, goma_link.py and goma_ld.py take a new option,
--no-gomacc, which causes them to generate build rules without gomacc
invocations. This allows these scripts to be used to break a local
ThinLTO linker invocation into smaller commands which still run
locally.

Bug: 1072888
Change-Id: I47900e40811e9e39248246126491dfeb80725256
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158061
Commit-Queue: Bob Haarman <inglorion@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763514}

https://dawn.googlesource.com/dawn.git/+log/c244f5392178..2d79ef264eba

git log c244f5392178..2d79ef264eba --date=short --first-parent --format='%ad %ae %s'
2020-04-28 cwallez@chromium.org Do not use Dawn's warnings for compiling Chromium's gtest main.
2020-04-28 bryan.bernhart@intel.com D3D12: Fix invalid allocation size check.
2020-04-28 jiawei.shao@intel.com Add basic supports of readonly and writeonly storage textures on Metal
2020-04-27 xilefmai@gmail.com Fix MSVC compilation.
2020-04-27 cwallez@chromium.org Enable -pedantic and disable currently triggered warnings
2020-04-27 cwallez@chromium.org Fix ValidateRowsPerImage error text.
2020-04-24 cwallez@chromium.org Enable more warning needed for Skia to build with Dawn on Linux
2020-04-24 cwallez@chromium.org Add Matrix chatrooms to README.md
2020-04-24 cwallez@chromium.org Deprecate BufferCopyView.rowPitch/imageHeight -> bytesPerRow/rowsPerImage

Created with:
  gclient setdep -r src/third_party/dawn@2d79ef264eba

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/dawn-chromium-autoroll
Please CC cwallez@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel
Bug: chromium:1072449,chromium:1075817
Tbr: cwallez@google.com
Change-Id: I62b5622ab62c6489c631c7b4b232efc87aa825e3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170793Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#763513}

Causes all RenderTest comparison failures to surface when running the
tests locally, even if the particular hardware/software combination is
not supported. This is so that developers using unsupported
configurations, e.g. an Android emulator, to develop locally can still
see pixel output.

Bug: 1057851
Change-Id: I3bc40966746a011eb4fd4a2eb3b16a76e5d8ea70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170549
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763512}

CHECK, CHECK_EQ etc., and NOTREACHED/NOTIMPLEMENTED have moved
to the much smaller headers check.h, check_op.h, and notreached.h,
respectively.

This CL updates .cc files to use those headers instead when
possible, with the purpose of saving compile time.

(Split out from https://crrev.com/c/2164525 which also has
notes on how the change was generated.)

Bug: 1031540
Change-Id: I643818242b92e19a1048fac89dd8aae323e8b1ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2164510Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763511}

Snapping the dragged tab to the correct position will be implemented in
a follow-up change.

This also adds a function GetSnapPositionForLocation() that takes just a
location and ignores window-specific properties, unlike
GetSnapPosition(). This is necessary since the DragImageView used by
DragDropController is not snappable itself. Instead, it is just a
placeholder for a new browser window that will be snapped.

Bug: 1069869
Change-Id: I4b9946c9e1f6484a7ec79f8ad71db518d9dd9c7c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150025
Commit-Queue: Collin Baker <collinbaker@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763510}

BUG=1033029
TEST=WebLayerTest.getUserAgentString

Change-Id: I6331b3731ac36dbde138e7a8ca731165a6ba0b3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2166352
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763509}

This provides a quick fix for the regression introduced
by crrev.com/c/2079607.

The use of transforms will be re-introduced shortly.

Bug: 1073653
Test: manual
Change-Id: I7612d0923e9991ad63e083007c1a30763fc60d15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2165857Reviewed-by: Vladislav Kaznacheev <kaznacheev@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Commit-Queue: Vladislav Kaznacheev <kaznacheev@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763508}

Create new structs to hold content attributes for the image. These
specify different UI-related properties of the image.

In a future CL, we will add code to media_feeds_converter to fill in the
new content attribute fields.

Bug: 1071658
Change-Id: I82bcf01dffdd399bfc43fde4707cf2ccdaaa057e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2163439
Commit-Queue: Sam Bowen <sgbowen@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763507}

This is to catch up the spec change in AudioWorkletNode.onprocessorerror
event handler. The current implementation uses a regular Event object to
report an error, but the spec has changed to use a proper ErrorEvent.

The CL also cleaned up redundant modification in the test file,
which was caused by the previous revision.

Bug: 1064240
Test: external/wpt/webaudio/the-audio-api/the-audioworklet-interface/audioworkletnode-onerror.https.html
Change-Id: If7ac7eee96138ec0dbe02a3a046a5bdee27389db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2168542Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763506}

This will help identify crashes related to partner customization.
Customization includes the default homepage url and default bookmarks.

Bug: 1063948
Change-Id: I62ceb297f0fcfda7e322c97a6476454d147bc0a1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150011Reviewed-by: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: bttk <bttk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763505}