- 06 Apr, 2018 40 commits
-
-
James Cook authored
Widget::InitParams setup is different in classic ash vs. mash. Centralize the boilerplate code. This eliminates some ash/shell.h includes, making it clearer that there's only one issue here. It also reduces the chance of weird compiler errors if you copy/paste the boilerplate but forget the type converters header. Bug: 756057 Test: browser_tests Change-Id: I3f1c76f2b174ef305697f8551a6923534a73dbaf Reviewed-on: https://chromium-review.googlesource.com/999813 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#548875}
-
Michael Achenbach authored
This will allow webrtc and v8 to share the configs. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win-msvc-dbg Bug: 653569 Change-Id: I41a4d9025f47fd3a9d6837f88c2bece108c213a8 Reviewed-on: https://chromium-review.googlesource.com/997794Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#548874}
-
Torne (Richard Coles) authored
The old native implementation of findAddress only accepted addresses without zip codes if they appeared at the end of the string. This was probably a bug as the documentation implies this should work in all cases, but fixing this bug has caused a lot of false positives while not fixing very many false negatives and this functionality is being deprecated anyway, so change it back. Bug: 829411 Change-Id: Id280f524eaaade1851ae23e7ed17d0755ddb2ba9 Reviewed-on: https://chromium-review.googlesource.com/998754Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#548873}
-
Becca Hughes authored
When generating the media controls DOM we were recalculating styles each time we called 'AppendChild'. This moves us to using 'ParserAppendChild' which does not do this. According to manual testing this reduces the time calculating styles from 230ms to 139ms. BUG=821961,821414 Change-Id: I0d673ddc6e12ff81a311315466be735a7673c1bd Reviewed-on: https://chromium-review.googlesource.com/998187 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#548872}
-
Allen Bauer authored
This is a reland of 7a462a5d Original change's description: > Added material refresh layout provider. Updated material design controller. > > Added IsMaterialRefreshMode() function to ChromeLayoutProvider. > > Bug: 822000 > Change-Id: I379d7603838cdec60b3f94fc0e163e9907995b61 > Reviewed-on: https://chromium-review.googlesource.com/988052 > Commit-Queue: Allen Bauer <kylixrd@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548413} Bug: 822000 Change-Id: I10e27e8294308d01415664adccfac7c4a7206b38 Reviewed-on: https://chromium-review.googlesource.com/999335Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#548871}
-
Peng Huang authored
Bug: 828721 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie0ae4daf4622b30db79b71c9024c5b67a3095bc6 Reviewed-on: https://chromium-review.googlesource.com/997953Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#548870}
-
Takumi Fujimoto authored
The test has been timing out on win7_chromium_rel_ng and linux_chromium_rel_ng. TBR=loonybear@chromium.org Bug: 829921 Change-Id: I87950fa86cccfe00a0d5b02778c551216bc32e02 Reviewed-on: https://chromium-review.googlesource.com/999912 Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#548869}
-
https://skia.googlesource.com/skia.git/+log/485dc868fff7..0cfd547b465a $ git log 485dc868f..0cfd547b4 --date=short --no-merges --format='%ad %ae %s' 2018-04-05 brianosman Remove SK_SUPPORT_LEGACY_BLURMASKFILTER 2018-04-06 bsalomon Add versions of MakeGL() that don't require include GrGLInterface.h in order to use the GrGLMakeNativeInterface 2018-04-06 egdaniel Don't use GrPixelConfig value as proxy for valid on GrBackendSurface. 2018-04-05 liyuqian Exercise the threaded backend in test bots 2018-04-06 angle-skia-autoroll Roll third_party/externals/angle2/ c3755fc56..b8e396609 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=herb@chromium.org Change-Id: I9f6d64530d85e8cf511092f02df3dc85abf8afda Reviewed-on: https://chromium-review.googlesource.com/999733Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548868}
-
Mugdha Lakhani authored
Developers can provide multiple icons through BackgroundFetchOptions. We calculate an Icon Score for each, and pick the icon with the highest score to show with the UI. Scoring is a combination of size score (the image closest in size to the ideal display size gets the highest score) and an aspect ratio score (the image closest to a square shape gets the highest score). Design doc here: https://docs.google.com/document/d/1rEhpXios2wkeePHm6NfHzplESecn0-zQ2XBVjP7ykOk/edit# TBR=peter@chromium.org Bug: 813564 Change-Id: I4b74bc0db06a71ca276e98659ee1b2148358e1e7 Reviewed-on: https://chromium-review.googlesource.com/986265 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#548867}
-
Reilly Grant authored
This patch provides UI controls for the new WebUSB guard permission in the page info popup and on the site settings pages. Screenshots of the new UI are included in the design doc: https://goo.gl/uMPMZZ Bug: 771703 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4c9dc2cc59a589e558ceb346982d493ac66dc674 Reviewed-on: https://chromium-review.googlesource.com/982595Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#548866}
-
Peter Kasting authored
BUG=none TEST=none Change-Id: I0c4a1c28077e0b19b3e2be8f0448eef5e58c8909 Reviewed-on: https://chromium-review.googlesource.com/996771 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#548865}
-
Gabriel Charette authored
(as opposed to invoked on a delegate right away) Prerequisite for a note I'm about to add on Posix MessagePumps' WatchFileDescriptor() API. R=fdoray@chromium.org Bug: 645114, 825327 Change-Id: I5ead76650bd7a605c7bd19648b10daf2195e052c Reviewed-on: https://chromium-review.googlesource.com/999792 Commit-Queue: Gabriel Charette <gab@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#548864}
-
Michael Achenbach authored
Bug: 828846 Change-Id: I6c0fd0f3d148b5eb075e71f8523819e6d35e382a Reviewed-on: https://chromium-review.googlesource.com/999491Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#548863}
-
Martin Sramek authored
This ID will be used to make sure that we don't mistakenly associate the consent with an incorrect account if the user gives consent for an account before finishing sign-in, or if the user signs out and signs in to a different account before the proto can be transmitted. Currently, the account ID is only an empty string. The field will be populated once https://chromium-review.googlesource.com/c/chromium/src/+/986293 lands. However, this CL can unblock the corresponding changes in UserEventService that will consume this field. Bug: 781765 Change-Id: I2dae998c599c2480771e54315627ee2be3bafe5d Reviewed-on: https://chromium-review.googlesource.com/998195 Commit-Queue: Martin Šrámek <msramek@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#548862}
-
Xi Cheng authored
Bug: 734095 Change-Id: Ia832d7b3b176d90d4c5d618ac169ad0cc5fe8a72 Reviewed-on: https://chromium-review.googlesource.com/996455Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Xi Cheng <chengx@chromium.org> Cr-Commit-Position: refs/heads/master@{#548861}
-
Derek Cheng authored
The cast protocol allows a max message size of 64kb = 65536 bytes. However Chrome does not enforce this correctly in the following ways: - 65535 is used instead of 65536 as the max limit - The limit should not include the 4 byte header, but Chrome includes it (e.g., the IOBuffer used to read both only has 65535 bytes of capacity) This patch fixes this by allocating 65536 + 4 bytes for the input buffer, and modifying the check for message size against 65536. Bug: 822611 Change-Id: I27121abb57dee5aee9741173e19cf0178184477d Reviewed-on: https://chromium-review.googlesource.com/996475 Commit-Queue: Derek Cheng <imcheng@chromium.org> Reviewed-by:
Adam Parker <amp@chromium.org> Cr-Commit-Position: refs/heads/master@{#548860}
-
erikchen authored
The core logic for dealing with the HeapProfiler has three major components: 1) Interfacing with the service [depends on components/services/heap_profiling] 2) Connecting new clients [depends on content/] 3) Uploading heap dumps [depends on chrome/] This CL moves the logic for (1) into components/services/heap_profiling. This allows android_webview to reuse the logic. Change-Id: Idd307c805746cacd8760b71addc88650cd81402f Bug: 827545 Reviewed-on: https://chromium-review.googlesource.com/999328 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Miguel Casas authored
This CL refactors the multiple individual functions of edid_parser.* into a single EdidParser class that parses an EDID blob passed on ctor, populating the necessary/available fields. This simplifies extending this parser (which has happened and is expected to happen again), and simplifies the client APIs and the unittests. The client contract is changed a bit, since EdidParser won't tell if the parsing failed, but this is not really impactful since the current users ignore this booleans anyhow. Erroneous parsing is signalled via error values. Besides that, a notable change is that now we're parsing the whole EDID whereas on ToT this was somewhat on demand. But anyway drm_util always wanted all those parsings, and EDIDParserX11, which only needed one on ToT, is expected to work on Linux, where walking a 128B array should not be very demanding. Also EDIDParserX11 had two unused methods, removed. Change-Id: Id38a02dad1bc4ba55a3f7041034098dac5153020 Bug: 821393 Reviewed-on: https://chromium-review.googlesource.com/970085Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#548858}
-
Benjamin Pastene authored
Bug: 828392 Change-Id: Iddc8ad3d6501b981e39e6569c5e6e3dbfbed5e31 Reviewed-on: https://chromium-review.googlesource.com/998335 Commit-Queue: Benjamin Pastene <bpastene@chromium.org> Reviewed-by:
-
edchin authored
Bug: 825888 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib47af308aef7797fd682f647e8cfa7481c466a0f Reviewed-on: https://chromium-review.googlesource.com/999306Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548856}
-
Aidan Wolter authored
Similar to chromecasts, we now check the release channel to determine the device build type. If the AT build is a user build, the returned build type will be BUILD_PROD if the channel is (1) empty or (2) stable-channel. Otherwise, the returned build type is BUILD_BETA. dogfood-channel, ensure GetBuildType returns BUILD_BETA. Bug: None Test: Build internal, flash on user build, set channel to Change-Id: I02a629943fc3d7e91b103bb54b5e6d88595b7849 Reviewed-on: https://chromium-review.googlesource.com/999100Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Aidan Wolter <awolter@chromium.org> Cr-Commit-Position: refs/heads/master@{#548855}
-
Michael Lippautz authored
Post marking processing assumed that the backing store for weak HashTable's remains unchanged during marking which is not correct in the presence of incremental marking. Since post marking was just marking the header of the backing store this can be merged into the weak processing steps. This CL - Remove Heap::post_marking_worklist_ completely, avoid any memory consumption it might require. - Merges WeakProcessing and PostMarkingProcessing as the post marking steps were only used for weak HashTables. Bug: chromium:828537, chromium:757440 Change-Id: I0d0b7552786659becf039419bff3701e7bb72aee Reviewed-on: https://chromium-review.googlesource.com/999485Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548854}
-
Victor Costan authored
https://chromium.googlesource.com/external/github.com/google/googletest.git/+log/a325ad2db5de..82febb8eafc0 This CL also aliases <tr1/tuple> types used by googletest to C++11 <tuple> types, to prepare for gradually transitioning the Chromium codebase from std::tr1::tuple to std::tuple. $ git log a325ad2db..82febb8ea --date=short --no-merges --format='%ad %ae %s' 2018-04-05 misterg Merging gMock, 2 2018-04-05 misterg formatting 2018-04-05 misterg And more MCVS warnings 2018-04-05 misterg fixing MCVS warn 2018-04-05 misterg Have to wait for this one 2018-04-05 misterg Have to wait for this one 2018-04-05 misterg Merging matchers test 2018-04-05 misterg Merging matchers test 2018-04-04 misterg bad cut/paste 2018-04-04 misterg More on MSVC warning C4503, decorated name length exceeded 2018-04-04 misterg More on MSVC warning C4503, decorated name length exceeded 2018-04-04 misterg Address MSVC warning C4503, decorated name length exceeded, name was truncated 2018-04-04 misterg Fixing build break on MSVC 2018-04-04 misterg merging gmock matchers 1 2018-04-04 fo40225 fix build break on locale windows 2018-04-04 misterg Tweaking https://github.com/google/googletest/pull/1523 to exclude nacl 2018-04-03 misterg Upstreaming, cl 191344765 2018-04-03 misterg merging port, cont. 191443078 2018-04-03 misterg merging, cont - 2 2018-04-03 misterg merging gtest-port.h , 191439094 2018-04-03 misterg merging, just comments format 2018-04-03 misterg testing, merge 2018-04-03 misterg Testing, gtest-port.h merge 2018-04-02 misterg merging gtest-port.h, again - 1 2018-03-29 gennadiycivil Include OSX builds back into PR builds 2018-03-29 gennadiycivil Revert "merging gtest-port 1 of N" 2018-03-29 gennadiycivil Revert "merging gtest-port, 2" 2018-03-29 leissa typo 2018-03-29 misterg merging gtest-port, 2 2018-03-28 leissa provide alternative for DebugBreak() 2018-03-27 misterg merging gtest-port 1 of N 2018-03-26 misterg merges 1 2018-03-26 misterg merges, gtest 2018-03-26 misterg merging gmock-matchers.h 3 2018-03-26 misterg merging gmock-matchers.h 2 2018-03-26 misterg Upstreaming FloatingEq2Matcher, 2018-03-23 misterg Merging gmock-matchers.h -2 2018-03-23 misterg gmock-matchers merging -2 2018-03-22 misterg merging, gmock -1 2018-03-22 misterg reverting gtest_list_tests_unittest.py 2018-03-22 gennadiycivil Update appveyor.yml 2018-03-22 misterg more merges 2018-03-22 misterg more merges 2018-03-21 misterg More merges 2018-03-16 misterg cl 189032107, again 2018-03-16 misterg cl 189032107 2018-03-15 misterg merge, again, IsRecursiveContainer Created with: roll-dep src/third_party/googletest/src Bug: 829773 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.win:win_chrome_official Change-Id: Ic865698379d3626a5165f81b56104223ad1558d9 Reviewed-on: https://chromium-review.googlesource.com/987696Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Reviewed-by:
-
Ryan Sleevi authored
https://crrev.com/548318 introduced two additional preferences for controlling Certificate Transparency disabling, and this glues up these preferences to Enterprise Policies - specifically, CertificateTransparencyEnforcementDisabledForCas and CertificateTransparencyEnforcementDisabledForLegacyCas BUG=824184 Change-Id: I06338e82c8280db21f1b48e9455074d020f51f83 Reviewed-on: https://chromium-review.googlesource.com/998546 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Bartosz Fabianowski <bartfab@chromium.org> Cr-Commit-Position: refs/heads/master@{#548852}
-
Scott Violet authored
ShowWindowWithState() for windows and linux always calls SetVisible(true), even when minimized. This makes the compositor hidden when minimized. BUG=none TEST=none Change-Id: Id8a48ab0096797904d894f6138cd9458afe60e61 Reviewed-on: https://chromium-review.googlesource.com/996249 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Ryan Sleevi authored
During a refactor, an accidental disabling of the CT enforcement crept in, meaning the test no longer tested that the policy overrode any CT requirements. BUG=769401 TBR=pastarmovj@chromium.org Change-Id: I2c060f0027ad838d4447235fe368f0fa2c1cd2ca Reviewed-on: https://chromium-review.googlesource.com/998547 Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#548850}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1118a2193b8f..5e79d07891aa $ git log 1118a2193..5e79d0789 --date=short --no-merges --format='%ad %ae %s' 2018-04-06 szuend Move path to depot to the front of PATH in the tutorial. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I5fcba6e3553a9b5158e90ecc71d67fcc714d8081 Reviewed-on: https://chromium-review.googlesource.com/998977 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#548849}
-
Becky Zhou authored
Bug: 814902 Change-Id: Ice5da70720f398c1ade0396e10f5990ee043c505 Reviewed-on: https://chromium-review.googlesource.com/999164Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#548848}
-
Pete Williamson authored
We were referencing a null pointer to try and get values. Changed to use default null values. This fixes the symptom (the crash), but not the underlying cause. The underlying cause is more complex and will be fixed in another patch. Bug: 829099 Change-Id: Ida10bd9366afac8dbbcbb5c2b7d41d36b0d46759 Reviewed-on: https://chromium-review.googlesource.com/996796Reviewed-by:
Yafei Duan <romax@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#548847}
-
Peter Kasting authored
This lets us avoid some ViewHierarchyChanged() overrides. BUG=none TEST=none Change-Id: I7896460f65cedf2351f5acd3e16893674faa72ea Reviewed-on: https://chromium-review.googlesource.com/996908 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#548846}
-
Misha Efimov authored
Bug: 812268 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I15a0d9f4e3a0c16d9a63e82ebb10943e082e1835 Reviewed-on: https://chromium-review.googlesource.com/999331Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#548845}
-
Eric Roman authored
Bug: 814849 Change-Id: I0d6b10c038d0d7d77ced05ad7a5246803803d0e8 Reviewed-on: https://chromium-review.googlesource.com/998844 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#548844}
-
Raymond Toy authored
Move the AudioNode tests to WPT. Can't move tail-processing.html because it's specific to Chrome's tail processing. Firefox passes all tests except: * audionode.html (because new AudioContext(1,44100,44100) succeeds but shouldn't * tests that use oac.suspend * audionode-connect-method-chaining.html with an IndexSizeError connecting Bug: 745778 Change-Id: I0e21e2117a75246367ea2642759ed917ee3e028f Reviewed-on: https://chromium-review.googlesource.com/994136Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
-
Nico Weber authored
Speculative change to try and get the debug bots to link again. Bug: 829795 Change-Id: I987675ee5c0163f2dc1e725910f9be14ca92aa1e Reviewed-on: https://chromium-review.googlesource.com/999323Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#548842}
-
Carlos IL authored
SupervisedUserInterstitial now keeps track of whether it called Proceed() on interstitial_page_ and doesn't call it again if it has already been called for the current interstitial. Bug: 829345 Change-Id: I2e5a66884bf9b9aa7182fdc70ea6629c38cb097b Reviewed-on: https://chromium-review.googlesource.com/998062 Commit-Queue: Carlos IL <carlosil@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#548841}
-
Andrey Kosyakov authored
Also fix request-response-interception-disable-between.js which only used to work because interception on both response and request did not. Bug: 829595 Change-Id: I6e00c6b5a56e512d24fedc6369462376dddcbe3e Reviewed-on: https://chromium-review.googlesource.com/999040Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#548840}
-
Krishna Govind authored
R=cmasso@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I04ef7e852874486c5d2594a7d6b224a165b3df20 Reviewed-on: https://chromium-review.googlesource.com/999818Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#548839}
-
Simon La Macchia authored
Problem: When the GLVirtualContextsTest tests are run on a device with Open GL ES 2.0, the tests fail during initialization because it tries to re-initialize a GLManager (gl_real_) after failing to initialize as content type ES 3.0. The problem being theat the gl_real_ is now in an inconsistent state and cannot be initialized again. Solution: Reset the GLManager (gl_real_) after failing to be initialized as ES3, so that it can be re-tried as ES2. Bug: None Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idb0a6947baa80c3135418504e77458171eebe1fa Reviewed-on: https://chromium-review.googlesource.com/999268Reviewed-by:
-
Tetsui Ohkubo authored
This CL removes WebNotificationTray button when --enable-features= SystemTrayUnified. UnifiedSystemTray will replace WebNotificationTray and SystemTray. When the flag is enabled, UiController, AshPopupAlignmentDelegate, and MessagePopupCollection will be also owned by UnifiedSystemTray. TEST=manual BUG=828752 Change-Id: I03cf6949bb2b165d4bda89327570aac74328e88c Reviewed-on: https://chromium-review.googlesource.com/987635Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#548837}
-
Chris Lu authored
Original assets had white backgrounds. These have transparent ones. Also uses the new history asset in Recent Tabs. Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ibbdcff9a87cc3b93a59710736fa1b82f1b246efb Reviewed-on: https://chromium-review.googlesource.com/999294 Commit-Queue: Chris Lu <thegreenfrog@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#548836}
-
