- 11 Jan, 2021 21 commits
-
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I50ffbdcd4cf2033edb487e7d274dd9cfb486234e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619682Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841928}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610311594-320b29fe5375389a75bd4c89bfa97b0cd33c2b26.profdata to chrome-win64-master-1610322555-a70eefc496d1545b17a80d3dbb05e5ee869d1bda.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4fbac0b9118075637fc6ba052d730e38eaca0014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620589Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841927}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2199cde1f52b..a7548393d370 2021-01-11 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Change-Id: I580c37461fcf283247080b34b89fd64c18fee07c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620663Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I413bb8e919d348eb3e561f8f723d30bbfe0808fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620644Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841925}
-
Wenbin Zhang authored
This reverts commit aa20f9b8. Reason for revert: Mac builders on perf waterfall are failing after this CL: https://ci.chromium.org/p/chrome/builders/ci/mac-builder-perf Original change's description: > Cache Mac channel information > > Soon, with TargetChannel, an instance of Chrome on the disk > might be upgraded to an instance of Chrome of a different > channel. Cache the channel information on startup, so that > even if it's changed, the channel information of the current > running instance is available. > > Fixed: 1163159 > Change-Id: Ie9ffd98325a0da335778206709f94ea5591e9af0 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618041 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#841840} TBR=avi@chromium.org,mark@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ib6095e36b6c9964693607cfeba5b06e3acd1c42f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620609Reviewed-by:
Wenbin Zhang <wenbinzhang@google.com> Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Cr-Commit-Position: refs/heads/master@{#841924}
-
Joey Arhar authored
The number I used when I just added this use counter, 3745, was already being used by another usecounter that got deleted. You can see that it shows the old name on chromestatus as well: https://chromestatus.com/metrics/feature/timeline/popularity/3745 Bug: 1161163 Change-Id: I341b8727cdfea79539e2cc3448a8ec7076490ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618999 Auto-Submit: Joey Arhar <jarhar@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#841923}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610311594-efd75f7a3a70e07e3e92029af80c214e50282c24.profdata to chrome-win32-master-1610322555-5bda1313c81735158c242e62672a43655918de7e.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Iff88c90dfb40005712f9f289c6bd6dba4a1a024c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620662Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/42082f9045e7..952be209246a 2021-01-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 256cb7a3..e9fe5946 (841800:841903) 2021-01-10 alessiob@webrtc.org RNN VAD: add missing CPU features to test FC and GRU layers If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: If941ce05129f776a55632aedf514c5b24cab5d45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620587Reviewed-by:
-
Wanming Lin authored
Currently SetTimeout(..., 0) is clamped up to 1ms while which is not supposed to be in the spec. The Speedometer2 performance can boost ~1% on Windows without it based on Pinpoint perf. This CL is intended to fix the DevicePage test that become flaky with https://chromium-review.googlesource.com/c/chromium/src/+/2578703 Flaky test: OSSettingsDevicePageTest.KeyboardTest Fixing it by invoking additional 'flushTasks()' after 'MockInteractions.pressAndReleaseKeyOn' to make sure the 'onKeyUp_()' event in https://source.chromium.org/chromium/chromium/src/+/master:ui/webui/resources/cr_elements/cr_slider/cr_slider.js;l=319 be triggered in time. Bug: 402694 Change-Id: I2bb9c2a3a52861d2d2f3aaf0eff1a5267bc97671 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613715Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#841920}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 88.0.4324.84. R=rmhasan@google.com Bug: 1041619 Change-Id: I0cbee705c0095db4dbb4bc70ecf3634bcb7f8706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620642 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#841919}
-
Weblayer Skew Tests Version Updates authored
This CL will add skew tests for version 87.0.4280.147. R=rmhasan@google.com Bug: 1041619 Change-Id: I47d68abf15ad497530c2aae6cd04da0aa09c1af0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620641 Commit-Queue: Rakib Hasan <rmhasan@google.com> Reviewed-by:
-
Wanming Lin authored
Currently SetTimeout(..., 0) is clamped up to 1ms in Chromium while which is not supposed to be in the spec. The Speedometer2 performance can boost ~1% on Windows without it based on Pinpoint perf. This CL is intended to fix the devtool tests that become flaky with https://chromium-review.googlesource.com/c/chromium/src/+/2578703 Bug: 402694 Change-Id: I1ea3747aa97ea8e40ef8d5e7c3cc997ea687bcd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603037Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#841917}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610294646-d9496012030808fbbd5c6d71395353a15075c9f2.profdata to chrome-linux-master-1610322555-5bf68684dcbb68e2975c9261e4388c601cdf4faa.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If3d36a3689383ba72a1822444e1e2cccea1c0494 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620584Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/31a6a84b0393..f9e9052e7e6f 2021-01-11 miu@chromium.org Fix standalone_sender BUILD.gn for Mac. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I04ed4e57b8228710aa9d4f576db3e89ecb72fd90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620585Reviewed-by:
-
Nancy Wang authored
App dialogs are all system modal to block the user switch to other tasks. Well CL:2398943 change it to the window modal due to the desktop chrome request. App dialogs are only used for Chrome OS, so they should be the system modal. BUG=1163638 Change-Id: I9f32a8c404a13321666a42be61013a3a096570ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617173 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#841914}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/87e735e2e755..ae0631b5a5df If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shimazu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shimazu@google.com Change-Id: Ie63991e8dcc3d3f33ee58314c3535d463d5c1139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620658Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841913}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 64c04f0d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I970b301e758d2b6042110ae807e402165163dba7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619681Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841912}
-
Jinsuk Kim authored
This CL moves the classes for BottomControls MVC component plus its layout xml to chrome/browser/ui/android/toolbar/. Following dependencies on chrome_java were removed: - ShareDelegate - was not in use. - TabGroupUi - split to BottomControlsContentDelegate and extend from it. Bug: 1127732 Change-Id: I40a630eba6924b65a3b90b8ab95f2814dacb70d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2610411 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:Mei Liang <meiliang@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#841911}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/56e9ceb621af..39974fe062b2 2021-01-10 annabelzhou@google.com Added AccessibilityTree web component and toggle switch between If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:887173 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie5921f4bf86cf1f38b8670384f81522b929fc77d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619322Reviewed-by:
-
Kenton Lam authored
Change-Id: I91dd66a2086c615b6bda59bb8f988970801cd937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619121 Auto-Submit: Kenton Lam <kentonlam@google.com> Commit-Queue: John Palmer <jopalmer@chromium.org> Reviewed-by:
John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#841909}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610294646-5cd814ecb87ad7a408cdeda7da36a6886e7402c5.profdata to chrome-win32-master-1610311594-efd75f7a3a70e07e3e92029af80c214e50282c24.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id6469cc3647cf7a439fd32ea87695b63c9d1e25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620505Reviewed-by:
-
- 10 Jan, 2021 19 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ae141f7298b1..87e735e2e755 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I1b738aebd6a5956eea931efd80a3936347720a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620503Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610294646-193d19344cbd53e124bebc9434b6d5bafe44fd51.profdata to chrome-win64-master-1610311594-320b29fe5375389a75bd4c89bfa97b0cd33c2b26.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Id74a0e81b81c0288b532a2508abe823c05542a41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620504Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium f433462a. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I746001051af00d48f3148fa24acbb1e786b9b12e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619680Reviewed-by:
-
Austin Sullivan authored
In ChromeNativeFileSystemPermissionContext::PerformAfterWriteChecks Bug: N/A Change-Id: I2eb2030296dd8607509ce69345264338578d86ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616762 Auto-Submit: Austin Sullivan <asully@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8f282f5d9f30..2199cde1f52b 2021-01-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from b590fd1b9a59 to 51603c63d1cb (43 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: ethannicholas@google.com Test: Test: Test: Capture "World War Doh"Test: Test: angle_perftests --gtest_filter="*world_war_doh*"Test: Test: angle_perftests --gtest_filter=TracePerfTest.Run/*fifa_mobile*Test: Test: angle_perftests --gtest_filter=TracePerfTest.Run/*saint_seiya_awakening*Test: Test: angle_perftests --gtest_filter=TracePerfTest.Run/*world_war_doh* Change-Id: I356834d05790645ba53f6a0dd92114298f57dd74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619037Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I32a8db6f674634f12def4518d2c326aa9e3f22c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619541Reviewed-by:
-
David Van Cleve authored
This is the first of a series of two CLs adding support for slicing Trust Tokens operation outcome metrics by whether an operation is platform-provided (https://bit.ly/platform-provided-trust-tokens). The overall implementation approach is to add a new delegate to TrustTokenRequestIssuanceHelper that it notifies once it discovers a particular operation will be platform-provided; this delegate will be implemented by TrustTokenOperationMetricsRecorder, which will update the names of the metrics it writes to depending on whether the operation at hand is platform-provided. This change refactors refactors OperationTimingRequestHelperWrapper to take a metrics recorder as an input instead of default-initializing one as a member. This allows the child CL, crrev.com/c/2603584, to pass a handle to a MetricsRecorder to TrustTokenRequestIssuanceHelpers it creates before wrapping the RequestIssuanceHelpers in their OperationTimingRequestHelperWrappers. (Before this change, there would be a cyclic dependency: the OperationTimingRequestHelperWrapper and the RequestIssuanceHelper would both need handles to each other. Refactoring MetricsRecorder to be initialized separately from OperationTimingRequestHelperWrapper allows getting around this without needing a kludge like adding an IssuanceHelper::SetDelegate(Delegate*) method.) The child CL will update TrustTokenRequestIssuanceHelper with the new delegate interface and add the new metrics. Bug: 1163019 Change-Id: I2fc40399e48c6b4722a1147633eac678ee960200 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606141 Auto-Submit: David Van Cleve <davidvc@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#841901}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0c2c93a7e95f..ae141f7298b1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ica48e0943b059e6ba9873139afc17163b110e598 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620001Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610290036-f479e5e927d44a0ed32fe3dc594f25c7981710f1.profdata to chrome-win32-master-1610294646-5cd814ecb87ad7a408cdeda7da36a6886e7402c5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7ff7772e7b98e3fb4ca6832ee02c27879903047b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620396Reviewed-by:
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: Ifcde8ede13e482860df9ac560fd51fd6e27abedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620538Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841898}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610279392-c3eef99c17733135d5048f507d85c597521149a0.profdata to chrome-win64-master-1610294646-193d19344cbd53e124bebc9434b6d5bafe44fd51.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I25e18bb1dbed0ff17d09c4e9370609c3f79e55f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619542Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610279392-abbffc99163c3b4c9ea29d27a1e1b6d90ba336a5.profdata to chrome-linux-master-1610294646-d9496012030808fbbd5c6d71395353a15075c9f2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6c903185aabd1b114cc8161b860c865c8edf6592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620393Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f183deebb6e6..0c2c93a7e95f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I42a8bba87435952001fe4f77e5e4dea1006034ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620392Reviewed-by:
-
Danan S authored
The timeout was being cleared when the PostMessageAPIServer was receiving various messages before it received the 'init' message from the guest content. We can't rely on the messages only arriving after an 'init' is received from the guest content. The channel should be considered up and ready from the moment that the *Chrome* side sends its 'init' to the guest content. We also can't rely on the guest content sending only expected messages, since the web app frameworks we use for the guest content generate messages for ui events like scrolling of the guest content, that we do not process. Bug: 1161564 Change-Id: I209d0a23b01dd8553a4ede5dedaff2a98f4f8ec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618621Reviewed-by:
Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Dan S <danan@chromium.org> Cr-Commit-Position: refs/heads/master@{#841894}
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/b07d8724d4e4..e59ae1af7571 2021-01-10 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from f0634ebbb36f to 46237b593c3f (2 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com,enga@google.com Change-Id: I073cb0f66efbe4b7e632cb6472eaee3903bfc310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620386Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610279392-91324c69635fade40a7c8c6e3c1ac92d59c49dd4.profdata to chrome-win32-master-1610290036-f479e5e927d44a0ed32fe3dc594f25c7981710f1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I8c65b1904086242b8cfc96fe9726b6b374ca452d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620381Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/48bdef49061d..f183deebb6e6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I697ac188ddb8517d3619a4c346c0ca852ddc868d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620387Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/569646057afa..48bdef49061d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: Ia985ced3d922a1457a8d483fbccc8272e66393a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620202Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Iabb42cdd8c85b0e1f51a94d0b88dd0fe7a8865d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2619594Reviewed-by:
-
