- 20 Apr, 2018 40 commits
-
-
Bo Liu authored
Instead of base::Process::Terminate. This only makes a difference on Android where "child" processes are not actually forked from the browser process. Browser may or may not have permission to to kill a "child" process. In practice, chrome on android only supports unsandboxed GPU and utility processes (for now) which are in the same uid as the browser, so sending kill signal generally works. Bug: 693484 Change-Id: I830b92b079fa4a52a6c8c7512939ffad2bd72cfb Reviewed-on: https://chromium-review.googlesource.com/1020445Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#552461}
-
Roger Tawa authored
Bug: 820783 Change-Id: If60b92464261fbf6523153f9cab9bba5bbf61dcd Reviewed-on: https://chromium-review.googlesource.com/1022513Reviewed-by:
Wenzhao (Colin) Zang <wzang@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#552460}
-
Michael Thiessen authored
This reverts commit bae94e3a. Found the reason for the perf regressions, was an oversight that caused our glClear to do nothing. Original change's description: > Revert "VR: Implement quad buffer for content quad." > > This reverts commit 1e24d20a. > > Reason for revert: Tanks performance. Quad layers are apparently expensive, yo. > > Original change's description: > > VR: Implement quad buffer for content quad. > > > > Huge thanks to bajones for building the prototype I built this CL > > off of, and for debugging for me ;) > > > > Uses a separate viewport with transform to avoid resampling the > > content quad when drawing it into our scene. The viewport is placed > > underneath the viewport for the other browser UI, and a transparent > > hole is punched through to the underlying viewport. > > > > Also avoids toggling multisampling at runtime (which recreates the > > swap chain) by re-using the two buffers (one multisampled and one > > not) across browsing and webVR modes. > > > > Bug: 714304 > > > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr > > Change-Id: Ibcbb2752aaa957c3f904d4b76bf6dd5fdf9164c8 > > Reviewed-on: https://chromium-review.googlesource.com/1017589 > > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > > Reviewed-by: Ian Vollick <vollick@chromium.org> > > Reviewed-by: Brandon Jones <bajones@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#552212} > > TBR=vollick@chromium.org,mthiesse@chromium.org,bajones@chromium.org > > Change-Id: Iea71c2d624193c5f90c7554ee212d28fb526bcfc > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 714304 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr > Reviewed-on: https://chromium-review.googlesource.com/1021972 > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552333} TBR=vollick@chromium.org,mthiesse@chromium.org,bajones@chromium.org Bug: 714304 Change-Id: Iba87b74983d4b65d2067a8390cf45f4864ebf32a Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr Reviewed-on: https://chromium-review.googlesource.com/1022550Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#552459}
-
Erik Luo authored
Bug: 810176 Change-Id: I03d9cbe50625ad0dd067bbf19502ede59b412b94 Reviewed-on: https://chromium-review.googlesource.com/1020524 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552458}
-
Malay Keshav authored
Enabling the flag for display zoom does not disable or change the ui scale being applied. The same is true for when we disable the display zoom. We do not change or remove the zoom value. This patch disables applying any display zoom when the flag is disabled and disables applying any ui scale when the flag is enabled. Bug: 834950 Change-Id: I07593806f54ee7daf3b5df38023c525501d85a95 Component: Display Manager, ui scale, display zoom Reviewed-on: https://chromium-review.googlesource.com/1020532Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#552457}
-
Donn Denman authored
This reverts commit 721b8605. Reason for revert: Caused a few test failures: testTap and testImageControl. Original change's description: > [TTS] Fix Tap mojo race condition and update tests. > > This CL implements a workaround for the race condition between the mojo > tap notification and the selection-changed notification. Now we never enter > the SELECTION_CLEARED internal state unless there was a previous > selection that got cleared. > > Before this CL every tap caused a transition to the SELECTION_CLEARED > internal state even when there was no previous selection. This would usually > happen before the Tap notification, but now that's faster due to mojo so it > sometimes arrives beforehand. With this change we ignore selection changes > from empty to empty so there's only one notification for most taps. Now we only > enter the SELECTION_CLEARED state when it's really needed (in the tap > near previous selection use-case). > > Also does some minor test cleanup and re-enabling disabled tests that > were flaky. > > BUG=818897 > > Change-Id: I269815ad087aabf93332e99a6c7d1208addabe3e > Reviewed-on: https://chromium-review.googlesource.com/1018300 > Commit-Queue: Donn Denman <donnd@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552439} TBR=donnd@chromium.org,twellington@chromium.org Change-Id: Ic84b636996d182fce0cf630d1255b142f8f7619b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 818897 Reviewed-on: https://chromium-review.googlesource.com/1022670Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#552456}
-
Devlin Cronin authored
ExtensionResourceRequestPolicyTests have been updated to manifest v2. Remove the allowance for manifest v1 extensions. Bug: 816679 Change-Id: I05069412df2ff5bc93cdc6299046b0389e0ad33d Reviewed-on: https://chromium-review.googlesource.com/1022002Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552455}
-
crystallambert@chromium.org authored
This gives sections of the DevGuide a cals to action, removes deprecated API's, and includes more resources. Bug: none Change-Id: I47f55c80310a06383b2df4c1d79223b53dba50d8 Reviewed-on: https://chromium-review.googlesource.com/714361 Commit-Queue: Crystal Lambert <crystallambert@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552454}
-
Xing Liu authored
Currently media gallery API serializes the metadata inside media gallery util service with Chrome extension's idl generated dictionary serializer. Since download will use the service on Android, it can't depend on extension. This CL introduces mojo metadata struct for media gallery util service and does the serialization in chrome extension code outside media gallery util service. Bug: 826021,826975 Change-Id: Iae14d2c443824c826b27a96c2a9aad6de018cb59 Reviewed-on: https://chromium-review.googlesource.com/1002533 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#552453}
-
https://webrtc.googlesource.com/src.git/+log/6847f9b49096..bd7392829a81 $ git log 6847f9b49..bd7392829 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=chromium:b/73147161 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I4bb054ac99a863609538447a7ce41f54b57ad603 Reviewed-on: https://chromium-review.googlesource.com/1022350Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#552452}
-
Tommy C. Li authored
We aren't planning on implementing vertical layout in the near future, so we are removing this flag to simplify the code. Bug: 725599 Change-Id: I2074eb0d9cf99cdf315bbe5cdcd67ef796883865 Reviewed-on: https://chromium-review.googlesource.com/1020079Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#552451}
-
Rohit Rao authored
The BrowsingDataRemoverImpl needs to create a dummy WKWebView in order to remove cookies. The BrowsingDataRemoverImpl also continues to run removal tasks even after it or its BrowserState is destroyed. A completion block was incorrectly referencing an ivar, which turned out to be a garbage pointer in cases where the BrowserDataRemoverImpl had been destroyed before the completion block ran. This CL captures the ivar as a local variable before passing it to the block, avoiding the use-after-free bug. The WKWebView is captured using a strong reference, because we intentionally want it to stay alive until the block completes. BUG=818736 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ic343e0fc1fe48db623245eec4932ceefdf954b70 Reviewed-on: https://chromium-review.googlesource.com/1022031 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552450}
-
Jesse Doherty authored
This reverts commit eace50a8. Reason for revert: Causing failure on win7 browser_tests https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/68573 Original change's description: > Turn the unload controller tests on for fast unload controller > > As the fast unload controller can be used now by command line's switch > it should be tested more. There are lots of tests of the browser's > behavior when the unload controller is used, so they can be easily > reused to check the browser's behavior when the FAST unload controller > is used. > > Change-Id: Ieda101bced3f53ab7678a9f3a5a2ff379c11bb7c > Reviewed-on: https://chromium-review.googlesource.com/1012118 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552337} TBR=avi@chromium.org,creis@chromium.org,aranovskii@yandex-team.ru Change-Id: Ibe190d372f18c3510a3aca02e341b0b801368156 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1022553Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#552449}
-
Ken MacKay authored
Bug: internal b/78206552 Change-Id: I33a0b68fc81aae7682874e0a5370b978e82075c9 Reviewed-on: https://chromium-review.googlesource.com/1020402 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Stephen Lanham <slan@chromium.org> Cr-Commit-Position: refs/heads/master@{#552448}
-
Conley Owens authored
This change removes the Physical Web from NTP snippets. This feature was never enabled on Stable. It only got to M57 Beta. BUG=826540 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4028c97771dfd325e3dd22f8ac57695a07b962c9 Reviewed-on: https://chromium-review.googlesource.com/1015720Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#552447}
-
Daniele Castagna authored
This CL was originally (crrev.com/c/911841) reverted since it broke ARC++ video playback where we initialize the decoder with bind_cb_ set to null. The new patch removes the call to bind_cb_ unconditionally. That's what we want, since we need the client mapping from texture id to GLImage to stay valid for scanout to work. Additionally, unbinding the images doesn't actually free the underlying memory, since the driver texture keeps a reference. The buffers will be freed when either the client textures are freed or a different GLImage is bound. Original description: When GLImages were introduced to v4l2 in crrev.com/c/517883 to replace EGLImages, a scoped ref to a GLImage was added to OutputRecord in place of the EGLImage. This was not necessary since when we bind the GLImage in GLES2 cmd decoder, the decoder increases the ref count and keeps the GLImage alive. Additionally, copying the scoped_refptr<GLImage> in a different thread than it was created, when we associate GLImage to OutputRecords, causes a DCHECK to go off. This CL removes GLImage scoped_refptr from V4L2SliceVideoDecodeAccelerator::OutputRecord. Test: Youtube video on kevin. ARC++ video on kevin Bug: b/73751133 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie5f70db57e2ae1dc906cb8197dc5996651be08db Reviewed-on: https://chromium-review.googlesource.com/1022373 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Kristian H. Kristensen <hoegsberg@chromium.org> Cr-Commit-Position: refs/heads/master@{#552446}
-
Victor Costan authored
https://chromium.googlesource.com/external/leveldb.git/+log/6fa45666703a..d177a0263cce $ git log 6fa456667..d177a0263 --date=short --no-merges --format='%ad %ae %s' 2018-04-17 costan Replace port_posix with port_stdcxx. 2018-04-16 falke.marco Fix sign mismatch warnings in GCC. 2018-04-13 costan Add forgotten <limits> header to util/logging.cc. 2018-04-13 costan Reimplement ConsumeDecimalNumber. 2018-04-13 costan Add tests for ConsumeDecimalNumber. 2018-04-11 costan Document the building process. 2018-04-10 costan Replace NULL with nullptr in C++ files. 2018-04-10 costan Remove PLATFORM_IS_LITTLE_ENDIAN from port/posix.h. 2018-04-09 costan Define LEVELDB_HAS_PORT_CONFIG_H for old compilers. Created with: roll-dep src/third_party/leveldatabase/src Change-Id: Icabf330020abf70e91b00c835d34af070bcea4e2 Reviewed-on: https://chromium-review.googlesource.com/1015774Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#552445}
-
Jonathan Metzman authored
Finish removing fuzzing to fix CHECK failure. Bug: 835177 Change-Id: Ia65d58861a4842cba214eb2dc7bb5e01b8740949 Reviewed-on: https://chromium-review.googlesource.com/1022336Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#552444}
-
Xiaocheng Hu authored
To check whether an InlineBox is an InlineTextBox, the current function to call is IsInlineTextBox() instead of IsText(). This patch changes one caller using IsText(), to fix a bad cast. Bug: 834850 Change-Id: I37acb6234ae60384138074d430a31dac9e6e11a7 Reviewed-on: https://chromium-review.googlesource.com/1019922Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#552443}
-
Erik Chen authored
Bug: 833590 Change-Id: Idde436685e6f5400271c2b850c2740c9ec5c9fb0 TBR: thakis@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1022394Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#552442}
-
proberge authored
Like for inline-installation, the Chrome Web Store should be able to get the full referrer chain of how the user got to the CWS item detail page. This change adds a new API that the CWS (and only the CWS) will be able to call in order to report & detect misleading user acquisition patterns. Note that the SafeBrowsing "download" ping which is sent if the user chooses to install the extension already contains the referrer data. This change effectively allows the CWS to collect the data before the user chooses to install the extension. Bug: 807090 Change-Id: I6b7f85fca75fc134a3d6207cb47a1f3674d15c96 Reviewed-on: https://chromium-review.googlesource.com/1015792 Commit-Queue: proberge <proberge@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#552441}
-
Benjamin Pastene authored
TBR=jbudorick@chromium.org Bug: 835056 Change-Id: I27d45a5b0e80ec9412deaf8574d950924f1e9813 Reviewed-on: https://chromium-review.googlesource.com/1022514Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#552440}
-
Donn Denman authored
This CL implements a workaround for the race condition between the mojo tap notification and the selection-changed notification. Now we never enter the SELECTION_CLEARED internal state unless there was a previous selection that got cleared. Before this CL every tap caused a transition to the SELECTION_CLEARED internal state even when there was no previous selection. This would usually happen before the Tap notification, but now that's faster due to mojo so it sometimes arrives beforehand. With this change we ignore selection changes from empty to empty so there's only one notification for most taps. Now we only enter the SELECTION_CLEARED state when it's really needed (in the tap near previous selection use-case). Also does some minor test cleanup and re-enabling disabled tests that were flaky. BUG=818897 Change-Id: I269815ad087aabf93332e99a6c7d1208addabe3e Reviewed-on: https://chromium-review.googlesource.com/1018300 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#552439}
-
Rohit Rao authored
BUG=818736 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ib36d98ce7d4a89b1384f8ea5169705d7b64a87c9 Reviewed-on: https://chromium-review.googlesource.com/1022370 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#552438}
-
Moe Ahmadi authored
Bug: 834404 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I95e93dfae14271e2cd08a42685b8e3f3ad9ff169 Reviewed-on: https://chromium-review.googlesource.com/1022076Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#552437}
-
Xiaohan Wang authored
This switch supersedes the current SupportExperimentalCdmInterface feature, which is removed in this CL. A library CDM interface is "supported" if it's implemented by CdmAdapter and CdmWrapper. Typically multiple CDM interfaces are supported: - The latest stable CDM interface. - Previous stable CDM interface(s), for supporting older CDMs. - Experimental CDM interface(s), for development. A library CDM interface is "enabled" if it's enabled at runtime, e.g. being able to be registered and creating CDM instances. Typically experimental CDM interfaces are supported, but not enabled. The new switch will override default enabled CDM interface versions, which provides finer control in a test environment or for local debugging, including enabling the support of experimental CDM interfaces. This is in preparation of supporting CDM_10 by default in Chromium, where we need to be able test CDM_9, CDM_10 and potentially CDM_11 with the same set of tests. switch. Bug: 733821 Test: No functionality change. Existing tests updated to use the new Change-Id: I84d79f7b9e63e80434139bedb6d5533baacf8ff0 Reviewed-on: https://chromium-review.googlesource.com/1018726Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Nick Carter <nick@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#552436}
-
Tarun Bansal authored
These histograms were added in a previous CL (http://shortn/_1VKvI480Ld), but I forgot to add them to histograms.xml. Bug: 830088 Change-Id: I8496ee47d11d0e631df46fff3706b3b668bba570 Reviewed-on: https://chromium-review.googlesource.com/1022230Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#552435}
-
khmel@google.com authored
This keeps webview displaying overlay help hidden until new content is loaded. Applied for both, OOBE and in-session OptIn. Test: Locally Bug: 832003 Bug: 821327 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ibc6574f770bbbeb2d33dd042699f0e149256eec8 Reviewed-on: https://chromium-review.googlesource.com/1021841 Commit-Queue: Yury Khmel <khmel@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#552434}
-
xlai authored
Both canvas.toBlob() and OffscreenCanvas.convertToBlob() require support of idle tasks, which are only enabled when threaded compositing is turned on for layout tests. Bug: 831595 Change-Id: If47e0a1c6c6669c24a34424d20020a2969d2a3fc Reviewed-on: https://chromium-review.googlesource.com/1020365Reviewed-by:
Justin Novosad <junov@chromium.org> Commit-Queue: Olivia Lai <xlai@chromium.org> Cr-Commit-Position: refs/heads/master@{#552433}
-
Ken Rockot authored
This reverts commit 523d88f8. Reason for revert: Tests should be fixed now. Original change's description: > Disable flaky services java tests. > > TBR=sky@chromium.org > > Bug: 834288, 833088 > Change-Id: Ide3dc52c89a77be635b1143dcb4c6ae28d3dcb0e > Reviewed-on: https://chromium-review.googlesource.com/1021120 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#552283} TBR=futhark@chromium.org Change-Id: I1168452281fb0331ac7ee9e4cefbd53bef1c3318 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 834288, 833088 Reviewed-on: https://chromium-review.googlesource.com/1022551Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#552432}
-
fr.fang authored
The CL removes the comment in file "components/ntp_snippets/features.h". There are related features with names based on the ArticleSuggestions name. So the CL removes the TODO and leaves the whole code intact. BUG= R=jkrcal@chromium.org Signed-off-by:fr.fang <fr.fang@samsung.com> Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ie6cd5b9409b1ae6e5778e8b6c467d061cf835afe Reviewed-on: https://chromium-review.googlesource.com/989383 Commit-Queue: Filip Gorski <fgorski@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#552431}
-
Chris Mumford authored
Upcoming network servicification changes require that the cookies to be deleted be serializable for transport over IPC. This change converts all net::CookieStore::CookiePredicate's to a structure (net::CookieStore::CookieDeletionInfo). Bug: 823297 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4176e1a0acacd95b165223cebab64c61e2129903 Reviewed-on: https://chromium-review.googlesource.com/996353Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#552430}
-
Kim Paulhamus authored
The message right now assumes mojom::CredentialManager failed, but it could have been mojom::AuthenticatorImpl. Bug: 832910 Change-Id: Ibaca9d938ffe854ab6ee81a3aa56721991e505e6 Reviewed-on: https://chromium-review.googlesource.com/1012967Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#552429}
-
Matthew Jones authored
Since the bottom sheet is now largely per-tab, there is logic that closes the sheet when a new tab is selected or when a page navigates. This handles the cases for intents, making the code that was removed by this patch obsolete. Bug: 833574 Change-Id: Ibe09ce81f96946eeb8980e2a79dbd9db7f56cb6f Reviewed-on: https://chromium-review.googlesource.com/1020061Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#552428}
-
Peter Kotwicz authored
This CL changes the test to navigate to a non-404 URL. This change make the 404 interstitial no longer show. I suspect that the interstitial was causing the test to be flaky. Navigating to a non-404 URL was accomplished by: - specifying the target port via the --host-resolver-rules command line flag - navigating to non-https URLs (navigating to an https URL causes an interstitial about certificate validation to show) This CL introduces a new test WebAPK - "http_webapk" - which has a http scope BUG=834466 Change-Id: I9e9dda7079e3bf2fb62f57d2ecf3ccaad5dbd10d Reviewed-on: https://chromium-review.googlesource.com/1020229Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#552427}
-
Stephen Martinis authored
Adds --zero-tests-executed-ok, which makes the layout test runner exit with an ok status if zero tests are executed. This is important for re-running layout tests without patch, which we do on tryservers to check if the test was being flaky. Bug: 533481 Change-Id: I7d6bcd805b99818fdf82ecb88e71863ff72b72e7 Reviewed-on: https://chromium-review.googlesource.com/1018590Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Jeff Carpenter <jeffcarp@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#552426}
-
Eugene But authored
Bug: 835342 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I1c5ae21731c6b5b339591f44926ad0a5769578ae Reviewed-on: https://chromium-review.googlesource.com/1022182 Commit-Queue: Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#552425}
-
Evan Stade authored
This allows us to get rid of an ugly priority promotion hack used for download notifications on Chrome OS. On platforms with a message center bubble (Chrome OS), web notifications that don't specify renotify won't pop up again if the original popup was dismissed. On platforms without a message center bubble (Linux, Windows when using non-native notifications), all notifications will pop up again on update. Bug: none Change-Id: I6a00b21348335b29a97a78a603c03a31ae8e5452 Reviewed-on: https://chromium-review.googlesource.com/976545Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#552424}
-
Devlin Cronin authored
The ExtensionFunction::GetAssociatedWebContentsDeprecated() method is unpredictable and can return surprising values in certain circumstances. It is deprecated and should be removed to ensure that callers are using the WebContents they expect. Update the easyUnlockPrivate API to use GetSenderWebContents() instead. Bug: 461394 Change-Id: I1ba338c4c551b94ab8c21d5f642cf203383aea8a Reviewed-on: https://chromium-review.googlesource.com/1022122Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#552423}
-
Sadrul Habib Chowdhury authored
The tests have not been very useful, and has remain disabled on a number of bots for a while. So stop running the tests on the perf bots altogether. The tests can still be used locally to watch for improvements/regressions for specific changes as desired/needed. BUG=784454, 721757, 736150 BUG=698831, 792995, 723821 Change-Id: Ifede89a3f7a87d96bbb726e0911e1df26e6f9a6b Reviewed-on: https://chromium-review.googlesource.com/1021653Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#552422}
-