- 06 Dec, 2019 40 commits
-
-
Anand K. Mistry authored
Also add a host encapsulation class, and a helper class for performing the actual mount operation. Bug: 939235 Change-Id: I2e8af1c88fe59d190d41b31d8b7060be6fdb0e08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923868 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#722378}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I5aba229b433d9c2a30afd77e4761793b3e0db2f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954642Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722377}
-
Felicia Lim authored
Cherry-picked from https://git.xiph.org/?p=opus.git;a=commit;h=8493bf5 Bug: webrtc:11139 Change-Id: I5c3129b68b605fd557d40446d4a0313b3cc98ea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949065Reviewed-by:
James Zern <jzern@google.com> Commit-Queue: Felicia Lim <flim@chromium.org> Auto-Submit: Felicia Lim <flim@chromium.org> Cr-Commit-Position: refs/heads/master@{#722376}
-
Kurt Horimoto authored
- Exposes size(). - Exposes indexed access via GetRequest() and array bracket syntax. - Allows insertions at any index. This also required updating logic in OverlayPresenterImpl in order to correctly trigger dismissals if the presented request was replaced. Bug: 1030357 Change-Id: If1d8d076d881e75dec24fd011a4b3ce1612712b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952099 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#722375}
-
Vikas Soni authored
Vulkan uses VkSamplerYcbcrConversion struct which needs the chromaFilter and formatFeatures information. Update the chromaFilter based on the bits set in formatFeatures as per the vulkan spec. Bug: 991291 Change-Id: I598219ec3fb851957447da00fb1f1fd2934fb1f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954708 Commit-Queue: vikas soni <vikassoni@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722374}
-
Ken Rockot authored
This is a reland of a4d27f51 The reland moves the TestingApi binder support into a component library to avoid duplicate definitions that resulted in browser test failures in component builds. Original change's description: > Move Audio Service off Service Manager > > All the details around if/when a service instance is started and whether > it's in- or out-of-process have been centralized into the implementation > of a single GetAudioService() helper in Content. > > A few other helpers are added to ease the transition off the Service > Manager, though they aren't necessarily ideal APIs. For example, > client library APIs which once took a Service Manager Connector may now > take a RepeatingCallback to bind a specific type of interface. > > In addition to GetAudioService(), Content provides helpers for > AudioSystem construction and StreamFactory binding from any sequence. > > Because all timeout/lifetime management logic is now generically > supported within Mojo and Content and requires no service implementation > details to get right (and because unit tests launching service processes > is no longer supported outside of Content), all Audio Service test > coverage relevant to lifetime management is deemed superfluous and has > been removed. > > Bug: 977637 > Change-Id: I4c59948eafce2322547bf2b0479961e095b3edee > Tbr: oshima@chromium.org > Tbr: guidou@chromium.org > Tbr: vollick@chromium.org > Tbr: xiaohuic@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941280 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#721832} Bug: 977637 Change-Id: I183e79042c99458f2abf9423d8f9bbefedf5b374 No-Presubmit: true Tbr: oshima@chromium.org Tbr: guidou@chromium.org Tbr: vollick@chromium.org Tbr: xiaohuic@chromium.org Tbr: avi@chromium.org Tbr: rsesek@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952601Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#722373}
-
Jeevan Shikaram authored
App Management was not filtering out based on the readiness of kUninstalledByUser. This caused uninstalled apps to be shown in the app list. This CL fixes this problem. Bug: 1030480 Change-Id: I7091e9cad23eebf5211bab37f7220e2bf1ca2457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953239 Auto-Submit: Jeevan Shikaram <jshikaram@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org> Cr-Commit-Position: refs/heads/master@{#722372}
-
Alex Danilo authored
The display panel is the container for progress, summary and error panel items. The box shadow that surrounds the contained entries should be invisible when there is no child content, and hence, no size. Change the 'spread' for the CSS box-shadow to stop it drawing when there is no child content. Bug: 1031394 Change-Id: If8573547f1b50b70327797a76663edfdb566eac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953238Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#722371}
-
Ricky Liang authored
This CL handles the calls to SharedImageInterface() and CreateGpuMemoryBuffer() when they return nullptr in some corner cases. Bug: 982201 Bug: b:144805331 Change-Id: Ic7340aeb7fb733806c29407ae2d86a66a71240ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950373 Commit-Queue: Ricky Liang <jcliang@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#722370}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=hashimoto@chromium.org Bug: 891670 Change-Id: I046b6ca92574c6de264971678ee890dfa6b5df3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945809Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Auto-Submit: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#722369}
-
chrome://media-appTrent Apted authored
To test the full flow via platform_util::OpenItem(path-on-disk), the file_manager code needs to be able to map it to a valid, mounted volume to provide a filesystem:// URL. This CL achieves that with a helper test class that owns a folder inside MyFiles that is passed to VolumeManager::RegisterDownloadsDirectoryForTesting() The end-to-end test now tests everything from platform_util::OpenItem(path) until the image file is loaded into the chrome://media-app interface. Bug: 1023742 Change-Id: I4971d555da2eaef88cd8743de72b1ab9d9532595 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951264 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#722368}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e15a8a703b3e..3eb4d5bb62e0 Created with: gclient setdep -r src-internal@3eb4d5bb62e0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie551d7f3f5c9f0198cea44332f1a2fbd14eebe51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954265Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722367}
-
Peter Kotwicz authored
BUG=1031065 Change-Id: I8da0b5e620913b872a9363f1729c030546dde3e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953696Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#722366}
-
Tim Song authored
TEST=manually verified with --whitelisted-extension-id BUG=996079 Change-Id: I7270097752736ad99a911be63495b0578f6190e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951561Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Gustavo Sacomoto <sacomoto@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#722365}
-
Mounir Lamouri authored
Bug: 1028264 Change-Id: I98acba2acfc95f7e4ff64c1ce942a0220e287e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933202 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#722364}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/22bb298bec7a..447ab8a42a5b git log 22bb298bec7a..447ab8a42a5b --date=short --first-parent --format='%ad %ae %s' 2019-12-06 dberris@chromium.org Fix userdata parsing 2019-12-06 fancl@chromium.org Add tests for SheriffConfigClient Created with: gclient setdep -r src/third_party/catapult@447ab8a42a5b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1031037,chromium:953181 Tbr: oysteine@google.com Change-Id: I78e03d3a24cbf3a9e820fb77e20077c9bc6ae199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954264Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722363}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3b9bf9564607..9cec36038932 git log 3b9bf9564607..9cec36038932 --date=short --first-parent --format='%ad %ae %s' 2019-12-06 primiano@google.com Delete SanitizerTests.TSAN_ThreadDataRace Created with: gclient setdep -r src/third_party/perfetto@9cec36038932 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:144688853 Tbr: perfetto-bugs@google.com Change-Id: I54aaf8589e1154aa67a47b77f0a55e32949398f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954267Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722362}
-
Brian Sheedy authored
Updates the VR browser data URL golden images. The security token icon was recently updated to be a warning triangle instead of an "i" in a circle. TBR=alcooper@chromium.org Change-Id: Iafebbb86ca660be5a92c8202431f06001e7afd0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954881Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#722361}
-
Dominic Farolino authored
The crash being investigated in crbug.com/1021908 is resolved, so we can re-inline the request's referrer serialization. R=kinuko@chromium.org, yhirano@chromium.org Bug: 1021908 Change-Id: I84ee6f23ef0b7eaad20ded7bbdbe1752d3a52ead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954211Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#722360}
-
Ahmed Fakhry authored
If Alt-Tab ends resulting in changing the active window, and the user had 2 or more desks, the desks distance is reported. A distance of 0 means no desks switch occurred. BUG=1023445 Change-Id: If6ee23126393c9abb136bf638ac8fca8ef9e1493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951980 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#722359}
-
Chris Lu authored
This change ensures that any change in the source/target language by the user in the Infobar modal will be saved and changed in the InfobarTranslateDelegate right before executing a new Translate. It also cleans up some logic to ensure that the correct new language is always displayed in the modal and also the correct new language is checked in the LanguageSelectionViewController. Bug: 1014959 Change-Id: I4bd40c1b916e0479d551bd5962231916a04a920d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952424 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#722358}
-
Karolina Soltys authored
BUG=1001087 Change-Id: I5ae2a96ce978864e857c03ccc306019276fdebf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1840653 Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#722357}
-
Mounir Lamouri authored
When a favicon is available but no artwork is available through the Media Session API, the favicon primary colour is used for the background colour of the media notification. Bug: 1028822 Change-Id: I7c70d7e215c6352f65bc95a6754082381d7c5feb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937785Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#722356}
-
Jason Chase authored
In crrev.com/c/1932241, origin trials could now be enabled in insecure contexts. The secure context restriction could only be removed by by hard-coding trial names in a function. This CL adds support to configure a trial for insecure contexts via settings in runtime_enabled_features.json5. It introduces two settings: 1) origin_trial_type 2) origin_trial_allows_insecure Only "deprecation" trials can be used in insecure contexts, and this CL includes validation to ensure trials are configured appropriately. Bug: 1027546 Change-Id: I7e83dd2caa07c0ccf799b945eeafa49905b8c188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946847Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#722355}
-
Nate Fischer authored
This documents how to see log messages in tests. This includes robolectric unit tests, which handles logging differently than on-device tests. This also notes that robolectric tests do not require a device, since the top of the doc says ""except where otherwise noted, all tests require a device or emulator. Bug: 918221 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: Ib810c2417b7579f46816438e722637af730d0f1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1955066Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#722354}
-
Daniel Cheng authored
base::Hash() is deprecated and is being replaced by base::FastHash(). The output of base::FastHash() is only fixed within the lifetime of a single process, so if the code depends on the mapping of inputs to hash outputs not changing over time, base::PersistentHash() must be used instead. Bug: 1025358 Change-Id: Idfa61dfb3162d8d5ff40e7ee7a18cf1813570b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952554Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#722353}
-
Kenichi Ishibashi authored
ServiceWorkerStorage::DidGetAllRegistrationsInfos() should set navigation preload flag and header size so that chrome://service-worker-internals shows these information correctly when registrations are read from the storage. Bug: 1030263 Change-Id: I1226aa5cb53c4a94027c417647bb41f35d58e8c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954808 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#722352}
-
Xianzhu Wang authored
Bug: 696842 Change-Id: I30e1e8162fcd4e362c10c98e589b7b4c409febec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816578Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#722351}
-
Yuri Wiitala authored
Includes changes to Chromium-side platform glue code to accommodate API changes. Also, a few IWYU fixes and `git cl format` run. https://chromium.googlesource.com/openscreen/+log/1ab48f99911c..2b02e3287584 $ git log 1ab48f999..2b02e3287 --date=short --no-merges --format='%ad %ae %s' 2019-12-03 miu Flatten namespace for platform/ code: opescreen::platform → openscreen 2019-12-03 miu Remove Abseil use from platform/api and platform/base. 2019-12-03 jophba Enable fuzzing outside of Chrome 2019-12-02 btolsch Add connection namespace handling 2019-11-20 jophba Implement ReceiverSession offer handling Created with: roll-dep src/third_party/openscreen/src Bug: openscreen:88, openscreen:90 Change-Id: I40071a391158862b73fb42d5c1f67d8c49f45e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1951419Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Yuri Wiitala <miu@chromium.org> Cr-Commit-Position: refs/heads/master@{#722350}
-
Rob Schonberger authored
This will not be neccessary in the future, but is needed for making sure that folks on device not in experiment can set neural flag on/off reliably. Adds the relevant DeviceCapabilities captured from basking. Bug: 1009290 Change-Id: I9b54c8c16efc30eb476ac7c6607992c7d14fddbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950368Reviewed-by:
Sean O'Brien <seobrien@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Rob Schonberger <robsc@chromium.org> Cr-Commit-Position: refs/heads/master@{#722349}
-
James Vecore authored
Localization of the proxy connection types were too big to fit in the select box. A local style override was added to widen the select box size. Fixed: b/145304792 Change-Id: I1a60c491d543de7f58e5edfdeb63d56d7c224f71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954852Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#722348}
-
Daniel Cheng authored
Bug: 742517 Change-Id: I6c7785d85d0e1c86b2bf5616db94268ea19d1c62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950045Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#722347}
-
Aga Wronska authored
Bug: 1015661 Test: PerAppTimeLimitsTest Change-Id: Id733885b80730fcb9bdb84ca5d43ce1da2c8212b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953926 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#722346}
-
Jun Mukai authored
I got notified about some tab-dragging tests are flaky, and the reason turned out to be TopControlsSlideController; this allows to slide out the top-controls (i.e. tabstrip) on tablet mode on certain situation. However, it looks like, on entering into the tablet-mode, this controller is activated, and sets 'shown ratio' to 0 (meaning invisible), and then sets to 1 immediately. Sometimes the test scenario runs between them, which means the top controls are positioned out of the screen, and therefore tab-dragging hasn't started, and the test crashes. This CL adds a method to BrowserView for testing which suppresses the TopControlsSlideController itself. With that, the top controls will never be hidden. Bug: 1031075 Test: release build of interactive_ui_tests, passes all 20 runs Change-Id: Ibdd5ac622533692802ecc17f3364c2e8cb20e4ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954362Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#722345}
-
Chih-Yu Huang authored
The build condition of //media/gpu/chromeos is either Vaapi or V4L2 is used. Both API are only available at linux platform, so actually the build condition imply the OS is linux. This CL add the assertion at BUILD.gn, and remove the build flag inside the code. Bug: 1012587 Test: ninja chrome on Eve and Linux Change-Id: Icd9b16dc7af9c82bdf2a405da2bbdcb54c6277d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952626 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#722344}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/dd4e75afd290..02a82546e547 git log dd4e75afd290..02a82546e547 --date=short --first-parent --format='%ad %ae %s' 2019-12-05 thestig@chromium.org Fix botched merge of https://crrev.com/688711 for PartitionAlloc. 2019-12-05 thestig@chromium.org Roll third_party/instrumented_libraries/ b1c3ca208..4dca59c6a (7 commits) 2019-12-05 thestig@chromium.org Update PartitionAlloc from Chromium at r721710. 2019-12-05 thestig@chromium.org Roll third_party/zlib/ f4f46747b..f262c1b3c (5 commits) 2019-12-05 thestig@chromium.org Roll third_party/depot_tools/ 79d4f9950..fe18a43d5 (62 commits; 14 trivial rolls) 2019-12-05 thestig@chromium.org Update PartitionAlloc from Chromium at r709322. 2019-12-05 thestig@chromium.org Use more size_t in CPDF_CryptoHandler. 2019-12-05 thestig@chromium.org Roll third_party/catapult/ 3992f6564..32775164b (119 commits) Created with: gclient setdep -r src/third_party/pdfium@02a82546e547 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pdfium-autoroll Please CC pdfium-deps-rolls@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: pdfium-deps-rolls@chromium.org Change-Id: I97c7e4e12e2d61236b5a0f587514062587ba699c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954529Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#722343}
-
Connie Wan authored
See the inline comment and the attached bug for the case that this is handling. I suspect this would be extremely rare but possible, especially as we extend support to extensions post-MVP. I opted with no-oping in this case, since I think any side effects are likely to be unintended. Bug: 922736 Change-Id: Ie295416563c2338c0b3638ae630499814d2c8e69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954005Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#722342}
-
John Lee authored
Bug: 1023492 Change-Id: I0d97aae6000c90ef08f742cc80467fdb91c05ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954229 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#722341}
-
Li, Hao authored
Both WebGLVideoTexture and video-rAF refer to video frame metadata, so rename it to VideoFrameMetadata and use the IDL under third_party/blink/renderer/modules/video_raf. Bug: 776222 Change-Id: I5d8bf616a82c054a9c78f4087344b5e0ce654c00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1923497Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Hao Li <hao.x.li@intel.com> Cr-Commit-Position: refs/heads/master@{#722340}
-
Joshua Peraza authored
359fc4a1336d [Windows] Add checks for DLL loader lock 9a312ddff5fa Increase kAllowedOffset for non-optimized build e01fb92aa9a9 Fix #elif in crrev.com/c/1949846 6b81e8173fa3 Removes the obsolete cq.cfg file c9f089eee409 linux: update lss bcab7ad54c2e linux: handle large mapped files Change-Id: Ia4be884ad545e134ee41e908c5d0a99f2e3d7abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954932Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#722339}
-