GitLab

This will make it easy to tell when the main thread is busy decoding
webfonts.

BUG=none

Review URL: https://codereview.chromium.org/1161923003

git-svn-id: svn://svn.chromium.org/blink/trunk@200627 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves spell checker related files into "core/editing/spellcheck/"
directory to reduce number of files immediately under "core/editing/" for ease
of working these files as same as issue 448772, which moves iterator related
files into "core/editing/iterators/".

Moved files:
 - SpellCheckRequest.{cpp,h}
 - SpellChecker.{cpp,h}
 - TextCheckingHelper.{cpp,h}

BUG=509527
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1287263004

git-svn-id: svn://svn.chromium.org/blink/trunk@200625 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink r200483 (increased apache threads) seems to have fixed this.

BUG=518982

Review URL: https://codereview.chromium.org/1293063002

git-svn-id: svn://svn.chromium.org/blink/trunk@200623 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change updates the node description label to match updated tooltip
UI. These labels have the following characteristics:
- Default to above the anchor element
- Centered above the anchor element
- Clamped to the visible viewport (no change)
- Non monospace font to improve text readibility
- Removal of "px" in dimensions

This change is behind the material experiment.

BUG=513066

Review URL: https://codereview.chromium.org/1286483003

git-svn-id: svn://svn.chromium.org/blink/trunk@200622 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Fix flaky crash in WebPagePopupImpl::closePopup. (patchset #1 id:1 of https://codereview.chromium.org/1291303002/ )

Reason for revert:
Caused another issue.


Original issue's description:
> Fix flaky crash in WebPagePopupImpl::closePopup.
> 
> Reentrance to WebViewImpl::closePagePopup is possible.  closePopup crashed in
> that case because m_page was valid and m_page->mainFrame() was nullptr.
> 
> The details:
> If WebViewImpl::closePagePopup is called, and the LocalFrame in the page popup
> has the last references to the page popup owner Element,
>  1. WebPagePopupImpl::closePopup() calls destroyPage().
>  2. destroyPage() calls Page::willBeDestroyed().
>  3. willBeDestroyed() destructs the LocalFrame.
>  4. The LocalFrame destructor destructs the owner Element.
>  5. The owner Element destructor destructs PickerIndicatorElement.
>  6. PickerIndicatorElement destructor calls WebViewImpl::closePagePopup().
> 
> This CL changes WebViewImpl::closePagePopup() so that m_pagePopup is cleared
> before calling WebPagePopupImpl::closePopup() to avoid reentrancy to it.
> 
> BUG=454043
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200528

TBR=keishi@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=454043

Review URL: https://codereview.chromium.org/1297883002

git-svn-id: svn://svn.chromium.org/blink/trunk@200621 bbb929c8-8fbe-4397-9dbb-9b2b20218538

NaCl's system page size is 64 KB. This causes a problem in Oilpan's heap layout
because Oilpan allocates two guard pages for each blink page (whose size is 128 KB).
After a couple of discussions, we decided not to use guard pages in NaCl.

This CL adds a flag to change the guard page size to 0.
It will be used by NaCl in a follow-up CL.

BUG=

Review URL: https://codereview.chromium.org/1297873002

git-svn-id: svn://svn.chromium.org/blink/trunk@200620 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- pause-remove-from-document-networkState.html and selection.html are
  just slow.
- 047.html and 048.html are not slow.

TBR=kochi@chromium.org
BUG=490511

Review URL: https://codereview.chromium.org/1297673007

git-svn-id: svn://svn.chromium.org/blink/trunk@200619 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I landed a CL (https://codereview.chromium.org/1276003003/) which fixes system
font problems on OSX 10.9 and OSX 10.10. The CL also fixed MatchNSFontFamily()
to correctly return the system font on 10.11, but this causes glyph rendering
problems. In the short term, I'm adding logic to MatchNSFontFamily() to return
nil on 10.11, which was the original behavior before I landed that CL.

BUG=521034

Review URL: https://codereview.chromium.org/1284993004

git-svn-id: svn://svn.chromium.org/blink/trunk@200618 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes Heap::s_heapSizePerPersistent and instead introduces
Heap::s_markedObjectSizeAtLastCompleteSweep.

This is a preparation CL for landing https://codereview.chromium.org/1272083003/.
This CL is just code refactoring and shouldn't change any GC heuristics.

BUG=475801

Review URL: https://codereview.chromium.org/1297493002

git-svn-id: svn://svn.chromium.org/blink/trunk@200617 bbb929c8-8fbe-4397-9dbb-9b2b20218538

enabled property should be cleared on InspectorState when DOMDebugger gets disabled.

BUG=521036,521106

Review URL: https://codereview.chromium.org/1285133005

git-svn-id: svn://svn.chromium.org/blink/trunk@200616 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Introduced by r200510.

BUG=521152

Review URL: https://codereview.chromium.org/1293023002

git-svn-id: svn://svn.chromium.org/blink/trunk@200614 bbb929c8-8fbe-4397-9dbb-9b2b20218538

See https://codereview.chromium.org/1291623002/ for the reasoning.
Also allow kFooBar names in enums.

BUG=none

Review URL: https://codereview.chromium.org/1290803002

git-svn-id: svn://svn.chromium.org/blink/trunk@200613 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds the plumbing for slimming paint phase 2's compositing
algorithm. The basic idea is to move compositing after painting. This
patch has the plumbing for two prerequesites to support that change:
1) A hook has been added so the merge algorithm can update a
DisplayItemDiff structure.
2) A step for property tree building has been added during the
compositing step.

The full design can be found at:
https://docs.google.com/document/d/1qF7wpO_lhuxUO6YXKZ3CJuXi0grcb5gKZJBBgnoTd0k/view

This patch is an updated version of Chrishtr's initial implementation
in https://codereview.chromium.org/1238123004 except the display list
API has not been implemented.

BUG=481592

Review URL: https://codereview.chromium.org/1287093004

git-svn-id: svn://svn.chromium.org/blink/trunk@200612 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This changes the following:
* win10 is now the primary win port version.
* win7 baselines are placed in win7/ instead of win/
* Baseline directory search path is now xp -> win7 -> win8 -> win


BUG=496259

Review URL: https://codereview.chromium.org/1294603002

git-svn-id: svn://svn.chromium.org/blink/trunk@200611 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=507335

Review URL: https://codereview.chromium.org/1290693003

git-svn-id: svn://svn.chromium.org/blink/trunk@200610 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=393155

Review URL: https://codereview.chromium.org/1296573002

git-svn-id: svn://svn.chromium.org/blink/trunk@200609 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=474470

Review URL: https://codereview.chromium.org/1301463002

git-svn-id: svn://svn.chromium.org/blink/trunk@200608 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=200605

BUG=449197
TBR=fmalita@chromium.org

Review URL: https://codereview.chromium.org/1294993002 .

git-svn-id: svn://svn.chromium.org/blink/trunk@200607 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For the Platform object used by ResourceTest, add required
override of getTraceCategoryEnabledFlag(). Needed following
the addition GC tracing in Blink r200146.

R=haraken
BUG=521230

Review URL: https://codereview.chromium.org/1292983003

git-svn-id: svn://svn.chromium.org/blink/trunk@200606 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rework DragImage using the SkImage API. Significant bits:

* get rid of Image::deprecatedBitmapCurrentFrame callers, convert to Image::imageForCurrentFrame

* consolidate the currently distinct DragImage passes (create, fitToMaxSize, dissolveToFraction)
  into a single pass (this can avoid several unneeded copies)

* implement the above using Skia SkSurface/SkCanvas primitives (instead of ImageOperations::Resize
  and direct pixel RAM poking)

* avoid unneeded rasterization in LocalFrame::paintIntoDragImage() - return an
  SkPictureImageGenerator-backed Image instead

* also remove an unneeded clip and related plumbing in LocalFrame::paintIntoDragImage()

BUG=449197
R=reed@google.com,junov@chromium.org

Review URL: https://codereview.chromium.org/1290133002

git-svn-id: svn://svn.chromium.org/blink/trunk@200605 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=463547

Review URL: https://codereview.chromium.org/1292943002

git-svn-id: svn://svn.chromium.org/blink/trunk@200604 bbb929c8-8fbe-4397-9dbb-9b2b20218538

dataReceived() can be called reentrantly if it triggers a nested message
loop when detaching a Document or parsing script for the new Document.
Since dataReceived() isn't safe for reentrancy, any nested invocations
queue the received data to be processed by the top-level invocation of
dataReceived().

BUG=515876

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200436

Review URL: https://codereview.chromium.org/1263363005

git-svn-id: svn://svn.chromium.org/blink/trunk@200603 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're about ready to try making this behavior 'stable'.  To help flush out
issues in advance of that, promote it to 'experimental'.

BUG=157855

Review URL: https://codereview.chromium.org/1216953003

git-svn-id: svn://svn.chromium.org/blink/trunk@200602 bbb929c8-8fbe-4397-9dbb-9b2b20218538

DocumentLifecycle::canAdvanceTo has a large switch statement which
isn't immediately clear if you fail to notice that "state" is not the
current state.

Review URL: https://codereview.chromium.org/1296763003

git-svn-id: svn://svn.chromium.org/blink/trunk@200601 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=dgozman

Review URL: https://codereview.chromium.org/1298503003

git-svn-id: svn://svn.chromium.org/blink/trunk@200600 bbb929c8-8fbe-4397-9dbb-9b2b20218538

UNSIGNED_SHORT and SHORT can be supported in glReadPixels in WebGL 2, see Table 4.5 
in GLES 3.0 spec: https://www.khronos.org/registry/gles/specs/3.0/es_spec_3.0.3.pdf

BUG=295792

Review URL: https://codereview.chromium.org/1288303002

git-svn-id: svn://svn.chromium.org/blink/trunk@200599 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of pretending it's a struct, let's make it a real class,
with functions that help along the commont usage patterns at the
callsites.

R=yoav@yoav.ws
BUG=

Review URL: https://codereview.chromium.org/1287783003

git-svn-id: svn://svn.chromium.org/blink/trunk@200598 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This feature has been deprecated in Filter Effects level 1:
http://dev.w3.org/fxtf/filters/#AccessBackgroundImage

BUG=507615

Review URL: https://codereview.chromium.org/1286973002

git-svn-id: svn://svn.chromium.org/blink/trunk@200597 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No code was changed.

Review URL: https://codereview.chromium.org/1285213005

git-svn-id: svn://svn.chromium.org/blink/trunk@200596 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There should only be one code path the runs the blink pipeline.
Having multiple code paths means we mess up and end up with
multiple pipelines. At the moment, there's a security bug here
because only the updateLifecyclePhasesInternal code path has
a FrameView protector.

Review URL: https://codereview.chromium.org/1272143003

git-svn-id: svn://svn.chromium.org/blink/trunk@200595 bbb929c8-8fbe-4397-9dbb-9b2b20218538

HTMLImageElement::width/height were not updating layout first before
checking for the layoutObject() which means that we fall back to the
attribute when we shouldn't. We're also using the updateLayout method
instead of updateLayoutIgnorePendingStylesheets which should be used
for all JS APIs. Finally I deleted the unused boolean argument to the
methods.

We also make sure to check if we're in the document before causing a
layout so checking for a disconnected image's width/height before
drawing to a canvas doesn't cause a sync layout.

Review URL: https://codereview.chromium.org/1299563002

git-svn-id: svn://svn.chromium.org/blink/trunk@200594 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add ortuno and me to the Web Bluetooth owners files so we can make progress during scheib vacations.

Review URL: https://codereview.chromium.org/1297843002

git-svn-id: svn://svn.chromium.org/blink/trunk@200593 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=pfeldman
BUG=520483

Review URL: https://codereview.chromium.org/1300483002

git-svn-id: svn://svn.chromium.org/blink/trunk@200591 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=yurys

Review URL: https://codereview.chromium.org/1293903002

git-svn-id: svn://svn.chromium.org/blink/trunk@200590 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch rolls CodeMirror javaScirpt mode to the latest @7c3fb566
(tip-of-tree) version.

The new javascript mode will fix troubles with highlighting unicode
variables.

BUG=520521
TBR=pfeldman

Review URL: https://codereview.chromium.org/1296733002

git-svn-id: svn://svn.chromium.org/blink/trunk@200589 bbb929c8-8fbe-4397-9dbb-9b2b20218538

imported csswg-test@6c7dfbcd6bb33092c4668bbb781592ba2498fa1e
imported web-platform-tests@5467daf5acb707ed07f664f37b0962a48460d190

* 2 new directories skipped:
  web-platform-tests/editing/
  web-platform-tests/selection/

* Some new crashes added to TestExpectations (could be flaky):
  web-platform-tests/html/semantics/
  web-platform-tests/shadow-dom/

TBR=dpranke@chromium.org,jsbell@chromium.org,tkent@chromium.org,hayato@chromium.org,kochi@chromium.org
BUG=492664, 519997, 490511, 505364, 517836, 492664, 514645

Review URL: https://codereview.chromium.org/1295773004

git-svn-id: svn://svn.chromium.org/blink/trunk@200588 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After r200515 we no longer start producing frames until the stylesheets
have loaded which means we will never attempt to paint with pending
sheets so we don't need the FOUC avoidance code that paints white. Lets
remove it.

See: https://src.chromium.org/viewvc/blink?revision=200515&view=revision

Review URL: https://codereview.chromium.org/1297803002

git-svn-id: svn://svn.chromium.org/blink/trunk@200587 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=521057

Review URL: https://codereview.chromium.org/1295523004

git-svn-id: svn://svn.chromium.org/blink/trunk@200586 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Instead of requesting scripts through Page.getResourceContent, we should
use Debugger.getScriptSource or CSS.getStylesheetTest.

NetworkProject already does that.

A couple of race fixes along the way because of changed timings.

BUG=none

Review URL: https://codereview.chromium.org/1238103002

git-svn-id: svn://svn.chromium.org/blink/trunk@200585 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Having this in a separate method just encourages duplicate checks like
the NULL check here, and the local root frame check which are both not
needed. Move this into the only caller so the sequence of steps when
updating the lifecycle phases is more clear.

Review URL: https://codereview.chromium.org/1288613004

git-svn-id: svn://svn.chromium.org/blink/trunk@200584 bbb929c8-8fbe-4397-9dbb-9b2b20218538