- 04 Jan, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ebf0d23ee62e..51771a7cad87 git log ebf0d23ee62e..51771a7cad87 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 perezju@chromium.org [telemetry] Remove TimelineBasedPageTest from record_wpr.py Created with: gclient setdep -r src/third_party/catapult@51771a7cad87 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:851948 TBR=sullivan@chromium.org Change-Id: Idb1dee30b43f183728970cdb5b1b6a9cb905b442 Reviewed-on: https://chromium-review.googlesource.com/c/1395729Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619905}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2bfcc8d6a43e..399f17e09b4a Created with: gclient setdep -r src-internal@399f17e09b4a The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8a98e3c936774ad05393147635bca6a1cb700ccd Reviewed-on: https://chromium-review.googlesource.com/c/1395728Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619904}
-
Henrik Boström authored
The file is still marked as flaky due to https://crbug.com/919035. If this still flakes we should add [ Pass Failure Timeout ] to both "track-stats" lines of the TestExpectations file and investigate in the referenced bug. TBR=hta@chromium.org Bug: 919035 Change-Id: Ief45b6504db40874439c4966eabf0e65d4363ae2 Reviewed-on: https://chromium-review.googlesource.com/c/1396117Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#619903}
-
Shu Chen authored
BUG=919011 Change-Id: I0f4d83244dabb164a345f1239e6bd9982dfe9cff Reviewed-on: https://chromium-review.googlesource.com/c/1391657 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#619902}
-
Colin Blundell authored
After https://chromium-review.googlesource.com/c/chromium/src/+/1390012, SigninErrorController is now layered on top of signin internals code rather than being part of it. This CL accordingly move it out of the signin_internals GN target back into the browser target that is layered on top of it. I verified that making this change did not remove any dependencies from the signin_internals target (that would have been a nice side-benefit). Bug: 917836 Change-Id: I5dc4947722c6183c91d3cee3225404919bd4b21a Reviewed-on: https://chromium-review.googlesource.com/c/1391671Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#619901}
-
Arthur Hemery authored
Another unit test now uses NavigationSimulator. Bug: 728571 Change-Id: I36254912d9c04d16103f3cbf0b156dc92400c6df Reviewed-on: https://chromium-review.googlesource.com/c/1393324 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#619900}
-
Maxim Kolosovskiy authored
TODO: Measure the performance of the button titles heuristics and consider optimisations. Bug: 910546 Change-Id: Ic54111a4d8613578e216bd75deeeb5656871e89d Reviewed-on: https://chromium-review.googlesource.com/c/1392092 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#619899}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fb93e618138a..c519fed6ddce git log fb93e618138a..c519fed6ddce --date=short --no-merges --format='%ad %ae %s' 2019-01-04 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset 2019-01-04 reed@google.com start to build with no paint-text fields Created with: gclient setdep -r src/third_party/skia@c519fed6ddce The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I45389ffca1a01037d18391f4bc2f105bd0447ba7 Reviewed-on: https://chromium-review.googlesource.com/c/1395938Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619898}
-
Joel Hockey authored
Chrome creates the container with default username derived from the email address of the current logged in profile. E.g. test.user@gmail.com gets username 'testuser'. It is possible for users to change the username inside the container. As long as the user keeps uid=1000, this does not cause issues except for the sshfs mount where FilesApp connects to the container using 'sshfs://username@hostname'. Cicerone is now updated to return the container username in ContainerStartedSignal and in SetUpLxdContainerUser. CrostiniManager can now use this for the sshfs mount. Removed crostini_util ContainerHomeDirectoryForProfile which was using the default username. The container homedir is now available in CrostiniManager::GetContainerInfo. Bug: 916297 Change-Id: I27f41647c3b8809170521d741867a8ed430e5476 Reviewed-on: https://chromium-review.googlesource.com/c/1388124 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#619897}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f15d3e50..a8182ff8 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ie42cb3720e3b99f3a0e009e4bc52d9a16f4d2fd4 Reviewed-on: https://chromium-review.googlesource.com/c/1395980Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619896}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/519dec6ea078..2bfcc8d6a43e Created with: gclient setdep -r src-internal@2bfcc8d6a43e The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Idc31d530ac3b17d159b3d20bb166629c637b74e1 Reviewed-on: https://chromium-review.googlesource.com/c/1395726Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619895}
-
Reka Norman authored
This CL changes the GetApps function of the app management PageHandler to return the initial apps directly rather than calling onAppsAdded, which simplifies initialisation of the ApiListener. It also changes the onAppsAdded function to onAppAdded. Bug: 906508 Change-Id: I649530920dfcce9d3998d9b2eda0320244ced15c Reviewed-on: https://chromium-review.googlesource.com/c/1393587 Commit-Queue: Reka Norman <rekanorman@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#619894}
-
Dan Beam authored
Screenshots: https://imgur.com/a/mcoKkKc Specs: https://docs.google.com/presentation/d/1kJoBzf_HGYK-_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit#slide=id.g471d243f08_0_874 There's still a bit of work to be done (notably: buttons), but this gets us closer to Namrata's mocks. To run locally, use --enable-features=WebUIDarkMode --force-dark-mode BUG=883049 R=hcarmona@chromium.org Change-Id: I232adf9b487d8be2042c5123484fdb6f87da13c4 Reviewed-on: https://chromium-review.googlesource.com/c/1377147Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#619893}
-
Prashant Malani authored
Add UMA logging of time taken to complete ML service requests, as well as the time spent before a pending request is cancelled. Also update the existing Smart Dim unit tests to verify that the logging works. Bug: 893425, 914640 Test: - Builds and boots, inference calls checked via logs on nocturne - All related unit tests still pass. Change-Id: I542af752a0133939c65eaa435ed3f5be907140db Reviewed-on: https://chromium-review.googlesource.com/c/1393670Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Prashant Malani <pmalani@chromium.org> Cr-Commit-Position: refs/heads/master@{#619892}
-
Cecilia Ni authored
This CL extracts permission view header from chrome app permission view and pwa permission view to avoid duplicate code. Bug: 906508 Change-Id: If4335bf7fcf70ec2b5d429f1b632c66839ec6853 Reviewed-on: https://chromium-review.googlesource.com/c/1393127Reviewed-by:
calamity <calamity@chromium.org> Commit-Queue: Cecilia Ni <ceciliani@google.com> Cr-Commit-Position: refs/heads/master@{#619891}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/76616a10a786..fb93e618138a git log 76616a10a786..fb93e618138a --date=short --no-merges --format='%ad %ae %s' 2019-01-04 reed@google.com fix conditionals for flag Created with: gclient setdep -r src/third_party/skia@fb93e618138a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: I578d39a1dea877a93c261e38533aa2daaad2fe67 Reviewed-on: https://chromium-review.googlesource.com/c/1395725Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619890}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0b364067d04c..ea56333c1e64 git log 0b364067d04c..ea56333c1e64 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 yunchao.he@intel.com Replace DepthStencilState builder via DepthStencilState descriptor. Created with: gclient setdep -r src/third_party/dawn@ea56333c1e64 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: Id9ad7785fb6fd19aa026e6ab65eb4702475d37c0 Reviewed-on: https://chromium-review.googlesource.com/c/1395724Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619889}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/c30e42d5..f15d3e50 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I262da6b87758b99d707c339b81b8caead449804b Reviewed-on: https://chromium-review.googlesource.com/c/1395778Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619888}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d85cad21ef30..519dec6ea078 Created with: gclient setdep -r src-internal@519dec6ea078 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I6ea7b6f919ce3b7f3177e71fd4a77172a39b245f Reviewed-on: https://chromium-review.googlesource.com/c/1395723Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619887}
-
rbpotter authored
- Remove PROCESS_INVITE_FAILED event that was handled identically to PROCESS_INVITE event. - Use CustomEvent instead of Event for all events Bug: None Change-Id: I9de2723779267dc0e8b8d195337b89d9aeb5ca8f Reviewed-on: https://chromium-review.googlesource.com/c/1395178 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#619886}
-
Ben Kelly authored
The SimpleCache stores stream 0 and a footer at the end of the entry file. Currently it must seek to the end to read the footer and then seek to the beginning of stream 0 to read it. This seeking may be costly on devices with spinning disks. This CL adds support for prefetching the entire stream 0 and footer in a single read operation. The amount to prefetch may be speculatively set or, when in APP_CACHE mode, stored in the index. Storing the exact amount is only supported in APP_CACHE mode since the access time field is not needed in that mode and can be reused. Bug: 913107 Change-Id: I3877fc08875bf0206bda9b97bd119d3543877016 Reviewed-on: https://chromium-review.googlesource.com/c/1366762Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#619885}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/b7e284b4ec4f..8743424b5d6d git log b7e284b4ec4f..8743424b5d6d --date=short --no-merges --format='%ad %ae %s' 2019-01-04 jclinton@chromium.org Revert "cbuildbot/manifest_version.py: Use Gerrit autosubmit feature throughout" 2019-01-04 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@8743424b5d6d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I35a43eecb4c6781dbec3514412b3c2ec887acfe0 Reviewed-on: https://chromium-review.googlesource.com/c/1395161Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619884}
-
Sean Gilhuly authored
Begin frames were being processed when there was no BeginFrameObserver, occasionally causing |last_begin_frame_args_| in ExternalBeginFrameSource to be overwritten. These lost frames create a backlog in |pipeline_reporting_frame_times_|, which eventually causes a DCHECK. Remember whether or not begin frames are needed. If they aren't, call DidNotProduceFrame() instead of OnBeginFrame(). This mirrors a check in AsyncLayerTreeFrameSink::OnBeginFrame(). Bug: 916354 Change-Id: Id5361ec6c48044a21c4946585f0da5ef862dd6d5 Reviewed-on: https://chromium-review.googlesource.com/c/1393441Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#619883}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/9bb34ca22069..76616a10a786 git log 9bb34ca22069..76616a10a786 --date=short --no-merges --format='%ad %ae %s' 2019-01-04 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 9fa54eab2590..e4109f27136d (7 commits) Created with: gclient setdep -r src/third_party/skia@76616a10a786 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@chromium.org Change-Id: Ibd709927cbd2fd6b0c8a1c03c0b2bdf5026a888e Reviewed-on: https://chromium-review.googlesource.com/c/1395818Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619882}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72ed1926c934..d85cad21ef30 Created with: gclient setdep -r src-internal@d85cad21ef30 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I05e04a89786621db1fd3b6a5801e4836875cd6c3 Reviewed-on: https://chromium-review.googlesource.com/c/1395817Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619881}
-
Lin Sun authored
Remove intel flag from faiure expectations for fixed cases. Comment fixed mesa version for Linux driver bugs. Bug: 483282, 905006, 686075, 666384, 905011 Bug: 680276, 867675 Change-Id: Ib54f28397bdd073778bea7294870516bb19d1ce6 Reviewed-on: https://chromium-review.googlesource.com/c/1390765 Commit-Queue: Lin Sun <lin.sun@intel.com> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619880}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a2033f83..c30e42d5 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic99d2771f7dfbb0e9772c9f09f5869ed03271dcc Reviewed-on: https://chromium-review.googlesource.com/c/1395155Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619879}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2bfdf22c. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" e9314f41 "Fix resource-timing.html document.domain test" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 4836c563 "Change web platform test with mouse inputs under "pinterevents/"" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ksakamoto@chromium.org: external/wpt/resource-timing NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I765f112223b7604f3a33563797575d2d9e76df1d Reviewed-on: https://chromium-review.googlesource.com/c/1395564Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619878}
-
Prashant Malani authored
ScopedTaskEnvironment is sufficient for the purposes of power/ml unit tests, so remove usages of TestMockTimeTaskRunner. This also removes need to support both TestMockTimeTaskRunner *and* ScopedTaskEnvironment in FakeBookClock. Bug: 917580 Test: All related unit tests still pass. Change-Id: Iec413bf52422a12462f8ff99ef5e02e23907925a Reviewed-on: https://chromium-review.googlesource.com/c/1393896Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Prashant Malani <pmalani@chromium.org> Cr-Commit-Position: refs/heads/master@{#619877}
-
Sky Malice authored
Bug: 908963 Change-Id: I655419255ea7a99e3d053fba85464f0ce082ddfe Reviewed-on: https://chromium-review.googlesource.com/c/1395137Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#619876}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/225f08bf85a3..e4109f27136d git log 225f08bf85a3..e4109f27136d --date=short --no-merges --format='%ad %ae %s' 2019-01-04 jdarpinian@chromium.org WebGL: validate texture format matches sampler type Created with: gclient setdep -r src/third_party/angle@e4109f27136d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:809237 TBR=syoussefi@chromium.org Change-Id: Ic594afb3521a746b929d588bb130d454908513c5 Reviewed-on: https://chromium-review.googlesource.com/c/1395346Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619875}
-
Findit authored
This reverts commit 8f13336d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 619841 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOGYxMzMzNmQ0M2NhMTBlZTEwYmQyMmFkMDJhYWIxMWM3ZDc5OTEyOAw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests/8493 Sample Failed Step: viz_unittests on (none) GPU on Mac Sample Flaky Test: SkiaOutputSurfaceImplTest.CopyOutOutside Original change's description: > Add reshape and copy outside case for SkiaOutputSurfaceImplTest > > Bug: 894806 > Change-Id: Id76b1a229b9583e7d7304b4f5262e2b8d9bbbbb3 > Reviewed-on: https://chromium-review.googlesource.com/c/1388020 > Commit-Queue: Xing Xu <xing.xu@intel.com> > Reviewed-by: Peng Huang <penghuang@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619841} Change-Id: Ic8105579dffefcf7f13cfb12e30e350c6ffee6e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 894806, 919012 Reviewed-on: https://chromium-review.googlesource.com/c/1395719 Cr-Commit-Position: refs/heads/master@{#619874}
-
Kenneth Russell authored
Pixel_Canvas2DRedBox Pixel_CanvasDisplayLinearRGBAccelerated2D Pixel_CanvasDisplayLinearRGBUnaccelerated2DGPUCompositing Pixel_CanvasLowLatency2D Bug: 918952 Change-Id: Ic747a861cb778f5f07c00e6b5862c8a3e4ce9407 Tbr: fserb@chromium.org Tbr: mcasas@chromium.org Tbr: zakerinasab@chromium.org Tbr: ynovikov@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1394984Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619873}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d690842f5ccd..72ed1926c934 Created with: gclient setdep -r src-internal@72ed1926c934 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:860880 TBR=mmoss@chromium.org Change-Id: If0646ec71c34da071513c0b1a3241d865e932d6d Reviewed-on: https://chromium-review.googlesource.com/c/1395162Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619872}
-
Chris Harrelson authored
Change-Id: Iadcbd28ef1aba41f27e0c0a7c9256e3fd42d0941 Reviewed-on: https://chromium-review.googlesource.com/c/1394875 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#619871}
-
Findit authored
This reverts commit 5aa7731c. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 619843 as the culprit for flakes in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNWFhNzczMWMzMDc1ZmU2M2QxZjAxNjI1MmZjMDk0YmJhMTQ5MWQxNww Sample Failed Build: https://ci.chromium.org/buildbot/chromium.win/Win10%20Tests%20x64/30552 Sample Failed Step: network_service_browser_tests on Windows-10-15063 Sample Flaky Test: CrExtensionsManagerTestWithOptionsDialog.ShowOptionsDialog Original change's description: > Extensions: Focus correct button on options dialog close. > > Also fix some const references surfaced by presubmit. > > Bug: 912026 > Change-Id: I2661f69f0e63e613a9b8e9d565813c3e27fed340 > Reviewed-on: https://chromium-review.googlesource.com/c/1377494 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Commit-Queue: Hector Carmona <hcarmona@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619843} Change-Id: I66ae0de35342e94b47e76dac658df2eb1f12e4b0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912026, 919007 Reviewed-on: https://chromium-review.googlesource.com/c/1395717 Cr-Commit-Position: refs/heads/master@{#619870}
-
Doug Turner authored
Bug: 916654 Change-Id: I70e2f99d558c797b0d1d98cb543fdc13c866e091 Reviewed-on: https://chromium-review.googlesource.com/c/1394374Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Doug Turner <dougt@chromium.org> Cr-Commit-Position: refs/heads/master@{#619869}
-
Darren Shen authored
Currently right-clicking on input fields in Mojo apps will bring up an emoji option. Clicking it would crash the app. This is because we assume that an emoji callback function always exists, but actually this is not true for Mojo apps because they are in a different process. This patch adds a null check for the emoji callback so that we don't show the emoji option when we don't have a callback. Bug: 887649 Change-Id: Iaccb0d9f890187f5c405888babefde7d3f33abe0 Reviewed-on: https://chromium-review.googlesource.com/c/1393584 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#619868}
-
Doug Turner authored
If we find a null frame, we reject with a "Document not active" exception. Bug: 916656 Change-Id: If76de22eb1fd977571bb7517e6d745e3ad9077e9 Reviewed-on: https://chromium-review.googlesource.com/c/1391773 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#619867}
-
Joel Hockey authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/825055dd8383..ea44d5db9e74 $ git log 825055dd8..ea44d5db9 --date=short --no-merges --format='%ad %ae %s' 2019-01-02 joelhockey system_api: Return homedir in ContainerStartedSignal Created with: roll-dep src/third_party/cros_system_api Change-Id: Ib010b26d2483c7d299196e9abf0790b3e874d62d Reviewed-on: https://chromium-review.googlesource.com/c/1395577Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#619866}
-